[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
https://bugzilla.redhat.com/show_bug.cgi?id=855588 Fedora Update System changed: What|Removed |Added Fixed In Version|ghc-concrete-typerep-0.1.0. |ghc-concrete-typerep-0.1.0. |1-4.el6 |2-2.el7 --- Comment #27 from Fedora Update System --- ghc-concrete-typerep-0.1.0.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
https://bugzilla.redhat.com/show_bug.cgi?id=855588 --- Comment #26 from Fedora Update System --- ghc-concrete-typerep-0.1.0.2-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/ghc-concrete-typerep-0.1.0.2-2.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
https://bugzilla.redhat.com/show_bug.cgi?id=855588 --- Comment #25 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
https://bugzilla.redhat.com/show_bug.cgi?id=855588 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
https://bugzilla.redhat.com/show_bug.cgi?id=855588 Jens Petersen changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #24 from Jens Petersen --- Package Change Request == Package Name: ghc-concrete-typerep New Branches: epel7 Owners: petersen InitialCC: haskell-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
https://bugzilla.redhat.com/show_bug.cgi?id=855588 Fedora Update System changed: What|Removed |Added Fixed In Version||ghc-concrete-typerep-0.1.0. ||1-4.el6 Resolution|CURRENTRELEASE |ERRATA --- Comment #23 from Fedora Update System --- ghc-concrete-typerep-0.1.0.1-4.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TCzJed1JgP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=855588 --- Comment #22 from Fedora Update System --- ghc-concrete-typerep-0.1.0.1-4.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5A2GWLctXj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=855588 --- Comment #21 from Fedora Update System --- ghc-concrete-typerep-0.1.0.1-4.fc16 has been pushed to the Fedora 16 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BbqRUpbcju&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=855588 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2013-01-06 22:54:45 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EHDbb4uU8f&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=855588 --- Comment #20 from Fedora Update System --- ghc-concrete-typerep-0.1.0.1-4.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1G3rTUyxzX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=855588 --- Comment #19 from Fedora Update System --- ghc-concrete-typerep-0.1.0.1-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/ghc-concrete-typerep-0.1.0.1-4.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rWGMoKo7HA&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=855588 --- Comment #18 from Kevin Fenzi --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PFVZjHgP6u&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=855588 Lakshmi Narasimhan changed: What|Removed |Added Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #17 from Lakshmi Narasimhan --- Package Change Request == Package Name: ghc-concrete-typerep New Branches: el6 Owners: narasim InitialCC: haskell-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Lba0qqtTRG&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=855588 --- Comment #16 from Fedora Update System --- ghc-concrete-typerep-0.1.0.1-4.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PGt7Dna6Wl&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=855588 Fedora Update System changed: What|Removed |Added Status|RELEASE_PENDING |ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8LIVi8fkcb&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=855588 --- Comment #15 from Fedora Update System --- ghc-concrete-typerep-0.1.0.1-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/ghc-concrete-typerep-0.1.0.1-4.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DH12YwBELj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=855588 --- Comment #14 from Fedora Update System --- ghc-concrete-typerep-0.1.0.1-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/ghc-concrete-typerep-0.1.0.1-4.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=N9wuZY1XUE&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=855588 Lakshmi Narasimhan changed: What|Removed |Added Status|VERIFIED|RELEASE_PENDING -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gMrej1RuBw&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=855588 --- Comment #13 from Fedora Update System --- ghc-concrete-typerep-0.1.0.1-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/ghc-concrete-typerep-0.1.0.1-4.fc16 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HiBw6pMhrZ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=855588 --- Comment #12 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PUr3GbfLZX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=855588 Lakshmi Narasimhan changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0M41dxJ6CR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=855588 --- Comment #11 from Lakshmi Narasimhan --- Thanks for the review. New Package SCM Request === Package Name: ghc-concrete-typerep Short Description: Provides Binary and Hashable instances for TypeRep Owners: narasim Branches: f16 f17 f18 InitialCC: haskell-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GGXuaE9i7c&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=855588
Shakthi Kannan changed:
What|Removed |Added
Status|ASSIGNED|VERIFIED
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #10 from Shakthi Kannan ---
[+]MUST: rpmlint must be run on every package. The output should be posted in
the review.
$ rpmlint ghc-concrete-typerep.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint ghc-concrete-typerep-0.1.0.1-4.fc17.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint ghc-concrete-typerep-devel-0.1.0.1-4.fc17.x86_64.rpm
ghc-concrete-typerep-devel.x86_64: W: invalid-url URL:
http://hackage.haskell.org/package/concrete-typerep timed out
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
$ rpmlint ghc-concrete-typerep-0.1.0.1-4.fc17.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
Naming-Yes
Version-release - Matches
License - OK
No prebuilt external bits - OK
Spec legibity - OK
Package template - OK, based on cabal-rpm-0.6.6
Arch support - OK
Libexecdir - OK
rpmlint - yes
changelogs - OK
Source url tag - OK, validated.
Buildroot is ignored - OK
%clean is ignored - OK
Build Requires list - OK
Summary and description - OK
API documentation - OK
[+]MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
License is BSD
[+]MUST: The License field in the package spec file must match the actual
license.
[+]MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream
source,as provided in the spec URL. Reviewers should use md5sum for this task.
$ md5sum concrete-typerep-0.1.0.1.tar.gz
9390a961061c4c1f96b154d42cae8873 concrete-typerep-0.1.0.1.tar.gz
$ md5sum concrete-typerep-0.1.0.1.tar.gz
9390a961061c4c1f96b154d42cae8873 concrete-typerep-0.1.0.1.tar.gz
[+]MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
[+]MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+]MUST: All build dependencies must be listed in BuildRequires.
[NA]MUST: The spec file MUST handle locales properly using the %find_lang macro
[NA]MUST: Packages stores shared library files must call ldconfig in %post and
%postun.
[+]MUST: Packages must NOT bundle copies of system libraries.
[NA]MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review.
[+]MUST: A package must own all directories that it creates.
[+]MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
[+]MUST: Permissions on files must be set properly.
[+]MUST: Each package must consistently use macros.
[+]MUST: The package must contain code, or permissible content.
[NA]MUST: Large documentation files must go in a -doc subpackage.
[+]MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[NA]MUST: Header files must be in a -devel package.
[NA]MUST: Static libraries must be in a -static package.
[NA]MUST: If a package contains library files with a suffix
(e.g.libfoo.so.1.1), then library files that end in .so (without suffix) must
go in a -devel package.
[+]MUST: devel packages must require the base package using a fully versioned
dependency: Requires: {name} = %{version}-%{release}
[NA]MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
[NA]MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section
[+]MUST: Packages must not own files or directories already owned by other
packages.
[+]MUST: All filenames in rpm packages must be valid UTF-8.
Should items
[+]SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[+]SHOULD: The reviewer should test that the package functions as described.
[+]SHOULD: If scriptlets are used, those
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=855588 Lakshmi Narasimhan changed: What|Removed |Added Flags|needinfo? | --- Comment #9 from Lakshmi Narasimhan --- Spec file: http://narasim.fedorapeople.org/package_reviews/ghc-concrete-typerep.spec SRPM link: http://narasim.fedorapeople.org/package_reviews/ghc-concrete-typerep-0.1.0.1-4.fc17.src.rpm F18 and F19 builds http://koji.fedoraproject.org/koji/taskinfo?taskID=4802288 http://koji.fedoraproject.org/koji/taskinfo?taskID=4802277 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=66viDllQ0M&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=855588 Shakthi Kannan changed: What|Removed |Added Flags||needinfo? --- Comment #8 from Shakthi Kannan --- The build fails for F18, and F19. http://koji.fedoraproject.org/koji/taskinfo?taskID=4802235 http://koji.fedoraproject.org/koji/taskinfo?taskID=4802236 Configuring concrete-typerep-0.1.0.1... Setup: At least the following dependencies are missing: ghc >=7.2 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yMr97yObIy&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=855588 --- Comment #7 from Lakshmi Narasimhan --- Spec file: http://narasim.fedorapeople.org/package_reviews/ghc-concrete-typerep.spec SRPM link: http://narasim.fedorapeople.org/package_reviews/ghc-concrete-typerep-0.1.0.1-4.fc17.src.rpm rpmlint output: rpmlint -i ghc-concrete-typerep-0.1.0.1-4.fc17.src.rpm ghc-concrete-typerep-devel-0.1.0.1-4.fc17.x86_64.rpm ghc-concrete-typerep-0.1.0.1-4.fc17.x86_64.rpm ../ghc-concrete-typerep.spec 3 packages and 1 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dOEuEReUyQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=855588 --- Comment #6 from Shakthi Kannan --- #01 Group is deprecated #02 Please mention the name of the package and the version in the patch filename #03 Can you please update the spec using cabal2rpm? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GI7VsfliSl&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=855588 --- Comment #5 from Lakshmi Narasimhan --- Koji builds: F17 : http://koji.fedoraproject.org/koji/taskinfo?taskID=4747772 F18 : http://koji.fedoraproject.org/koji/taskinfo?taskID=4747771 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=855588 --- Comment #4 from Lakshmi Narasimhan --- Jens, Thanks for the suggestion. I have created a patch to make new-typerep flag True by default. http://narasim.fedorapeople.org/package_reviews/ghc-concrete-typerep.spec http://narasim.fedorapeople.org/package_reviews/ghc-concrete-typerep-0.1.0.1-3.fc17.src.rpm rpmlint output: rpmlint -i ghc-concrete-typerep-0.1.0.1-3.fc17.x86_64.rpm ghc-concrete-typerep-devel-0.1.0.1-3.fc17.x86_64.rpm ghc-concrete-typerep-0.1.0.1-3.fc17.src.rpm ../ghc-concrete-typerep.spec 3 packages and 1 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
https://bugzilla.redhat.com/show_bug.cgi?id=855588 --- Comment #3 from Jens Petersen --- It is better to patch the flag default in the .cabal file actually for tools like cabal-rpm - sorry didn't think to mention that earlier. Since the flag is only needed for ghc > 7.2, ie currently only f18 and f19, it is not needed for epel currently. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
https://bugzilla.redhat.com/show_bug.cgi?id=855588 --- Comment #2 from Lakshmi Narasimhan --- Jens, Shakthi, I have modified the spec file. I haven't enabled cabal flag for epel. If necessary, I will include it later. http://narasim.fedorapeople.org/package_reviews/ghc-concrete-typerep.spec http://narasim.fedorapeople.org/package_reviews/ghc-concrete-typerep-0.1.0.1-2.fc18.src.rpm Koji builds: F17: http://koji.fedoraproject.org/koji/taskinfo?taskID=4627665 F18: http://koji.fedoraproject.org/koji/taskinfo?taskID=4627667 Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=4627669 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
https://bugzilla.redhat.com/show_bug.cgi?id=855588 --- Comment #1 from Jens Petersen --- (In reply to comment #0) > For F18 and greater, we need to add configure flags to cabal. Link to spec > file for f18 > http://narasim.fedorapeople.org/package_reviews/ghc-concrete-typerep-f18.spec Then please make it conditional. One spec file should be able to build for both f18 and earlier. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855588] Review Request: ghc-concrete-typerep - Provides Binary and Hashable instances for TypeRep.
https://bugzilla.redhat.com/show_bug.cgi?id=855588 Shakthi Kannan changed: What|Removed |Added Status|NEW |ASSIGNED CC||shakthim...@gmail.com Assignee|nob...@fedoraproject.org|shakthim...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
