[Bug 855701] Review Request: cabal-rpm - creates rpm spec files for Haskell Cabal packages
https://bugzilla.redhat.com/show_bug.cgi?id=855701 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||cabal-rpm-0.9.1-1.el5 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- cabal-rpm-0.9.1-1.el5 has been pushed to the Fedora EPEL 5 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855701] Review Request: cabal-rpm - creates rpm spec files for Haskell Cabal packages
https://bugzilla.redhat.com/show_bug.cgi?id=855701 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- cabal-rpm-0.9.1-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/cabal-rpm-0.9.1-1.el5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855701] Review Request: cabal-rpm - creates rpm spec files for Haskell Cabal packages
https://bugzilla.redhat.com/show_bug.cgi?id=855701 Jens Petersen peter...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #13 from Jens Petersen peter...@redhat.com --- Package Change Request == Package Name: cabal-rpm New Branches: el5 Owners: petersen InitialCC: haskell-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855701] Review Request: cabal-rpm - creates rpm spec files for Haskell Cabal packages
https://bugzilla.redhat.com/show_bug.cgi?id=855701 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855701] Review Request: cabal-rpm - creates rpm spec files for Haskell Cabal packages
https://bugzilla.redhat.com/show_bug.cgi?id=855701 --- Comment #14 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855701] Review Request: cabal-rpm - creates rpm spec files for Haskell Cabal packages
https://bugzilla.redhat.com/show_bug.cgi?id=855701 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-09-25 12:37:48 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- cabal-rpm-0.6.2-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855701] Review Request: cabal-rpm - creates rpm spec files for Haskell Cabal packages
https://bugzilla.redhat.com/show_bug.cgi?id=855701 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- cabal-rpm-0.6.2-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/cabal-rpm-0.6.2-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855701] Review Request: cabal-rpm - creates rpm spec files for Haskell Cabal packages
https://bugzilla.redhat.com/show_bug.cgi?id=855701 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- cabal-rpm-0.6.2-1.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855701] Review Request: cabal-rpm - creates rpm spec files for Haskell Cabal packages
https://bugzilla.redhat.com/show_bug.cgi?id=855701 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855701] Review Request: cabal-rpm - creates rpm spec files for Haskell Cabal packages
https://bugzilla.redhat.com/show_bug.cgi?id=855701 --- Comment #4 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855701] Review Request: cabal-rpm - creates rpm spec files for Haskell Cabal packages
https://bugzilla.redhat.com/show_bug.cgi?id=855701 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855701] Review Request: cabal-rpm - creates rpm spec files for Haskell Cabal packages
https://bugzilla.redhat.com/show_bug.cgi?id=855701 --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- cabal-rpm-0.6.2-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/cabal-rpm-0.6.2-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855701] Review Request: cabal-rpm - creates rpm spec files for Haskell Cabal packages
https://bugzilla.redhat.com/show_bug.cgi?id=855701 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- cabal-rpm-0.6.2-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/cabal-rpm-0.6.2-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855701] Review Request: cabal-rpm - creates rpm spec files for Haskell Cabal packages
https://bugzilla.redhat.com/show_bug.cgi?id=855701 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- cabal-rpm-0.6.2-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/cabal-rpm-0.6.2-1.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855701] Review Request: cabal-rpm - creates rpm spec files for Haskell Cabal packages
https://bugzilla.redhat.com/show_bug.cgi?id=855701 Jens Petersen peter...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #8 from Jens Petersen peter...@redhat.com --- Thanks Jon - sorry forgot to request epel6 too: Package Change Request == Package Name: cabal-rpm New Branches: el6 Owners: petersen InitialCC: haskell-sig -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855701] Review Request: cabal-rpm - creates rpm spec files for Haskell Cabal packages
https://bugzilla.redhat.com/show_bug.cgi?id=855701 Jens Petersen peter...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Jens Petersen peter...@redhat.com --- Thank you for the package review. :) I am adding creating a manpage to the upstream TODO list. New Package SCM Request === Package Name: cabal-rpm Short Description: Create RPM spec files from Haskell Cabal packages Owners: petersen Branches: f18 f17 f16 InitialCC: haskell-sig -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855701] Review Request: cabal-rpm - creates rpm spec files for Haskell Cabal packages
https://bugzilla.redhat.com/show_bug.cgi?id=855701
Lakshmi Narasimhan lakshminaras2...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flags||fedora-review+
--- Comment #2 from Lakshmi Narasimhan lakshminaras2...@gmail.com ---
[+]MUST: rpmlint must be run on every package. The output should be posted in
the review.
rpmlint -i cabal-rpm-0.6.2-1.fc17.src.rpm cabal-rpm-0.6.2-1.fc17.x86_64.rpm
../cabal-rpm.spec
cabal-rpm.x86_64: W: no-manual-page-for-binary cabal-rpm
Each executable in standard binary directories should have a man page.
2 packages and 1 specfiles checked; 0 errors, 1 warnings.
[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
Naming-Yes
Version-release - Matches
License - OK
No prebuilt external bits - OK
Spec legibity - OK
Package template - OK
Arch support - OK
Libexecdir - OK
rpmlint - yes
changelogs - OK
Source url tag - OK, validated.
Build Requires list - OK
Summary and description - OK
API documentation - OK, NA
[+]MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
GPLv3
[+]MUST: The License field in the package spec file must match the actual
license.
[+]MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
COPYING file is included.
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
sha256sum cabal-rpm-0.6.2-1.fc17.src/cabal-rpm-0.6.2.tar.gz
cabal-rpm-0.6.2.tar.gz
f4d9efae8973fc3fe837e46f7580945511bb9df4302472860a0e4c62c871de07
cabal-rpm-0.6.2-1.fc17.src/cabal-rpm-0.6.2.tar.gz
f4d9efae8973fc3fe837e46f7580945511bb9df4302472860a0e4c62c871de07
cabal-rpm-0.6.2.tar.gz
[+]MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
Built on x86_64.
[+]MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+]MUST: All build dependencies must be listed in BuildRequires.
[+]MUST: Packages must NOT bundle copies of system libraries.
Checked with rpmquery --list.
[NA]MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review.
[+]MUST: A package must own all directories that it creates.
Checked with rpmquery --whatprovides
[+]MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
[+]MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[+]MUST: Each package must consistently use macros.
[+]MUST: The package must contain code, or permissible content.
[+]MUST: Large documentation files must go in a -doc subpackage.
[+]MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[NA]MUST: devel packages must require the base package using a fully versioned
dependency: Requires: {name} = %{version}-%{release}
[NA]MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
[NA]MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section
[+]MUST: Packages must not own files or directories already owned by other
packages.
[+]MUST: All filenames in rpm packages must be valid UTF-8.
Should items
[+]SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[-]SHOULD: The description and summary sections in the package spec file should
contain translations for supported Non-English languages, if available.
[-]SHOULD: The reviewer should test that the package builds in mock.
[+]SHOULD: The reviewer should test that the package functions as described. A
package should not segfault instead of running, for example.
Ran cabal-rpm on a cabal file. The resulting spec file looks fine.
[+]SHOULD: If scriptlets are used, those scriptlets must be sane. This is
[Bug 855701] Review Request: cabal-rpm - creates rpm spec files for Haskell Cabal packages
https://bugzilla.redhat.com/show_bug.cgi?id=855701 --- Comment #1 from Jens Petersen peter...@redhat.com --- This is planned to cabal2spec: perhaps I should add an obsoletes. Sorry, I meant planned to *replace* the current cabal2spec script. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855701] Review Request: cabal-rpm - creates rpm spec files for Haskell Cabal packages
https://bugzilla.redhat.com/show_bug.cgi?id=855701 Lakshmi Narasimhan lakshminaras2...@gmail.com changed: What|Removed |Added CC||lakshminaras2...@gmail.com Assignee|nob...@fedoraproject.org|lakshminaras2...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855701] Review Request: cabal-rpm - creates rpm spec files for Haskell Cabal packages
https://bugzilla.redhat.com/show_bug.cgi?id=855701 Jens Petersen peter...@redhat.com changed: What|Removed |Added Alias||cabal-rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
