[Bug 856002] Review Request: plug - Linux software for Fender Mustang amplifiers
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=856002 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-12-14 18:31:42 --- Comment #14 from Mario Blättermann mario.blaetterm...@gmail.com --- Packages for all the requested Git branches are marked as stable now. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NwwXA55FZJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856002] Review Request: plug - Linux software for Fender Mustang amplifiers
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=856002 --- Comment #13 from Mario Blättermann mario.blaetterm...@gmail.com --- No packages built yet...? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856002] Review Request: plug - Linux software for Fender Mustang amplifiers
https://bugzilla.redhat.com/show_bug.cgi?id=856002 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856002] Review Request: plug - Linux software for Fender Mustang amplifiers
https://bugzilla.redhat.com/show_bug.cgi?id=856002 --- Comment #10 from Jonathan Underwood jonathan.underw...@gmail.com --- Thanks for taking the time to review, Mario. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856002] Review Request: plug - Linux software for Fender Mustang amplifiers
https://bugzilla.redhat.com/show_bug.cgi?id=856002 Jonathan Underwood jonathan.underw...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #11 from Jonathan Underwood jonathan.underw...@gmail.com --- New Package SCM Request === Package Name: plug Short Description: Linux replacement for Fender FUSE software for Mustang amps Owners: jgu Branches: f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856002] Review Request: plug - Linux software for Fender Mustang amplifiers
https://bugzilla.redhat.com/show_bug.cgi?id=856002
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #9 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4651203
$ rpmlint -i -v *
plug.src: I: checking
plug.src: I: checking-url http://piorekf.org/plug/ (timeout 10 seconds)
plug.src: I: checking-url https://bitbucket.org/piorekf/plug/get/v1.1.tar.gz
(timeout 10 seconds)
plug.i686: I: checking
plug.i686: I: checking-url http://piorekf.org/plug/ (timeout 10 seconds)
plug.i686: W: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.
plug.i686: W: no-manual-page-for-binary plug
Each executable in standard binary directories should have a man page.
plug.x86_64: I: checking
plug.x86_64: I: checking-url http://piorekf.org/plug/ (timeout 10 seconds)
plug.x86_64: W: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.
plug.x86_64: W: no-manual-page-for-binary plug
Each executable in standard binary directories should have a man page.
plug-debuginfo.i686: I: checking
plug-debuginfo.i686: I: checking-url http://piorekf.org/plug/ (timeout 10
seconds)
plug-debuginfo.x86_64: I: checking
plug-debuginfo.x86_64: I: checking-url http://piorekf.org/plug/ (timeout 10
seconds)
plug.spec: I: checking-url https://bitbucket.org/piorekf/plug/get/v1.1.tar.gz
(timeout 10 seconds)
5 packages and 1 specfiles checked; 0 errors, 4 warnings.
No recognizable issues.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
GPLv3+
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
92d7562fc8b803176d01234c73f6594816d8a0f1ff046b6f7ab980e3f4e65723
v1.1.tar.gz
92d7562fc8b803176d01234c73f6594816d8a0f1ff046b6f7ab980e3f4e65723
v1.1.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more than once in
[Bug 856002] Review Request: plug - Linux software for Fender Mustang amplifiers
https://bugzilla.redhat.com/show_bug.cgi?id=856002 --- Comment #8 from Jonathan Underwood jonathan.underw...@gmail.com --- Spec URL: http://fedorapeople.org/~jgu/plug.spec SRPM URL: http://fedorapeople.org/~jgu/plug-1.1-6.fc17.src.rpm * Tue Oct 16 2012 Jonathan G. Underwood jonathan.underw...@gmail.com - 1.1-6 - Change udev rules to be systemd conformant (See BZ 856002 comment 6) - No longer created the plugdev group - Drop unneeded README.Fedora file -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856002] Review Request: plug - Linux software for Fender Mustang amplifiers
https://bugzilla.redhat.com/show_bug.cgi?id=856002 --- Comment #7 from Jonathan Underwood jonathan.underw...@gmail.com --- Thanks Ian, that's useful info - I had been digging into this actually, but hadn't actually got it figured out - you just saved me a lot of brain ache! Am a little snowed under at work, but will upload new packages at the weekend with these changes. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856002] Review Request: plug - Linux software for Fender Mustang amplifiers
https://bugzilla.redhat.com/show_bug.cgi?id=856002
--- Comment #6 from Ian Malone ibmal...@gmail.com ---
Thanks very much for picking this one up! Just one note about the udev/plughw
group rule, I went through some discussion about this a while back with the
devel list and the correct fedora way is with a dynamic access control list,
see
http://lists.freedesktop.org/archives/systemd-devel/2012-March/004795.html
and
http://lists.fedoraproject.org/pipermail/devel/2012-March/164837.html
In summary having this installed as plug.50-mustang.rules :
SUBSYSTEM==usb, ENV{DEVTYPE}==usb_device, \
ATTRS{idVendor}==1ed8, ATTRS{idProduct}==000[456], \
ENV{ID_AMPLIFIER_PANEL}=1
ENV{ID_AMPLIFIER_PANEL}==1, TAG+=uaccess
Means you don't need the plugdev group and udev rule to change group for it.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856002] Review Request: plug - Linux software for Fender Mustang amplifiers
https://bugzilla.redhat.com/show_bug.cgi?id=856002 Brendan Jones brendan.jones...@gmail.com changed: What|Removed |Added CC||brendan.jones...@gmail.com Blocks||805236 (FedoraAudio) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856002] Review Request: plug - Linux software for Fender Mustang amplifiers
https://bugzilla.redhat.com/show_bug.cgi?id=856002 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co ||m Flags||fedora-review? --- Comment #5 from Mario Blättermann mario.blaetterm...@gmail.com --- New scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4552310 $ rpmlint -i -v * plug.src: I: checking plug.src: I: checking-url http://piorekf.org/plug/ (timeout 10 seconds) plug.src: I: checking-url https://bitbucket.org/piorekf/plug/get/v1.1.tar.gz (timeout 10 seconds) plug.i686: I: checking plug.i686: I: checking-url http://piorekf.org/plug/ (timeout 10 seconds) plug.i686: W: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. plug.i686: W: no-manual-page-for-binary plug Each executable in standard binary directories should have a man page. plug.x86_64: I: checking plug.x86_64: I: checking-url http://piorekf.org/plug/ (timeout 10 seconds) plug.x86_64: W: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. plug.x86_64: W: no-manual-page-for-binary plug Each executable in standard binary directories should have a man page. plug-debuginfo.i686: I: checking plug-debuginfo.i686: I: checking-url http://piorekf.org/plug/ (timeout 10 seconds) plug-debuginfo.x86_64: I: checking plug-debuginfo.x86_64: I: checking-url http://piorekf.org/plug/ (timeout 10 seconds) plug.spec: I: checking-url https://bitbucket.org/piorekf/plug/get/v1.1.tar.gz (timeout 10 seconds) 5 packages and 1 specfiles checked; 0 errors, 4 warnings. No recognizable issues. The group plugdev will be created at installation. This is OK so far, but the command has to be followed by exit 0. See http://fedoraproject.org/wiki/Packaging:UsersAndGroups for more information. No further objections from my side, your package is ready for a full review once you've fixed the mentioned issue. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856002] Review Request: plug - Linux software for Fender Mustang amplifiers
https://bugzilla.redhat.com/show_bug.cgi?id=856002 --- Comment #4 from Jonathan Underwood jonathan.underw...@gmail.com --- Spec URL: http://fedorapeople.org/~jgu/plug.spec SRPM URL: http://fedorapeople.org/~jgu/plug-1.1-5.fc17.src.rpm * Sun Sep 30 2012 Jonathan G. Underwood jonathan.underw...@gmail.com - 1.1-5 - Change Group to Applications/System - Untabify spec file - Fix Source URL (In reply to comment #3) Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4525705 $ rpmlint -i -v * plug.src: I: checking plug.src: W: non-standard-group Hardware/Other The value of the Group tag in the package is not valid. Valid groups are: Amusements/Games, Amusements/Graphics, Applications/Archiving, Applications/Communications, Applications/Databases, Applications/Editors, Applications/Emulators, Applications/Engineering, Applications/File, Applications/Internet, Applications/Multimedia, Applications/Productivity, Applications/Publishing, Applications/System, Applications/Text, Development/Debug, Development/Debuggers, Development/Languages, Development/Libraries, Development/System, Development/Tools, Documentation, System Environment/Base, System Environment/Daemons, System Environment/Kernel, System Environment/Libraries, System Environment/Shells, Unspecified, User Interface/Desktops, User Interface/X, User Interface/X Hardware Support. Changed group to Applications/System plug.src: I: checking-url http://piorekf.org/plug/ (timeout 10 seconds) plug.src:12: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. Fixed. plug.src: I: checking-url http://piorekf.org/plug/download/v1.1.tar.gz (timeout 10 seconds) plug.src: W: invalid-url Source0: http://piorekf.org/plug/download/v1.1.tar.gz HTTP Error 404: Not Found The value should be a valid, public HTTP, HTTPS, or FTP URL. Fixed. plug.i686: I: checking plug.i686: W: non-standard-group Hardware/Other The value of the Group tag in the package is not valid. Valid groups are: Amusements/Games, Amusements/Graphics, Applications/Archiving, Applications/Communications, Applications/Databases, Applications/Editors, Applications/Emulators, Applications/Engineering, Applications/File, Applications/Internet, Applications/Multimedia, Applications/Productivity, Applications/Publishing, Applications/System, Applications/Text, Development/Debug, Development/Debuggers, Development/Languages, Development/Libraries, Development/System, Development/Tools, Documentation, System Environment/Base, System Environment/Daemons, System Environment/Kernel, System Environment/Libraries, System Environment/Shells, Unspecified, User Interface/Desktops, User Interface/X, User Interface/X Hardware Support. plug.i686: I: checking-url http://piorekf.org/plug/ (timeout 10 seconds) plug.i686: W: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. This is a false positive - the file under /usr/lib is a udev rule file which absolutely must go in /usr/lib/udev/rules.d/ plug.i686: W: no-manual-page-for-binary plug Each executable in standard binary directories should have a man page. plug.x86_64: I: checking plug.x86_64: W: non-standard-group Hardware/Other The value of the Group tag in the package is not valid. Valid groups are: Amusements/Games, Amusements/Graphics, Applications/Archiving, Applications/Communications, Applications/Databases, Applications/Editors, Applications/Emulators, Applications/Engineering, Applications/File, Applications/Internet, Applications/Multimedia, Applications/Productivity, Applications/Publishing, Applications/System, Applications/Text, Development/Debug, Development/Debuggers, Development/Languages, Development/Libraries, Development/System, Development/Tools, Documentation, System Environment/Base, System Environment/Daemons, System Environment/Kernel, System Environment/Libraries, System Environment/Shells, Unspecified, User Interface/Desktops, User Interface/X, User Interface/X Hardware Support. Fixed. plug.x86_64: I: checking-url http://piorekf.org/plug/ (timeout 10 seconds) plug.x86_64: W: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. False positive - see above. plug.x86_64: W: no-manual-page-for-binary plug Each executable in standard binary directories should have a man page. This is a graphical application with no command line switches. A man page really isn't necessary. plug-debuginfo.i686: I: checking plug-debuginfo.i686: I: checking-url http://piorekf.org/plug/ (timeout 10 seconds) plug-debuginfo.x86_64: I: checking plug-debuginfo.x86_64: I: checking-url http://piorekf.org/plug/ (timeout 10 seconds) plug.spec:5: W: non-standard-group Hardware/Other The value of the Group
[Bug 856002] Review Request: plug - Linux software for Fender Mustang amplifiers
https://bugzilla.redhat.com/show_bug.cgi?id=856002 --- Comment #3 from Mario Blättermann mario.blaetterm...@gmail.com --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4525705 $ rpmlint -i -v * plug.src: I: checking plug.src: W: non-standard-group Hardware/Other The value of the Group tag in the package is not valid. Valid groups are: Amusements/Games, Amusements/Graphics, Applications/Archiving, Applications/Communications, Applications/Databases, Applications/Editors, Applications/Emulators, Applications/Engineering, Applications/File, Applications/Internet, Applications/Multimedia, Applications/Productivity, Applications/Publishing, Applications/System, Applications/Text, Development/Debug, Development/Debuggers, Development/Languages, Development/Libraries, Development/System, Development/Tools, Documentation, System Environment/Base, System Environment/Daemons, System Environment/Kernel, System Environment/Libraries, System Environment/Shells, Unspecified, User Interface/Desktops, User Interface/X, User Interface/X Hardware Support. plug.src: I: checking-url http://piorekf.org/plug/ (timeout 10 seconds) plug.src:12: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. plug.src: I: checking-url http://piorekf.org/plug/download/v1.1.tar.gz (timeout 10 seconds) plug.src: W: invalid-url Source0: http://piorekf.org/plug/download/v1.1.tar.gz HTTP Error 404: Not Found The value should be a valid, public HTTP, HTTPS, or FTP URL. plug.i686: I: checking plug.i686: W: non-standard-group Hardware/Other The value of the Group tag in the package is not valid. Valid groups are: Amusements/Games, Amusements/Graphics, Applications/Archiving, Applications/Communications, Applications/Databases, Applications/Editors, Applications/Emulators, Applications/Engineering, Applications/File, Applications/Internet, Applications/Multimedia, Applications/Productivity, Applications/Publishing, Applications/System, Applications/Text, Development/Debug, Development/Debuggers, Development/Languages, Development/Libraries, Development/System, Development/Tools, Documentation, System Environment/Base, System Environment/Daemons, System Environment/Kernel, System Environment/Libraries, System Environment/Shells, Unspecified, User Interface/Desktops, User Interface/X, User Interface/X Hardware Support. plug.i686: I: checking-url http://piorekf.org/plug/ (timeout 10 seconds) plug.i686: W: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. plug.i686: W: no-manual-page-for-binary plug Each executable in standard binary directories should have a man page. plug.x86_64: I: checking plug.x86_64: W: non-standard-group Hardware/Other The value of the Group tag in the package is not valid. Valid groups are: Amusements/Games, Amusements/Graphics, Applications/Archiving, Applications/Communications, Applications/Databases, Applications/Editors, Applications/Emulators, Applications/Engineering, Applications/File, Applications/Internet, Applications/Multimedia, Applications/Productivity, Applications/Publishing, Applications/System, Applications/Text, Development/Debug, Development/Debuggers, Development/Languages, Development/Libraries, Development/System, Development/Tools, Documentation, System Environment/Base, System Environment/Daemons, System Environment/Kernel, System Environment/Libraries, System Environment/Shells, Unspecified, User Interface/Desktops, User Interface/X, User Interface/X Hardware Support. plug.x86_64: I: checking-url http://piorekf.org/plug/ (timeout 10 seconds) plug.x86_64: W: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. plug.x86_64: W: no-manual-page-for-binary plug Each executable in standard binary directories should have a man page. plug-debuginfo.i686: I: checking plug-debuginfo.i686: I: checking-url http://piorekf.org/plug/ (timeout 10 seconds) plug-debuginfo.x86_64: I: checking plug-debuginfo.x86_64: I: checking-url http://piorekf.org/plug/ (timeout 10 seconds) plug.spec:5: W: non-standard-group Hardware/Other The value of the Group tag in the package is not valid. Valid groups are: Amusements/Games, Amusements/Graphics, Applications/Archiving, Applications/Communications, Applications/Databases, Applications/Editors, Applications/Emulators, Applications/Engineering, Applications/File, Applications/Internet, Applications/Multimedia, Applications/Productivity, Applications/Publishing, Applications/System, Applications/Text, Development/Debug, Development/Debuggers, Development/Languages, Development/Libraries, Development/System, Development/Tools, Documentation, System Environment/Base, System Environment/Daemons, System Environment/Kernel, System Environment/Libraries, System Environment/Shells, Unspecified, User
[Bug 856002] Review Request: plug - Linux software for Fender Mustang amplifiers
https://bugzilla.redhat.com/show_bug.cgi?id=856002 --- Comment #2 from Jonathan Underwood jonathan.underw...@gmail.com --- Spec URL: http://fedorapeople.org/~jgu/plug.spec SRPM URL: http://fedorapeople.org/~jgu/plug-1.1-4.fc17.src.rpm * Sun Sep 23 2012 Jonathan G. Underwood jonathan.underw...@gmail.com - 1.1-4 - Remove BuildRequires for gcc-c++ - Use pkgconfig style BuildRequires for qt-devel -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856002] Review Request: plug - Linux software for Fender Mustang amplifiers
https://bugzilla.redhat.com/show_bug.cgi?id=856002 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added CC||mario.blaetterm...@gmail.co ||m --- Comment #1 from Mario Blättermann mario.blaetterm...@gmail.com --- gcc-c++ is part of the minimum build environment, please drop it from BR: http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
