[Bug 856560] Review Request: pg_journal - Module for sending PostgreSQL log messages directly to the systemd journal
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=856560 ma...@juffo.org changed: What|Removed |Added CC||ma...@juffo.org --- Comment #14 from ma...@juffo.org --- Not sure if this is the appropriate medium, but I (upstream) have released a new version 0.2.0. Binaries: https://bitbucket.org/intgr/pg_journal/downloads Changelog: * `SYSLOG_IDENTIFIER` is now set from the `syslog_ident` GUC variable, rather than process title, which changes. Makes journalctl output prettier. * Fix build with PostgreSQL 9.3 and later. * Add new fields SCHEMA, TABLE, COLUMN, DATATYPE, CONSTRAINT, introduced in PostgreSQL 9.3. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lGQZBtoXaLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856560] Review Request: pg_journal - Module for sending PostgreSQL log messages directly to the systemd journal
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=856560 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2013-02-03 08:50:39 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qdM0P41iaAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856560] Review Request: pg_journal - Module for sending PostgreSQL log messages directly to the systemd journal
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=856560 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- pg_journal-0.1.1-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=e1qvcXhfJWa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856560] Review Request: pg_journal - Module for sending PostgreSQL log messages directly to the systemd journal
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=856560 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zKgUZGJSSRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856560] Review Request: pg_journal - Module for sending PostgreSQL log messages directly to the systemd journal
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=856560 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- pg_journal-0.1.1-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Nmo38ZV9eMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856560] Review Request: pg_journal - Module for sending PostgreSQL log messages directly to the systemd journal
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=856560 Tomasz Torcz zdzi...@irc.pl changed: What|Removed |Added CC|ma...@juffo.org | Flags||fedora-cvs? --- Comment #9 from Tomasz Torcz zdzi...@irc.pl --- New Package SCM Request === Package Name: pg_journal Short Description: PostgreSQL module for sending log messages to the systemd journal Owners: ttorcz Branches: f18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=j0vhebuq6ta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856560] Review Request: pg_journal - Module for sending PostgreSQL log messages directly to the systemd journal
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=856560 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=okVAmoaIpia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856560] Review Request: pg_journal - Module for sending PostgreSQL log messages directly to the systemd journal
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=856560 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IH24EoSvE9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856560] Review Request: pg_journal - Module for sending PostgreSQL log messages directly to the systemd journal
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=856560 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- pg_journal-0.1.1-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/pg_journal-0.1.1-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DOnDCvG9Ssa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856560] Review Request: pg_journal - Module for sending PostgreSQL log messages directly to the systemd journal
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=856560 Michael Scherer m...@zarb.org changed: What|Removed |Added CC||m...@zarb.org Assignee|nob...@fedoraproject.org|m...@zarb.org Flags||fedora-review? --- Comment #5 from Michael Scherer m...@zarb.org --- Let's take a look -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MkDiiDfh3Ea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856560] Review Request: pg_journal - Module for sending PostgreSQL log messages directly to the systemd journal
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=856560
--- Comment #6 from Michael Scherer m...@zarb.org ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= Issues =
- %build honors applicable compiler flags or justifies otherwise.
The compiler options (especially the hardening options) are not used, and
guidelines recommend them
( unless I am wrong ). Is there some trick ( like postgresql taking care of
this by itself )
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 1 files have unknown license. Detailed output of
licensecheck in
/home/misc/checkout/git/FedoraReview/856560-pg_journal/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 10240 bytes in 1 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of
[Bug 856560] Review Request: pg_journal - Module for sending PostgreSQL log messages directly to the systemd journal
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=856560 --- Comment #7 from ma...@juffo.org --- (In reply to comment #6) - %build honors applicable compiler flags or justifies otherwise. The compiler options (especially the hardening options) are not used, and guidelines recommend them ( unless I am wrong ). Is there some trick ( like postgresql taking care of this by itself ) Did you check the gcc command lines generated by make? It should automatically pick up whatever compiler flags were used to build PostgreSQL from /usr/lib/postgresql/pgxs/src/Makefile.global (or wherever it is located in Fedora) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4QDyRv9MX2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856560] Review Request: pg_journal - Module for sending PostgreSQL log messages directly to the systemd journal
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=856560 Michael Scherer m...@zarb.org changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #8 from Michael Scherer m...@zarb.org --- Indeed, so I guess the package is good. I would add a comment for the %build issue, so if there is someone checking, he will not do the same error as me, but that can be done later. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=E2godUcU2Va=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856560] Review Request: pg_journal - Module for sending PostgreSQL log messages directly to the systemd journal
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=856560 --- Comment #4 from Tomasz Torcz zdzi...@irc.pl --- Hello? I've fixed all the issues, I believe review can be approved, can't it? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LPVet884nCa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856560] Review Request: pg_journal - Module for sending PostgreSQL log messages directly to the systemd journal
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=856560 --- Comment #3 from Tomasz Torcz zdzi...@irc.pl --- Ping? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856560] Review Request: pg_journal - Module for sending PostgreSQL log messages directly to the systemd journal
https://bugzilla.redhat.com/show_bug.cgi?id=856560 --- Comment #2 from Tomasz Torcz zdzi...@irc.pl --- Thank you for picking this review. I'll ask upstream for LICENSE file, in the meantime I've addressed your remarks. Spec URL: http://ttorcz.fedorapeople.org/pg_journal.spec SRPM URL: http://ttorcz.fedorapeople.org/pg_journal-0.1.1-2.fc18.src.rpm Scratch : http://koji.fedoraproject.org/koji/taskinfo?taskID=4587167 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856560] Review Request: pg_journal - Module for sending PostgreSQL log messages directly to the systemd journal
https://bugzilla.redhat.com/show_bug.cgi?id=856560 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added CC||volke...@gmx.at --- Comment #1 from Volker Fröhlich volke...@gmx.at --- BR systemd-devel I think you should also BR pkgconfig, looking at the Makefile. Remove %defattr(-,root,root,-), it's the default. The package contains no copy of the license. Ask upstream to include one. You're using libdir/pgsql, which belongs to postgresql. postgresql is not required by your package yet. You can use the name macro in Source0. You could also consider to leave a version constraint for postgresql-devel and systemd-devel or a hint on which Fedora release this works. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856560] Review Request: pg_journal - Module for sending PostgreSQL log messages directly to the systemd journal
https://bugzilla.redhat.com/show_bug.cgi?id=856560 Tomasz Torcz zdzi...@irc.pl changed: What|Removed |Added See Also||https://bugzilla.redhat.com ||/show_bug.cgi?id=823937 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
