[Bug 857639] Review Request: duff - Quickly find duplicate files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857639 Bug 857639 depends on bug 859795, which changed state. Bug 859795 Summary: Review Request: sha - File hashing utility https://bugzilla.redhat.com/show_bug.cgi?id=859795 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=68RoX3aUqHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #27 from Fedora Update System upda...@fedoraproject.org --- duff-0.5.2-5.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hvTPaBKliRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #28 from Fedora Update System upda...@fedoraproject.org --- duff-0.5.2-5.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OvsmoFju7ba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #29 from Fedora Update System upda...@fedoraproject.org --- duff-0.5.2-5.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wkaaI9SmQfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #24 from Fedora Update System upda...@fedoraproject.org --- duff-0.5.2-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/duff-0.5.2-5.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tesmYo9THJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #25 from Fedora Update System upda...@fedoraproject.org --- duff-0.5.2-5.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/duff-0.5.2-5.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=izYqZrPAUGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #26 from Fedora Update System upda...@fedoraproject.org --- duff-0.5.2-5.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/duff-0.5.2-5.fc16 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WdCUXzX6O3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857639 Bug 857639 depends on bug 859795, which changed state. Bug 859795 Summary: Review Request: sha - File hashing utility https://bugzilla.redhat.com/show_bug.cgi?id=859795 What|Removed |Added Status|CLOSED |ASSIGNED Resolution|ERRATA |--- -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KZC944ZNhxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857639 Bug 857639 depends on bug 859795, which changed state. Bug 859795 Summary: Review Request: sha - File hashing utility https://bugzilla.redhat.com/show_bug.cgi?id=859795 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eLnXRIANZTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=857639
--- Comment #23 from Michael Schwendt mschwe...@gmail.com ---
* Directory %{_datadir}/duff/ is not included.
%check
make DESTDIR=%{buildroot} check
Didn't perform any checks according to the build.log.
Btw, as %check is run after %install, one typically places the %check section
below the %install section in the spec file.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=reA9hcn9L7a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857639 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-12-01 03:33:11 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- duff-0.5.2-4.fc16 has been pushed to the Fedora 16 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #21 from Fedora Update System upda...@fedoraproject.org --- duff-0.5.2-4.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #22 from Fedora Update System upda...@fedoraproject.org --- duff-0.5.2-4.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857639 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- duff-0.5.2-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/duff-0.5.2-4.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- duff-0.5.2-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/duff-0.5.2-4.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- duff-0.5.2-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/duff-0.5.2-4.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857639 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- duff-0.5.2-4.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #15 from Eduardo Echeverria echevemas...@gmail.com --- rpmlint -v duff-0.5.2-4.fc17.x86_64.rpm duff.x86_64: I: checking duff.x86_64: I: checking-url http://duff.sourceforge.net/ (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings rpmlint -v duff-debuginfo-0.5.2-4.fc17.x86_64.rpm duff-debuginfo.x86_64: I: checking duff-debuginfo.x86_64: I: checking-url http://duff.sourceforge.net/ (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint -v duff-0.5.2-4.fc17.src.rpm duff.src: I: checking duff.src: I: checking-url http://duff.sourceforge.net/ (timeout 10 seconds) duff.src: I: checking-url http://sourceforge.net/projects/duff/files/duff/0.5.2/duff-0.5.2.tar.gz (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #12 from Eduardo Echeverria echevemas...@gmail.com --- I've built duff against the sha libs, here the spec and SRPM, I grateful a final review please SPEC:http://echevemaster.fedorapeople.org/duff/4/duff.spec SRPM: http://echevemaster.fedorapeople.org/duff/4/duff-0.5.2-4.fc17.src.rpm Koji Build Rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=4648530 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #13 from Eduardo Echeverria echevemas...@gmail.com --- Created attachment 636879 -- https://bugzilla.redhat.com/attachment.cgi?id=636879action=edit Linking to shared library of sha -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #14 from Eduardo Echeverria echevemas...@gmail.com --- Created attachment 636880 -- https://bugzilla.redhat.com/attachment.cgi?id=636880action=edit Remove docs of bundle sha -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
https://bugzilla.redhat.com/show_bug.cgi?id=857639 Eduardo Echeverria echevemas...@gmail.com changed: What|Removed |Added Depends On||859795 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #11 from Eduardo Echeverria echevemas...@gmail.com --- Toshio, Luis I contacted to Allan Saddi (shaX-asaddi) and provided me the necessary source for building shared libraries for duff, now need to do the necessary changes to link against it Sha is in BZ 859795 Regards -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
https://bugzilla.redhat.com/show_bug.cgi?id=857639
--- Comment #5 from Luis Bazan bazanlui...@gmail.com ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
C/C++
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[ ]: MUST Package does not contain kernel modules.
[ ]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
Generic
[x]: EXTRA Rpmlint is run on all installed packages.
Note: No rpmlint messages.
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[ ]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[ ]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[ ]: MUST Package contains no bundled libraries.
[ ]: MUST Changelog in prescribed format.
[ ]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[ ]: MUST Macros in Summary, %description expandable at SRPM build time.
[ ]: MUST Package contains desktop file if it is a GUI application.
[ ]: MUST Development files must be in a -devel package
[ ]: MUST Package requires other packages for directories it uses.
[ ]: MUST Package uses nothing in %doc for runtime.
[ ]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[ ]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[ ]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[ ]: MUST License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
BSD (2 clause), GPL (v3 or later), zlib/libpng For detailed output
of licensecheck see file:
/home/soporte/rpmbuild/SPECS/857639-duff/licensecheck.txt
[ ]: MUST The spec file handles locales properly.
[ ]: MUST Package consistently uses macro is (instead of hard-coded directory
names).
[x]: MUST Package is named using only allowed ascii characters.
[ ]: MUST Package is named according to the Package Naming Guidelines.
[ ]: MUST Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[ ]: MUST Package obeys FHS, except libexecdir and /usr/target.
[ ]: MUST If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: MUST Package must own all directories that it creates.
[ ]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[ ]: MUST Package is not relocatable.
[ ]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
[ ]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[ ]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[ ]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[!]: SHOULD Buildroot is not present
Note: Buildroot is not needed unless packager plans to package for EPEL5
[x]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL5 is required
[ ]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[ ]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[ ]: SHOULD Package functions as described.
[ ]: SHOULD Latest version is packaged.
[ ]: SHOULD Package does not include license text files separate
[Bug 857639] Review Request: duff - Quickly find duplicate files
https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #6 from Luis Bazan bazanlui...@gmail.com --- # rpmlint -v duff-0.5.2-3.fc17.src.rpm duff.src: I: checking duff.src: I: checking-url http://duff.sourceforge.net/ (timeout 10 seconds) duff.src: I: checking-url http://sourceforge.net/projects/duff/files/duff/0.5.2/duff-0.5.2.tar.gz (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. For me everything is ready and corrected what was requested and passed all tests. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
https://bugzilla.redhat.com/show_bug.cgi?id=857639 Luis Bazan bazanlui...@gmail.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|bazanlui...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
https://bugzilla.redhat.com/show_bug.cgi?id=857639 Luis Bazan bazanlui...@gmail.com changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
https://bugzilla.redhat.com/show_bug.cgi?id=857639 Luis Bazan bazanlui...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
https://bugzilla.redhat.com/show_bug.cgi?id=857639 Eduardo Echeverria echevemas...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Eduardo Echeverria echevemas...@gmail.com --- New Package SCM Request === Package Name: duff Short Description: Quickly find duplicate files Owners: echevemaster Branches: f16 f17 f18 InitialCC: lbazan -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #9 from Toshio Ernie Kuratomi a.bad...@gmail.com --- I see some problems here. Including a bundled piece of hashing code: the sha* files are taken from here: http://hg.saddi.com/sha-asaddi That code doesn't produce a shared library -- it just builds a static library that is immediately linked into the sha* command line tools and then the libraries are discarded. You might be able to get a generic bundling exception from the FPC similar to the md5 exceptions: https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Packages_granted_exceptions Or you might need to build the saddi package separately and create a static library from that which you'd then be able to link against here. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #10 from Toshio Ernie Kuratomi a.bad...@gmail.com --- btw, I found those files by doing grep -ri license in the top level of the source tree and noticing that some things talking about different licenses the sha* implementation. That lead to more scrutiny of those files to find out what their source was. (And along with that, the license for those files are different than the license for the other duff files. I believe it's BSD rather than zlib). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #4 from Eduardo Echeverria echevemas...@gmail.com --- Remove rm -rf buildroot in the clean section Corrected Spec and SRPM = Spec URL: http://echevemaster.fedorapeople.org/duff/3/duff.spec SRPM URL: http://echevemaster.fedorapeople.org/duff/3/duff-0.5.2-3.fc17.src.rpm rpmlint -i duff-0.5.2-3.fc17.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint -i duff-0.5.2-3.fc17.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
https://bugzilla.redhat.com/show_bug.cgi?id=857639 Eduardo Echeverria echevemas...@gmail.com changed: What|Removed |Added Summary|duff - Quickly find |Review Request: duff - |duplicate files |Quickly find duplicate ||files -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
https://bugzilla.redhat.com/show_bug.cgi?id=857639 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC||rdie...@math.unl.edu --- Comment #2 from Rex Dieter rdie...@math.unl.edu --- Initial comments: * no need to BuildRequires: glibc-devel see: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 (glibc-devel is a dependency of gcc already) * please document the need for automake, autoconf, libtool -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #3 from Eduardo Echeverria echevemas...@gmail.com --- (In reply to comment #2) Initial comments: * no need to BuildRequires: glibc-devel see: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 (glibc-devel is a dependency of gcc already) * please document the need for automake, autoconf, libtool Rex You're right, do not need any of these BuildRequires Sorry!! in the README Building Duff If you got this source tree from a Git repository then you will need to bootstrap the build environment using `bootstrap.sh'. Note that this script requires GNU autoconf, automake and gettext to run. Also note that running gettextize may cause a few duplicate entries in various build files. To remove these, use `git reset --hard`. If (or once) you have a `configure' script, go ahead and run it. No additional magic should be required. If it is, then that's a bug and should be reported. Corrected Spec and SRPM = Spec URL: http://echevemaster.fedorapeople.org/duff/2/duff.spec SRPM URL: http://echevemaster.fedorapeople.org/duff/2/duff-0.5.2-2.fc17.src.rpm rpmlint -i duff-0.5.2-2.fc17.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint -i duff-0.5.2-2.fc17.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Regards -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
