[Bug 858082] Review Request: mingw-qt5-qttranslations - Qt5 for Windows - QtTranslations component
https://bugzilla.redhat.com/show_bug.cgi?id=858082 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||mingw-qt5-qtimageformats-5. ||0.2-2.fc19 Resolution|--- |ERRATA Last Closed||2013-06-13 02:38:18 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- mingw-qt5-qtimageformats-5.0.2-2.fc19, mingw-qt5-qtgraphicaleffects-5.0.2-4.fc19, mingw-qt5-qttranslations-5.0.2-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DOi21GJn5Ga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858082] Review Request: mingw-qt5-qttranslations - Qt5 for Windows - QtTranslations component
https://bugzilla.redhat.com/show_bug.cgi?id=858082 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|mingw-qt5-qtimageformats-5. |mingw-qt5-qtimageformats-5. |0.2-2.fc19 |0.2-2.fc18 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- mingw-qt5-qtimageformats-5.0.2-2.fc18, mingw-qt5-qtgraphicaleffects-5.0.2-4.fc18, mingw-qt5-qttranslations-5.0.2-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4WWYjxFsnUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858082] Review Request: mingw-qt5-qttranslations - Qt5 for Windows - QtTranslations component
https://bugzilla.redhat.com/show_bug.cgi?id=858082 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- mingw-qt5-qtimageformats-5.0.2-2.fc19, mingw-qt5-qtgraphicaleffects-5.0.2-4.fc19, mingw-qt5-qttranslations-5.0.2-2.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=B2uVkoj3JZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858082] Review Request: mingw-qt5-qttranslations - Qt5 for Windows - QtTranslations component
https://bugzilla.redhat.com/show_bug.cgi?id=858082 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=l9aj2nrljNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858082] Review Request: mingw-qt5-qttranslations - Qt5 for Windows - QtTranslations component
https://bugzilla.redhat.com/show_bug.cgi?id=858082 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- mingw-qt5-qtimageformats-5.0.2-2.fc19,mingw-qt5-qtgraphicaleffects-5.0.2-4.fc19,mingw-qt5-qttranslations-5.0.2-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mingw-qt5-qtimageformats-5.0.2-2.fc19,mingw-qt5-qtgraphicaleffects-5.0.2-4.fc19,mingw-qt5-qttranslations-5.0.2-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3wFfI6Ebqia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858082] Review Request: mingw-qt5-qttranslations - Qt5 for Windows - QtTranslations component
https://bugzilla.redhat.com/show_bug.cgi?id=858082 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- mingw-qt5-qtimageformats-5.0.2-2.fc18,mingw-qt5-qtgraphicaleffects-5.0.2-4.fc18,mingw-qt5-qttranslations-5.0.2-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mingw-qt5-qtimageformats-5.0.2-2.fc18,mingw-qt5-qtgraphicaleffects-5.0.2-4.fc18,mingw-qt5-qttranslations-5.0.2-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qBH4oV3I1la=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858082] Review Request: mingw-qt5-qttranslations - Qt5 for Windows - QtTranslations component
https://bugzilla.redhat.com/show_bug.cgi?id=858082 greg.helli...@gmail.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #8 from greg.helli...@gmail.com --- I'm getting mingw-qt5-qttranslations.src: W: invalid-url URL: http://www.qtsoftware.com/ timed out. We just spoke on IRC about updating that to qt-project.org. Everything else appears to be addressed. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5gSqlUtFlLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858082] Review Request: mingw-qt5-qttranslations - Qt5 for Windows - QtTranslations component
https://bugzilla.redhat.com/show_bug.cgi?id=858082 Erik van Pienbroek erik-fed...@vanpienbroek.nl changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Erik van Pienbroek erik-fed...@vanpienbroek.nl --- Thanks for the review! New Package SCM Request === Package Name: mingw-qt5-qttranslations Short Description: Qt5 for Windows - QtTranslations component Owners: epienbro Branches: f17 f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qeb3FtNG58a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858082] Review Request: mingw-qt5-qttranslations - Qt5 for Windows - QtTranslations component
https://bugzilla.redhat.com/show_bug.cgi?id=858082 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tHXiLWt82Ga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858082] Review Request: mingw-qt5-qttranslations - Qt5 for Windows - QtTranslations component
https://bugzilla.redhat.com/show_bug.cgi?id=858082 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gCJaZPdWPHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858082] Review Request: mingw-qt5-qttranslations - Qt5 for Windows - QtTranslations component
https://bugzilla.redhat.com/show_bug.cgi?id=858082 --- Comment #7 from Erik van Pienbroek erik-fed...@vanpienbroek.nl --- Here's another scratch build with the srpm: SRPM URL: http://kojipkgs.fedoraproject.org//work/tasks/3287/5443287/mingw-qt5-qttranslations-5.0.2-1.fc20.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5443287 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6ANg26xfvla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858082] Review Request: mingw-qt5-qttranslations - Qt5 for Windows - QtTranslations component
https://bugzilla.redhat.com/show_bug.cgi?id=858082 --- Comment #6 from greg.helli...@gmail.com --- The spec file looks fine upon inspection but I can't get the SRPM from the koji link. I'm guessing koji doesn't keep those files around forever and I was too slow in getting back to this. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5ODmKVFTEAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858082] Review Request: mingw-qt5-qttranslations - Qt5 for Windows - QtTranslations component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858082 Erik van Pienbroek erik-fed...@vanpienbroek.nl changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #5 from Erik van Pienbroek erik-fed...@vanpienbroek.nl --- Updated Spec URL: http://svn.nntpgrab.nl/svn/fedora_cross/mingw-qt5-qttranslations/mingw-qt5-qttranslations.spec Updated SRPM URL: http://kojipkgs.fedoraproject.org/work/tasks/1793/5331793/mingw-qt5-qttranslations-5.0.2-1.fc20.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5331793 * Sat May 4 2013 Erik van Pienbroek epien...@fedoraproject.org - 5.0.2-1 - Update to 5.0.2 - Don't generate debuginfo packages - Dropped the temporary BR: mingw32-qt-qmake mingw64-qt-qmake as the package mingw-qt5-qttools is in Fedora now - Use the %mingw_find_lang macro - Updated the Source URL -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RavwlBZtQra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858082] Review Request: mingw-qt5-qttranslations - Qt5 for Windows - QtTranslations component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858082 greg.helli...@gmail.com changed: What|Removed |Added CC||greg.helli...@gmail.com Assignee|nob...@fedoraproject.org|greg.helli...@gmail.com Flags||fedora-review? --- Comment #3 from greg.helli...@gmail.com --- Taking for review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=weduUwoiTga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858082] Review Request: mingw-qt5-qttranslations - Qt5 for Windows - QtTranslations component
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858082
--- Comment #4 from greg.helli...@gmail.com ---
$ rpmlint mingw-qt5-qttranslations.spec
mingw-qt5-qttranslations.spec:26: W: macro-in-comment %{qt_module}
mingw-qt5-qttranslations.spec:26: W: macro-in-comment %{snapshot_rev}
mingw-qt5-qttranslations.spec:26: W: macro-in-comment %{qt_module}
mingw-qt5-qttranslations.spec:26: W: macro-in-comment %{snapshot_rev}
0 packages and 1 specfiles checked; 0 errors, 4 warnings.
$ rpmlint mingw-qt5-qttranslations-5.0.1-1.fc19.src.rpm
mingw-qt5-qttranslations.src:26: W: macro-in-comment %{qt_module}
mingw-qt5-qttranslations.src:26: W: macro-in-comment %{snapshot_rev}
mingw-qt5-qttranslations.src:26: W: macro-in-comment %{qt_module}
mingw-qt5-qttranslations.src:26: W: macro-in-comment %{snapshot_rev}
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
$ rpmlint results_mingw-qt5-qttranslations/5.0.1/1.fc18/mingw{32,64}*
mingw32-qt5-qttranslations.noarch: W: no-documentation
mingw32-qt5-qttranslations-debuginfo.noarch: E: empty-debuginfo-package
mingw64-qt5-qttranslations.noarch: W: no-documentation
mingw64-qt5-qttranslations-debuginfo.noarch: E: empty-debuginfo-package
4 packages and 0 specfiles checked; 2 errors, 2 warnings.
Since there is no binary portion to this package, it appears you should disable
building of the debuginfo packages.
$ rpm -q --requires mingw32-qt5-qttranslations
rpmlib(FileDigests) = 4.6.0-1
rpmlib(PayloadFilesHavePrefix) = 4.0-1
rpmlib(CompressedFileNames) = 3.0.4-1
rpmlib(PayloadIsXz) = 5.2-1
$ rpm -q --requires mingw64-qt5-qttranslations
rpmlib(FileDigests) = 4.6.0-1
rpmlib(PayloadFilesHavePrefix) = 4.0-1
rpmlib(CompressedFileNames) = 3.0.4-1
rpmlib(PayloadIsXz) = 5.2-1
$ rpm -q --provides mingw32-qt5-qttranslations
mingw32-qt5-qttranslations = 5.0.1-1.fc18
$ rpm -q --provides mingw64-qt5-qttranslations
mingw64-qt5-qttranslations = 5.0.1-1.fc18
$ wget --quiet
http://releases.qt-project.org/qt5/5.0.1/submodules_tar/qttranslations-opensource-src-5.0.1.tar.xz
-O - | md5sum
de27f8384296e366e454754b69197634 -
$ md5sum qttranslations-opensource-src-5.0.1.tar.xz
de27f8384296e366e454754b69197634 qttranslations-opensource-src-5.0.1.tar.xz
+ OK
! Needs to be looked into
/ Not applicable
[+] Compliant with generic Fedora Packaging Guidelines
[+] Source package name is prefixed with 'mingw-'
[+] Spec file starts with %{?mingw_package_header}
[+] BuildRequires: mingw32-filesystem = 95 is in the .spec file
[+] BuildRequires: mingw64-filesystem = 95 is in the .spec file
[+] Spec file contains %package sections for both mingw32 and mingw64 packages
[+] Binary mingw32 and mingw64 packages are noarch
[+] Spec file contains %{?mingw_debug_package} after the %description section
[+] Uses one of the macros %mingw_configure, %mingw_cmake, %mingw_cmake_kde4
or %mingw_qmake_qt5 to configure the package
[+] Uses the macro %mingw_make to build the package
[+] Uses the macro %mingw_make to install the package
[!] If package contains translations, the %mingw_find_lang macro must be used
[+] No binary package named mingw-$pkgname is generated
[+] Libtool .la files are not bundled
[+] .def files are not bundled
[+] Man pages which duplicate native package are not bundled
[+] Info files which duplicate native package are not bundled
[+] Provides of the binary mingw32 and mingw64 packages are equal
[+] Requires of the binary mingw32 and mingw64 packages are equal
I believe the debug package can be suppressed as there is no binary code which
includes debug symbols here.
Additionally, this package is, by its very nature, a translations package. Yet
you're not using the find_lang macro. Does it not support .qm files? Does it
need to be updated to include these files as well, or are qm files considered
too app specific for that?
You note that the BR for mingw32-qt-qmake and mingw64-qt-qmake are Temporary
until lrelease-qt5 is built. I don't see a native package for those yet, but I
see mingw{32,64}-qt5-qttools-lrelease. Is the native package built and ready
yet? If not, you might note what issue # will see it completed in the spec file
for sanity's sake.
The rest of the issues have been addressed elsewhere in mingw-qt5 reviews.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=fSNZqvLswZa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858082] Review Request: mingw-qt5-qttranslations - Qt5 for Windows - QtTranslations component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858082 Bug 858082 depends on bug 858080, which changed state. Bug 858080 Summary: Review Request: mingw-qt5-qttools - Qt5 for Windows - QtTools component https://bugzilla.redhat.com/show_bug.cgi?id=858080 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mLOvOrToGIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858082] Review Request: mingw-qt5-qttranslations - Qt5 for Windows - QtTranslations component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858082 Erik van Pienbroek erik-fed...@vanpienbroek.nl changed: What|Removed |Added Depends On||858080 --- Comment #2 from Erik van Pienbroek erik-fed...@vanpienbroek.nl --- Updated Spec URL: http://svn.openftd.org/svn/fedora_cross/mingw-qt5-qttranslations/mingw-qt5-qttranslations.spec Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/work/tasks/1813/1813/mingw-qt5-qttranslations-5.0.1-1.fc19.src.rpm Koji scratch build: http://koji.vanpienbroek.nl/koji/buildinfo?buildID=126 * Sat Feb 9 2013 Erik van Pienbroek epien...@fedoraproject.org - 5.0.1-1 - Update to 5.0.1 Note: this package currently fails to build, because it depends on the lrelease tool which is part of mingw-qt5-qttools. Once the mingw-qt5-qttools package (bug 858080) is approved (and the qmake.conf which is part of mingw-qt5-qtbase is updated) this package should build fine -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oyDgUaMQ7Ma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858082] Review Request: mingw-qt5-qttranslations - Qt5 for Windows - QtTranslations component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858082 Bug 858082 depends on bug 858058, which changed state. Bug 858058 Summary: Review Request: mingw-qt5-qtbase - Qt5 for Windows - QtBase component https://bugzilla.redhat.com/show_bug.cgi?id=858058 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CiCcNel7Pia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858082] Review Request: mingw-qt5-qttranslations - Qt5 for Windows - QtTranslations component
https://bugzilla.redhat.com/show_bug.cgi?id=858082 --- Comment #1 from Erik van Pienbroek erik-fed...@vanpienbroek.nl --- Updated Spec URL: http://svn.openftd.org/svn/fedora_cross/mingw-qt5-qttranslations/mingw-qt5-qttranslations.spec Updated SRPM URL: http://build1.openftd.org/fedora-cross/src/mingw-qt5-qttranslations-5.0.0-0.2.beta1.git20121112.ad9181a5.fc19.src.rpm * Mon Nov 12 2012 Erik van Pienbroek epien...@fedoraproject.org - 5.0.0-0.2.beta1.git20121112.ad9181a5 - Update to 20121112 snapshot (rev ad9181a5) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858082] Review Request: mingw-qt5-qttranslations - Qt5 for Windows - QtTranslations component
https://bugzilla.redhat.com/show_bug.cgi?id=858082 Erik van Pienbroek erik-fed...@vanpienbroek.nl changed: What|Removed |Added Depends On||858058 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
