[Bug 859469] Review Request: nemo - File manager for Cinnamon
https://bugzilla.redhat.com/show_bug.cgi?id=859469 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859469] Review Request: nemo - File manager for Cinnamon
https://bugzilla.redhat.com/show_bug.cgi?id=859469 --- Comment #15 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859469] Review Request: nemo - File manager for Cinnamon
https://bugzilla.redhat.com/show_bug.cgi?id=859469 leigh scott changed: What|Removed |Added Flags||fedora-cvs? --- Comment #14 from leigh scott --- Package Change Request == Package Name: nemo New Branches: epel7 Owners: leigh123linux -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859469] Review Request: nemo - File manager for Cinnamon
https://bugzilla.redhat.com/show_bug.cgi?id=859469 --- Comment #13 from Jon Ciesla --- No epel7 branches yet. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859469] Review Request: nemo - File manager for Cinnamon
https://bugzilla.redhat.com/show_bug.cgi?id=859469 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859469] Review Request: nemo - File manager for Cinnamon
https://bugzilla.redhat.com/show_bug.cgi?id=859469 leigh scott changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #12 from leigh scott --- Package Change Request == Package Name: nemo New Branches: epel7 Owners: leigh123linux -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859469] Review Request: nemo - File manager for Cinnamon
https://bugzilla.redhat.com/show_bug.cgi?id=859469 Christopher Meng changed: What|Removed |Added Status|NEW |CLOSED CC||cicku...@gmail.com Resolution|--- |CURRENTRELEASE Last Closed||2013-11-21 10:44:42 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859469] Review Request: nemo - File manager for Cinnamon
https://bugzilla.redhat.com/show_bug.cgi?id=859469 Bill Nottingham changed: What|Removed |Added Status|CLOSED |NEW Last Closed|2013-11-21 10:44:42 | CC|cicku...@gmail.com | Resolution|CURRENTRELEASE |--- Keywords||Reopened -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859469] Review Request: nemo - File manager for Cinnamon
https://bugzilla.redhat.com/show_bug.cgi?id=859469 Christopher Meng changed: What|Removed |Added Status|NEW |CLOSED CC||cicku...@gmail.com Resolution|--- |CURRENTRELEASE Last Closed||2013-11-21 11:02:44 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859469] Review Request: nemo - File manager for Cinnamon
https://bugzilla.redhat.com/show_bug.cgi?id=859469 --- Comment #11 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859469] Review Request: nemo - File manager for Cinnamon
https://bugzilla.redhat.com/show_bug.cgi?id=859469 leigh scott changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from leigh scott --- New Package SCM Request === Package Name: nemo Short Description: File manager for Cinnamon Owners: leigh123linux Branches: f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859469] Review Request: nemo - File manager for Cinnamon
https://bugzilla.redhat.com/show_bug.cgi?id=859469 --- Comment #8 from leigh scott --- As for the FSF errors https://github.com/linuxmint/nemo/commit/b6dcfc14ae8cd060eee2e1b03630c9c11986d7c4 and more https://github.com/linuxmint/nemo/pull/24 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859469] Review Request: nemo - File manager for Cinnamon
https://bugzilla.redhat.com/show_bug.cgi?id=859469 --- Comment #7 from leigh scott --- Spec URL: http://leigh123linux.fedorapeople.org/pub/review/nemo/3/nemo.spec SRPM URL: http://leigh123linux.fedorapeople.org/pub/review/nemo/3/nemo-1.0.1-3.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859469] Review Request: nemo - File manager for Cinnamon
https://bugzilla.redhat.com/show_bug.cgi?id=859469
--- Comment #6 from leigh scott ---
(In reply to comment #4)
> a little hint.
> %{_sysconfdir}/xdg/autostart/nemo-autostart.desktop
> has to validate with desktop-file-utils
Do I have to?
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859469] Review Request: nemo - File manager for Cinnamon
https://bugzilla.redhat.com/show_bug.cgi?id=859469 --- Comment #5 from leigh scott --- Spec URL: http://leigh123linux.fedorapeople.org/pub/review/nemo/2/nemo.spec SRPM URL: http://leigh123linux.fedorapeople.org/pub/review/nemo/2/nemo-1.0.1-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859469] Review Request: nemo - File manager for Cinnamon
https://bugzilla.redhat.com/show_bug.cgi?id=859469
--- Comment #4 from Wolfgang Ulbrich ---
a little hint.
%{_sysconfdir}/xdg/autostart/nemo-autostart.desktop
has to validate with desktop-file-utils
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859469] Review Request: nemo - File manager for Cinnamon
https://bugzilla.redhat.com/show_bug.cgi?id=859469
--- Comment #3 from Wolfgang Ulbrich ---
(In reply to comment #2)
> (In reply to comment #1)
> > 1. Some issues in file section of the spec:
> > -- change %{_sysconfdir}/xdg/autostart/nemo-autostart.desktop to
> > %config(noreplace) %{_sysconfdir}/xdg/autostart/nemo-autostart.desktop
> No. It doesn't make sense to tag this Autostart file as %config, since it's
> not intended to be modified in any way by users.
agree, a desktop file isn't a config file.
pls change
%{_mandir}/man1/nemo-connect-server.1.gz
%{_mandir}/man1/nemo.1.gz
to
%{_mandir}/man1/nemo-connect-server.1.*
%{_mandir}/man1/nemo.1.*
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859469] Review Request: nemo - File manager for Cinnamon
https://bugzilla.redhat.com/show_bug.cgi?id=859469
Mohamed El Morabity changed:
What|Removed |Added
CC||pikachu.2...@gmail.com
--- Comment #2 from Mohamed El Morabity ---
(In reply to comment #1)
> 1. Some issues in file section of the spec:
> -- change %{_sysconfdir}/xdg/autostart/nemo-autostart.desktop to
> %config(noreplace) %{_sysconfdir}/xdg/autostart/nemo-autostart.desktop
No. It doesn't make sense to tag this Autostart file as %config, since it's not
intended to be modified in any way by users.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859469] Review Request: nemo - File manager for Cinnamon
https://bugzilla.redhat.com/show_bug.cgi?id=859469
--- Comment #1 from Wolfgang Ulbrich ---
1. Some issues in file section of the spec:
-- change %{_datadir}/nemo to %{_datadir}/nemo/ for own the directory
-- change %{_includedir}/nemo to %{_includedir}/nemo/ for own the directory
-- change %{_sysconfdir}/xdg/autostart/nemo-autostart.desktop to
%config(noreplace) %{_sysconfdir}/xdg/autostart/nemo-autostart.desktop
2. I think we can remove provide/obsolete eel2/gnome-volume-manager stuff.
This are apps from f10/f11 and no application need this anymore.
[rave@mother ~]$ repoquery --whatrequires eel2
[rave@mother ~]$ repoquery --whatrequires gnome-volume-manager
gives no output.
3. rpmlint errors and warnings
rave@mother ~]$ rpmlint -iv /home/rave/rpmbuild/SPECS/others/nemo.spec
/home/rave/rpmbuild/SPECS/others/nemo.spec:22: W: macro-in-comment
%{_internal_version}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
/home/rave/rpmbuild/SPECS/others/nemo.spec:22: W: macro-in-comment %{version}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
/home/rave/rpmbuild/SPECS/others/nemo.spec:22: W: macro-in-comment
%{_internal_version}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
/home/rave/rpmbuild/SPECS/others/nemo.spec:103: W: macro-in-comment %patch1
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
/home/rave/rpmbuild/SPECS/others/nemo.spec: W: patch-not-applied Patch1:
nemo-3.4.3-unmount-notification.patch
A patch is included in your package but was not applied. Refer to the patches
documentation to see what's wrong.
/home/rave/rpmbuild/SPECS/others/nemo.spec: I: checking-url
http://leigh123linux.fedorapeople.org/pub/nemo/source/nemo-1.0.1.tar.gz
(timeout 10 seconds)
0 packages and 1 specfiles checked; 0 errors, 5 warnings.
Pls, delete the patch if you don't want to use them.
[rave@mother ~]$ rpmlint -iv
/var/lib/mock/fedora-17-x86_64/nemo-1.0.1-1.fc17.x86_64.rpm
nemo.x86_64: I: checking
nemo.x86_64: W: spelling-error %description -l en_US filesystems -> file
systems, file-systems, ecosystems
The value of this tag appears to be misspelled. Please double-check.
nemo.x86_64: I: checking-url https://github.com/linuxmint/nemo (timeout 10
seconds)
nemo.x86_64: E: incorrect-fsf-address /usr/share/doc/nemo-1.0.1/COPYING.LIB
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
nemo.x86_64: E: incorrect-fsf-address /usr/share/doc/nemo-1.0.1/COPYING-DOCS
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
nemo.x86_64: E: incorrect-fsf-address /usr/share/doc/nemo-1.0.1/COPYING
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
nemo.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/nemo-autostart.desktop
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.
nemo.x86_64: W: no-manual-page-for-binary nemo-autorun-software
Each executable in standard binary directories should have a man page.
1 packages and 0 specfiles checked; 3 errors, 3 warnings.
Notice upstream about incorrect-fsf-address.
[rave@mother ~]$ rpmlint -iv
/var/lib/mock/fedora-17-x86_64/nemo-extensions-1.0.1-1.fc17.x86_64.rpm
nemo-extensions.x86_64: I: checking
nemo-extensions.x86_64: I: checking-url https://github.com/linuxmint/nemo
(timeout 10 seconds)
nemo-extensions.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
nemo-extensions.x86_64: E: library-without-ldconfig-postin
/usr/lib64/libnemo-extension.so.1.4.0
This package contains a library and provides no %post scriptlet containing a
call to ldconfig.
nemo-extensions.x86_64: E: library-without-ldconfig-postun
/usr/lib64/libnemo-extension.so.1.4.0
This package contains a library and provides no %postun scriptlet containing a
[Bug 859469] Review Request: nemo - File manager for Cinnamon
https://bugzilla.redhat.com/show_bug.cgi?id=859469 Wolfgang Ulbrich changed: What|Removed |Added CC||chat-to...@raveit.de Assignee|nob...@fedoraproject.org|chat-to...@raveit.de Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
