[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-11-14 13:29:18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #34 from Fedora Update System --- valkyrie-2.0.0-5.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #33 from Fedora Update System --- Package valkyrie-2.0.0-5.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing valkyrie-2.0.0-5.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-17275/valkyrie-2.0.0-5.fc18 then log in and leave karma (feedback). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #32 from Fedora Update System --- valkyrie-2.0.0-5.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/valkyrie-2.0.0-5.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #31 from Fedora Update System --- valkyrie-2.0.0-5.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/valkyrie-2.0.0-5.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #30 from Fedora Update System --- valkyrie-2.0.0-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/valkyrie-2.0.0-5.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #29 from Fedora Update System --- valkyrie-2.0.0-5.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/valkyrie-2.0.0-5.el6 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #28 from Mario Blättermann --- Go to https://admin.fedoraproject.org/updates/, log in and click on "New update" in the left pane. Then you can add the Koji builds and submit them for testing. Don't forget to submit the bug number and activate "Close this bug when update is stable". This makes sure that modifying and closing the review request will handled properly. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #27 from Nathan Scott --- Ah, thanks for the reminder Mario. I'm not sure whether I've missed a step - usually at this point I would use the web interface to mark the packages as "submitted for testing" ... but, https://admin.fedoraproject.org/updates/search/valkyrie gives no results (for my other packages, this shows all the builds). Have a missed setting something up? thanks! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #26 from Mario Blättermann --- Packages for all requested branches have been built, but I cannot find anything in Bodhi. What's the matter? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #25 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 Nathan Scott changed: What|Removed |Added Flags|fedora-cvs+ | Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 Nathan Scott changed: What|Removed |Added Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #24 from Nathan Scott --- New Package SCM Request === Package Name: valkyrie Short Description: Graphical User Interface for Valgrind Suite Owners: nathans Branches: f16 f17 f18 el5 el6 InitialCC: mjw -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #23 from Nathan Scott --- Awesome, thanks for all the help guys! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 Sebastian Dyroff changed: What|Removed |Added Assignee|nob...@fedoraproject.org|fed...@dyroff.org --- Comment #22 from Sebastian Dyroff --- Oops, forgot to edit the assignee field :-). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 Sebastian Dyroff changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-review+ --- Comment #21 from Sebastian Dyroff --- Thanks Mario, for the explanation. All issues are resolved. PACKAGE APPROVED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #20 from Mario Blättermann --- @Sebastian, because you are sponsored in the packagers group now, you might assign this review request to you and complete the review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160
--- Comment #19 from Mario Blättermann ---
(In reply to comment #17)
> I made a complete review now, based on valkyrie-2.0.0-5.el6_3.src.rpm.
>
> There are two remaining issues, but I am not 100% sure about them.
>
> First: Package uses nothing in %doc for runtime. You moved the html
> documentation in %doc. It is shown at runtime when you click on Help ->
> Contents. I think this is not really using it at runtime. If these html
> files are missing, the Online Documentation will be empty.
>
If it works as expected, don't bother with it. Even it it fails to start the
application, users will find the right doc folder according to the package
name, and can open the html stuff in the browser of their choice.
Anyway, anything in %doc must not affect the runtime of an application, see the
review guidelines.
> Second: %build honors applicable compiler flags or justifies otherwise. I do
> not see something like CFLAGS=... in your spec file and I am not familiar
> with qmake Makefile generation, environment CFLAGS set during build. If the
> package honors the compiler flags, tell me how it works :-).
>
This is due to the macro %{?_smp_mflags}. Only in special cases, when CFLAGS,
CXXFLAGS, OPTS or anything similar is harcoded in a pre-built Makefile, the
appropriate definition has to be applied. Mostly the debug packages are empty
if compiler flags are not applied correctly, but rpmlint takes care about this.
> I also do not know how to check: Packages should try to preserve timestamps
> of original installed files. It is only and I marked it with Not evaluated.
> As above, I would be thankful if someone could enlighten me howto check this.
>
With automake, qmake and similar tools timestamps will be preserved anyway.
When installing files manually, make it sure by using the "preserve" switches
(install -p or cp -p).
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #18 from Sebastian Dyroff --- Oh and I forgot to mention, that the issues listed by fedora-review are false positives, because you are intending to package for epel5 and the license thing is checked. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160
--- Comment #17 from Sebastian Dyroff ---
I made a complete review now, based on valkyrie-2.0.0-5.el6_3.src.rpm.
There are two remaining issues, but I am not 100% sure about them.
First: Package uses nothing in %doc for runtime. You moved the html
documentation in %doc. It is shown at runtime when you click on Help ->
Contents. I think this is not really using it at runtime. If these html files
are missing, the Online Documentation will be empty.
Second: %build honors applicable compiler flags or justifies otherwise. I do
not see something like CFLAGS=... in your spec file and I am not familiar with
qmake Makefile generation, environment CFLAGS set during build. If the package
honors the compiler flags, tell me how it works :-).
I also do not know how to check: Packages should try to preserve timestamps of
original installed files. It is only and I marked it with Not evaluated. As
above, I would be thankful if someone could enlighten me howto check this.
I generated a koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4575518
The full fedora-review output with manual checks:
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
C/C++
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[x]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
Generic
[x]: EXTRA Rpmlint is run on all installed packages.
Note: No rpmlint messages.
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[ ]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Sources contain only permissible code or content.
[!]: MUST Each %files section contains %defattr if rpm < 4.4
Note: defattr() present in %files section. This is OK if packaging
for EPEL5. Otherwise not needed
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package contains desktop file if it is a GUI application.
[x]: MUST Package installs a %{name}.desktop using desktop-file-install if
there is such a file.
[-]: MUST Development files must be in a -devel package
[x]: MUST Package requires other packages for directories it uses.
[ ]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[ ]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf is only needed if supporting EPEL5
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[x]: MUST Package consistently uses macro is (instead of hard-coded directory
names).
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[-]: MUST If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Package is not relocatable.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160
--- Comment #16 from Nathan Scott ---
I've uploaded http://oss.sgi.com/~nathans/valkyrie-2.0.0-5.el6_3.src.rpm (and
spec file in same location) which addresses the remaining issues, I think.
Going through the issues/questions listed in c13...
| You are intending to package this for EPEL5 right?
Yes.
| There is a COPYING file which contains the license. It should be listed via
%doc.
*nod* - done.
| The INSTALL file does not look like relevant documentation, it can be
removed.
I read through it again, I think there's some handy tips in there for users, so
I left it for now (unless someone feels strongly that it should go?).
| I think, the license is GPLv2+.
As you guys discussed, I think its OK as is too (no +).
| fedora-review produces the following issues:
| Issues:
| [!]: MUST Each %files section contains %defattr if rpm < 4.4
| Note: defattr() present in %files section. This is OK if packaging
| for EPEL5. Otherwise not needed
Yep, keen to support EPEL5 too.
| See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions
| [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at
the
| beginning of %install.
| Note: rm -rf is only needed if supporting EPEL5
As above.
| [!]: MUST If (and only if) the source package includes the text of the
| license(s) in its own file, then that file, containing the text of the
| license(s) for the package is included in %doc.
Fixed.
| [!]: MUST License field in the package spec file matches the actual license.
| Note: Checking patched sources after %prep for licenses. No licenses
| found. Please check the source files for licenses manually.
COPYING is in %doc now, and License field looks correct as discussed.
| [!]: SHOULD Buildroot is not present
| Note: Invalid buildroot found:
| %{_tmppath}/%{valkyrie}-%{release}-root-%(%{__id_u} -n)
It is present, and thats because we're going for EPEL5 support.
Not clear why it thinks this is invalid, perhaps its use of %{valkyrie}?
Certainly appears to work correctly, and have seen this general pattern
used in a number of other spec files. Hmm, bit odd.
| [!]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or
| $RPM_BUILD_ROOT)
| Note: Clean is needed only if supporting EPEL5
Which we will (support EPEL5), so this is fine.
| [!]: SHOULD Spec use %global instead of %define.
| Note: %define valkyrie %{name}-%{version}
Fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #15 from Sebastian Dyroff --- Sorry, my fault. I read the part of the COPYING about later versions again. Mario is right, it is GPLv2. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #14 from Mario Blättermann --- (In reply to comment #13) > I think, the license is GPLv2+. The COPYING file says GPLv2, and the source file headers doesn't contain the "newer versions" clause. That's why it remains as GPLv2. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160
--- Comment #13 from Sebastian Dyroff ---
You are intending to package this for EPEL5 right? If so, some issues are
irrelevant.
There is a COPYING file which contains the license. It should be listed via
%doc. The INSTALL file does not look like relevant documentation, it can be
removed.
I think, the license is GPLv2+.
fedora-review produces the following issues:
Issues:
[!]: MUST Each %files section contains %defattr if rpm < 4.4
Note: defattr() present in %files section. This is OK if packaging
for EPEL5. Otherwise not needed
See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf is only needed if supporting EPEL5
See: None
[!]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
[!]: MUST License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#ValidLicenseShortNames
There are some SHOULD issues too:
[!]: SHOULD Buildroot is not present
Note: Invalid buildroot found:
%{_tmppath}/%{valkyrie}-%{release}-root-%(%{__id_u} -n)
[!]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean is needed only if supporting EPEL5
[!]: SHOULD Spec use %global instead of %define.
Note: %define valkyrie %{name}-%{version}
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #12 from Nathan Scott --- Thanks Sebastian - I've uploaded http://oss.sgi.com/~nathans/valkyrie-2.0.0-4.el6_3.src.rpm (and spec file in same location) which include your patch. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #11 from Sebastian Dyroff --- It was getpid. Error message was: utils/vk_utils.cpp: In function 'void vkPrint(const char*, ...)': utils/vk_utils.cpp:54:104: error: 'getpid' was not declared in this scope utils/vk_utils.cpp: In function 'void vkPrintErr(const char*, ...)': utils/vk_utils.cpp:68:104: error: 'getpid' was not declared in this scope utils/vk_utils.cpp: In function 'void vkDebug(const char*, ...)': utils/vk_utils.cpp:83:104: error: 'getpid' was not declared in this scope -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #10 from Nathan Scott --- Thanks Sebastian - producing a patched spec now - could you let me know which symbol was missing there? (will need to mention it to upstream) Guess its one/more of these...? U exit U fflush U free U getenv U getpid U malloc U mkstemp U stderr U stdout U strcmp U strcpy U strlen thanks. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #9 from Sebastian Dyroff --- Created attachment 622075 --> https://bugzilla.redhat.com/attachment.cgi?id=622075&action=edit patch to include unistd.h in vk_utils.cpp It still did not build for me. I have created a patch that fixes the last build error for me. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #8 from Nathan Scott --- I've uploaded a new http://oss.sgi.com/~nathans/valkyrie-2.0.0-3.el6_3.src.rpm which should fix this new build issue. Will discuss the FSF address with upstream (as well as asking re a man page). thanks! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 Mario Blättermann changed: What|Removed |Added CC||mario.blaetterm...@gmail.co ||m --- Comment #7 from Mario Blättermann --- (In reply to comment #5) > valkyrie.x86_64: E: incorrect-fsf-address > ... > Looks like the FSF address needs fixing. Doesn't need to be fixed at all. All we have to do is to inform the upstream people about that. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #6 from Sebastian Dyroff --- Does still not work for me (f17). I even tried a koji scratch build for rawhide, because I wanted to be sure that it is not my system. See http://koji.fedoraproject.org/koji/taskinfo?taskID=4560328 The build error is now: utils/vk_config.cpp: In static member function 'static const QString& VkCfg::tmpDir()': utils/vk_config.cpp:125:25: error: 'getuid' was not declared in this scope It builds on f16, see: http://koji.fedoraproject.org/koji/taskinfo?taskID=4560328 Regards Sebastian -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 Thibault North changed: What|Removed |Added CC||thibault.no...@gmail.com --- Comment #5 from Thibault North --- Works for me (f16) with the following rpmlint output: rpmlint -v /home/tnorth/rpmbuild/SRPMS/valkyrie-2.0.0-2.fc16.src.rpm /home/tnorth/rpmbuild/RPMS/x86_64/valkyrie-2.0.0-2.fc16.x86_64.rpm /home/tnorth/rpmbuild/RPMS/x86_64/valkyrie-debuginfo-2.0.0-2.fc16.x86_64.rpm valkyrie.src: I: checking valkyrie.src: I: checking-url http://www.valgrind.org/ (timeout 10 seconds) valkyrie.src: I: checking-url http://www.valgrind.org/downloads/valkyrie-2.0.0.tar.bz2 (timeout 10 seconds) valkyrie.x86_64: I: checking valkyrie.x86_64: I: checking-url http://www.valgrind.org/ (timeout 10 seconds) valkyrie.x86_64: E: incorrect-fsf-address /usr/share/doc/valkyrie-2.0.0/COPYING valkyrie.x86_64: W: no-manual-page-for-binary valkyrie valkyrie.x86_64: W: install-file-in-docs /usr/share/doc/valkyrie-2.0.0/INSTALL valkyrie-debuginfo.x86_64: I: checking valkyrie-debuginfo.x86_64: I: checking-url http://www.valgrind.org/ (timeout 10 seconds) 3 packages and 0 specfiles checked; 1 errors, 2 warnings. Looks like the FSF address needs fixing. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #4 from Nathan Scott --- Fedora and EPEL. Same spec file should work everywhere though (I hope). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 Sebastian Dyroff changed: What|Removed |Added CC||b...@dyroff.org --- Comment #3 from Sebastian Dyroff --- Is this package intended for fedora and epel, or epel only? I have no centos 6 machine at hand only a centos 5 box. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #2 from Nathan Scott --- Hi Sebastian, Thanks for taking a look (and for the tip about fedora-review, trying that out now). I've uploaded a new http://oss.sgi.com/~nathans/valkyrie-2.0.0-2.el6_3.src.rpm which should fix this build issue. I'll confirm with fedora-review once thats run (looks like mock will be awhile, downloading a build root atm). cheers. -- Nathan -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite
https://bugzilla.redhat.com/show_bug.cgi?id=862160 --- Comment #1 from Sebastian Dyroff --- Created attachment 620749 --> https://bugzilla.redhat.com/attachment.cgi?id=620749&action=edit build.log with errors I am not a member of the packager group, so this is just informal. I was not able to build the package using fedora-review. objects/tool_object.cpp: In member function 'bool ToolObject::startProcess(QStringList)': objects/tool_object.cpp:391:26: error: 'usleep' was not declared in this scope objects/tool_object.cpp: In member function 'void ToolObject::stopProcess()': objects/tool_object.cpp:474:42: error: 'usleep' was not declared in this scope The full build.log is attached. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
