[Bug 863445] Review Request: sisu-guice - Lightweight dependency injection framework for Java 5 and above
https://bugzilla.redhat.com/show_bug.cgi?id=863445 Mikolaj Izdebski changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2012-10-31 10:48:39 --- Comment #5 from Mikolaj Izdebski --- This package was just pushed to rawhide, except that I kept the old name (google-guice). This means that a formal review wasn't needed after all, but thank you for it anyways! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863445] Review Request: sisu-guice - Lightweight dependency injection framework for Java 5 and above
https://bugzilla.redhat.com/show_bug.cgi?id=863445
--- Comment #4 from gil cattaneo ---
Hi Mikolaj,
for backwards compatibility you can add to depmap
%add_maven_depmap JPP.%{name}-guice-assistedinject.pom
%{name}/guice-assistedinject.jar -f assistedinject -a
"com.google.inject.extensions:guice-assistedinject"
%add_maven_depmap JPP.%{name}-guice-extensions.pom -f extensions
%add_maven_depmap JPP.%{name}-guice-grapher.pom %{name}/guice-grapher.jar -f
grapher -a "com.google.inject.extensions:guice-grapher"
%add_maven_depmap JPP.%{name}-guice-jmx.pom %{name}/guice-jmx.jar -f jmx -a
"com.google.inject.extensions:guice-jmx"
%add_maven_depmap JPP.%{name}-guice-jndi.pom %{name}/guice-jndi.jar -f jndi -a
"com.google.inject.extensions:guice-jndi"
%add_maven_depmap JPP.%{name}-guice-multibindings.pom
%{name}/guice-multibindings.jar -f multibindings -a
"com.google.inject.extensions:guice-multibindings"
%add_maven_depmap JPP.%{name}-guice-parent.pom -f parent
%add_maven_depmap JPP.%{name}-guice-persist.pom %{name}/guice-persist.jar -f
persist -a "com.google.inject.extensions:guice-persist"
%add_maven_depmap JPP.%{name}-guice-servlet.pom %{name}/guice-servlet.jar -f
servlet -a "com.google.inject.extensions:guice-servlet"
%add_maven_depmap JPP.%{name}-guice-spring.pom %{name}/guice-spring.jar -f
spring -a "com.google.inject.extensions:guice-spring"
%add_maven_depmap JPP.%{name}-guice-throwingproviders.pom
%{name}/guice-throwingproviders.jar -f throwingproviders -a
"com.google.inject.extensions:guice-throwingproviders"
%add_maven_depmap JPP.%{name}-%{name}.pom %{name}/%{name}.jar -a
"com.google.inject:guice"
thanks
regaeds
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863445] Review Request: sisu-guice - Lightweight dependency injection framework for Java 5 and above
https://bugzilla.redhat.com/show_bug.cgi?id=863445 gil cattaneo changed: What|Removed |Added Status|NEW |ASSIGNED Flags|fedora-review? | Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863445] Review Request: sisu-guice - Lightweight dependency injection framework for Java 5 and above
https://bugzilla.redhat.com/show_bug.cgi?id=863445
--- Comment #3 from gil cattaneo ---
Hi Mikolaj,
Issues:
===
[!]: Fully versioned dependency in subpackages, if present.
Note: Missing: 'Requires: %%{name} =' in: %package -n guice-parent
See: http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage
[!]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
Note: sisu-guice-3.1.2-1.fc19.spec should be sisu-guice.spec
See: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name
if the second issue isn't a problem the package is approved
thanks
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863445] Review Request: sisu-guice - Lightweight dependency injection framework for Java 5 and above
https://bugzilla.redhat.com/show_bug.cgi?id=863445
--- Comment #2 from gil cattaneo ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[x] = Manual review needed
Issues:
===
[!]: Fully versioned dependency in subpackages, if present.
Note: Missing: 'Requires: %%{name} =' in: %package -n guice-parent
See: http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage
[!]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
Note: sisu-guice-3.1.2-1.fc19.spec should be sisu-guice.spec
See: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[-]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in %package
javadoc, %package -n guice-parent
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[-]: Large documentation files are in a -doc subpackage, if required.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Apache (v2.0)", "Unknown or generated". 2 files have unknown license.
Detailed output of licensecheck in /home/gil/863445-sisu-
guice-3.1.2-1.fc19/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[-]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[!]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
Note: sisu-guice-3.1.2-1.fc19.spec should be sisu-guice.spec
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
Java:
[x]: If source tarball includes bundled jar/class files these need to be
removed prior to building
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
[!]: Fully versioned dependency in subpackages, if present.
Note: Missing: 'Requires: %%{name} =' in: %package -n guice-parent
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Maven:
[x]: Pom files have correct add_maven_depmap call
Note: Some add_maven_depmap calls found. Please check if they are correct
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap m
[Bug 863445] Review Request: sisu-guice - Lightweight dependency injection framework for Java 5 and above
https://bugzilla.redhat.com/show_bug.cgi?id=863445 gil cattaneo changed: What|Removed |Added CC||punto...@libero.it Assignee|nob...@fedoraproject.org|punto...@libero.it Flags||fedora-review? --- Comment #1 from gil cattaneo --- I am taking this review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863445] Review Request: sisu-guice - Lightweight dependency injection framework for Java 5 and above
https://bugzilla.redhat.com/show_bug.cgi?id=863445 Mikolaj Izdebski changed: What|Removed |Added Blocks||690777 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863445] Review Request: sisu-guice - Lightweight dependency injection framework for Java 5 and above
https://bugzilla.redhat.com/show_bug.cgi?id=863445 Mikolaj Izdebski changed: What|Removed |Added See Also||https://bugzilla.redhat.com ||/show_bug.cgi?id=863279 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
