[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 --- Comment #28 from Fedora Update System --- log4c-1.2.2-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xas1ACdLHm&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 --- Comment #27 from Fedora Update System --- log4c-1.2.2-2.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LC8zX1OxGu&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-12-27 22:53:34 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RxpgTSUZWn&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 --- Comment #26 from Fedora Update System --- log4c-1.2.2-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/log4c-1.2.2-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CWjLBrkHDc&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 --- Comment #25 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ysop4ilWkX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 František Dvořák changed: What|Removed |Added Flags||fedora-cvs? --- Comment #24 from František Dvořák --- Package Change Request == Package Name: log4c New Branches: f17 Owners: valtri Please add branch for f17, there will be packages depending on log4c. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3RUetN3G1m&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 --- Comment #23 from Joseph Marrero --- It is a dep for the owncloud-client. It would be nice If f17 support so I can deliver the newest updates since the current verision needs log4c thanks -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=14GLHF3Jt1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 --- Comment #22 from František Dvořák --- Would you need it for f17? If there is demand for log4c in f17, we can push it. I had no plans so far. log4c is needed as dependency for some upcoming gLite middleware components planned for f18 or later. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yukKYdiH4e&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 --- Comment #21 from Joseph Marrero --- František Dvořák: any plan of pushing this into f17? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RCndTawsXF&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 --- Comment #20 from Fedora Update System --- log4c-1.2.2-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iZ42G4zbhZ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QyBXzNpnbZ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 --- Comment #19 from Fedora Update System --- log4c-1.2.2-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/log4c-1.2.2-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=A4nLXsSqNQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tKgSL2zzd7&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=863569
--- Comment #18 from František Dvořák ---
The file log4c-config is conflicting when installing both 32-bit and 64-bit
version of log4c-devel. I'm adding this to %install section yet:
# munge log4c-config to prevent file conflicts on multilib systems,
# the default paths are not needed in the build flags anyway
sed -r -i \
-e 's|^libdir=/usr/lib(64)?$|libdir=/usr/lib|' \
-e 's|-L\$libdir ||' \
-e 's|-I\$includedir ||' %{buildroot}%{_bindir}/log4c-config
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=YlTVzjQrTA&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 --- Comment #17 from Jon Ciesla --- What, you want me to *read* bugs now? Sheesh! SOrry for the confusion. :) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 Rex Dieter changed: What|Removed |Added Flags||fedora-cvs? --- Comment #16 from Rex Dieter --- Jon, *this* is the re-review. :) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 --- Comment #15 from Jon Ciesla --- It's deprecated and should be re-reviewed. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 František Dvořák changed: What|Removed |Added Flags||fedora-cvs? --- Comment #14 from František Dvořák --- Package Change Request == Package Name: log4c New Branches: devel Owners: valtri InitialCC: valtri Please grant me access to master branch (and/or assign ownership to me if the log4c is deprecated or orphaned). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 --- Comment #13 from Jon Ciesla --- Misformatted request. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 --- Comment #12 from Rex Dieter --- According to, http://fedoraproject.org/wiki/Orphaned_package_that_need_new_maintainers#Claiming_Ownership_of_a_Deprecated_Package that doing devel too should fix things up. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 František Dvořák changed: What|Removed |Added Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #11 from František Dvořák --- Package Change Request == Package Name: log4c New Branches: devel Can you give me access to the master branch too? It is orphaned now. (I'm not sure how to write it in the template.) Thank you. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 --- Comment #10 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 František Dvořák changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Flags||fedora-cvs? --- Comment #9 from František Dvořák --- Package Change Request == Package Name: log4c New Branches: f18 Owners: valtri InitialCC: valtri The package resurrected in F18 and new review has been carried out here. The previous request was https://bugzilla.redhat.com/show_bug.cgi?id=479835 . -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 Rex Dieter changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #8 from Rex Dieter --- Looks good, thanks. APPROVED. I'll get you sponsored now, and you can move onto the scm request step of the process -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 --- Comment #7 from František Dvořák --- Changes applied. AUTHORS file has a non-UTF-8 character, I suggest it could fixed directly in upstream sources (for next release). New URLs: Spec URL: http://scientific.zcu.cz/fedora/log4c-1.2.2-1c/log4c.spec SRPM URL: http://scientific.zcu.cz/fedora/log4c-1.2.2-1c/log4c-1.2.2-1.fc19.src.rpm koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4737887 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=863569
--- Comment #6 from Rex Dieter ---
$ rpmlint *.rpm
log4c.src: W: spelling-error %description -l en_US syslog -> slog
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
naming: ok
license: NOT ok
1. MUST add license file
%doc COPYING
while, we're at it, may as well add
%doc AUTHORS ChangeLog README
as well
macros: ok
sources: ok
6dae664d3ce052ce8f99b249f094d152 log4c-1.2.2.tar.gz
builds/installs: ok
there's a few SHOULD items I'd like you to consider:
2. SHOULD track library soname use
%{_libdir}/liblog4c.so.3*
instead of
%{_libdir}/liblog4c.so.*
3. SHOULD drop deprecated items from .spec, if you're supporting fedora and/or
rhel >=6, like
Group: tags
BuildRoot: tags
%defattr tags
%clean section
rm -rf %{buildroot} (from beginning of %install section)
4. SHOULD drop from -devel:
Requires: automake
rpm -q -f /usr/share/aclocal
filesystem-3.1-2.fc18.x86_64
is already owned by filesystem package in recent versions of fedora
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 Rex Dieter changed: What|Removed |Added Status|NEW |ASSIGNED CC||rdie...@math.unl.edu Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu Flags||fedora-review? --- Comment #5 from Rex Dieter --- I can review/sponsor -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 --- Comment #4 from František Dvořák --- Absolutely. But I guess I will need to find a sponsor before the review? (I can't contact the sponsor for Fedora Grid Computing SIG so far.) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 Joseph Marrero changed: What|Removed |Added CC||jmarr...@gmail.com --- Comment #3 from Joseph Marrero --- I could officially take this review, if still needed. It would be nice to have this ready before the official fedora 18 release. Let me know. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
https://bugzilla.redhat.com/show_bug.cgi?id=863569 --- Comment #2 from František Dvořák --- > > Adding manual pages or extra documentation is probably not up to you, that's > why ignorable. The wrong FSF address should be reported to the upstream > developers, but no further action is needed from your side. > OK. > The %defattr line is obsolete, even for EPEL 5. I assume there will be such > a package, in view of BuildRoot, %clean and so on. > %defattr removed. > The summary and description for the -devel package are incorrect. There are > no static files at all, and if this would be the case, they would have to go > into a -static subpackage anyway. And we have no development documentation > in the -devel package. > Description corrected. > What about the log4c-config script in -devel? Shouldn't this go into the > base package? No, I think it should be in the -devel. The -config file is used to get compilation flags for development with log4c and it is better not to install it without the log4c-devel package. New URLs: Spec URL: http://scientific.zcu.cz/fedora/log4c-1.2.2-1b/log4c.spec SRPM URL: http://scientific.zcu.cz/fedora/log4c-1.2.2-1b/log4c-1.2.2-1.fc19.src.rpm koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4564782 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863569] Review Request: log4c - an application message logging library
https://bugzilla.redhat.com/show_bug.cgi?id=863569 Mario Blättermann changed: What|Removed |Added CC||mario.blaetterm...@gmail.co ||m Blocks||177841 (FE-NEEDSPONSOR) --- Comment #1 from Mario Blättermann --- $ rpmlint -i -v * log4c.i686: I: checking log4c.i686: W: spelling-error %description -l en_US syslog -> slog The value of this tag appears to be misspelled. Please double-check. log4c.i686: I: checking-url http://log4c.sourceforge.net/ (timeout 10 seconds) log4c.src: I: checking log4c.src: W: spelling-error %description -l en_US syslog -> slog The value of this tag appears to be misspelled. Please double-check. log4c.src: I: checking-url http://log4c.sourceforge.net/ (timeout 10 seconds) log4c.src: I: checking-url http://downloads.sourceforge.net/log4c/log4c-1.2.2.tar.gz (timeout 10 seconds) log4c.x86_64: I: checking log4c.x86_64: W: spelling-error %description -l en_US syslog -> slog The value of this tag appears to be misspelled. Please double-check. log4c.x86_64: I: checking-url http://log4c.sourceforge.net/ (timeout 10 seconds) log4c-debuginfo.i686: I: checking log4c-debuginfo.i686: I: checking-url http://log4c.sourceforge.net/ (timeout 10 seconds) log4c-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/log4c-1.2.2/src/sd/malloc.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. log4c-debuginfo.x86_64: I: checking log4c-debuginfo.x86_64: I: checking-url http://log4c.sourceforge.net/ (timeout 10 seconds) log4c-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/log4c-1.2.2/src/sd/malloc.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. log4c-devel.i686: I: checking log4c-devel.i686: I: checking-url http://log4c.sourceforge.net/ (timeout 10 seconds) log4c-devel.i686: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. log4c-devel.i686: W: no-manual-page-for-binary log4c-config Each executable in standard binary directories should have a man page. log4c-devel.x86_64: I: checking log4c-devel.x86_64: I: checking-url http://log4c.sourceforge.net/ (timeout 10 seconds) log4c-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. log4c-devel.x86_64: W: no-manual-page-for-binary log4c-config Each executable in standard binary directories should have a man page. log4c.spec: I: checking-url http://downloads.sourceforge.net/log4c/log4c-1.2.2.tar.gz (timeout 10 seconds) 7 packages and 1 specfiles checked; 2 errors, 7 warnings. Adding manual pages or extra documentation is probably not up to you, that's why ignorable. The wrong FSF address should be reported to the upstream developers, but no further action is needed from your side. The %defattr line is obsolete, even for EPEL 5. I assume there will be such a package, in view of BuildRoot, %clean and so on. The summary and description for the -devel package are incorrect. There are no static files at all, and if this would be the case, they would have to go into a -static subpackage anyway. And we have no development documentation in the -devel package. What about the log4c-config script in -devel? Shouldn't this go into the base package? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
