[Bug 863719] Review Request: ivykis - Library for asynchronous I/O readiness notification
https://bugzilla.redhat.com/show_bug.cgi?id=863719 --- Comment #15 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863719] Review Request: ivykis - Library for asynchronous I/O readiness notification
https://bugzilla.redhat.com/show_bug.cgi?id=863719 Jose Pedro Oliveira changed: What|Removed |Added Flags||fedora-cvs? --- Comment #14 from Jose Pedro Oliveira --- Package Change Request == Package Name: ivykis New Branches: el5 Owners: jpo -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863719] Review Request: ivykis - Library for asynchronous I/O readiness notification
https://bugzilla.redhat.com/show_bug.cgi?id=863719 --- Comment #13 from Jon Ciesla --- Please use a Package Change Request for a new branch. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863719] Review Request: ivykis - Library for asynchronous I/O readiness notification
https://bugzilla.redhat.com/show_bug.cgi?id=863719 Jose Pedro Oliveira changed: What|Removed |Added Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #12 from Jose Pedro Oliveira --- The package author is also interested in having ivykis in EPEL5: New Package SCM Request === Package Name: ivykis Short Description: Library for asynchronous I/O readiness notification Owners: jpo Branches: el5 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863719] Review Request: ivykis - Library for asynchronous I/O readiness notification
https://bugzilla.redhat.com/show_bug.cgi?id=863719 Jose Pedro Oliveira changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-10-24 11:56:11 --- Comment #11 from Jose Pedro Oliveira --- Already available in the Fedora >= 17 and EPEL6 stable repos. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863719] Review Request: ivykis - Library for asynchronous I/O readiness notification
https://bugzilla.redhat.com/show_bug.cgi?id=863719 Jose Pedro Oliveira changed: What|Removed |Added Blocks||700766 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863719] Review Request: ivykis - Library for asynchronous I/O readiness notification
https://bugzilla.redhat.com/show_bug.cgi?id=863719 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863719] Review Request: ivykis - Library for asynchronous I/O readiness notification
https://bugzilla.redhat.com/show_bug.cgi?id=863719 --- Comment #10 from Fedora Update System --- ivykis-0.30.4-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863719] Review Request: ivykis - Library for asynchronous I/O readiness notification
https://bugzilla.redhat.com/show_bug.cgi?id=863719 --- Comment #9 from Fedora Update System --- ivykis-0.30.4-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/ivykis-0.30.4-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863719] Review Request: ivykis - Library for asynchronous I/O readiness notification
https://bugzilla.redhat.com/show_bug.cgi?id=863719 --- Comment #8 from Fedora Update System --- ivykis-0.30.4-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/ivykis-0.30.4-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863719] Review Request: ivykis - Library for asynchronous I/O readiness notification
https://bugzilla.redhat.com/show_bug.cgi?id=863719 --- Comment #7 from Fedora Update System --- ivykis-0.30.4-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/ivykis-0.30.4-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863719] Review Request: ivykis - Library for asynchronous I/O readiness notification
https://bugzilla.redhat.com/show_bug.cgi?id=863719 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863719] Review Request: ivykis - Library for asynchronous I/O readiness notification
https://bugzilla.redhat.com/show_bug.cgi?id=863719 --- Comment #6 from Jason Tibbitts --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863719] Review Request: ivykis - Library for asynchronous I/O readiness notification
https://bugzilla.redhat.com/show_bug.cgi?id=863719 Jose Pedro Oliveira changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Jose Pedro Oliveira --- New Package SCM Request === Package Name: ivykis Short Description: Library for asynchronous I/O readiness notification Owners: jpo Branches: f17 f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863719] Review Request: ivykis - Library for asynchronous I/O readiness notification
https://bugzilla.redhat.com/show_bug.cgi?id=863719 --- Comment #4 from Jose Pedro Oliveira --- (In reply to comment #3) ---[snip]--- > > > > PACKAGE APPROVED > > Mario, Thanks for the review. I'll will remove the EL5 bits from the specfile in a future update (right now I need to find out if there are ppl interested in having ivykis in EPEL5). /jpo -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863719] Review Request: ivykis - Library for asynchronous I/O readiness notification
https://bugzilla.redhat.com/show_bug.cgi?id=863719
Mario Blättermann changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #3 from Mario Blättermann ---
New scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4568280
$ rpmlint -i -v *
ivykis.src: I: checking
ivykis.src: W: spelling-error %description -l en_US epoll -> poll, e poll
The value of this tag appears to be misspelled. Please double-check.
ivykis.src: W: spelling-error %description -l en_US kqueue -> queue, k queue,
liqueur
The value of this tag appears to be misspelled. Please double-check.
ivykis.src: W: spelling-error %description -l en_US dev -> deb, derv, div
The value of this tag appears to be misspelled. Please double-check.
ivykis.src: I: checking-url http://libivykis.sourceforge.net/ (timeout 10
seconds)
ivykis.src: I: checking-url
http://downloads.sourceforge.net/project/libivykis/0.30.4/ivykis-0.30.4.tar.gz
(timeout 10 seconds)
ivykis.i686: I: checking
ivykis.i686: W: spelling-error %description -l en_US epoll -> poll, e poll
The value of this tag appears to be misspelled. Please double-check.
ivykis.i686: W: spelling-error %description -l en_US kqueue -> queue, k queue,
liqueur
The value of this tag appears to be misspelled. Please double-check.
ivykis.i686: W: spelling-error %description -l en_US dev -> deb, derv, div
The value of this tag appears to be misspelled. Please double-check.
ivykis.i686: I: checking-url http://libivykis.sourceforge.net/ (timeout 10
seconds)
ivykis.x86_64: I: checking
ivykis.x86_64: W: spelling-error %description -l en_US epoll -> poll, e poll
The value of this tag appears to be misspelled. Please double-check.
ivykis.x86_64: W: spelling-error %description -l en_US kqueue -> queue, k
queue, liqueur
The value of this tag appears to be misspelled. Please double-check.
ivykis.x86_64: W: spelling-error %description -l en_US dev -> deb, derv, div
The value of this tag appears to be misspelled. Please double-check.
ivykis.x86_64: I: checking-url http://libivykis.sourceforge.net/ (timeout 10
seconds)
ivykis-debuginfo.i686: I: checking
ivykis-debuginfo.i686: I: checking-url http://libivykis.sourceforge.net/
(timeout 10 seconds)
ivykis-debuginfo.x86_64: I: checking
ivykis-debuginfo.x86_64: I: checking-url http://libivykis.sourceforge.net/
(timeout 10 seconds)
ivykis-devel.i686: I: checking
ivykis-devel.i686: I: checking-url http://libivykis.sourceforge.net/ (timeout
10 seconds)
ivykis-devel.x86_64: I: checking
ivykis-devel.x86_64: I: checking-url http://libivykis.sourceforge.net/ (timeout
10 seconds)
ivykis.spec: I: checking-url
http://downloads.sourceforge.net/project/libivykis/0.30.4/ivykis-0.30.4.tar.gz
(timeout 10 seconds)
7 packages and 1 specfiles checked; 0 errors, 9 warnings.
No recognizable issues.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
LGPLv2+
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
9aa71f0dcea69f9877edac4e3091df096fae7112f1cc076e53dbb6823167da39
ivykis-0.30.4.tar.gz
9aa71f0dcea69f9877edac4e3091df096fae7112f1cc076e53dbb6823167da39
ivykis-0.30.4.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. T
[Bug 863719] Review Request: ivykis - Library for asynchronous I/O readiness notification
https://bugzilla.redhat.com/show_bug.cgi?id=863719
--- Comment #2 from Jose Pedro Oliveira ---
(In reply to comment #1)
---[snip]---
>
> Ok so far. Some issues, though:
>
> Requires: %{name} = %{version}-%{release}
> has to be
> Requires: %{name}%{?_isa} = %{version}-%{release}
>
> It's an arch dependent package, that's why the "isa" macro must be present.
> See http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
Done.
> The %defattr lines are obsolete. It is only needed for rpm < 4.4, and even
> EPEL 5 ships rpm-4.4.2. Just remove them.
Also done but someone needs to update the EPEL6 rpmlint (0.94-2.el6) as it
reports the defattr issue as error:
--
$ rpmlint ivykis-0.30.4-2.el6.src.rpm
...
ivykis.src:68: E: files-attr-not-set
ivykis.src:69: E: files-attr-not-set
ivykis.src:72: E: files-attr-not-set
ivykis.src:73: E: files-attr-not-set
ivykis.src:74: E: files-attr-not-set
ivykis.src:75: E: files-attr-not-set
1 packages and 0 specfiles checked; 6 errors, 3 warnings.
--
New SRPM:
http://um-pe09-2.di.uminho.pt/fedora/ivykis-0.30.4-2.el6.src.rpm
and specfile:
http://um-pe09-2.di.uminho.pt/fedora/ivykis.spec
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863719] Review Request: ivykis - Library for asynchronous I/O readiness notification
https://bugzilla.redhat.com/show_bug.cgi?id=863719
Mario Blättermann changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||mario.blaetterm...@gmail.co
||m
Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
||m
Flags||fedora-review?
--- Comment #1 from Mario Blättermann ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4568128
$ rpmlint -i -v *
ivykis.src: I: checking
ivykis.src: W: spelling-error %description -l en_US epoll -> poll, e poll
The value of this tag appears to be misspelled. Please double-check.
ivykis.src: W: spelling-error %description -l en_US kqueue -> queue, k queue,
liqueur
The value of this tag appears to be misspelled. Please double-check.
ivykis.src: W: spelling-error %description -l en_US dev -> deb, derv, div
The value of this tag appears to be misspelled. Please double-check.
ivykis.src: I: checking-url http://libivykis.sourceforge.net/ (timeout 10
seconds)
ivykis.src: I: checking-url
http://downloads.sourceforge.net/project/libivykis/0.30.4/ivykis-0.30.4.tar.gz
(timeout 10 seconds)
ivykis.i686: I: checking
ivykis.i686: W: spelling-error %description -l en_US epoll -> poll, e poll
The value of this tag appears to be misspelled. Please double-check.
ivykis.i686: W: spelling-error %description -l en_US kqueue -> queue, k queue,
liqueur
The value of this tag appears to be misspelled. Please double-check.
ivykis.i686: W: spelling-error %description -l en_US dev -> deb, derv, div
The value of this tag appears to be misspelled. Please double-check.
ivykis.i686: I: checking-url http://libivykis.sourceforge.net/ (timeout 10
seconds)
ivykis.x86_64: I: checking
ivykis.x86_64: W: spelling-error %description -l en_US epoll -> poll, e poll
The value of this tag appears to be misspelled. Please double-check.
ivykis.x86_64: W: spelling-error %description -l en_US kqueue -> queue, k
queue, liqueur
The value of this tag appears to be misspelled. Please double-check.
ivykis.x86_64: W: spelling-error %description -l en_US dev -> deb, derv, div
The value of this tag appears to be misspelled. Please double-check.
ivykis.x86_64: I: checking-url http://libivykis.sourceforge.net/ (timeout 10
seconds)
ivykis-debuginfo.i686: I: checking
ivykis-debuginfo.i686: I: checking-url http://libivykis.sourceforge.net/
(timeout 10 seconds)
ivykis-debuginfo.x86_64: I: checking
ivykis-debuginfo.x86_64: I: checking-url http://libivykis.sourceforge.net/
(timeout 10 seconds)
ivykis-devel.i686: I: checking
ivykis-devel.i686: I: checking-url http://libivykis.sourceforge.net/ (timeout
10 seconds)
ivykis-devel.x86_64: I: checking
ivykis-devel.x86_64: I: checking-url http://libivykis.sourceforge.net/ (timeout
10 seconds)
ivykis.spec: I: checking-url
http://downloads.sourceforge.net/project/libivykis/0.30.4/ivykis-0.30.4.tar.gz
(timeout 10 seconds)
7 packages and 1 specfiles checked; 0 errors, 9 warnings.
Ok so far. Some issues, though:
Requires: %{name} = %{version}-%{release}
has to be
Requires: %{name}%{?_isa} = %{version}-%{release}
It's an arch dependent package, that's why the "isa" macro must be present. See
http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
The %defattr lines are obsolete. It is only needed for rpm < 4.4, and even EPEL
5 ships rpm-4.4.2. Just remove them.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
