[Bug 863756] Review Request: python-xmlbuilder - A python xml/(x)html builder
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863756 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE Last Closed||2012-12-08 03:33:50 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RMNSFtHhY3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863756] Review Request: python-xmlbuilder - A python xml/(x)html builder
https://bugzilla.redhat.com/show_bug.cgi?id=863756 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863756] Review Request: python-xmlbuilder - A python xml/(x)html builder
https://bugzilla.redhat.com/show_bug.cgi?id=863756 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- python-xmlbuilder-1.0-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-xmlbuilder-1.0-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863756] Review Request: python-xmlbuilder - A python xml/(x)html builder
https://bugzilla.redhat.com/show_bug.cgi?id=863756 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- python-xmlbuilder-1.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-xmlbuilder-1.0-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863756] Review Request: python-xmlbuilder - A python xml/(x)html builder
https://bugzilla.redhat.com/show_bug.cgi?id=863756 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863756] Review Request: python-xmlbuilder - A python xml/(x)html builder
https://bugzilla.redhat.com/show_bug.cgi?id=863756 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- python-xmlbuilder-1.0-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863756] Review Request: python-xmlbuilder - A python xml/(x)html builder
https://bugzilla.redhat.com/show_bug.cgi?id=863756 --- Comment #7 from Mario Blättermann mario.blaetterm...@gmail.com --- Just a reminder: Packages are built, but not submitted to the testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863756] Review Request: python-xmlbuilder - A python xml/(x)html builder
https://bugzilla.redhat.com/show_bug.cgi?id=863756 --- Comment #6 from Jason Tibbitts ti...@math.uh.edu --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863756] Review Request: python-xmlbuilder - A python xml/(x)html builder
https://bugzilla.redhat.com/show_bug.cgi?id=863756
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||mario.blaetterm...@gmail.co
||m
Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
||m
Flags||fedora-review?
--- Comment #1 from Mario Blättermann mario.blaetterm...@gmail.com ---
$ rpmlint -i -v *
python-xmlbuilder.src: I: checking
python-xmlbuilder.src: W: spelling-error Summary(en_US) xml - XML, ml, x ml
The value of this tag appears to be misspelled. Please double-check.
python-xmlbuilder.src: W: spelling-error Summary(en_US) html - HTML, ht ml,
ht-ml
The value of this tag appears to be misspelled. Please double-check.
python-xmlbuilder.src: W: spelling-error %description -l en_US xml - XML, ml,
x ml
The value of this tag appears to be misspelled. Please double-check.
python-xmlbuilder.src: W: spelling-error %description -l en_US pythonomic -
nonrhythmic
The value of this tag appears to be misspelled. Please double-check.
python-xmlbuilder.src: I: checking-url http://pypi.python.org/pypi/xmlbuilder
(timeout 10 seconds)
python-xmlbuilder.src: I: checking-url
http://pypi.python.org/packages/source/x/xmlbuilder/xmlbuilder-1.0.tar.gz
(timeout 10 seconds)
python-xmlbuilder.noarch: I: checking
python-xmlbuilder.noarch: W: spelling-error Summary(en_US) xml - XML, ml, x ml
The value of this tag appears to be misspelled. Please double-check.
python-xmlbuilder.noarch: W: spelling-error Summary(en_US) html - HTML, ht ml,
ht-ml
The value of this tag appears to be misspelled. Please double-check.
python-xmlbuilder.noarch: W: spelling-error %description -l en_US xml - XML,
ml, x ml
The value of this tag appears to be misspelled. Please double-check.
python-xmlbuilder.noarch: W: spelling-error %description -l en_US pythonomic -
nonrhythmic
The value of this tag appears to be misspelled. Please double-check.
python-xmlbuilder.noarch: I: checking-url
http://pypi.python.org/pypi/xmlbuilder (timeout 10 seconds)
python-xmlbuilder.spec: I: checking-url
http://pypi.python.org/packages/source/x/xmlbuilder/xmlbuilder-1.0.tar.gz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 8 warnings.
Some ignorable spelling errors.
The source tarball contains a bundled egg-info. Please remove it before
building your package (in the %prep section):
rm -rf %{srcname}.egg-info
See https://fedoraproject.org/wiki/Packaging:Python_Eggs#Upstream_Eggs for more
information.
python-setuptools-devel in BR could be replaced by python-setuptools because
the latter provides python-setuptools-devel anyway.
The date in %changelog is wrong, should be Sun Oct 07 2012.
The description could be tweaked a bit. My suggestion:
XMLBuilder is a tiny library built on top of ElementTree.TreeBuilder to make
XML files creation more pythonomic. `XMLBuilder` uses the `with` statement and
attribute access to define the XML document structure.
Taking this for a full review.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863756] Review Request: python-xmlbuilder - A python xml/(x)html builder
https://bugzilla.redhat.com/show_bug.cgi?id=863756
--- Comment #2 from Fabian Affolter m...@fabian-affolter.ch ---
(In reply to comment #1)
$ rpmlint -i -v *
python-xmlbuilder.src: I: checking
python-xmlbuilder.src: W: spelling-error Summary(en_US) xml - XML, ml, x ml
The value of this tag appears to be misspelled. Please double-check.
python-xmlbuilder.src: W: spelling-error Summary(en_US) html - HTML, ht ml,
ht-ml
The value of this tag appears to be misspelled. Please double-check.
python-xmlbuilder.src: W: spelling-error %description -l en_US xml - XML,
ml, x ml
The value of this tag appears to be misspelled. Please double-check.
python-xmlbuilder.src: W: spelling-error %description -l en_US pythonomic -
nonrhythmic
The value of this tag appears to be misspelled. Please double-check.
python-xmlbuilder.src: I: checking-url
http://pypi.python.org/pypi/xmlbuilder (timeout 10 seconds)
python-xmlbuilder.src: I: checking-url
http://pypi.python.org/packages/source/x/xmlbuilder/xmlbuilder-1.0.tar.gz
(timeout 10 seconds)
python-xmlbuilder.noarch: I: checking
python-xmlbuilder.noarch: W: spelling-error Summary(en_US) xml - XML, ml, x
ml
The value of this tag appears to be misspelled. Please double-check.
python-xmlbuilder.noarch: W: spelling-error Summary(en_US) html - HTML, ht
ml, ht-ml
The value of this tag appears to be misspelled. Please double-check.
python-xmlbuilder.noarch: W: spelling-error %description -l en_US xml -
XML, ml, x ml
The value of this tag appears to be misspelled. Please double-check.
python-xmlbuilder.noarch: W: spelling-error %description -l en_US pythonomic
- nonrhythmic
The value of this tag appears to be misspelled. Please double-check.
python-xmlbuilder.noarch: I: checking-url
http://pypi.python.org/pypi/xmlbuilder (timeout 10 seconds)
python-xmlbuilder.spec: I: checking-url
http://pypi.python.org/packages/source/x/xmlbuilder/xmlbuilder-1.0.tar.gz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 8 warnings.
Some ignorable spelling errors.
There is only one spelling error left.
The source tarball contains a bundled egg-info. Please remove it before
building your package (in the %prep section):
rm -rf %{srcname}.egg-info
See https://fedoraproject.org/wiki/Packaging:Python_Eggs#Upstream_Eggs for
more information.
egg-info removed.
python-setuptools-devel in BR could be replaced by python-setuptools because
the latter provides python-setuptools-devel anyway.
Fixed
The date in %changelog is wrong, should be Sun Oct 07 2012.
Fixed
The description could be tweaked a bit. My suggestion:
XMLBuilder is a tiny library built on top of ElementTree.TreeBuilder to make
XML files creation more pythonomic. `XMLBuilder` uses the `with` statement
and attribute access to define the XML document structure.
Thanks
Updated files:
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-xmlbuilder.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/python-xmlbuilder-1.0-2.fc17.src.rpm
[fab@laptop11 SRPMS]$ rpmlint python-xmlbuilder*
python-xmlbuilder.src: W: spelling-error %description -l en_US pythonomic -
nonrhythmic
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
[fab@laptop11 noarch]$ rpmlint python-xmlbuilder*
python-xmlbuilder.noarch: W: spelling-error %description -l en_US pythonomic -
nonrhythmic
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863756] Review Request: python-xmlbuilder - A python xml/(x)html builder
https://bugzilla.redhat.com/show_bug.cgi?id=863756
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #3 from Mario Blättermann mario.blaetterm...@gmail.com ---
New scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4568198
$ rpmlint -i -v *
python-xmlbuilder.src: I: checking
python-xmlbuilder.src: W: spelling-error %description -l en_US pythonomic -
nonrhythmic
The value of this tag appears to be misspelled. Please double-check.
python-xmlbuilder.src: I: checking-url http://pypi.python.org/pypi/xmlbuilder
(timeout 10 seconds)
python-xmlbuilder.src: I: checking-url
http://pypi.python.org/packages/source/x/xmlbuilder/xmlbuilder-1.0.tar.gz
(timeout 10 seconds)
python-xmlbuilder.noarch: I: checking
python-xmlbuilder.noarch: W: spelling-error %description -l en_US pythonomic -
nonrhythmic
The value of this tag appears to be misspelled. Please double-check.
python-xmlbuilder.noarch: I: checking-url
http://pypi.python.org/pypi/xmlbuilder (timeout 10 seconds)
python-xmlbuilder.spec: I: checking-url
http://pypi.python.org/packages/source/x/xmlbuilder/xmlbuilder-1.0.tar.gz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
OK so far.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
LGPLv3+
[.] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
cdeb3231bfe9caa87abeff64f9eb96c83779eb1748300ac451a37ae4e371a25c
xmlbuilder-1.0.tar.gz
cdeb3231bfe9caa87abeff64f9eb96c83779eb1748300ac451a37ae4e371a25c
xmlbuilder-1.0.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable
[Bug 863756] Review Request: python-xmlbuilder - A python xml/(x)html builder
https://bugzilla.redhat.com/show_bug.cgi?id=863756 --- Comment #4 from Fabian Affolter m...@fabian-affolter.ch --- Thanks for the review, Mario. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863756] Review Request: python-xmlbuilder - A python xml/(x)html builder
https://bugzilla.redhat.com/show_bug.cgi?id=863756 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Fabian Affolter m...@fabian-affolter.ch --- New Package SCM Request === Package Name: python-xmlbuilder Short Description: A python XML/(x)HTML builder Owners: fab Branches: f18 f17 f16 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
