[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
https://bugzilla.redhat.com/show_bug.cgi?id=863793 Miro Hrončok changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
https://bugzilla.redhat.com/show_bug.cgi?id=863793 --- Comment #1 from Miro Hrončok --- Spec URL: https://raw.github.com/hroncok/SPECS/master/skeinforge.spec SRPM URL: http://repo.hroncok.cz/SRPMS/skeinforge-12.03.14-7.fc17.src.rpm skeinforge dir no longer in printrun dir. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
https://bugzilla.redhat.com/show_bug.cgi?id=863793 Volker Fröhlich changed: What|Removed |Added CC||volke...@gmx.at --- Comment #2 from Volker Fröhlich --- Don't use macros for rm and cp. Including the license file in the main package should be enough. I'm a bit sceptical about how it is installed. http://fabmetheus.crsndoo.com/wiki/index.php/How_To_Run_Skeinforge This looks like GUI software to me. That requires a number of changes in the package. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
https://bugzilla.redhat.com/show_bug.cgi?id=863793 --- Comment #3 from Miro Hrončok --- Thanks. Well, I could add a desktop file to run it, but everybody just runs Skeinforge from Pronterface, as I think about this more like about a library or set of scripts. Is adding a desktop file the only think I should do, or should I also create something in /bin ? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
https://bugzilla.redhat.com/show_bug.cgi?id=863793 --- Comment #4 from Miro Hrončok --- Spec URL: https://raw.github.com/hroncok/SPECS/master/skeinforge.spec SRPM URL: http://repo.hroncok.cz/SRPMS/skeinforge-12.03.14-8.fc17.src.rpm - Added desktop file - Don't use macros for rm and cp - Removed license file from doc package -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
https://bugzilla.redhat.com/show_bug.cgi?id=863793 --- Comment #5 from Volker Fröhlich --- Can you give a quote about the AGPL version? The code claims AGPL, but I couldn't find a note about which version. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
https://bugzilla.redhat.com/show_bug.cgi?id=863793 --- Comment #6 from Miro Hrončok --- Beta release here: http://members.axion.net/~enrique/reprap_python_beanshell.zip includes AGPLv3. It will be in the next release. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
https://bugzilla.redhat.com/show_bug.cgi?id=863793 --- Comment #7 from Miro Hrončok --- Spec URL: https://raw.github.com/hroncok/SPECS/master/skeinforge.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/skeinforge-12.03.14-8.fc17.src.rpm - Nothing has changed, I've just moved SRPM to a new location -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863793 Mario Blättermann changed: What|Removed |Added CC||mario.blaetterm...@gmail.co ||m Blocks|177841 (FE-NEEDSPONSOR) | -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863793 --- Comment #8 from Miro Hrončok --- Spec URL: https://raw.github.com/hroncok/SPECS/master/skeinforge.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/skeinforge-12.03.14-9.fc17.src.rpm - Do not download the desktop file from my GitHub -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5UO3b0qE2f&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
https://bugzilla.redhat.com/show_bug.cgi?id=863793 Miro Hrončok changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #30 from Miro Hrončok --- Package Change Request == Package Name: skeinforge New Branches: el6 Owners: churchyard -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
https://bugzilla.redhat.com/show_bug.cgi?id=863793 --- Comment #31 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
https://bugzilla.redhat.com/show_bug.cgi?id=863793 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
https://bugzilla.redhat.com/show_bug.cgi?id=863793 --- Comment #32 from Fedora Update System --- skeinforge-12.03.14-16.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/skeinforge-12.03.14-16.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
https://bugzilla.redhat.com/show_bug.cgi?id=863793 Fedora Update System changed: What|Removed |Added Status|CLOSED |ON_QA Resolution|CURRENTRELEASE |--- Keywords||Reopened --- Comment #33 from Fedora Update System --- skeinforge-12.03.14-16.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
https://bugzilla.redhat.com/show_bug.cgi?id=863793 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||skeinforge-12.03.14-16.el6 Resolution|--- |ERRATA Last Closed|2013-01-24 16:58:53 |2013-11-30 21:49:00 --- Comment #34 from Fedora Update System --- skeinforge-12.03.14-16.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=863793
--- Comment #9 from Miro Hrončok ---
Spec URL: https://raw.github.com/hroncok/SPECS/master/skeinforge.spec
SRPM URL:
https://github.com/downloads/hroncok/SPECS/skeinforge-12.03.14-10.fc17.src.rpm
- Changed location of skeinforge from %{_datadir}/%{name}/
to %{python_sitelib}/%{name}
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=swyholrBF3&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863793 --- Comment #10 from Miro Hrončok --- Spec URL: https://raw.github.com/hroncok/SPECS/master/skeinforge.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/skeinforge-12.03.14-11.fc17.src.rpm - Don't add license.txt as a separate source -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ax4Xm5e3Vw&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863793 T.C. Hollingsworth changed: What|Removed |Added CC||tchollingswo...@gmail.com --- Comment #11 from T.C. Hollingsworth --- The SRPM URL is invalid: % fedora-review -b 863793 Processing bugzilla bug: 863793 Getting .spec and .srpm Urls from : 863793 --> SRPM url: https://github.com/downloads/hroncok/SPECS/skeinforge-12.03.14-11.fc17.src.rpm --> Spec url: https://raw.github.com/hroncok/SPECS/master/skeinforge.spec Using review directory: /home/fedora/patches/863793-skeinforge Downloading .spec and .srpm files Error: 'Error 404 downloading https://github.com/downloads/hroncok/SPECS/skeinforge-12.03.14-11.fc17.src.rpm' (logs in ~/.cache/fedora-review.log) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BPQU8PBBvp&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863793 --- Comment #12 from Miro Hrončok --- Sorry, I forgot to change the Fedora number. Spec URL: https://raw.github.com/hroncok/SPECS/master/skeinforge.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/skeinforge-12.03.14-11.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dW4FW7LheE&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863793 T.C. Hollingsworth changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|tchollingswo...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IMBGQanEjl&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=863793
T.C. Hollingsworth changed:
What|Removed |Added
Flags||needinfo?(mhroncok@redhat.c
||om)
--- Comment #13 from T.C. Hollingsworth ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Status: NEEDS WORK
Blocker Issues
- Please provide access to the application in /usr/bi. (If it's worth
providing a .desktop file, it's worth putting in /usr/bin as well. ;-)
- This package removes files from the BUILD directory in %install. This breaks
`rpmbuild --short-circuit`. Remove these files in %prep or from %buildroot
post-install instead.
- This package installs documentation in %{python_sitelib}, instead of using
%doc. Please use %doc, unless there is a clear, documented, reason not to.
- This package contains unnecessary shebang lines in %{python_sitelib}. Please
remove these in %prep.
- The spec file contains macros in the changelog. Please escape them (e.g.
"%%{python_sitelib}" or otherwise remove them.
See the rpmlint section at the bottom of the review for more details on the
last
two issues.
Other Issues
- This package contains code that may be under other licenses than the primary
license. Consider reflecting this fact in the License tag. (See the section
of the review pertaining to this for more details.)
- The packager has indicated that upstream is including a LICENSE file in a
future release. Please do not forget to include this file when the new
version is released.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install if there is
such a file.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
Don't forget to include this once upstream provides it.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"*No copyright* GPL (v3 or later)", "*No copyright* GPL (v2 or later)",
"GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated". 5 files
have unknown license. Detailed output of licensecheck in
/home/fedora/patches/863793-skeinforge/licensecheck.txt
I think licensecheck may think the AGPL is the GPL If not, you might want to
add e.g. "and GPLv2+ and GPLv3+", though it isn't strictly necessary since the
AGPL ends up being the most restrictive license.
[-]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: Rpmlint is
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=863793
--- Comment #14 from Miro Hrončok ---
(In reply to comment #13)
> - Please provide access to the application in /usr/bi. (If it's worth
> providing a .desktop file, it's worth putting in /usr/bin as well. ;-)
Actually, it's not worth providing a .desktop file, but unfortunately,
packaging guidelines say so. But OK, a shell script to /usr/bin shouldn't be a
problem.
> - This package installs documentation in %{python_sitelib}, instead of using
> %doc. Please use %doc, unless there is a clear, documented, reason not to.
There is a button in the application, that opens the documentation.
I could either symlink the documentation form doc to python_sitelib, or patch
the app to search it in doc, but in both cases, it would brake the rule "If a
package includes something as %doc, it must not affect the runtime of the
application", right?
Will clear the rest issues.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=MEMaAFKS99&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=863793
--- Comment #15 from T.C. Hollingsworth ---
(In reply to comment #14)
> > - This package installs documentation in %{python_sitelib}, instead of using
> > %doc. Please use %doc, unless there is a clear, documented, reason not
> > to.
> There is a button in the application, that opens the documentation.
>
> I could either symlink the documentation form doc to python_sitelib, or
> patch the app to search it in doc, but in both cases, it would brake the
> rule "If a package includes something as %doc, it must not affect the
> runtime of the application", right?
It's okay to break online help if excludedoc is set, I think. (KDE does the
same thing, as do many other packages.) Even if not, this would still need to
go in %_datadir, help in %python_sitelib is just wrong.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=UBQMdxmEzC&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863793 --- Comment #16 from T.C. Hollingsworth --- By the way, this documentation package is only 224KB. I'm not sure why that needs to be separately packaged. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=c8hHdvfHqr&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863793 Miro Hrončok changed: What|Removed |Added Flags|needinfo?(mhroncok@redhat.c | |om) | --- Comment #17 from Miro Hrončok --- Spec URL: https://raw.github.com/hroncok/SPECS/master/skeinforge.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/skeinforge-12.03.14-12.fc18.src.rpm - Comment macros in changelog - Remove shebangs from nonexecutable files - Move deleting files from %%install to %%prep - Added bash launcher to /usr/bin - Modified .desktop file to use that launcher - Moved documentation to %doc (help button in the app doesn't work anyway) - Patch0: Remove non-working help button I left the -doc separated, as it is not big, but it has lot's of files. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4YMtgdSzxR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863793 --- Comment #18 from Miro Hrončok --- - Require pypy (used in craft launcher) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vQHcfk7hhq&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863793 Miro Hrončok changed: What|Removed |Added Blocks||863796 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Feo0YY1aOD&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863793 --- Comment #19 from T.C. Hollingsworth --- This package is still not yet rpmlint clean: Rpmlint --- Checking: skeinforge-12.03.14-12.fc19.noarch.rpm skeinforge-doc-12.03.14-12.fc19.noarch.rpm skeinforge-12.03.14-12.fc19.src.rpm skeinforge.noarch: W: no-documentation skeinforge.noarch: E: non-standard-executable-perm /usr/bin/skeinforge-craft 0775L skeinforge.noarch: E: non-standard-executable-perm /usr/bin/skeinforge 0775L These should be 0755, unless there is clear rationale for otherwise. skeinforge.noarch: W: no-manual-page-for-binary skeinforge skeinforge.noarch: W: no-manual-page-for-binary skeinforge-craft Ignore these, this is a GUI application. skeinforge.src: W: strange-permission skeinforge 0775L skeinforge.src: W: strange-permission skeinforge-craft 0775L See above. skeinforge.src:82: W: macro-in-%changelog %doc 3 packages and 0 specfiles checked; 2 errors, 6 warnings. Rpmlint (installed packages) # rpmlint skeinforge-doc skeinforge skeinforge.noarch: W: no-documentation skeinforge.noarch: E: non-standard-executable-perm /usr/bin/skeinforge-craft 0775L skeinforge.noarch: E: non-standard-executable-perm /usr/bin/skeinforge 0775L skeinforge.noarch: W: no-manual-page-for-binary skeinforge skeinforge.noarch: W: no-manual-page-for-binary skeinforge-craft 2 packages and 0 specfiles checked; 2 errors, 3 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L0X1ZrIuOP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863793 T.C. Hollingsworth changed: What|Removed |Added Flags||needinfo?(mhroncok@redhat.c ||om) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Lrujm0mv7a&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863793 --- Comment #20 from Miro Hrončok --- Sorry. Haven't noticed that. Try it now please (didn't bumped revision number, as there is no change in spec). Don't forget to mv ...rpm.1 to ...rpm if using wget. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pvbwCX8Fjy&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863793 Miro Hrončok changed: What|Removed |Added Flags|needinfo?(mhroncok@redhat.c | |om) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BLAlxbOAhq&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=863793
T.C. Hollingsworth changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #21 from T.C. Hollingsworth ---
In the future, please bump Release even if there are no spec changes, just SRPM
changes. It's really easy to do (especially if you use `rpmdev-bumpspec`),
eliminates the chance of mistakes like the wget thing you mentioned, and is a
required part of the review process.
rpmlint is almost clean, except for the "macro-in-%changelog %doc" issue.
(Sorry, I forgot to call attention to that in the last comment.) Please fix
that in git.
To reduce the chance of things like the problematic executable permission from
happening in the future, consider explicitly setting the permissions of
packager-provided SourceN files upon install, e.g. by doing `install -Dpm0755
%{SOURCE7} %{buildroot}%{_bindir}/foo`.
This package is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=lSXV5zDyLG&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863793 --- Comment #22 from Miro Hrončok --- Thanks a lot for the review and for the tips. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YTuhvDURir&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863793 Miro Hrončok changed: What|Removed |Added Flags||fedora-cvs? --- Comment #23 from Miro Hrončok --- New Package SCM Request === Package Name: skeinforge Short Description: Converts 3D model into G-Code for RepRap Owners: churchyard Branches: f17 f18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1dr8rmjcTL&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863793 --- Comment #24 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gYMP0tbwN8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863793 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TcZ2PsKiIK&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863793 --- Comment #25 from Fedora Update System --- skeinforge-12.03.14-12.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/skeinforge-12.03.14-12.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iwzTCTfmQl&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863793 --- Comment #26 from Fedora Update System --- skeinforge-12.03.14-12.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/skeinforge-12.03.14-12.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hkEmLhy8NH&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863793 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bfTIN1C4Ss&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863793 --- Comment #27 from Fedora Update System --- skeinforge-12.03.14-12.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=STUsKdGasC&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863793 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2013-01-24 16:58:53 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=brd4YJH09v&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863793 --- Comment #28 from Fedora Update System --- skeinforge-12.03.14-12.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tsWIoR624y&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863793 --- Comment #29 from Fedora Update System --- skeinforge-12.03.14-12.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ykKe2OvBE2&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
