[Bug 863879] Review Request: f2fs-tools - Tools for Flash-Friendly File System (F2FS)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863879 Eduardo Echeverria echevemas...@gmail.com changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE Last Closed||2012-12-02 21:35:12 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863879] Review Request: f2fs-tools - Tools for Flash-Friendly File System (F2FS)
https://bugzilla.redhat.com/show_bug.cgi?id=863879 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863879] Review Request: f2fs-tools - Tools for Flash-Friendly File System (F2FS)
https://bugzilla.redhat.com/show_bug.cgi?id=863879 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- f2fs-tools-1.0.0-3.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863879] Review Request: f2fs-tools - Tools for Flash-Friendly File System (F2FS)
https://bugzilla.redhat.com/show_bug.cgi?id=863879 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- f2fs-tools-1.0.0-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/f2fs-tools-1.0.0-3.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863879] Review Request: f2fs-tools - Tools for Flash-Friendly File System (F2FS)
https://bugzilla.redhat.com/show_bug.cgi?id=863879
Mathieu Bridon boche...@fedoraproject.org changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #5 from Mathieu Bridon boche...@fedoraproject.org ---
Diff with the previous spec is:
--
@@ -1,8 +1,8 @@
Name:f2fs-tools
Version:1.0.0
-Release:2%{?dist}
+Release:3%{?dist}
Summary:Tools for Flash-Friendly File System (F2FS)
-License:GPLv2
+License:GPLv2+
URL:http://sourceforge.net/projects/f2fs-tools/
Source0:
http://downloads.sourceforge.net/project/%{name}/%{name}-%{version}.tar.gz
BuildRequires:autoconf
@@ -45,12 +45,16 @@
%files
-%doc COPYING README AUTHORS ChangeLog
+%doc COPYING AUTHORS ChangeLog
%{_bindir}/mkfs.f2fs
%{_mandir}/man8/mkfs.f2fs.8*
%changelog
+* Mon Oct 22 2012 Eduardo Echeverria echevemas...@gmail.com - 1.0.0-3
+- Change to the correct license GPLv2+
+- Remove README file to the section doc
+
* Mon Oct 15 2012 Eduardo Echeverria echevemas...@gmail.com - 1.0.0-2
- Add Changelog AUTHORS files to section doc
- Add wilcard to the manpages section.
--
This fixes the only problem I had with the previous submission (the License
tag), so the package is approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863879] Review Request: f2fs-tools - Tools for Flash-Friendly File System (F2FS)
https://bugzilla.redhat.com/show_bug.cgi?id=863879 --- Comment #6 from Eduardo Echeverria echevemas...@gmail.com --- Mathieu, Thanks again for the review New Package SCM Request === Package Name: f2fs-tools Short Description: Tools for Flash-Friendly File System (F2FS) Owners: echevemaster Branches: f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863879] Review Request: f2fs-tools - Tools for Flash-Friendly File System (F2FS)
https://bugzilla.redhat.com/show_bug.cgi?id=863879 Eduardo Echeverria echevemas...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863879] Review Request: f2fs-tools - Tools for Flash-Friendly File System (F2FS)
https://bugzilla.redhat.com/show_bug.cgi?id=863879 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863879] Review Request: f2fs-tools - Tools for Flash-Friendly File System (F2FS)
https://bugzilla.redhat.com/show_bug.cgi?id=863879 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863879] Review Request: f2fs-tools - Tools for Flash-Friendly File System (F2FS)
https://bugzilla.redhat.com/show_bug.cgi?id=863879 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- f2fs-tools-1.0.0-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/f2fs-tools-1.0.0-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863879] Review Request: f2fs-tools - Tools for Flash-Friendly File System (F2FS)
https://bugzilla.redhat.com/show_bug.cgi?id=863879 --- Comment #4 from Eduardo Echeverria echevemas...@gmail.com --- Thanks to take the review Mathieu: Added the changes: SPEC URL: http://echevemaster.fedorapeople.org/f2fs-tools/3/f2fs-tools.spec SRPM URL: http://echevemaster.fedorapeople.org/f2fs-tools/3/f2fs-tools-1.0.0-3.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863879] Review Request: f2fs-tools - Tools for Flash-Friendly File System (F2FS)
https://bugzilla.redhat.com/show_bug.cgi?id=863879
--- Comment #3 from Mathieu Bridon boche...@fedoraproject.org ---
First, a minor nitpick: I'm not convinced the README file has any value as
%doc, as it mostly just explains how to install, which is not useful in an RPM
package context.
If it were me, I wouldn't include it in the package at all, but it's really
your call. (it's obviously not a review blocker, just a personal preference)
Now for the actual review...
Summary
===
[!]: License field in the package spec file matches the actual license.
= The license tag should be GPLv2+
Fix that and I'll approve the package.
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm 4.4
[-]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[-]: Large documentation files are in a -doc subpackage, if required.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v2). 1 files have unknown license. Detailed output of licensecheck
in /home/mathieu/Workspace/dist-git/f2fs-tools/863879-f2fs-
tools/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[-]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Useful -debuginfo package or justification otherwise.
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball
[Bug 863879] Review Request: f2fs-tools - Tools for Flash-Friendly File System (F2FS)
https://bugzilla.redhat.com/show_bug.cgi?id=863879 Mathieu Bridon boche...@fedoraproject.org changed: What|Removed |Added CC||boche...@fedoraproject.org Assignee|nob...@fedoraproject.org|boche...@fedoraproject.org Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863879] Review Request: f2fs-tools - Tools for Flash-Friendly File System (F2FS)
https://bugzilla.redhat.com/show_bug.cgi?id=863879
--- Comment #2 from Eduardo Echeverria echevemas...@gmail.com ---
(In reply to comment #1)
Consider to add AUTHORS and ChangeLog.
Better make it %{_mandir}/man8/mkfs.f2fs.8* because the compression method
could change.
Thanks Volker:
Added the changes:
SPEC URL: http://echevemaster.fedorapeople.org/f2fs-tools/2/f2fs-tools.spec
SRPM URL:
http://echevemaster.fedorapeople.org/f2fs-tools/2/f2fs-tools-1.0.0-2.fc17.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863879] Review Request: f2fs-tools - Tools for Flash-Friendly File System (F2FS)
https://bugzilla.redhat.com/show_bug.cgi?id=863879
Volker Fröhlich volke...@gmx.at changed:
What|Removed |Added
CC||volke...@gmx.at
--- Comment #1 from Volker Fröhlich volke...@gmx.at ---
Consider to add AUTHORS and ChangeLog.
Better make it %{_mandir}/man8/mkfs.f2fs.8* because the compression method
could change.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
