[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
https://bugzilla.redhat.com/show_bug.cgi?id=864187 Miro Hrončok changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Depends On||825489 --- Comment #1 from Miro Hrončok --- Previous version bug 678980 Rewrited from scratch. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
https://bugzilla.redhat.com/show_bug.cgi?id=864187 Martin Gieseking changed: What|Removed |Added CC||m...@blagblagblag.org --- Comment #2 from Martin Gieseking --- *** Bug 678980 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
https://bugzilla.redhat.com/show_bug.cgi?id=864187 Ryan K changed: What|Removed |Added Flags||needinfo? --- Comment #3 from Ryan K --- I see that no one is working on this but I'm interested in this package getting into the repos. I know nothing about Fedora's packaging infrastructure, but I learn fast. Is there some way I can help? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
https://bugzilla.redhat.com/show_bug.cgi?id=864187 Miro Hrončok changed: What|Removed |Added Flags|needinfo? | --- Comment #4 from Miro Hrončok --- You might help by doing the package review, but I'll still need a sponsor. http://fedoraproject.org/wiki/Packaging:ReviewGuidelines -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
https://bugzilla.redhat.com/show_bug.cgi?id=864187 Mario Blättermann changed: What|Removed |Added CC||mario.blaetterm...@gmail.co ||m --- Comment #5 from Mario Blättermann --- The problem is, there's an open review request for opencsg (bug #825489) which is needed for openscad. But for opencsg, the requester has obviously no time to maintain this package in Fedora officially, and he needs a sponsor anyway. Miro, would you maintain both packages? If yes, then I could imagine to help out with a sponsorship. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #6 from Miro Hrončok --- Yes I would. I've originally made also a openscg spec file, but I've dropped it, it was very similar to #825489. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
https://bugzilla.redhat.com/show_bug.cgi?id=864187 Mario Blättermann changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co ||m --- Comment #7 from Mario Blättermann --- Ok, then please file a new review request for openscg (you might reuse the current spec and srpm, adding a new changelog entry) and mark the current one as a duplicate of yours. Then I will sponsor you and review openscg first. Once it it is built and submitted for testing, we go ahead with openscad. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
https://bugzilla.redhat.com/show_bug.cgi?id=864187 Miro Hrončok changed: What|Removed |Added Depends On|825489 |870860 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
https://bugzilla.redhat.com/show_bug.cgi?id=864187 Miro Hrončok changed: What|Removed |Added Depends On|870860 | -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #8 from Miro Hrončok --- OK, bug #870860 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
https://bugzilla.redhat.com/show_bug.cgi?id=864187 Miro Hrončok changed: What|Removed |Added Depends On||870860 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #9 from Miro Hrončok --- Spec URL: https://raw.github.com/hroncok/SPECS/master/openscad.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/openscad-2012.10.31-1.fc17.src.rpm - New version - Solved 2 MLCAD files license issues - Using full date version -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #10 from Miro Hrončok --- Mario, can we focus on this now? There are no new commits since 2012.10.31. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=864187
--- Comment #11 from Mario Blättermann ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4710481
Requires: %{name}
is insufficient here. You'll need a fully versioned dependency:
Requires: %{name}%{?_isa} = %{version}-%{release}
Your package contains a *.desktop file, which needs to be installed separately
or validated:
http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage
Some warnings from rpmlint:
openscad.src:12: W: macro-in-comment %{name}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
There are some more, regarding missing manpages and so on. Nothing of interest.
The package versioning could cause some problems when upgrading it once a fully
versioned tarball has been released. Please read the following:
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=864187
--- Comment #12 from Miro Hrončok ---
(In reply to comment #11)
> Requires: %{name}
> is insufficient here. You'll need a fully versioned dependency:
> Requires: %{name}%{?_isa} = %{version}-%{release}
Well, I know I should do this, but the think here is MCAD doesn't really need
the exact same version and release as OpenSCAD. In my case, you should be able
to update openSCAD or MCAD separately. I mean, you can simply run OpenSCAD
2012.11.01 and MCAD form 2012.05.10, it works.
> Your package contains a *.desktop file, which needs to be installed
> separately or validated:
> http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage
Will do that.
> Some warnings from rpmlint:
>
> openscad.src:12: W: macro-in-comment %{name}
> There is a unescaped macro after a shell style comment in the specfile.
> Macros
> are expanded everywhere, so check if it can cause a problem in this case and
> escape the macro with another leading % if appropriate.
The macros are there uncommented, so they can be evaluated if someone wants to
recreate the source tarball.
> The package versioning could cause some problems when upgrading it once a
> fully versioned tarball has been released. Please read the following:
> http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
I will certainly read that, just for the record, the date based versioning is
not something I've invented, if you build OpenSCAD, the version used is todays
date. I overwrite that with:
qmake-qt4 VERSION=%{version} PREFIX=%{_prefix}
Othervise the version (in program's About and such) would depend on the date of
building.
What would you suggest? This?
Version: 2011.12 (Latest stable)
Release: 1.20121031gitb04734cbf5%{?dist}
That would mean in program itself, the version would be noted as 2011.06 (a bit
old).
What about:
Version: 2012.10 (used version, without day)
Release: 0.31.1{?dist} (0 at the beginning, 31 as the day and .1 so I can bump
it)
That would mean in program itself, the version would be noted as 2012.10 (seems
OK).
If there is a tarball (e.g. 2012.10) released, I'll do:
Version: 2012.10
Release: 1{?dist}
This should work, right?
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=864187
--- Comment #13 from Mario Blättermann ---
(In reply to comment #12)
> (In reply to comment #11)
> > Requires: %{name}
> > is insufficient here. You'll need a fully versioned dependency:
> > Requires: %{name}%{?_isa} = %{version}-%{release}
> Well, I know I should do this, but the think here is MCAD doesn't really
> need the exact same version and release as OpenSCAD. In my case, you should
> be able to update openSCAD or MCAD separately. I mean, you can simply run
> OpenSCAD 2012.11.01 and MCAD form 2012.05.10, it works.
>
Well, could be, but with full versioning you make sure that both packages will
be upfdated, which avoids updating only one by accidence. Of course I believe
that it works for the time being, but this could change in the future.
> > Your package contains a *.desktop file, which needs to be installed
> > separately or validated:
> > http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage
> Will do that.
>
> > Some warnings from rpmlint:
> >
> > openscad.src:12: W: macro-in-comment %{name}
> > There is a unescaped macro after a shell style comment in the specfile.
> > Macros
> > are expanded everywhere, so check if it can cause a problem in this case and
> > escape the macro with another leading % if appropriate.
> The macros are there uncommented, so they can be evaluated if someone wants
> to recreate the source tarball.
>
The macros are "commented" by the hash line. It is not needed, drop it.
> > The package versioning could cause some problems when upgrading it once a
> > fully versioned tarball has been released. Please read the following:
> > http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
> I will certainly read that, just for the record, the date based versioning
> is not something I've invented, if you build OpenSCAD, the version used is
> todays date. I overwrite that with:
>
> qmake-qt4 VERSION=%{version} PREFIX=%{_prefix}
>
> Othervise the version (in program's About and such) would depend on the date
> of building.
>
> What would you suggest? This?
>
> Version: 2011.12 (Latest stable)
> Release: 1.20121031gitb04734cbf5%{?dist}
>
> That would mean in program itself, the version would be noted as 2011.06 (a
> bit old).
>
> What about:
>
> Version: 2012.10 (used version, without day)
> Release: 0.31.1{?dist} (0 at the beginning, 31 as the day and .1 so I can
> bump it)
>
> That would mean in program itself, the version would be noted as 2012.10
> (seems OK).
>
> If there is a tarball (e.g. 2012.10) released, I'll do:
>
> Version: 2012.10
> Release: 1{?dist}
>
> This should work, right?
This should work, but prepend a version number "0-" as proposed in the
guidelines to make sure that a future version "0.1" (or anything similar) gets
the correct upgrade path. Or must we not expect such a versioning?
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=864187
--- Comment #14 from Miro Hrončok ---
(In reply to comment #13)
> This should work, but prepend a version number "0-" as proposed in the
> guidelines to make sure that a future version "0.1" (or anything similar)
> gets the correct upgrade path. Or must we not expect such a versioning?
The upstream versions are noted as 2012.6 so if I prepend the version with 0, I
would be unable to release further shapshot after the release.
Is this usable?
Version:2012.10
Release:0.2%{?dist}
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #15 from Mario Blättermann --- OK, forget the prepended "0". Seems this is not to resolve this way... Keep the version as it is for the time being. Once a fully versioned tarball has been released (if it ever happens) you could add "Obsoletes:" and "Provides:" tags to get a proper upgrade path. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 Bug 864187 depends on bug 870860, which changed state. Bug 870860 Summary: Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL https://bugzilla.redhat.com/show_bug.cgi?id=870860 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #16 from Miro Hrončok --- Spec URL: https://raw.github.com/hroncok/SPECS/master/openscad.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/openscad-2012.10.31-2.fc17.src.rpm - Commented macros in comments - Fully versioned dependency of the main package - added desktop-file-validate -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #17 from Miro Hrončok --- Spec URL: https://raw.github.com/hroncok/SPECS/master/openscad.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/openscad-2012.10.31-3.fc17.src.rpm - Added manpage (BR gzip) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #18 from Mario Blättermann --- (In reply to comment #17) > - Added manpage (BR gzip) gzip is part of the basic build environment: http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2 It is not needed to add it explicitely. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #19 from Miro Hrončok --- Sorry for missing that, updated (didn't bumped the revision number). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=864187
Ralf Corsepius changed:
What|Removed |Added
CC||rc040...@freenet.de
--- Comment #20 from Ralf Corsepius ---
This is superflous (and wrong):
gzip %{buildroot}%{_mandir}/man1/%{name}.1
rpm-build automatically compresses manpages under %{_mandir}/man1 in the format
the distributions wants them the be compressed into (currently gzip).
Please remove this line.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #21 from Miro Hrončok --- I was googling it, because I expected such a behaviour, but I couldn't find anything specific, could you plese provide a link to documentation about this? Thanks a lot. Spec URL: https://raw.github.com/hroncok/SPECS/master/openscad.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/openscad-2012.10.31-4.fc17.src.rpm - Removed useless gziping -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #22 from Ralf Corsepius --- (In reply to comment #21) > I was googling it, because I expected such a behaviour, but I couldn't find > anything specific, could you plese provide a link to documentation about > this? Thanks a lot. Errm, no. Apparently, it's one of the details everybody who is envolved into RH-rpm packaging takes for granted, because RH-rpm-build has been automatically compressing man-pages probably ever rpm since it exists ;) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #23 from Mario Blättermann --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4764644 It fails with the following error message: BuildError: mismatch when analyzing openscad-MCAD-2012.10.31-4.fc19.noarch.rpm, rpmdiff output was: removed REQUIRES openscad(x86-64) = 2012.10.31-4.fc19 added REQUIRES openscad(x86-32) = 2012.10.31-4.fc19 This means, different output will be produced for the arches, although the package is actually noarch. You could try to find out the reason for the differences. But maybe there is another solution. You are using two source packages for openscad, and as you already wrote, openscad doesn't need openscad-MCAD in the same version (probably, but this is yours). What about to build openscad-MCAD in an independent source rpm? Anyway, openscad-MCAD is not in "Requires:" for openscad, so that could be a proper way to get rid of such errors. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=864187
--- Comment #24 from Miro Hrončok ---
The reason is obviously here (isa part):
Requires: %{name}%{?_isa} = %{version}-%{release}
But as you say, separating this might be better.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #25 from Miro Hrončok --- Spec URL: https://raw.github.com/hroncok/SPECS/master/openscad.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/openscad-2012.10.31-5.fc17.src.rpm Removed MCAD from this source package -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 Miro Hrončok changed: What|Removed |Added Blocks||884876 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=864187
Mario Blättermann changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #26 from Mario Blättermann ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4767543
$ rpmlint -i -v *
openscad.src: I: checking
openscad.src: I: checking-url http://www.openscad.org/ (timeout 10 seconds)
openscad.src: W: invalid-url Source0: openscad-2012.10.31.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.
openscad.i686: I: checking
openscad.i686: I: checking-url http://www.openscad.org/ (timeout 10 seconds)
openscad.x86_64: I: checking
openscad.x86_64: I: checking-url http://www.openscad.org/ (timeout 10 seconds)
openscad-debuginfo.i686: I: checking
openscad-debuginfo.i686: I: checking-url http://www.openscad.org/ (timeout 10
seconds)
openscad-debuginfo.x86_64: I: checking
openscad-debuginfo.x86_64: I: checking-url http://www.openscad.org/ (timeout 10
seconds)
openscad.spec: W: invalid-url Source0: openscad-2012.10.31.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.
5 packages and 1 specfiles checked; 0 errors, 2 warnings.
Nothing of interest.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
GPLv2 with exceptions
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
0257c25980035444fa3912a19ebf6fbba9247b8f52a0656219910d60858953d8
openscad-2012.10.31.tar.gz
0257c25980035444fa3912a19ebf6fbba9247b8f52a0656219910d60858953d8
openscad-2012.10.31.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #27 from Miro Hrončok --- New Package SCM Request === Package Name: openscad Short Description: The Programmers Solid 3D CAD Modeller Owners: churchyard mariobl Branches: f17 f18 InitialCC: gregjurman -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1lL6Rgnvhr&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 Mario Blättermann changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SScWifZHkv&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 Mario Blättermann changed: What|Removed |Added Flags||fedora-cvs? --- Comment #28 from Mario Blättermann --- Miro, please don't forget to set the fedora-cvs flag to "?" when requesting the Git repo. Just did it for you. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kIABnpShs2&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #29 from Miro Hrončok --- Oh, I would finaly notice that around May :D Thanks a lot. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2pT8llVQQ6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #30 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ym6dsnkNnU&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rLqCYOK7nL&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #31 from Fedora Update System --- openscad-2012.10.31-5.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/openscad-2012.10.31-5.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8ZWCEdWKgR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #32 from Fedora Update System --- openscad-2012.10.31-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/openscad-2012.10.31-5.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4utf3s68e2&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xvHIh6Frty&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #33 from Fedora Update System --- openscad-2012.10.31-5.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hztjgLnWT1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #34 from Fedora Update System --- openscad-2012.10.31-5.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=l8zCUuA3u5&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-12-19 22:18:30 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nJIBT0gzt6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
https://bugzilla.redhat.com/show_bug.cgi?id=864187 Jiri Kastner changed: What|Removed |Added CC||jkast...@redhat.com --- Comment #51 from Jiri Kastner --- Package Change Request == Package Name: openscad New Branches: epel7 Owners: churchyard -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #52 from Miro Hrončok --- Jiri, I'm not willing to maintain current version of OpenSCAD for 10+ years. Feel free to take this effort, but do not mark me as an owner. The same for openscad-MCAD. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #53 from Jiri Kastner --- Package Change Request == Package Name: openscad New Branches: epel7 Owners: jkastner -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #35 from Fedora Update System --- openscad-2013.01.05-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/openscad-2013.01.05-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QR4k65Dvrs&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #36 from Fedora Update System --- openscad-2013.01.05-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/openscad-2013.01.05-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NWNtXPt4gp&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #37 from Fedora Update System --- openscad-2013.01.08-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/openscad-2013.01.08-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=59GxmPuCYO&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #38 from Fedora Update System --- openscad-2013.01.08-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/openscad-2013.01.08-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cO3aASprSC&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #39 from Fedora Update System --- openscad-2012.10.31-5.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5yW7sCFFUD&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #40 from Fedora Update System --- openscad-2013.01.17-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/openscad-2013.01.17-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=waqv07GNbe&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #41 from Fedora Update System --- openscad-2013.01.17-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/openscad-2013.01.17-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Hb7M3RzxaC&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #42 from Fedora Update System --- openscad-2013.01.08-1.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ANTzrv0YGu&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #43 from Fedora Update System --- openscad-2013.01.17-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/openscad-2013.01.17-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=83K6evp4rH&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #44 from Fedora Update System --- openscad-2013.01.17-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/openscad-2013.01.17-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pkuW8PiJQs&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 Fedora Update System changed: What|Removed |Added CC|ryanskingsbury@alumni.utexa | |s.net | --- Comment #45 from Fedora Update System --- openscad-2013.01.17-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/openscad-2013.01.17-3.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JdgTlpOVKN&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #46 from Fedora Update System --- openscad-2013.01.17-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/openscad-2013.01.17-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yNrY7ihECL&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #47 from Mario Blättermann --- Miro, you don't have to submit the bug number of the review request when updating your packages. The bug report is already closed anyway. In case of an existing bug report for the package itself (e.g. a request to update it, or a crash report) please add those numbers. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nRdyuR0j1k&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #48 from Miro Hrončok --- OK. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ItyjJoWwhu&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #49 from Fedora Update System --- openscad-2013.01.17-3.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Q0IwMqukC5&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #50 from Fedora Update System --- openscad-2013.01.17-3.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1JWpKtfpLj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
