[Bug 864315] Review Request: lonote - Personal Notebook based on Qt Webkit
https://bugzilla.redhat.com/show_bug.cgi?id=864315 --- Comment #1 from Robin Lee --- - Fix and validate the desktop entry file Spec URL: http://cheeselee.fedorapeople.org/lonote.spec SRPM URL: http://cheeselee.fedorapeople.org/lonote-1.8.6-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864315] Review Request: lonote - Personal Notebook based on Qt Webkit
https://bugzilla.redhat.com/show_bug.cgi?id=864315 Eduardo Echeverria changed: What|Removed |Added CC||echevemas...@gmail.com --- Comment #2 from Eduardo Echeverria --- Robin, When trying to get in to see the spec, gives a 403 error -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864315] Review Request: lonote - Personal Notebook based on Qt Webkit
https://bugzilla.redhat.com/show_bug.cgi?id=864315 --- Comment #3 from Robin Lee --- (In reply to comment #2) > Robin, When trying to get in to see the spec, gives a 403 error Oh, sorry. Fixed file perm on fedorapeople.org. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864315] Review Request: lonote - Personal Notebook based on Qt Webkit
https://bugzilla.redhat.com/show_bug.cgi?id=864315 --- Comment #4 from Robin Lee --- - Update to 1.8.7 Spec URL: http://cheeselee.fedorapeople.org/lonote.spec SRPM URL: http://cheeselee.fedorapeople.org/lonote-1.8.7-1.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864315] Review Request: lonote - Personal Notebook based on Qt Webkit
https://bugzilla.redhat.com/show_bug.cgi?id=864315 Ankur Sinha (FranciscoD) changed: What|Removed |Added Status|NEW |ASSIGNED CC||sanjay.an...@gmail.com Assignee|nob...@fedoraproject.org|sanjay.an...@gmail.com Flags||fedora-review? --- Comment #5 from Ankur Sinha (FranciscoD) --- Thanks Robin, I'll review this one. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864315] Review Request: lonote - Personal Notebook based on Qt Webkit
https://bugzilla.redhat.com/show_bug.cgi?id=864315 Ankur Sinha (FranciscoD) changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #6 from Ankur Sinha (FranciscoD) --- Hi Robin, Here's the review: [+] OK [-] NA [?] Issue ** Mandatory review guidelines: ** [+] rpmlint output: [ankur@ankur SRPMS]$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm ../SPECS/lonote.spec lonote-1.8.7-1.fc17.src.rpm lonote.src: W: strange-permission lonote.spec 0600L lonote.src:22: W: macro-in-comment %setup ../SPECS/lonote.spec:22: W: macro-in-comment %setup lonote.src: W: strange-permission lonote.spec 0600L lonote.src:22: W: macro-in-comment %setup 3 packages and 1 specfiles checked; 0 errors, 5 warnings. [ankur@ankur SRPMS]$ ^^ Looks okay. The permissions of the spec etc are wrong for some reason though. [+] License is acceptable [+] License field in spec is correct [+] License files included in package %docs if included in source package [-] License files installed when any subpackage combination is installed [+] Spec written in American English [+] Spec is legible [+] Sources match upstream unless altered to fix permissibility issues [ankur@ankur SRPMS]$ review-md5check.sh ../SPECS/lonote.spec Getting http://lonote.googlecode.com/files/lonote-1.8.7.7z to /tmp/review/lonote-1.8.7.7z % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 100 532k 100 532k0 0 362k 0 0:00:01 0:00:01 --:--:-- 450k 019878f95567dde43dcb5e4a07660c07 /tmp/review/lonote-1.8.7.7z 019878f95567dde43dcb5e4a07660c07 /home/ankur/rpmbuild/SOURCES/lonote-1.8.7.7z removed `/tmp/review/lonote-1.8.7.7z' removed directory: `/tmp/review' [ankur@ankur SRPMS]$ [+] Build succeeds on at least one primary arch [+] Build succeeds on all primary arches or has ExcludeArch + bugs filed [+] BuildRequires correct, justified where necessary [+] Locales handled with %find_lang, not %_datadir/locale/* [-] %post, %postun call ldconfig if package contains shared .so files [+] No bundled libs [-] Relocatability is justified [+] Package owns all directories it creates [+] No duplication in %files unless necessary for license files [+] File permissions are sane [+] Package contains permissible code or content [-] Large docs go in -doc subpackage [-] %doc files not required at runtime [+] GUI app uses .desktop file, installs it with desktop-file-install [+] File list does not conflict with other packages' without justification [+] File names are valid UTF-8 ** Optional review guidelines: ** [-] Query upstream about including license files [-] Translations of description, summary [+] Builds in mock [+] Builds on all arches [-] Functions as described (e.g. no crashes) ^ Not verified. Please verify [-] Scriptlets are sane [-] Subpackages require base with fully-versioned dependency if sensible [-] .pc file subpackage placement is sensible [-] No file deps outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin [+] Include man pages if available Naming guidelines: [+] Package names use only a-zA-Z0-9-._+ subject to restrictions on -._+ [+] Package names are sane [+] No naming conflicts [+] Spec file name matches base package name [+] Version is sane [+] Version does not contain ~ [+] Release is sane [+] %dist tag [-] Case used only when necessary [-] Renaming handled correctly Packaging guidelines: [-] Useful without external bits [-] No kmods [-] Pre-built binaries, libs removed in %prep [+] Sources contain only redistributable code or content [+] Spec format is sane [+] Package obeys FHS, except libexecdir, /run, /usr/target [+] No files in /bin, /sbin, /lib* on >= F17 [-] Programs run before FS mounting use /run instead of /var/run [-] Binaries in /bin, /sbin do not depend on files in /usr on < F17 [-] No files under /srv, /opt, /usr/local [+] Changelog in prescribed format [+] No Packager, Vendor, Copyright, PreReq tags [+] Summary does not end in a period [-] Correct BuildRoot tag on < EL6 [-] Correct %clean section on < EL6 [+] Requires correct, justified where necessary [+] Summary, description do not use trademarks incorrectly [-] All relevant documentation is packaged, appropriately marked with %doc [+] Doc files do not drag in extra dependencies (e.g. due to +x) [-] Code compilable with gcc is compiled with gcc [-] Build honors applicable compiler flags or justifies otherwise [-] PIE used for long-running/root daemons, setuid/filecap programs [-] Useful -debuginfo package or disabled and justified [-] Package with .pc files Requires pkgconfig on < EL6 [-] No static executables [-] Rpath absent or only used for internal libs [-] Config files marked with %config(noreplace) or justified %config [-] No config files under /usr [-] Th
[Bug 864315] Review Request: lonote - Personal Notebook based on Qt Webkit
https://bugzilla.redhat.com/show_bug.cgi?id=864315 Robin Lee changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Robin Lee --- Thanks, Ankur. New Package SCM Request === Package Name: lonote Short Description: Personal Notebook based on Qt Webkit Owners: cheeselee Branches: f16 f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864315] Review Request: lonote - Personal Notebook based on Qt Webkit
https://bugzilla.redhat.com/show_bug.cgi?id=864315 --- Comment #8 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864315] Review Request: lonote - Personal Notebook based on Qt Webkit
https://bugzilla.redhat.com/show_bug.cgi?id=864315 --- Comment #9 from Fedora Update System --- lonote-1.8.7-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/lonote-1.8.7-1.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864315] Review Request: lonote - Personal Notebook based on Qt Webkit
https://bugzilla.redhat.com/show_bug.cgi?id=864315 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864315] Review Request: lonote - Personal Notebook based on Qt Webkit
https://bugzilla.redhat.com/show_bug.cgi?id=864315 --- Comment #10 from Fedora Update System --- lonote-1.8.7-1.fc16 has been pushed to the Fedora 16 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864315] Review Request: lonote - Personal Notebook based on Qt Webkit
https://bugzilla.redhat.com/show_bug.cgi?id=864315 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864315] Review Request: lonote - Personal Notebook based on Qt Webkit
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864315 Robin Lee changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||lonote-1.8.7-1.fc16 Resolution|--- |CURRENTRELEASE Last Closed||2012-12-11 23:10:26 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=l8vBbr3bgo&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
