[Bug 865890] Review Request: concurrentlinkedhashmap-lru - A ConcurrentLinkedHashMap for Java
https://bugzilla.redhat.com/show_bug.cgi?id=865890 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||concurrentlinkedhashmap-lru ||-1.3.2-1.fc19 Resolution|--- |ERRATA Last Closed||2013-06-05 22:24:53 --- Comment #15 from Fedora Update System --- concurrentlinkedhashmap-lru-1.3.2-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5UIeQLtik4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 865890] Review Request: concurrentlinkedhashmap-lru - A ConcurrentLinkedHashMap for Java
https://bugzilla.redhat.com/show_bug.cgi?id=865890 Fedora Update System changed: What|Removed |Added Fixed In Version|concurrentlinkedhashmap-lru |concurrentlinkedhashmap-lru |-1.3.2-1.fc19 |-1.3.2-1.fc18 --- Comment #16 from Fedora Update System --- concurrentlinkedhashmap-lru-1.3.2-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MyG9BetAu9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 865890] Review Request: concurrentlinkedhashmap-lru - A ConcurrentLinkedHashMap for Java
https://bugzilla.redhat.com/show_bug.cgi?id=865890 --- Comment #1 from gil cattaneo --- Spec URL: http://gil.fedorapeople.org/concurrentlinkedhashmap-lru.spec SRPM URL: http://gil.fedorapeople.org/concurrentlinkedhashmap-lru-1.3.2-1.fc18.src.rpm - update to 1.3.2 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EwAv8K9Dd0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 865890] Review Request: concurrentlinkedhashmap-lru - A ConcurrentLinkedHashMap for Java
https://bugzilla.redhat.com/show_bug.cgi?id=865890 Douglas Schilling Landgraf changed: What|Removed |Added CC||dougsl...@redhat.com Assignee|nob...@fedoraproject.org|dougsl...@redhat.com --- Comment #2 from Douglas Schilling Landgraf --- Hi Gil, Please check my comments below: - Maven packages should use new style packaging Note: If possible update your package to latest guidelines See: https://fedoraproject.org/wiki/Packaging:Java#Apache_Maven - Please do not include license into Source01 Source1: http://www.apache.org/licenses/LICENSE-2.0.txt Here suggestions how you can deal with this situation: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines Thanks Douglas -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QKQcQaBDfk&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 865890] Review Request: concurrentlinkedhashmap-lru - A ConcurrentLinkedHashMap for Java
https://bugzilla.redhat.com/show_bug.cgi?id=865890 --- Comment #3 from gil cattaneo --- hi (In reply to Douglas Schilling Landgraf from comment #2) > Hi Gil, > > Please check my comments below: > > - Maven packages should use new style packaging > Note: If possible update your package to latest guidelines > See: https://fedoraproject.org/wiki/Packaging:Java#Apache_Maven for no use F18 and xmvn binary isnt available > > - Please do not include license into Source01 > Source1: http://www.apache.org/licenses/LICENSE-2.0.txt > > Here suggestions how you can deal with this situation: > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/ > LicensingGuidelines see http://code.google.com/p/concurrentlinkedhashmap/issues/detail?id=38 > > > > Thanks > Douglas regards -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DDWVurNE2Y&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 865890] Review Request: concurrentlinkedhashmap-lru - A ConcurrentLinkedHashMap for Java
https://bugzilla.redhat.com/show_bug.cgi?id=865890 --- Comment #4 from gil cattaneo --- (In reply to gil cattaneo from comment #3) > hi > > (In reply to Douglas Schilling Landgraf from comment #2) > > Hi Gil, > > > > Please check my comments below: > > > > - Maven packages should use new style packaging > > Note: If possible update your package to latest guidelines > > See: https://fedoraproject.org/wiki/Packaging:Java#Apache_Maven > for no use F18 and xmvn binary isnt available for now i use F18 and xmvn binary isnt available -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9y1iKHgh0J&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 865890] Review Request: concurrentlinkedhashmap-lru - A ConcurrentLinkedHashMap for Java
https://bugzilla.redhat.com/show_bug.cgi?id=865890 Douglas Schilling Landgraf changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #5 from Douglas Schilling Landgraf --- (In reply to gil cattaneo from comment #3) > hi > > (In reply to Douglas Schilling Landgraf from comment #2) > > Hi Gil, > > > > Please check my comments below: > > > > - Maven packages should use new style packaging > > Note: If possible update your package to latest guidelines > > See: https://fedoraproject.org/wiki/Packaging:Java#Apache_Maven > for no use F18 and xmvn binary isnt available > > > > - Please do not include license into Source01 > > Source1: http://www.apache.org/licenses/LICENSE-2.0.txt > > > > Here suggestions how you can deal with this situation: > > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/ > > LicensingGuidelines > see http://code.google.com/p/concurrentlinkedhashmap/issues/detail?id=38 > > It's not required to include the license but nice that you have followed the instructions and notified the project. Please update your spec removing the Source1 which includes the license and include (or not) the LICENSE file into it. Thanks Douglas -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EWfPnDXtW1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 865890] Review Request: concurrentlinkedhashmap-lru - A ConcurrentLinkedHashMap for Java
https://bugzilla.redhat.com/show_bug.cgi?id=865890 --- Comment #6 from Douglas Schilling Landgraf --- (In reply to gil cattaneo from comment #4) > (In reply to gil cattaneo from comment #3) > > hi > > > > (In reply to Douglas Schilling Landgraf from comment #2) > > > Hi Gil, > > > > > > Please check my comments below: > > > > > > - Maven packages should use new style packaging > > > Note: If possible update your package to latest guidelines > > > See: https://fedoraproject.org/wiki/Packaging:Java#Apache_Maven > > for no use F18 and xmvn binary isnt available > for now i use F18 and xmvn binary isnt available Thanks for the check. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NKRQJmCwwO&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 865890] Review Request: concurrentlinkedhashmap-lru - A ConcurrentLinkedHashMap for Java
https://bugzilla.redhat.com/show_bug.cgi?id=865890 --- Comment #7 from gil cattaneo --- Spec URL: http://gil.fedorapeople.org/concurrentlinkedhashmap-lru.spec SRPM URL: http://gil.fedorapeople.org/concurrentlinkedhashmap-lru-1.3.2-1.fc18.src.rpm - removed SOURCE1 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KFHTI7dzgS&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 865890] Review Request: concurrentlinkedhashmap-lru - A ConcurrentLinkedHashMap for Java
https://bugzilla.redhat.com/show_bug.cgi?id=865890 --- Comment #8 from gil cattaneo --- concurrentlinkedhashmap-lru is a Build/requires for Apache Camel -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UFeKM6Mu9X&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 865890] Review Request: concurrentlinkedhashmap-lru - A ConcurrentLinkedHashMap for Java
https://bugzilla.redhat.com/show_bug.cgi?id=865890
Douglas Schilling Landgraf changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #9 from Douglas Schilling Landgraf ---
Hi Gil,
Package manually reviewed, also used fedora-review tool.
[OK] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
Checking: concurrentlinkedhashmap-lru-1.3.2-1.fc18.noarch.rpm
concurrentlinkedhashmap-lru-javadoc-1.3.2-1.fc18.noarch.rpm
concurrentlinkedhashmap-lru.noarch: W: spelling-error %description -l en_US
util -> til, until, u til
concurrentlinkedhashmap-lru.noarch: W: spelling-error %description -l en_US
LinkedHashMap
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
Rpmlint (installed packages)
# rpmlint concurrentlinkedhashmap-lru-javadoc concurrentlinkedhashmap-lru
concurrentlinkedhashmap-lru.noarch: W: spelling-error %description -l en_US
util -> til, until, u til
concurrentlinkedhashmap-lru.noarch: W: spelling-error %description -l en_US
LinkedHashMap
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
All above can be ignored.
[OK] MUST: The package must be named according to the Package Naming Guidelines
[OK] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption
[OK] MUST: The package must meet the Packaging Guidelines
[OK] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines
[OK] MUST: The License field in the package spec file must match the actual
license.
[OK] MUST: The spec file must be written in American English
[OK] MUST: The spec file for the package MUST be legible
[OK] MUST: Packages must NOT bundle copies of system libraries
[OK] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory. [13]
[OK] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)[14]
[OK] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. [15]
[OK] MUST: Each package must consistently use macros. [16]
[OK] MUST: The package must contain code, or permissable content
[OK]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[OK]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[OK]: Each %files section contains %defattr if rpm < 4.4
[OK]: Macros in Summary, %description expandable at SRPM build time.
[OK]: Package does not contain duplicates in %files.
[OK]: Permissions on files are set properly.
[OK]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[OK]: Package is named using only allowed ASCII characters.
[OK]: Package do not use a name that already exist
[OK]: Package is not relocatable.
[OK]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[OK]: File names are valid UTF-8.
[OK]: Packages must not store files under /srv, /opt or /usr/local
[OK]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[OK]: Package installs properly.
[OK]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Java:
===
[OK]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It is
pulled in by maven-local
[OK]: Fully versioned dependency in subpackages, if present.
[OK]: Javadoc documentation files are generated and included in -javadoc
subpackage
[OK]: Javadoc subpackages should not have Requires: jpackage-utils
[OK]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
[OK]: Bundled jar/class files should be removed before build
[OK]: Packages are noarch unless they use JNI
Maven:
[OK]: Old add_to_maven_depmap macro is not being used
[OK]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[OK]: Package DOES NOT use %update_maven_depmap in %post/%postun
[OK]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms
Should
===
[OK]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
http://code.google.com/p/concurrentlinkedhashmap/issues/detail?id=38
[OK]: Package functions as described.
[OK]: Latest version is packaged.
[OK]: Sou
[Bug 865890] Review Request: concurrentlinkedhashmap-lru - A ConcurrentLinkedHashMap for Java
https://bugzilla.redhat.com/show_bug.cgi?id=865890 gil cattaneo changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from gil cattaneo --- New Package SCM Request === Package Name: concurrentlinkedhashmap-lru Short Description: A ConcurrentLinkedHashMap for Java Owners: gil Branches: f18 f19 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gF5vokfm2E&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 865890] Review Request: concurrentlinkedhashmap-lru - A ConcurrentLinkedHashMap for Java
https://bugzilla.redhat.com/show_bug.cgi?id=865890 --- Comment #11 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mFyIPMFKE4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 865890] Review Request: concurrentlinkedhashmap-lru - A ConcurrentLinkedHashMap for Java
https://bugzilla.redhat.com/show_bug.cgi?id=865890 --- Comment #12 from Fedora Update System --- concurrentlinkedhashmap-lru-1.3.2-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/concurrentlinkedhashmap-lru-1.3.2-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HrbfaWqmhM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 865890] Review Request: concurrentlinkedhashmap-lru - A ConcurrentLinkedHashMap for Java
https://bugzilla.redhat.com/show_bug.cgi?id=865890 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SAFBBnTUoe&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 865890] Review Request: concurrentlinkedhashmap-lru - A ConcurrentLinkedHashMap for Java
https://bugzilla.redhat.com/show_bug.cgi?id=865890 --- Comment #13 from Fedora Update System --- concurrentlinkedhashmap-lru-1.3.2-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/concurrentlinkedhashmap-lru-1.3.2-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6P5lGN389c&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 865890] Review Request: concurrentlinkedhashmap-lru - A ConcurrentLinkedHashMap for Java
https://bugzilla.redhat.com/show_bug.cgi?id=865890 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oxJ9Poa7Qp&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 865890] Review Request: concurrentlinkedhashmap-lru - A ConcurrentLinkedHashMap for Java
https://bugzilla.redhat.com/show_bug.cgi?id=865890 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System --- concurrentlinkedhashmap-lru-1.3.2-1.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=01F1hhJtvW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
