[Bug 866183] Review Request: python-mididings - A MIDI router and processor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866183 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG Flags|needinfo? | Last Closed||2013-05-04 05:47:13 --- Comment #18 from Volker Fröhlich volke...@gmx.at --- Another week, closing -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ogbtJIxc5da=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866183] Review Request: python-mididings - A MIDI router and processor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866183 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added Flags||needinfo? --- Comment #17 from Volker Fröhlich volke...@gmx.at --- Still interested? If not, I'll close that ticket later. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JVwyJNDikNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866183] Review Request: python-mididings - A MIDI router and processor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866183 --- Comment #16 from Volker Fröhlich volke...@gmx.at --- Just a reminder -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GpV9n1FtK2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866183] Review Request: python-mididings - A MIDI router and processor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866183 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added Flags|needinfo?(volke...@gmx.at) | --- Comment #9 from Volker Fröhlich volke...@gmx.at --- Mamoru: The problem I noticed in #5 is still there, since there's no new SRPM. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hFYbHtQWqka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866183] Review Request: python-mididings - A MIDI router and processor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866183 --- Comment #11 from Mamoru TASAKA mtas...@fedoraproject.org --- Also, package maintainer need not use the same spec file for all branches (i.e. rawhide / F-18 / F-17) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Hn5u2GFufOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866183] Review Request: python-mididings - A MIDI router and processor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866183 --- Comment #10 from Mamoru TASAKA mtas...@fedoraproject.org --- Well, the fact that srpm in review does not build on F-17 is not a review blocker, actually. Srpm in review must build at least on _rawhide_ , however for F-18 and below, the submitter (who is going to be the owner of the package) can decide whether to support those branches or not. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kHnu48p2gqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866183] Review Request: python-mididings - A MIDI router and processor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866183 --- Comment #12 from Brendan Jones brendan.jones...@gmail.com --- (In reply to comment #11) Also, package maintainer need not use the same spec file for all branches (i.e. rawhide / F-18 / F-17) Yes, I will use a different spec for f17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KuF0BWXPqna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866183] Review Request: python-mididings - A MIDI router and processor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866183 --- Comment #13 from Volker Fröhlich volke...@gmx.at --- Good, I'm at it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Y1qfJ04uUfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866183] Review Request: python-mididings - A MIDI router and processor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866183 --- Comment #14 from Volker Fröhlich volke...@gmx.at --- livedings is a graphical application that requires tkinter to run. Consequently, it will need a desktop file. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VtmPOqYKl2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866183] Review Request: python-mididings - A MIDI router and processor
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866183
--- Comment #15 from Volker Fröhlich volke...@gmx.at ---
livedings also requires pyliblo. I'm not sure if there's a Python 3 version.
It seems like it's not necessary to export the optflags.
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[-]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[!]: Package contains desktop file if it is a GUI application.
livedings needs one
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
Also tried on PPC
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in %package -n
python3-%{pkgname}
Not a subpackage
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v2 or later), Unknown or generated. 2 files have unknown
license. Detailed output of licensecheck in
/media/speicher1/makerpm/866183-python-mididings/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[!]: Requires correct, justified where necessary.
livedings requires tkinter and pyliblo. pyliblo is stated as optional in README
for some reason.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 409600 bytes in 50 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
Note: Cannot find sources under BUILD (using prebuilt sources?)
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[-]: If the source package does not include
[Bug 866183] Review Request: python-mididings - A MIDI router and processor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866183 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Flags||needinfo?(volke...@gmx.at) --- Comment #8 from Mamoru TASAKA mtas...@fedoraproject.org --- What is the status of this bug? Volker, are you reviewing this? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NbiShpIYHua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866183] Review Request: python-mididings - A MIDI router and processor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866183 Bug 866183 depends on bug 867894, which changed state. Bug 867894 Summary: Please update to version 3.4.0 https://bugzilla.redhat.com/show_bug.cgi?id=867894 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3VCp2Q4ihla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866183] Review Request: python-mididings - A MIDI router and processor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866183 --- Comment #5 from Volker Fröhlich volke...@gmx.at --- Please bump the release when you publish a changed version. F17 build fails due to a linking issue: F17: http://kojipkgs.fedoraproject.org//work/tasks/601/4700601/build.log Rawhide: http://kojipkgs.fedoraproject.org//work/tasks/563/4700563/build.log -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866183] Review Request: python-mididings - A MIDI router and processor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866183 --- Comment #6 from Brendan Jones brendan.jones...@gmail.com --- I'll have to disable python3-mididings for F17 and lower. There are now python3 boost bindings for 1.48.x in F17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866183] Review Request: python-mididings - A MIDI router and processor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866183 --- Comment #7 from Brendan Jones brendan.jones...@gmail.com --- (In reply to comment #6) I'll have to disable python3-mididings for F17 and lower. There are now python3 boost bindings for 1.48.x in F17 That should read *no* python3 boost bindings -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866183] Review Request: python-mididings - A MIDI router and processor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866183 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added Assignee|nob...@fedoraproject.org|volke...@gmx.at Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866183] Review Request: python-mididings - A MIDI router and processor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866183 --- Comment #4 from Brendan Jones brendan.jones...@gmail.com --- Can I interest anyone in a review swap to finsih this off? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866183] Review Request: python-mididings - A MIDI router and processor
https://bugzilla.redhat.com/show_bug.cgi?id=866183 Brendan Jones brendan.jones...@gmail.com changed: What|Removed |Added Depends On||867894 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866183] Review Request: python-mididings - A MIDI router and processor
https://bugzilla.redhat.com/show_bug.cgi?id=866183 Brendan Jones brendan.jones...@gmail.com changed: What|Removed |Added Summary|Review Request: mididings - |Review Request: |A MIDI router and processor |python-mididings - A MIDI ||router and processor --- Comment #2 from Brendan Jones brendan.jones...@gmail.com --- OK, I've investigated rebuilding python3, but am getting runtime errors. I have contated upstream. In any case I think I'll rename the package python-mididings. The following builds for both python2 and python3. NEWS included SRPM: http://bsjones.fedorapeople.org/python-mididings-20120419-1.fc18.src.rpm SPEC: http://bsjones.fedorapeople.org/python-mididings.spec I will enable smf once I package it. As for the tests, I'm not sure how to use them - will contact upstream. rpmlint output clean: python-mididings.x86_64: W: no-manual-page-for-binary mididings python-mididings.x86_64: W: no-manual-page-for-binary livedings python3-mididings.x86_64: W: no-manual-page-for-binary python3-mididings python3-mididings.x86_64: W: no-manual-page-for-binary python3-livedings -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866183] Review Request: python-mididings - A MIDI router and processor
https://bugzilla.redhat.com/show_bug.cgi?id=866183 --- Comment #3 from Brendan Jones brendan.jones...@gmail.com --- OK, mididings upstream have a patch for python-decorator 3.3.3 which has been submitted to the python-decorator author so I'll proceed with python3 support as per the SPEC above. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
