[Bug 866226] Review Request: kde-plasma-akonadi-contacts - Plasmoid for displaying contacts from Akonadi resources
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866226 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- kde-plasma-akonadi-contacts-0.1.7-2.fc16 has been pushed to the Fedora 16 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6Gplfg3dHVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866226] Review Request: kde-plasma-akonadi-contacts - Plasmoid for displaying contacts from Akonadi resources
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866226 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-12-20 11:26:23 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0SpPHmfAHHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866226] Review Request: kde-plasma-akonadi-contacts - Plasmoid for displaying contacts from Akonadi resources
https://bugzilla.redhat.com/show_bug.cgi?id=866226 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866226] Review Request: kde-plasma-akonadi-contacts - Plasmoid for displaying contacts from Akonadi resources
https://bugzilla.redhat.com/show_bug.cgi?id=866226 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- kde-plasma-akonadi-contacts-0.1.7-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/kde-plasma-akonadi-contacts-0.1.7-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866226] Review Request: kde-plasma-akonadi-contacts - Plasmoid for displaying contacts from Akonadi resources
https://bugzilla.redhat.com/show_bug.cgi?id=866226 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- kde-plasma-akonadi-contacts-0.1.7-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/kde-plasma-akonadi-contacts-0.1.7-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866226] Review Request: kde-plasma-akonadi-contacts - Plasmoid for displaying contacts from Akonadi resources
https://bugzilla.redhat.com/show_bug.cgi?id=866226 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- kde-plasma-akonadi-contacts-0.1.7-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/kde-plasma-akonadi-contacts-0.1.7-1.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866226] Review Request: kde-plasma-akonadi-contacts - Plasmoid for displaying contacts from Akonadi resources
https://bugzilla.redhat.com/show_bug.cgi?id=866226 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866226] Review Request: kde-plasma-akonadi-contacts - Plasmoid for displaying contacts from Akonadi resources
https://bugzilla.redhat.com/show_bug.cgi?id=866226 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- kde-plasma-akonadi-contacts-0.1.7-1.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866226] Review Request: kde-plasma-akonadi-contacts - Plasmoid for displaying contacts from Akonadi resources
https://bugzilla.redhat.com/show_bug.cgi?id=866226 Lukáš Tinkl lti...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||lti...@redhat.com Assignee|nob...@fedoraproject.org|lti...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866226] Review Request: kde-plasma-akonadi-contacts - Plasmoid for displaying contacts from Akonadi resources
https://bugzilla.redhat.com/show_bug.cgi?id=866226 Lukáš Tinkl lti...@redhat.com changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866226] Review Request: kde-plasma-akonadi-contacts - Plasmoid for displaying contacts from Akonadi resources
https://bugzilla.redhat.com/show_bug.cgi?id=866226 --- Comment #1 from Jan Grulich jgrul...@redhat.com --- New Package SCM Request === Package Name: kde-plasma-akonadi-contacts Short Description: This plasmoid shows contacts from selected Akonadi resources Owners: jgrulich Branches: f16 f17 f18 InitialCC: jgrulich -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866226] Review Request: kde-plasma-akonadi-contacts - Plasmoid for displaying contacts from Akonadi resources
https://bugzilla.redhat.com/show_bug.cgi?id=866226
--- Comment #2 from Lukáš Tinkl lti...@redhat.com ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
[!]: Package installs a %{name}.desktop using desktop-file-install if there is
such a file.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop
= MUST items =
C/C++:
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[ ]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[ ]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm 4.4
[ ]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[!]: Package installs a %{name}.desktop using desktop-file-install if there is
such a file.
[ ]: Development files must be in a -devel package
[ ]: Package requires other packages for directories it uses.
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[ ]: Large documentation files are in a -doc subpackage, if required.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v3 or later), Unknown or generated. 2 files have unknown
license. Detailed output of licensecheck in /home/ltinkl/tmp/kde-plasma-
akonadi-contacts/866226-kde-plasma-akonadi-contacts/licensecheck.txt
[ ]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Package must own all directories that it creates.
[ ]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[ ]: Package is not relocatable.
[ ]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[ ]: Useful -debuginfo package or justification otherwise.
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[ ]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[ ]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[ ]: Package functions as described.
[x]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[x]: The
[Bug 866226] Review Request: kde-plasma-akonadi-contacts - Plasmoid for displaying contacts from Akonadi resources
https://bugzilla.redhat.com/show_bug.cgi?id=866226 Lukáš Tinkl lti...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #3 from Lukáš Tinkl lti...@redhat.com --- Fedora review passed from my POV, see comment #1 for the SCM request -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866226] Review Request: kde-plasma-akonadi-contacts - Plasmoid for displaying contacts from Akonadi resources
https://bugzilla.redhat.com/show_bug.cgi?id=866226 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Jan Grulich jgrul...@redhat.com --- New Package SCM Request === Package Name: kde-plasma-akonadi-contacts Short Description: This plasmoid shows contacts from selected Akonadi resources Owners: jgrulich Branches: f16 f17 f18 InitialCC: jgrulich -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866226] Review Request: kde-plasma-akonadi-contacts - Plasmoid for displaying contacts from Akonadi resources
https://bugzilla.redhat.com/show_bug.cgi?id=866226 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866226] Review Request: kde-plasma-akonadi-contacts - Plasmoid for displaying contacts from Akonadi resources
https://bugzilla.redhat.com/show_bug.cgi?id=866226 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Summary|Review Request: |Review Request: |kde-plasma-akonadi-contacts |kde-plasma-akonadi-contacts |- Plasmoid for contacts |- Plasmoid for displaying |from Akonadi resources |contacts from Akonadi ||resources -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
