[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 Haïkel Guémar changed: What|Removed |Added CC||karlthe...@gmail.com Assignee|nob...@fedoraproject.org|karlthe...@gmail.com --- Comment #1 from Haïkel Guémar --- * you should set minimal version supported of BR when known (ie: CMake >= 2.6) * use make instead of cmake wrappers as recommended by CMake guidelines. In the case of build, it allows to enable/disable quickly parallel builds * you don't need to specify CMAKE_INSTALL_PREFIX and CMAKE_BUILD_TYPE (default is debug and it will be stripped afterwards). As for INSTALL_LIB, it has been replaced by the more usual INCLUDE_INSTALL_DIR in master. https://github.com/libgit2/libgit2/pull/823 You should request that upstream replaces INSTALL_INC by INCLUDE_INSTALL_DIR Note, that %cmake macro sets INCLUDE_INSTALL_DIR and LIB_INSTALL_DIR which are the standard de facto in CMake community. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 Veeti Paananen changed: What|Removed |Added CC||veeti.paana...@rojekti.fi --- Comment #2 from Veeti Paananen --- Hi, Thanks for the comments. Here's a revised spec: Spec: http://veetipaananen.fi/files/libgit2-2/libgit2.spec SRPM: http://veetipaananen.fi/files/libgit2-2/libgit2-0.17.0-2.fc17.src.rpm Changelog: * Fri Oct 19 2012 Veeti Paananen - 0.17.0-2 - Use make for building and installation - Specify minimum CMake version - Remove useless OpenSSL build dependency - Move development documentation to the -devel package - Add code examples to the -devel package Just false spelling errors in rpmlint. --- > * you should set minimal version supported of BR when known (ie: CMake >= 2.6) Done > * use make instead of cmake wrappers as recommended by CMake guidelines. Done > * you don't need to specify CMAKE_INSTALL_PREFIX and CMAKE_BUILD_TYPE > (default is debug and it will be stripped afterwards). Removed prefix since make and make install apparently works after all. Their CMakeLists forces -O0 if the build type is debug, so CMAKE_BUILD_TYPE is needed. > You should request that upstream replaces INSTALL_INC by INCLUDE_INSTALL_DIR I'll submit some patches to them to fix the path variables (and possibly the debug thing) later. They might not apply cleanly to 0.17.0 and the spec since their development branch is quite far ahead, though, so I think keeping INSTALL_LIB and INSTALL_INC for now is reasonable. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 --- Comment #3 from Haïkel Guémar --- There are few bundled libraries: Not a problem: * zlib, regex (in deps tree): only used if system's version are unavailable. Requiring either packaging dependencies or Fesco approval: * joyent/http_parser (in deps tree): few changes, but it's unclear (to me) if it can work with upstream version which is actively maintained (https://github.com/joyent/http-parser) => check with upstream if they support upstream version, you can get a temporary permission if it can be fixed in upcoming versions. * libxdiff (in src tree): unmaintained by libxdiff upstream since 2008, there are few bugfixes and libgit2 specific changes in history. I assume that upstream is willing to maintain it as part of libgit2, so i consider that as a legit bundled library. You should file a ticket to Fesco on these before approval as explained here: https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 --- Comment #4 from Veeti Paananen --- Hi, Sorry for the late response. The libxdiff bundling seems to be somewhat complicated because the libgit2 developers tell me [1] that their copy of xdiff comes from git's source code [2] and not from libxdiff. Fedora's git package doesn't seem to have any exception for this "bundling". How do I proceed from here? I've written a patch to use to the system's instance of http-parser and I'll post an updated spec once this is clear. [1] https://github.com/libgit2/libgit2/pull/1005 [2] https://github.com/git/git/tree/master/xdiff -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 Veeti Paananen changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #29 from Veeti Paananen --- Package Change Request == Package Name: libgit2 New Branches: el5 el6 Owners: vpaan -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 --- Comment #30 from Kevin Fenzi --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 Kevin Fenzi changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 --- Comment #12 from Veeti Paananen --- Another update to that removes now unnecessary flags from the %cmake macro and fixes the pkgconfig file. Spec: http://veetipaananen.fi/files/libgit2/4/libgit2.spec SRPM: http://veetipaananen.fi/files/libgit2/4/libgit2-0.18.0-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=diMXF8SljW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 Tom "spot" Callaway changed: What|Removed |Added CC||tcall...@redhat.com Depends On||969111 --- Comment #13 from Tom "spot" Callaway --- Okay. I've made a merged libxdiff that libgit2 and git can both use. Here is a patch for libgit2 0.18.0 to use it: http://spot.fedorapeople.org/libgit2-0.18.0-system-libxdiff.patch Here is an updated spec that uses it (and nukes src/xdiff): http://spot.fedorapeople.org/libgit2.spec libxdiff is waiting for review here: https://bugzilla.redhat.com/show_bug.cgi?id=969111 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CTl7iQHOld&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 --- Comment #14 from Veeti Paananen --- Thanks so much! I guess this is ready for review now. I recall trying to do a scratch build with Koji a while back and having it fail on the test suite because there's no internet connection, so I've disabled the online tests in this new spec: Spec: http://veetipaananen.fi/files/libgit2/5/libgit2.spec SRPM: http://veetipaananen.fi/files/libgit2/5/libgit2-0.18.0-4.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fTqU4BWjI0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 --- Comment #15 from Haïkel Guémar --- Great news, there should be no more blockers for this review. :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4V2WlR4ohd&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959
Haïkel Guémar changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #16 from Haïkel Guémar ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[-]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: Using prebuilt rpms.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"MIT/X11 (BSD like)", "Apache (v2.0)", "Unknown or generated", "BSD (2
clause)". 463 files have unknown license. Detailed output of licensecheck
in /home/haikel/867959-libgit2/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Large documentation must go in a -doc subpackage.
[x]: Packages must not store files under /srv, /opt or /usr/local
Note: Cannot unpack rpms (using --prebuilt?)
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
Note: Re-using old build in mock
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq,
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 Veeti Paananen changed: What|Removed |Added Flags||fedora-cvs? --- Comment #17 from Veeti Paananen --- New Package SCM Request === Package Name: libgit2 Short Description: A C implementation of the Git core methods as a library Owners: vpaan Branches: f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5tfk84Howg&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VyiUd7G54u&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 --- Comment #18 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mu3EG8TFTY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 --- Comment #19 from Kalev Lember --- Can you import and build it, please? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ktaEiecVhE&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 --- Comment #20 from Ignacio Casal Quinteiro (nacho) --- fyi in a few days they will release 0.19.0 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gr1bjLy71d&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 --- Comment #21 from Veeti Paananen --- Yes, sorry, I've been waiting for 0.19.0. I'll import and build if it doesn't come out in the next few days. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RmvAfRjETH&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 Kalev Lember changed: What|Removed |Added Blocks||974834 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=V946EK7XbP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 Bug 867959 depends on bug 969111, which changed state. Bug 969111 Summary: Review Request: libxdiff - Basic functionality to create difference/patches in binary and text https://bugzilla.redhat.com/show_bug.cgi?id=969111 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ayJiAPqNZ9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CyC5tLJoV0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 --- Comment #22 from Fedora Update System --- libgit2-0.18.0-4.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/libgit2-0.18.0-4.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MozDSkDwNW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #23 from Fedora Update System --- libgit2-0.18.0-4.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=owK5OxF0re&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 --- Comment #24 from Fedora Update System --- libgit2-0.18.0-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libgit2-0.18.0-4.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jFkgF75KlC&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 --- Comment #25 from Fedora Update System --- libgit2-0.18.0-5.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/libgit2-0.18.0-5.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UvKdJFchQd&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 --- Comment #26 from Fedora Update System --- libgit2-0.18.0-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libgit2-0.18.0-5.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rt8dqqAJPv&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||libgit2-0.18.0-5.fc19 Resolution|--- |ERRATA Last Closed||2013-06-29 14:32:50 --- Comment #27 from Fedora Update System --- libgit2-0.18.0-5.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1ireCxhErJ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 Fedora Update System changed: What|Removed |Added Fixed In Version|libgit2-0.18.0-5.fc19 |libgit2-0.18.0-5.fc18 --- Comment #28 from Fedora Update System --- libgit2-0.18.0-5.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mUcFMBTg88&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=867959 Ignacio Casal Quinteiro (nacho) changed: What|Removed |Added CC||i...@gnome.org --- Comment #5 from Ignacio Casal Quinteiro (nacho) --- This review will block in a near future the one for libgit2-glib. http://git.gnome.org/browse/libgit2-glib -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YnK3N9RciB&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=867959 --- Comment #6 from Ken Dreyer --- adding myself to CC (I'll need this for Gitorious) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4vc8WU8zdZ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=867959 Troy Dawson changed: What|Removed |Added CC||tdaw...@redhat.com --- Comment #7 from Troy Dawson --- *** Bug 927310 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L9aa5gwnhv&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=867959 --- Comment #8 from Ignacio Casal Quinteiro (nacho) --- Any news on this? 0.18.0 has been released already -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OXiNjLzirz&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=867959 --- Comment #9 from Haïkel Guémar --- i'll finish the review as soon as the bundled libraries issues will be fixed (upstreamed patch or bundling exceptions etc...) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NejmeGj9nE&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=867959 Toshio Ernie Kuratomi changed: What|Removed |Added CC||a.bad...@gmail.com --- Comment #10 from Toshio Ernie Kuratomi --- /me notes that the urls for srpm and spec file are currently 404. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fSq9N3Wssu&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=867959 --- Comment #11 from Veeti Paananen --- Sorry about that. I've updated the package for 0.18.0 and added a patch to fix the http-parser bundling. Spec: http://veetipaananen.fi/files/libgit2/3/libgit2.spec SRPM: http://veetipaananen.fi/files/libgit2/3/libgit2-0.18.0-1.fc18.src.rpm Now only the xdiff mess needs to be sorted out. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vEfXY6WNgu&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
