[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266
--- Comment #45 from Petr Viktorin pvikt...@redhat.com ---
%py_byte_compile compiles the sources to bytecode.
It's a macro from python3-devel, so it won't be on EL7, but it's given in
Fedora package guidelines
(https://fedoraproject.org/wiki/Packaging:Python#Macros)
You can use code like this:
%if 0%{?with_python3}
%py_byte_compile %{__python2} %{buildroot}%{python_sitelib}/%{srcname}
%else
# py_byte_compile is only defined in python3-devel
%{__python2} -m compileall %{buildroot}%{python_sitelib}/%{srcname}
%endif
--
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266
--- Comment #46 from Miro Hrončok mhron...@redhat.com ---
You don't need to call %py_byte_compile on things in %{python_sitelib} or
%{python3_sitelib}.
See
https://fedoraproject.org/wiki/Packaging:Python#Bytecompiling_with_the_correct_python_version
for reference.
--
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #47 from Orion Poplawski or...@cora.nwra.com --- Package Change Request == Package Name: python-pyglet New Branches: epel7 Owners: pviktori orion InitialCC: -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #50 from Orion Poplawski or...@cora.nwra.com --- Petr - I'll push my changes to the EPEL7 branch first. Should be fine to push to Fedora, but I'll let you do that. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #49 from Petr Viktorin pvikt...@redhat.com --- Thanks Jon! And thanks Orion for your work! I gave you commit access to all branches, but I'd like to test the change before pushing to Fedora if you don't mind. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #48 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266
--- Comment #44 from Orion Poplawski or...@cora.nwra.com ---
I'd be happy to comaintain. FAS - orion
Why the use of %py_byte_compile? I've never seen that in a package before.
Macro doesn't seem to exist on EL7.
So, with:
diff --git a/python-pyglet.spec b/python-pyglet.spec
index b08a2c4..ede83af 100644
--- a/python-pyglet.spec
+++ b/python-pyglet.spec
@@ -1,4 +1,6 @@
+%if 0%{?fedora}
%global with_python3 1
+%endif
%global srcname pyglet
%global srcversion 1.2.1
@@ -102,12 +104,12 @@ popd
%install
%{__python} setup.py install --skip-build --root %{buildroot}
-%py_byte_compile %{__python} %{buildroot}%{python_sitelib}/%{srcname}
+%{__python} %{buildroot}%{python_sitelib}/%{srcname}
%if 0%{?with_python3}
pushd %{py3dir}
%{__python3} setup.py install --skip-build --root %{buildroot}
-%py_byte_compile %{__python3} %{buildroot}%{python3_sitelib}/%{srcname}
+%{__python3} %{buildroot}%{python3_sitelib}/%{srcname}
popd
%endif
I end up with:
+ /usr/bin/python
/builddir/build/BUILDROOT/python-pyglet-1.2.1-1.el7.x86_64/usr/lib/python2.7/site-packages/pyglet
/usr/bin/python: can't find '__main__' module in
'/builddir/build/BUILDROOT/python-pyglet-1.2.1-1.el7.x86_64/usr/lib/python2.7/site-packages/pyglet'
Perhaps the %py_byte_compile was supposed to set that up?
--
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #43 from Petr Viktorin pvikt...@redhat.com --- Well, I wouldn't mind a co-maintainer :) But, all that'll be needed is to make with_python3 conditional, and some testing. When I have a bit of time I'll go spin up an EL7 machine and do it. If anyone wants to help: build the package, and run events graphics from [0] with it installed. That should test it enough. https://bitbucket.org/pyglet/pyglet/src/cd6753287628056278d566b1cc556a41c66cf1b5/examples/?at=default -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added CC||or...@cora.nwra.com --- Comment #42 from Orion Poplawski or...@cora.nwra.com --- We need this in EPEL7 for sympy. Petr - would you be willing to maintain it there? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | See Also||https://bugzilla.redhat.com ||/show_bug.cgi?id=1015699 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #41 from Petr Viktorin pvikt...@redhat.com --- I've tested on f18 and checked that PNG images are loaded fine. On a typical desktop, the GDKPixbuf2ImageDecoder will probably get selected, but the PILImageDecoder also works. It uses python-imaging (PIL), which got replaced by python-pillow in f19. The Pyglet package does depend on python-imaging in f18. The PNG decoder is missing, as expected. If python-sympy really needs the PNG decoder and can't use another one that loads PNGs, then I'm sorry -- I'm not putting the bundled fork of pypng back. The right way would be to fix Pyglet to use upstream pypng, and package pypng for Fedora (https://bugzilla.redhat.com/show_bug.cgi?id=810376). Unfortunately I don't have resources to do that any time soon. Please open a new bug, e-mail me privately, for any further discussion. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NB3nKxYOP2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #40 from Petr Viktorin pvikt...@redhat.com --- Sorry for the late response, I was on vacation last week. Looks like I didn't test enough on f18. The fix should be easy (use python-imaging instead of Pillow on f18) but testing it will take longer. I'll open a new bug if you don't beat me to it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2DU8uxn0tTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 Andrej adund...@gmail.com changed: What|Removed |Added CC||adund...@gmail.com --- Comment #37 from Andrej adund...@gmail.com --- There is a problem with F18 package of python-pyglet[*]: Python-sympy needs png decoder in python-pyglest which is removed according to python-pyglest specs: (...) # Remove the bundled pypng library python-pillow provides the same functionality) rm pyglet/image/codecs/png.py rm pyglet/image/codecs/pypng.py (...) but python-pillow is never submitted in Fedora 18 repos, so png decoder doesn't work in F18 version of pyglet. Tnx. [*] I don't know if this is a good place to put it or should I open a new bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xLEOPBYWMIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||cicku...@gmail.com --- Comment #38 from Christopher Meng cicku...@gmail.com --- It's closed, you'd better create a new bug. IMO this package shouldn't have this branch if things are really being as you've said. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UKalYKAm5aa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #39 from Andrej adund...@gmail.com --- Tnx Christopher for a really fast response. I'll still wait for Petr's answer before I open a new bug because he is a primary maintainter so he will probably need to fix it. In the context of facts that in few months F18 will be EOL so this bug would be obsolete and this troublesome feature of SymPy is rearly used, I don't think I should open a new bug report only for the sake of formality. Let it be here only for a record but you guys can freely decide otherwise :-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=03BMvYoJVEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|python-pyglet-1.2-0.5.alpha |python-pyglet-1.2-0.5.alpha |1.fc18 |1.fc19 --- Comment #36 from Fedora Update System upda...@fedoraproject.org --- python-pyglet-1.2-0.5.alpha1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aYBtfclpO0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-pyglet-1.2-0.5.alpha ||1.fc18 Resolution|--- |ERRATA Last Closed||2013-06-26 22:10:09 --- Comment #35 from Fedora Update System upda...@fedoraproject.org --- python-pyglet-1.2-0.5.alpha1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OmM4Ukul7Ba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #30 from Fedora Update System upda...@fedoraproject.org --- python-pyglet-1.2-0.5.alpha1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-pyglet-1.2-0.5.alpha1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jZOVcpRKe0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #31 from Fedora Update System upda...@fedoraproject.org --- python-pyglet-1.2-0.5.alpha1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-pyglet-1.2-0.5.alpha1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5JUOYKNwhKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #32 from Fedora Update System upda...@fedoraproject.org --- python-pyglet-1.2-0.5.alpha1.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZYMB5KBNaDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #33 from Fedora Update System upda...@fedoraproject.org --- printrun-0.0-24.20130123git71e5da0.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qB7CIGN2E2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #34 from Fedora Update System upda...@fedoraproject.org --- printrun-0.0-24.20130123git71e5da0.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=43bY2iNHDGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #29 from Fedora Update System upda...@fedoraproject.org --- printrun-0.0-24.20130123git71e5da0.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wa4wYR1Qdsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 Petr Viktorin pvikt...@redhat.com changed: What|Removed |Added Summary|Review Request: pyglet - A |Review Request: |cross-platform windowing|python-pyglet - A |and multimedia library for |cross-platform windowing |Python |and multimedia library for ||Python -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1EWb6X9MNka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 Petr Viktorin pvikt...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #27 from Petr Viktorin pvikt...@redhat.com --- New Package SCM Request === Package Name: python-pyglet Short Description: A cross-platform windowing and multimedia library for Python Owners: pviktori Branches: f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CDMEvs2p2Da=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #28 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XJJSESAaHZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pIUC9h4LqPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
