[Bug 870323] Review Request: glogg - Smart interactive log explorer
https://bugzilla.redhat.com/show_bug.cgi?id=870323 --- Comment #15 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870323] Review Request: glogg - Smart interactive log explorer
https://bugzilla.redhat.com/show_bug.cgi?id=870323 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870323] Review Request: glogg - Smart interactive log explorer
https://bugzilla.redhat.com/show_bug.cgi?id=870323 Damian Wrobel changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #14 from Damian Wrobel --- Package Change Request == Package Name: glogg New Branches: el6 epel7 Owners: dwrobel -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870323] Review Request: glogg - Smart interactive log explorer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=870323 --- Comment #13 from Fedora Update System --- glogg-0.8.3-4.fc16 has been pushed to the Fedora 16 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OycFAirzng&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870323] Review Request: glogg - Smart interactive log explorer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=870323 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-12-09 00:57:31 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NSuvm37hjQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870323] Review Request: glogg - Smart interactive log explorer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=870323 --- Comment #12 from Fedora Update System --- glogg-0.8.3-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/glogg-0.8.3-4.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870323] Review Request: glogg - Smart interactive log explorer
https://bugzilla.redhat.com/show_bug.cgi?id=870323 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870323] Review Request: glogg - Smart interactive log explorer
https://bugzilla.redhat.com/show_bug.cgi?id=870323 --- Comment #11 from Fedora Update System --- glogg-0.8.3-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870323] Review Request: glogg - Smart interactive log explorer
https://bugzilla.redhat.com/show_bug.cgi?id=870323 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870323] Review Request: glogg - Smart interactive log explorer
https://bugzilla.redhat.com/show_bug.cgi?id=870323 --- Comment #10 from Fedora Update System --- glogg-0.8.3-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/glogg-0.8.3-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870323] Review Request: glogg - Smart interactive log explorer
https://bugzilla.redhat.com/show_bug.cgi?id=870323 --- Comment #9 from Fedora Update System --- glogg-0.8.3-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/glogg-0.8.3-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870323] Review Request: glogg - Smart interactive log explorer
https://bugzilla.redhat.com/show_bug.cgi?id=870323 --- Comment #8 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870323] Review Request: glogg - Smart interactive log explorer
https://bugzilla.redhat.com/show_bug.cgi?id=870323 Damian Wrobel changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Damian Wrobel --- New Package SCM Request === Package Name: glogg Short Description: Smart interactive log explorer Owners: dwrobel Branches: f16 f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870323] Review Request: glogg - Smart interactive log explorer
https://bugzilla.redhat.com/show_bug.cgi?id=870323 --- Comment #6 from Damian Wrobel --- (In reply to comment #5) > Please package the newest version 0.9.0! That was my initial approach. However the 0.9 is marked as a first version on the development branch towards 1.0. I even gave it a try, but the gcc reported some warnings like: warning: no return statement in function returning non-void additionally while running under valgrind it reports some uninitialized variables. Based on that I would prefer to stick to the latest stable version 0.8.3 for a while and switch to 1.0 once available. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870323] Review Request: glogg - Smart interactive log explorer
https://bugzilla.redhat.com/show_bug.cgi?id=870323 Volker Fröhlich changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #5 from Volker Fröhlich --- Please package the newest version 0.9.0! The changelog version doesn't match the actual version, please correct! ==APPROVED== Package Review == Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated = MUST items = C/C++: [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package contains no bundled libraries. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [-]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package complies to the Packaging Guidelines [x]: Spec file lacks Packager, Vendor, PreReq tags. [-]: Large documentation files are in a -doc subpackage, if required. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)", "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /media/speicher1/makerpm/rpmbuild/SPECS/870323-glogg/licensecheck.txt Helper scripts for release, test and performance testing scripts [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named using only allowed ASCII characters. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: Package do not use a name that already exist [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package installs properly. [x]: Package is not relocatable. [-]: Requires correct, justified where necessary. [x]: CheckResultdir [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file is legible and written in American English. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [x]: Useful -debuginfo package or justification otherwise. = SHOULD items = Generic: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: Package functions as described. [x]: Latest version is packaged. 0.9.0 is out [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstrea
[Bug 870323] Review Request: glogg - Smart interactive log explorer
https://bugzilla.redhat.com/show_bug.cgi?id=870323 Volker Fröhlich changed: What|Removed |Added Assignee|nob...@fedoraproject.org|volke...@gmx.at -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870323] Review Request: glogg - Smart interactive log explorer
https://bugzilla.redhat.com/show_bug.cgi?id=870323 --- Comment #4 from Damian Wrobel --- Everything else has been corrected. Please find updated files. Spec URL: http://dwrobel.fedorapeople.org/projects/rpmbuild/SPECS/glogg.spec SRPM URL: http://dwrobel.fedorapeople.org/projects/rpmbuild/SRPMS/glogg-0.8.3-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870323] Review Request: glogg - Smart interactive log explorer
https://bugzilla.redhat.com/show_bug.cgi?id=870323 --- Comment #3 from Volker Fröhlich --- You're right! qmake is responsible for the hidden directory. And as you pointed out, that is common. I don't know of a concrete policy, but it could be a useful addition to https://fedoraproject.org/wiki/Common_Rpmlint_issues. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870323] Review Request: glogg - Smart interactive log explorer
https://bugzilla.redhat.com/show_bug.cgi?id=870323 --- Comment #2 from Damian Wrobel --- (In reply to comment #1) Volker, Thank you for taking the review. > glogg-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/glogg-0.8.3/.moc > glogg-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/glogg-0.8.3/.moc > > Please delete! If those are included it means that the /usr/lib/debug/usr/bin/glogg.debug has references to those files and they are necessary to debug this application. The only thing I could do is to try to change the .moc -> moc by using: sed -i 's#\(^release:MOC_DIR.*\)\(\.moc\)\(.*\)#\1moc\3#g' %{name}.pro But I'm not sure if it's really necessary as it seems to be the common case: $ yum --enablerepo=\*-debuginfo provides '*/.moc/*' | wc -l 10645 BTW do we have any clear policy how to tackle it or it's only yet another rpmlint false positive? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870323] Review Request: glogg - Smart interactive log explorer
https://bugzilla.redhat.com/show_bug.cgi?id=870323 Volker Fröhlich changed: What|Removed |Added CC||volke...@gmx.at Flags||fedora-review? --- Comment #1 from Volker Fröhlich --- Please remove the qt-devel version constraint. Every version of Fedora fulfils the need. From what I see, you don't need pkgconfig. You need scriptlets, when you put files in %{_datadir}/icons/hicolor: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache glogg-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/glogg-0.8.3/.moc glogg-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/glogg-0.8.3/.moc Please delete! (You can remove the trailing slash on URL.) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review