[Bug 870719] Review Request: horst - A highly optimized radio scanning tool
https://bugzilla.redhat.com/show_bug.cgi?id=870719 Fabian Affolter changed: What|Removed |Added Blocks||563471 (FE-SECLAB) Alias||horst -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870719] Review Request: horst - A highly optimized radio scanning tool
https://bugzilla.redhat.com/show_bug.cgi?id=870719
Mario Blättermann changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||mario.blaetterm...@gmail.co
||m
Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
||m
Flags||fedora-review+
--- Comment #1 from Mario Blättermann ---
$ rpmlint -i -v *
horst.src: I: checking
horst.src: W: spelling-error %description -l en_US hoc -> ho, choc, hock
The value of this tag appears to be misspelled. Please double-check.
horst.src: W: spelling-error %description -l en_US neighbourhood ->
neighborhood, neighborliness
The value of this tag appears to be misspelled. Please double-check.
horst.src: I: checking-url http://br1.einfach.org/tech/horst/ (timeout 10
seconds)
horst.src: I: checking-url http://br1.einfach.org/horst_dl/horst-3.0.tar.gz
(timeout 10 seconds)
horst.i686: I: checking
horst.i686: W: spelling-error %description -l en_US hoc -> ho, choc, hock
The value of this tag appears to be misspelled. Please double-check.
horst.i686: W: spelling-error %description -l en_US neighbourhood ->
neighborhood, neighborliness
The value of this tag appears to be misspelled. Please double-check.
horst.i686: I: checking-url http://br1.einfach.org/tech/horst/ (timeout 10
seconds)
horst.i686: W: no-manual-page-for-binary horst
Each executable in standard binary directories should have a man page.
horst.x86_64: I: checking
horst.x86_64: W: spelling-error %description -l en_US hoc -> ho, choc, hock
The value of this tag appears to be misspelled. Please double-check.
horst.x86_64: W: spelling-error %description -l en_US neighbourhood ->
neighborhood, neighborliness
The value of this tag appears to be misspelled. Please double-check.
horst.x86_64: I: checking-url http://br1.einfach.org/tech/horst/ (timeout 10
seconds)
horst.x86_64: W: no-manual-page-for-binary horst
Each executable in standard binary directories should have a man page.
horst-debuginfo.i686: I: checking
horst-debuginfo.i686: I: checking-url http://br1.einfach.org/tech/horst/
(timeout 10 seconds)
horst-debuginfo.x86_64: I: checking
horst-debuginfo.x86_64: I: checking-url http://br1.einfach.org/tech/horst/
(timeout 10 seconds)
horst.spec: I: checking-url http://br1.einfach.org/horst_dl/horst-3.0.tar.gz
(timeout 10 seconds)
5 packages and 1 specfiles checked; 0 errors, 8 warnings.
Just one issue: "neighbourhood" is British English. But doesn't matter, it
isn't worth to change it actually.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
GPLv2+
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
7d8de85ff8715f3bea7ccecc0382e2d3c48bccce4be6dee5f1d0d15447776cc8
horst-3.0.tar.gz
7d8de85ff8715f3bea7ccecc0382e2d3c48bccce4be6dee5f1d0d15447776cc8
horst-3.0.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the
[Bug 870719] Review Request: horst - A highly optimized radio scanning tool
https://bugzilla.redhat.com/show_bug.cgi?id=870719 --- Comment #2 from Fabian Affolter --- Thanks for the review, Mario. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870719] Review Request: horst - A highly optimized radio scanning tool
https://bugzilla.redhat.com/show_bug.cgi?id=870719 Fabian Affolter changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Fabian Affolter --- New Package SCM Request === Package Name: horst Short Description: A highly optimized radio scanning tool Owners: fab Branches: f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870719] Review Request: horst - A highly optimized radio scanning tool
https://bugzilla.redhat.com/show_bug.cgi?id=870719 --- Comment #4 from Kevin Fenzi --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870719] Review Request: horst - A highly optimized radio scanning tool
https://bugzilla.redhat.com/show_bug.cgi?id=870719 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870719] Review Request: horst - A highly optimized radio scanning tool
https://bugzilla.redhat.com/show_bug.cgi?id=870719 --- Comment #6 from Fedora Update System --- horst-3.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/horst-3.0-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870719] Review Request: horst - A highly optimized radio scanning tool
https://bugzilla.redhat.com/show_bug.cgi?id=870719 --- Comment #5 from Fedora Update System --- horst-3.0-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/horst-3.0-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870719] Review Request: horst - A highly optimized radio scanning tool
https://bugzilla.redhat.com/show_bug.cgi?id=870719 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870719] Review Request: horst - A highly optimized radio scanning tool
https://bugzilla.redhat.com/show_bug.cgi?id=870719 --- Comment #7 from Fedora Update System --- horst-3.0-1.fc17 has been pushed to the Fedora 17 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870719] Review Request: horst - A highly optimized radio scanning tool
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=870719 Fabian Affolter changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE Last Closed||2012-12-02 11:16:31 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
