[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=870860 --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- opencsg-1.3.2-6.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=870860 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-11-27 00:33:01 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=870860 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- opencsg-1.3.2-6.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=870860 --- Comment #17 from Miro Hrončok m...@hroncok.cz --- Thanks, I see no information about pushng a package from testing to stable on that page (but it is a long page, so i might be wrong). I see this note here: https://fedoraproject.org/wiki/Package_update_HOWTO?rd=PackageMaintainers/UpdatingPackageHowTo#Submit_your_update_to_Bodhi If your update does not receive enough feedback to automatically push it to stable, you will have to submit it as a final update yourself. This can easily be done with the command-line tool, or with the web interface. There is a link in the top right corner (on an update page when logged in) saying Mark as Stable - but it took me a while to find that one. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=870860 --- Comment #18 from Mario Blättermann mario.blaetterm...@gmail.com --- (In reply to comment #17) There is a link in the top right corner (on an update page when logged in) saying Mark as Stable - but it took me a while to find that one. I do it always the same way. Well, you could use the command line interface of Bodhi, but in my mind, the web interface is somewhat easier, and you get a clear overview over your packages. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=870860 --- Comment #15 from Miro Hrončok m...@hroncok.cz --- Mario, could you help me with this? This update has reached 3 days in testing and can be pushed to stable now if the maintainer wishes How do i trigger such a puch? A link to a correct document about this would be great, no need to explain it here. Thanks -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=870860 --- Comment #16 from Eric Smith e...@brouhaha.com --- Isn't this documented in the Join the package collection maintainers page on the wiki? In short, log into the Fedora Update System: https://admin.fedoraproject.org/updates/ Use the Login link near the top left, then the My Updates (n) link below that. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=870860 Miro Hrončok m...@hroncok.cz changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Miro Hrončok m...@hroncok.cz --- New Package SCM Request === Package Name: opencsg Short Description: Library for Constructive Solid Geometry using OpenGL Owners: churchyard mariobl Branches: f17 f18 InitialCC: gregjurman -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=870860 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=870860 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=870860 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- opencsg-1.3.2-6.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/opencsg-1.3.2-6.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=870860 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- opencsg-1.3.2-6.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/opencsg-1.3.2-6.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=870860 --- Comment #12 from Miro Hrončok m...@hroncok.cz --- Thanks for sponsoring me and for the review. As this is my first package, I tryed to do everything as described in the documentation, but I'm lost here. https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers/Join#Submit_Package_as_Update_in_Bodhi This page says: Do not submit master (aka rawhide) packages via bodhi. So I did not. I can see f17 and f18 packages here: https://admin.fedoraproject.org/updates/opencsg-1.3.2-6.fc17 https://admin.fedoraproject.org/updates/opencsg-1.3.2-6.fc18 But what about rawhide package? Is it already in the repository? Or how does it work? Thanks -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=870860 --- Comment #13 from Mario Blättermann mario.blaetterm...@gmail.com --- (In reply to comment #12) Thanks for sponsoring me and for the review. As this is my first package, I tryed to do everything as described in the documentation, but I'm lost here. https://fedoraproject.org/wiki/ Join_the_package_collection_maintainers?rd=PackageMaintainers/ Join#Submit_Package_as_Update_in_Bodhi This page says: Do not submit master (aka rawhide) packages via bodhi. So I did not. I can see f17 and f18 packages here: https://admin.fedoraproject.org/updates/opencsg-1.3.2-6.fc17 https://admin.fedoraproject.org/updates/opencsg-1.3.2-6.fc18 But what about rawhide package? Is it already in the repository? Or how does it work? Indeed, you have to build it only. Such builds for Rawhide are automatically picked up, you don't have to submit them explicitely. But make sure to build them anyway. This way we get it quickly into the BuildRoot on Koji. For other branches, you have to request BuildRoot Overrides if there are other packages waiting for a review which depend on it. In any case, welcome in the package maintainers group! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=870860 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- opencsg-1.3.2-6.fc17 has been pushed to the Fedora 17 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=870860 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=870860
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #7 from Mario Blättermann mario.blaetterm...@gmail.com ---
(In reply to comment #6)
What about 'dos2unix license.txt' - is it OK?
This is OK. This way the text won't be changed, it affects the line endings
only, but doesn't touch the contents.
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4699261
$ rpmlint -i -v *
opencsg.src: I: checking
opencsg.src: I: checking-url http://www.opencsg.org/ (timeout 10 seconds)
opencsg.src: I: checking-url http://www.opencsg.org/OpenCSG-1.3.2.tar.gz
(timeout 10 seconds)
opencsg.i686: I: checking
opencsg.i686: I: checking-url http://www.opencsg.org/ (timeout 10 seconds)
opencsg.i686: E: incorrect-fsf-address /usr/share/doc/opencsg-1.3.2/license.txt
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
opencsg.x86_64: I: checking
opencsg.x86_64: I: checking-url http://www.opencsg.org/ (timeout 10 seconds)
opencsg.x86_64: E: incorrect-fsf-address
/usr/share/doc/opencsg-1.3.2/license.txt
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
opencsg-debuginfo.i686: I: checking
opencsg-debuginfo.i686: I: checking-url http://www.opencsg.org/ (timeout 10
seconds)
opencsg-debuginfo.x86_64: I: checking
opencsg-debuginfo.x86_64: I: checking-url http://www.opencsg.org/ (timeout 10
seconds)
opencsg-devel.i686: I: checking
opencsg-devel.i686: I: checking-url http://www.opencsg.org/ (timeout 10
seconds)
opencsg-devel.i686: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
opencsg-devel.x86_64: I: checking
opencsg-devel.x86_64: I: checking-url http://www.opencsg.org/ (timeout 10
seconds)
opencsg-devel.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
opencsg.spec: I: checking-url http://www.opencsg.org/OpenCSG-1.3.2.tar.gz
(timeout 10 seconds)
7 packages and 1 specfiles checked; 2 errors, 2 warnings.
No recognizable issues.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
GPLv2 with exceptions
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
c790c92998f7113cb35cde825f81c5532755908a0a3f43c3c3c8df2326b3b925
OpenCSG-1.3.2.tar.gz
c790c92998f7113cb35cde825f81c5532755908a0a3f43c3c3c8df2326b3b925
OpenCSG-1.3.2.tar.gz.packaged
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=870860 --- Comment #6 from Miro Hrončok m...@hroncok.cz --- Spec URL: https://raw.github.com/hroncok/SPECS/master/opencsg.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/opencsg-1.3.2-6.fc17.src.rpm - Removed FSF Address path - using sed instead, so the path is not needed to update in newer version - don't modify license file - License exception explained in a comment - Dropped doc form devel package - Usiyng cp -pP instead of mv to preserve timestamps Contacted the upstream about the FSF address issue. What about 'dos2unix license.txt' - is it OK? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=870860
--- Comment #5 from Mario Blättermann mario.blaetterm...@gmail.com ---
PLease don't bother with false positive rpmlint warnings and drop the docs from
the -devel package. All the files are present anyway due to the main package.
Patch1 is actually not needed, you have just to inform the upstream folks about
the wrong FSF address. However, if you want to patch the source files, don't
patch license.txt. It's somewhat critical to touch license texts, I would
discourage you to do so, and it is not allowed by the guidelines anyway:
https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
mv lib/* %{buildroot}/%{_libdir}/
doesn't keep the timestamps, why not use cp -p or even install -D instead?
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=870860 --- Comment #4 from Miro Hrončok m...@hroncok.cz --- Spec URL: https://raw.github.com/hroncok/SPECS/master/opencsg.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/opencsg-1.3.2-5.fc17.src.rpm - Nothing has changed, I've just moved SRPM and SPEC to a new location -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=870860 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added CC||gdj2...@rit.edu, ||loganje...@gmail.com, ||volke...@gmx.at Blocks|177841 (FE-NEEDSPONSOR) | Alias||opencsg -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=870860 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co ||m Flags||fedora-review? --- Comment #2 from Mario Blättermann mario.blaetterm...@gmail.com --- Lifting FE-NEEDSPONSOR, I will sponsor Miro. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=870860 --- Comment #3 from Mario Blättermann mario.blaetterm...@gmail.com --- *** Bug 825489 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=870860 Miro Hrončok m...@hroncok.cz changed: What|Removed |Added Clone Of|864187 |825489 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=870860 --- Comment #1 from Miro Hrončok m...@hroncok.cz --- I am sorry, I've sended it before editation, here are correct links: Spec URL: https://raw.github.com/hroncok/opencsg-spec/master/opencsg.spec SRPM URL: https://github.com/hroncok/opencsg-spec/raw/master/opencsg-1.3.2-5.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=870860 Miro Hrončok m...@hroncok.cz changed: What|Removed |Added Blocks||864187 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=870860 Miro Hrončok m...@hroncok.cz changed: What|Removed |Added Blocks|864187 |177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=870860 Miro Hrončok m...@hroncok.cz changed: What|Removed |Added Clone Of||864187 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870860] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=870860 Miro Hrončok m...@hroncok.cz changed: What|Removed |Added Blocks||864187 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
