[Bug 871021] Review Request: glassfish-ha-api - High Availability APIs and SPI
https://bugzilla.redhat.com/show_bug.cgi?id=871021 gil cattaneo changed: What|Removed |Added Depends On||871018 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871021] Review Request: glassfish-ha-api - High Availability APIs and SPI
https://bugzilla.redhat.com/show_bug.cgi?id=871021 gil cattaneo changed: What|Removed |Added Blocks||870977 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871021] Review Request: glassfish-ha-api - High Availability APIs and SPI
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871021 --- Comment #1 from gil cattaneo --- Spec URL: http://gil.fedorapeople.org/glassfish-ha-api.spec SRPM URL: http://gil.fedorapeople.org/glassfish-ha-api-3.1.9-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EZaxAwyP75&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871021] Review Request: glassfish-ha-api - High Availability APIs and SPI
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871021 Michal Srb changed: What|Removed |Added Status|NEW |ASSIGNED CC||m...@redhat.com Assignee|nob...@fedoraproject.org|m...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EU0fGq2Qdl&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871021] Review Request: glassfish-ha-api - High Availability APIs and SPI
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=871021
Michal Srb changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #2 from Michal Srb ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Large documentation must go in a -doc subpackage.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
Java:
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It is
pulled in by maven-local
[x]: Fully versioned dependency in subpackages, if present.
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
[x]: Bundled jar/class files should be removed before build
Maven:
[x]: Pom files have correct Maven mapping
[x]: If package contains pom.xml files install it (including depmaps) even
when building with ant
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL
[Bug 871021] Review Request: glassfish-ha-api - High Availability APIs and SPI
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871021 gil cattaneo changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from gil cattaneo --- New Package SCM Request === Package Name: glassfish-ha-api Short Description: High Availability APIs and SPI Owners: gil Branches: f18 f19 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ChEEAOUkXG&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871021] Review Request: glassfish-ha-api - High Availability APIs and SPI
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871021 Dennis Gilmore changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YcHgkndpTa&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871021] Review Request: glassfish-ha-api - High Availability APIs and SPI
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871021 --- Comment #4 from Dennis Gilmore --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AwOGLngF4g&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871021] Review Request: glassfish-ha-api - High Availability APIs and SPI
https://bugzilla.redhat.com/show_bug.cgi?id=871021 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=li8DjGeeRJ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871021] Review Request: glassfish-ha-api - High Availability APIs and SPI
https://bugzilla.redhat.com/show_bug.cgi?id=871021 --- Comment #5 from Fedora Update System --- glassfish-ha-api-3.1.9-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/glassfish-ha-api-3.1.9-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nuMMbZgiQe&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871021] Review Request: glassfish-ha-api - High Availability APIs and SPI
https://bugzilla.redhat.com/show_bug.cgi?id=871021 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- glassfish-ha-api-3.1.9-1.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zR3BIlejoh&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871021] Review Request: glassfish-ha-api - High Availability APIs and SPI
https://bugzilla.redhat.com/show_bug.cgi?id=871021 Bug 871021 depends on bug 871018, which changed state. Bug 871018 Summary: Review Request: glassfish-hk2 - Hundred Kilobytes Kernel https://bugzilla.redhat.com/show_bug.cgi?id=871018 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GfOpKCOJpy&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871021] Review Request: glassfish-ha-api - High Availability APIs and SPI
https://bugzilla.redhat.com/show_bug.cgi?id=871021 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||glassfish-ha-api-3.1.9-1.fc ||19 Resolution|--- |ERRATA Last Closed||2013-06-02 23:38:08 --- Comment #7 from Fedora Update System --- glassfish-ha-api-3.1.9-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YfPxVglMvB&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
