[Bug 871197] Review Request: catkin - Collection of CMake macros for ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- catkin-0.4.5-6.gitd4f1f24.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gNlEVywraYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: catkin - Collection of CMake macros for ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-04-20 15:44:32 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5Gh2TJDXQ5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: catkin - Collection of CMake macros for ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- catkin-0.4.5-6.gitd4f1f24.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OS2Y8Wh4q3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: catkin - Collection of CMake macros for ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ONhYQjPd11a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: catkin - Collection of CMake macros for ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- catkin-0.4.5-6.gitd4f1f24.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/catkin-0.4.5-6.gitd4f1f24.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2t8Iyo27oMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: catkin - Collection of CMake macros for ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- catkin-0.4.5-6.gitd4f1f24.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/catkin-0.4.5-6.gitd4f1f24.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=f5sLHH6zOBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: catkin - Collection of CMake macros for ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- catkin-0.4.5-6.gitd4f1f24.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=s1l5lBc6Vka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: catkin - Collection of CMake macros for ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kGloptihu8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: catkin - Collection of CMake macros for ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nJte0QF2Xna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: catkin - Collection of CMake macros for ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=APGeiqMdjDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: catkin - Collection of CMake macros for ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 Ankur Sinha (FranciscoD) sanjay.an...@gmail.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #10 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- Hi Rich, Yep. The scripts are invoked with python, and not invoked directly as far as I can tell too. The scripts being sourced don't need shebangs either. The rpmlint errors have been corrected. The package now looks good to me. XXX APPROVED XXX Thanks, Warm regards, Ankur -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mz2VAjO43ta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: catkin - Collection of CMake macros for ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 Rich Mattes richmat...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #11 from Rich Mattes richmat...@gmail.com --- New Package SCM Request === Package Name: catkin Short Description: Collection of CMake macros for ROS Owners: rmattes Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=a6z60QGv99a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: catkin - Collection of CMake macros for ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 --- Comment #9 from Rich Mattes richmat...@gmail.com --- Updated packages: Spec URL: http://rmattes.fedorapeople.org/rospackages/catkin/catkin.spec SRPM URL: http://rmattes.fedorapeople.org/rospackages/catkin/catkin-0.4.5-6.gitd4f1f24.fc18.src.rpm rpmlint: $ rpmlint catkin.spec ../RPMS/noarch/catkin-* catkin.spec: W: invalid-url Source0: ros-catkin-0.4.5-0-gd4f1f24.tar.gz catkin.noarch: W: no-manual-page-for-binary catkin_install_parse catkin.noarch: W: no-manual-page-for-binary git-catkin catkin.noarch: W: no-manual-page-for-binary git-catkin-track-all catkin.noarch: W: no-manual-page-for-binary catkin-version catkin.noarch: W: no-manual-page-for-binary catkin-parse-stack catkin.noarch: W: no-manual-page-for-binary catkin-bump-version catkin.noarch: W: no-manual-page-for-binary catkin-build-debs-of-workspace catkin.noarch: W: no-manual-page-for-binary catkin-topological-order catkin-devel.noarch: W: no-documentation 2 packages and 1 specfiles checked; 0 errors, 10 warnings. I checked on the usage of the python helpers. It looks like they're being invoked with python instead of executed directly, so they don't need the shebangs. I also got rid of the shebangs in the templates; they're meant to be sourced by other scripts and don't really need shebangs either. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QSbQpiXbEma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: catkin - Collection of CMake macros for ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 Ankur Sinha (FranciscoD) sanjay.an...@gmail.com changed: What|Removed |Added Summary|Review Request: catkin -|Review Request: catkin - |Official build system of|Collection of CMake macros |ROS |for ROS --- Comment #8 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- Errors have been corrected. rpmlint: [ankur@dhcppc1 SRPMS]$ rpmlint ../SPECS/catkin.spec ./catkin-0.4.5-5.gitd4f1f24.fc18.src.rpm /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm ../SPECS/catkin.spec: W: invalid-url Source0: ros-catkin-0.4.5-0-gd4f1f24.tar.gz catkin.src: W: invalid-url Source0: ros-catkin-0.4.5-0-gd4f1f24.tar.gz catkin.noarch: W: no-manual-page-for-binary catkin_install_parse catkin.noarch: W: no-manual-page-for-binary git-catkin catkin.noarch: W: no-manual-page-for-binary git-catkin-track-all catkin.noarch: W: no-manual-page-for-binary catkin-version catkin.noarch: W: no-manual-page-for-binary catkin-parse-stack catkin.noarch: W: no-manual-page-for-binary catkin-bump-version catkin.noarch: W: no-manual-page-for-binary catkin-build-debs-of-workspace catkin.noarch: W: no-manual-page-for-binary catkin-topological-order catkin.src: W: invalid-url Source0: ros-catkin-0.4.5-0-gd4f1f24.tar.gz catkin-devel.noarch: W: no-documentation catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.sh.installable.in 0644L /bin/sh catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.sh.installable.in.etc 0644L /bin/sh catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.zsh.installable.in 0644L /bin/zsh catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.bash.installable.in 0644L /bin/bash catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.bash.buildspace.in 0644L /bin/bash catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/update_project_index.py.in 0644L /usr/bin/env catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.sh.buildspace.in 0644L /bin/sh catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.zsh.buildspace.in 0644L /bin/zsh catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/interrogate_setup_dot_py.py 0644L /usr/bin/env 4 packages and 1 specfiles checked; 9 errors, 12 warnings. [ankur@dhcppc1 SRPMS]$ The *.in files are okay I guess. Although, the templates would've been better without shebangs. What about the one py file? :/ That's all I can find. The rest looks okay. I can't quite figure out what this one py file does. Does it need to have the shebang? I checked up. Py files in /usr/share have their shebangs removed. Thanks, Warm regards, Ankur -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1PkAGqk4sIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
