[Bug 871197] Review Request: python-catkin - Official build system of ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 --- Comment #7 from Rich Mattes richmat...@gmail.com --- The 4.x versions of catkin don't require catkin-pkg yet, only the groovy versions. Since I'm targeting Fuerte first, I'm trying to stick to the package versions listed in http://ros.org/rosinstalls/fuerte-ros-base.rosinstall This includes catkin 4.5. Once we upgrade to groovy, catkin-pkg will be needed. I named it python-catkin because i thought it was installed by pypi (though I think I was just confused, I was doing all of the other python-ros* utilities at the same time.) I'll rename the package to catkin. I think most of the rpmlint errors are OK (the ones with the .in files). The .in files are templates that catkin uses when it generates build files for other packages, so they never get executed directly. That's why they're in share and don't have an executable perm. The isa stuff is OK since catkin is a noarch package (it doesn't have an isa) Thus far I have been putting all the ROS packages I've gotten reviewed into EPEL6. This won't be an exception, so I added a %clean section. Functionally it should work fine. I used it for the rest of the ROS chain which I will be submitting for review soon. Ticket asking for license file at: https://github.com/ros/catkin/issues/398 So new packages are at:Spec URL: http://rmattes.fedorapeople.org/rospackages/catkin/catkin.spec SRPM URL: http://rmattes.fedorapeople.org/rospackages/catkin/catkin-0.4.5-5.gitd4f1f24.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=M46dwAlpaua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: python-catkin - Official build system of ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 Rich Mattes richmat...@gmail.com changed: What|Removed |Added Blocks||927458 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6aYjS9ktA7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: python-catkin - Official build system of ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 Rich Mattes richmat...@gmail.com changed: What|Removed |Added Blocks||927462 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=otu34X9dPta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: python-catkin - Official build system of ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 Rich Mattes richmat...@gmail.com changed: What|Removed |Added Blocks||927470 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=d8sP5qPXDea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: python-catkin - Official build system of ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 --- Comment #4 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- REVIEW: [+] OK [-] NA [?] Issue ** Mandatory review guidelines: ** [?] rpmlint output: [ankur@dhcppc1 SRPMS]$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm ../SPECS/python-catkin.spec ./python-catkin-0.4.5-4.gitd4f1f24.fc18.src.rpm python-catkin.noarch: W: no-manual-page-for-binary catkin_install_parse python-catkin.noarch: W: no-manual-page-for-binary git-catkin python-catkin.noarch: W: no-manual-page-for-binary git-catkin-track-all python-catkin.noarch: W: no-manual-page-for-binary catkin-version python-catkin.noarch: W: no-manual-page-for-binary catkin-parse-stack python-catkin.noarch: W: no-manual-page-for-binary catkin-bump-version python-catkin.noarch: W: no-manual-page-for-binary catkin-build-debs-of-workspace python-catkin.noarch: W: no-manual-page-for-binary catkin-topological-order python-catkin.src: W: invalid-url Source0: ros-catkin-0.4.5-0-gd4f1f24.tar.gz python-catkin-devel.noarch: W: no-documentation python-catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.sh.installable.in 0644L /bin/sh python-catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.sh.installable.in.etc 0644L /bin/sh python-catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.zsh.installable.in 0644L /bin/zsh python-catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.bash.installable.in 0644L /bin/bash python-catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.bash.buildspace.in 0644L /bin/bash python-catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/update_project_index.py.in 0644L /usr/bin/env python-catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.sh.buildspace.in 0644L /bin/sh python-catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.zsh.buildspace.in 0644L /bin/zsh python-catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/interrogate_setup_dot_py.py 0644L /usr/bin/env ../SPECS/python-catkin.spec: W: invalid-url Source0: ros-catkin-0.4.5-0-gd4f1f24.tar.gz python-catkin.src: W: invalid-url Source0: ros-catkin-0.4.5-0-gd4f1f24.tar.gz 4 packages and 1 specfiles checked; 9 errors, 12 warnings. [ankur@dhcppc1 SRPMS]$ ^^ Couple of rpmlint errors. Can be easily corrected. [+] License is acceptable [+] License field in spec is correct [?] License files included in package %docs if included in source package [?] License files installed when any subpackage combination is installed ^^ Couldn't find a license file. Please request upstream to include one. [+] Spec written in American English [+] Spec is legible [-] Sources match upstream unless altered to fix permissibility issues ^^ NA: generated from git tag [+] Build succeeds on at least one primary arch [+] Build succeeds on all primary arches or has ExcludeArch + bugs filed [+] BuildRequires correct, justified where necessary [-] Locales handled with %find_lang, not %_datadir/locale/* [-] %post, %postun call ldconfig if package contains shared .so files [-] No bundled libs [-] Relocatability is justified [+] Package owns all directories it creates [+] Package requires others for directories it uses but does not own [+] No duplication in %files unless necessary for license files [+] File permissions are sane [+] Package contains permissible code or content [-] Large docs go in -doc subpackage [+] %doc files not required at runtime [-] Static libs go in -static package/virtual Provides [+] Development files go in -devel package [+] -devel packages Require base with fully-versioned dependency, %_isa ^^ No isa, but it's a noarch [+] No .la files [+] GUI app uses .desktop file, installs it with desktop-file-install [+] File list does not conflict with other packages' without justification [+] File names are valid UTF-8 ** Optional review guidelines: ** [?] Query upstream about including license files ^^ Required [-] Translations of description, summary [+] Builds in mock [+] Builds on all arches [?] Functions as described (e.g. no crashes) ^^ Need to check this [-] Scriptlets are sane [+] Subpackages require base with fully-versioned dependency if sensible [+] .pc file subpackage placement is sensible [+] No file deps outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin [+] Include man pages if available Naming guidelines: [+] Package names use only a-zA-Z0-9-._+ subject to restrictions on -._+ [+] Package names are sane [+] No naming conflicts [+] Spec file name matches base package name [+] Version is sane [+] Version does not contain ~ [+] Release is sane [+] %dist tag [+] Case used only when necessary [-] Renaming handled correctly Packaging guidelines: [+] Useful without external
[Bug 871197] Review Request: python-catkin - Official build system of ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 --- Comment #5 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- I was also wondering if the package needs to be named python-catkin? Wouldn't just catkin be okay? It isnt' a python module and the python prefix is therefore not necessary IMO. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wHN4abDZLTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: python-catkin - Official build system of ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 Ankur Sinha (FranciscoD) sanjay.an...@gmail.com changed: What|Removed |Added See Also||https://bugzilla.redhat.com ||/show_bug.cgi?id=926034 --- Comment #6 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- Hi Rich, I've submitted python-catkin_pkg for review here: https://bugzilla.redhat.com/show_bug.cgi?id=926034 It's a really simple package. Please check if this one requires it. If it does, we can review it quickly and push it to the repos. Thanks, Warm regards, Ankur -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TNdJjkglvza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: python-catkin - Official build system of ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 Bug 871197 depends on bug 870788, which changed state. Bug 870788 Summary: Review Request: ros-release - Robot Operating System release files https://bugzilla.redhat.com/show_bug.cgi?id=870788 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=z3320UPMhOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: python-catkin - Official build system of ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 --- Comment #2 from Rich Mattes richmat...@gmail.com --- Alright I think the package is in good enough shape to be reviewed now. After a day or two that turned into a month or two... Spec URL: http://rmattes.fedorapeople.org/rospackages/catkin/python-catkin.spec SRPM URL: http://rmattes.fedorapeople.org/rospackages/catkin/python-catkin-0.4.5-4.gitd4f1f24.fc18.src.rpm rpmlint output: $ rpmlint python-catkin.spec ../RPMS/noarch/python-catkin-0.4.5-4.gitd4f1f24.fc18.noarch.rpm python-catkin.spec: W: invalid-url Source0: ros-catkin-0.4.5-0-gd4f1f24.tar.gz python-catkin.noarch: W: no-manual-page-for-binary catkin_install_parse python-catkin.noarch: W: no-manual-page-for-binary git-catkin python-catkin.noarch: W: no-manual-page-for-binary git-catkin-track-all python-catkin.noarch: W: no-manual-page-for-binary catkin-version python-catkin.noarch: W: no-manual-page-for-binary catkin-parse-stack python-catkin.noarch: W: no-manual-page-for-binary catkin-bump-version python-catkin.noarch: W: no-manual-page-for-binary catkin-build-debs-of-workspace python-catkin.noarch: W: no-manual-page-for-binary catkin-topological-order 1 packages and 1 specfiles checked; 0 errors, 9 warnings. The package is a checkout from github, and the checkout command is included in the spec comments. The package also doesn't have manpages, so the warnings are all OK. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YGJSyyux9Za=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: python-catkin - Official build system of ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 Ankur Sinha (FranciscoD) sanjay.an...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||sanjay.an...@gmail.com Assignee|nob...@fedoraproject.org|sanjay.an...@gmail.com Flags||fedora-review? --- Comment #3 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- Hi Rich, I'll try and review this by the weekend. Thanks, Ankur -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0XXmiv3kr4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: python-catkin - Official build system of ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 --- Comment #1 from Rich Mattes richmat...@gmail.com --- Update to use new ros-release package: Spec URL: http://rmattes.fedorapeople.org/rospackages/catkin/python-catkin.spec SRPM URL: http://rmattes.fedorapeople.org/rospackages/catkin/python-catkin-0.4.5-3.gitd4f1f24.fc18.src.rpm rpmlint still needs some attention, I'll clean it up in a day or two: python-catkin.spec: W: invalid-url Source0: ros-catkin-0.4.5-0-gd4f1f24.tar.gz python-catkin.noarch: E: devel-dependency python-setuptools-devel python-catkin.noarch: W: no-documentation python-catkin.noarch: W: non-conffile-in-etc /etc/catkin/profile.d/00.catkin.sh python-catkin.noarch: E: script-without-shebang /usr/bin/catkin_util.sh python-catkin.noarch: W: non-conffile-in-etc /etc/catkin/profile.d/00.catkin.all python-catkin.noarch: W: non-conffile-in-etc /etc/catkin/profile.d/00.catkin.tcsh python-catkin.noarch: W: non-conffile-in-etc /etc/catkin/profile.d/00.catkin.zsh python-catkin.noarch: W: non-conffile-in-etc /etc/catkin/profile.d/00.catkin.bash python-catkin.noarch: E: non-executable-script /usr/share/catkin/setup.bash 0644L /bin/bash python-catkin.noarch: W: non-conffile-in-etc /etc/catkin/profile.d/00.catkin.csh python-catkin.noarch: W: hidden-file-or-dir /usr/share/catkin/.rosinstall python-catkin.noarch: E: non-executable-script /usr/share/catkin/setup.zsh 0644L /bin/zsh python-catkin.noarch: E: non-executable-script /usr/share/catkin/setup.sh 0644L /bin/sh python-catkin.noarch: W: no-manual-page-for-binary catkin_install_parse python-catkin.noarch: W: no-manual-page-for-binary catkin-version python-catkin.noarch: W: no-manual-page-for-binary git-catkin-track-all python-catkin.noarch: W: no-manual-page-for-binary catkin_util.sh python-catkin.noarch: W: no-manual-page-for-binary git-catkin python-catkin.noarch: W: no-manual-page-for-binary catkin-parse-stack python-catkin.noarch: W: no-manual-page-for-binary catkin-bump-version python-catkin.noarch: W: no-manual-page-for-binary catkin-build-debs-of-workspace python-catkin.noarch: W: no-manual-page-for-binary catkin-topological-order python-catkin-devel.noarch: W: no-documentation python-catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.sh.installable.in 0644L /bin/sh python-catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.sh.installable.in.etc 0644L /bin/sh python-catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.zsh.installable.in 0644L /bin/zsh python-catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.bash.installable.in 0644L /bin/bash python-catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.bash.buildspace.in 0644L /bin/bash python-catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/update_project_index.py.in 0644L /usr/bin/env python-catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.sh.buildspace.in 0644L /bin/sh python-catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.zsh.buildspace.in 0644L /bin/zsh python-catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/interrogate_setup_dot_py.py 0644L /usr/bin/env 2 packages and 1 specfiles checked; 14 errors, 19 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=a7R6eCq1xWa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: python-catkin - Official build system of ROS
https://bugzilla.redhat.com/show_bug.cgi?id=871197 Rich Mattes richmat...@gmail.com changed: What|Removed |Added Depends On||870788 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
