[Bug 871203] Review Request: console-bridge - Lightweight set of macros used for reporting information in libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871203 --- Comment #12 from Fedora Update System --- console-bridge-0.1.4-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=q0PxTysuTH&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871203] Review Request: console-bridge - Lightweight set of macros used for reporting information in libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871203 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-05-04 23:23:52 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TVpIMpYwg6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871203] Review Request: console-bridge - Lightweight set of macros used for reporting information in libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871203 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VXoXjqOfT9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871203] Review Request: console-bridge - Lightweight set of macros used for reporting information in libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871203 --- Comment #11 from Fedora Update System --- console-bridge-0.1.4-2.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CuVN7P3snE&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871203] Review Request: console-bridge - Lightweight set of macros used for reporting information in libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871203 --- Comment #10 from Fedora Update System --- console-bridge-0.1.4-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/console-bridge-0.1.4-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aknYkjGtKv&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871203] Review Request: console-bridge - Lightweight set of macros used for reporting information in libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871203 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bjSaT9uuRu&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871203] Review Request: console-bridge - Lightweight set of macros used for reporting information in libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871203 --- Comment #9 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fWDvwytsvT&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871203] Review Request: console-bridge - Lightweight set of macros used for reporting information in libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871203 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jtJl4Y4Eq4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871203] Review Request: console-bridge - Lightweight set of macros used for reporting information in libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871203 Rich Mattes changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Rich Mattes --- New Package SCM Request === Package Name: console-bridge Short Description: Lightweight set of macros used for reporting information in libraries Owners: rmattes Branches: f17 f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jy9tRzv965&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871203] Review Request: console-bridge - Lightweight set of macros used for reporting information in libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871203 Ankur Sinha (FranciscoD) changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #7 from Ankur Sinha (FranciscoD) --- Hi Rich, Issues are fixed: [ankur@ankur-pc SRPMS]$ rpm -qp --requires /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm cmake boost-devel rpmlib(FileDigests) <= 4.6.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 /sbin/ldconfig /sbin/ldconfig libboost_system-mt.so.1.53.0()(64bit) libboost_thread-mt.so.1.53.0()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.11)(64bit) libstdc++.so.6(GLIBCXX_3.4.9)(64bit) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rtld(GNU_HASH) rpmlib(PayloadIsXz) <= 5.2-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadIsXz) <= 5.2-1 /usr/bin/pkg-config console-bridge(x86-64) = 0.1.4-2.fc20 libconsole_bridge.so.0()(64bit) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 [ankur@ankur-pc SRPMS]$ rpm -qp --provides /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm console-bridge = 0.1.4-2.fc20 console-bridge(x86-64) = 0.1.4-2.fc20 libconsole_bridge.so.0()(64bit) console-bridge-debuginfo = 0.1.4-2.fc20 console-bridge-debuginfo(x86-64) = 0.1.4-2.fc20 console-bridge-devel = 0.1.4-2.fc20 console-bridge-devel(x86-64) = 0.1.4-2.fc20 pkgconfig(console_bridge) [ankur@ankur-pc SRPMS]$ Package looks good to me. XXX APPROVED XXX -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DucP0Fuwm6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871203] Review Request: console-bridge - Lightweight set of macros used for reporting information in libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871203 --- Comment #6 from Rich Mattes --- Updated packages: Spec URL: http://rmattes.fedorapeople.org/RPMS/console-bridge/console-bridge.spec SRPM URL: http://rmattes.fedorapeople.org/RPMS/console-bridge/console-bridge-0.1.4-2.fc18.src.rpm I added the calls to ldconfig and patched CMakeLists.txt to set the SOVERSION to 0 (which should be safe if upstream starts adding their own SONAME). rpmlint: $ rpmlint console-bridge.spec ../RPMS/x86_64/console-bridge-* console-bridge.spec: W: invalid-url Source0: ros-console_bridge-0.1.4-0-g96c8951.tar.gz console-bridge.x86_64: W: no-documentation console-bridge-devel.x86_64: W: no-documentation 3 packages and 1 specfiles checked; 0 errors, 3 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TShUbzjkB8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871203] Review Request: console-bridge - Lightweight set of macros used for reporting information in libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871203 Ankur Sinha (FranciscoD) changed: What|Removed |Added Status|NEW |ASSIGNED CC||sanjay.an...@gmail.com Assignee|nob...@fedoraproject.org|sanjay.an...@gmail.com Alias||console-bridge Flags||fedora-review? --- Comment #5 from Ankur Sinha (FranciscoD) --- Hi Rich: Here's the review: [+] OK [-] NA [?] Issue ** Mandatory review guidelines: ** [+] rpmlint output: [ankur@localhost SRPMS]$ rpmlint ../SPECS/console-bridge.spec ./console-bridge-0.1.4-1.fc18.src.rpm /var/lib/mock/fedora-rawhide-x86_64/result/console-bridge-*rpm ../SPECS/console-bridge.spec: W: invalid-url Source0: ros-console_bridge-0.1.4-0-g96c8951.tar.gz console-bridge.src: W: invalid-url Source0: ros-console_bridge-0.1.4-0-g96c8951.tar.gz console-bridge.src: W: invalid-url Source0: ros-console_bridge-0.1.4-0-g96c8951.tar.gz console-bridge.x86_64: E: invalid-soname /usr/lib64/libconsole_bridge.so libconsole_bridge.so console-bridge.x86_64: W: no-documentation console-bridge-devel.x86_64: W: no-documentation 5 packages and 1 specfiles checked; 1 errors, 5 warnings. [ankur@localhost SRPMS]$ ^ The soname error is because the soname in the main package should have a version extension: libfoo.so.1 as rpmlint -i describes: console-bridge.x86_64: E: invalid-soname /usr/lib64/libconsole_bridge.so libconsole_bridge.so The soname of the library is neither of the form lib.so. or lib-.so. As a random example: [ankur@localhost lib64]$ lash libkrb5* 0 lrwxrwxrwx. 1 root root 14 Mar 24 14:30 libkrb5.so -> libkrb5.so.3.3 0 lrwxrwxrwx. 1 root root 14 Mar 7 20:45 libkrb5.so.3 -> libkrb5.so.3.3 932K -rwxr-xr-x. 1 root root 930K Mar 6 05:29 libkrb5.so.3.3 0 lrwxrwxrwx. 1 root root 21 Mar 24 14:30 libkrb5support.so -> libkrb5support.so.0.1 0 lrwxrwxrwx. 1 root root 21 Mar 7 20:45 libkrb5support.so.0 -> libkrb5support.so.0.1 48K -rwxr-xr-x. 1 root root 47K Mar 6 05:29 libkrb5support.so.0.1 [ankur@localhost lib64]$ The build system files (cmake here) will have to be modified to generate a versioned soname. A symlink can then go into the devel package. There isn't a shared object in the devel package at the moment. [+] License is acceptable (...) [+] License field in spec is correct [?] License files included in package %docs if included in source package ^^ Ros packages generally don't contain the BSD license text in them. Not a blocker [-] License files installed when any subpackage combination is installed [-] Spec written in American English [-] Spec is legible [-] Sources match upstream unless altered to fix permissibility issues Upstream SHA256: ... Your SHA256: ... ^ From git checkout using wget [+] Build succeeds on at least one primary arch [+] Build succeeds on all primary arches or has ExcludeArch + bugs filed [+] BuildRequires correct, justified where necessary [-] Locales handled with %find_lang, not %_datadir/locale/* [ ] %post, %postun call ldconfig if package contains shared .so files [+] No bundled libs [-] Relocatability is justified [+] Package owns all directories it creates [-] Package requires others for directories it uses but does not own [+] No duplication in %files unless necessary for license files [+] File permissions are sane [+] Package contains permissible code or content [-] Large docs go in -doc subpackage [-] %doc files not required at runtime [-] Static libs go in -static package/virtual Provides [+] Development files go in -devel package [+] -devel packages Require base with fully-versioned dependency, %_isa [+] No .la files [-] GUI app uses .desktop file, installs it with desktop-file-install [-] File list does not conflict with other packages' without justification [+] File names are valid UTF-8 ** Optional review guidelines: ** [?] Query upstream about including license files ^ ROS, so I don't expect anything, but you can query them when you have the time. [-] Translations of description, summary [+] Builds in mock [+] Builds on all arches [-] Functions as described (e.g. no crashes) [?] Scriptlets are sane ^^ Missing scriptlets for shared libraries. BLOCKER http://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries [+] Subpackages require base with fully-versioned dependency if sensible [+] .pc file subpackage placement is sensible [+] No file deps outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin [-] Include man pages if available Naming guidelines: [+] Package names use only a-zA-Z0-9-._+ subject to restrictions on -._+ [+] Package names are sane [+] No naming conflicts [+] Spec file name matches base package name [+] Version is sane [+] Version does not contain ~
[Bug 871203] Review Request: console-bridge - Lightweight set of macros used for reporting information in libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871203 --- Comment #4 from Rich Mattes --- Updated to latest upstream version: Spec URL: http://rmattes.fedorapeople.org/RPMS/console-bridge/console-bridge.spec SRPM URL: http://rmattes.fedorapeople.org/RPMS/console-bridge/console-bridge-0.1.4-1.fc18.src.rpm rpmlint: $ rpmlint ./console-bridge.spec ../RPMS/x86_64/console-bridge-* ./console-bridge.spec: W: invalid-url Source0: ros-console_bridge-0.1.4-0-g96c8951.tar.gz console-bridge.x86_64: E: invalid-soname /usr/lib64/libconsole_bridge.so libconsole_bridge.so console-bridge.x86_64: W: no-documentation console-bridge-devel.x86_64: W: no-documentation 3 packages and 1 specfiles checked; 1 errors, 3 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fYEfTv4LdU&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871203] Review Request: console-bridge - Lightweight set of macros used for reporting information in libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871203 --- Comment #3 from Rich Mattes --- Whoops, that was an oversight in a patch I added. I've fixed the error. New files at: Spec URL: http://rmattes.fedorapeople.org/RPMS/console-bridge/console-bridge.spec SRPM URL: http://rmattes.fedorapeople.org/RPMS/console-bridge/console-bridge-0.1.2-2.fc18.src.rpm rpmlint: $ rpmlint console-bridge.spec ../RPMS/x86_64/console-bridge* console-bridge.spec: W: invalid-url Source0: console-bridge-0.1.2.tar.bz2 console-bridge.x86_64: E: invalid-soname /usr/lib64/libconsole_bridge.so libconsole_bridge.so console-bridge.x86_64: W: no-documentation console-bridge-devel.x86_64: W: no-documentation 3 packages and 1 specfiles checked; 1 errors, 3 warnings. The project configuration files for CMake based projects don't seem to have any standard location. I've seen libraries put them in libdir/cmake, libdir/name, libdir/name/cmake, datadir/name, etc. The CMake wiki seems to think they should go in libdir[1], but I don't think Fedora has any policies regarding specific location of these files. [1] http://www.cmake.org/Wiki/CMake/Tutorials/Packaging#Package_Configuration_Files -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871203] Review Request: console-bridge - Lightweight set of macros used for reporting information in libraries
https://bugzilla.redhat.com/show_bug.cgi?id=871203 --- Comment #2 from Ivan Romanov --- I wonder. What for is need this file? If it is cmake module it should be places in /usr/share/cmake/Modules -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871203] Review Request: console-bridge - Lightweight set of macros used for reporting information in libraries
https://bugzilla.redhat.com/show_bug.cgi?id=871203 Ivan Romanov changed: What|Removed |Added CC||dr...@land.ru --- Comment #1 from Ivan Romanov --- weird path in console_bridge-config.cmake PATHS /usr//usr/lib -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871203] Review Request: console-bridge - Lightweight set of macros used for reporting information in libraries
https://bugzilla.redhat.com/show_bug.cgi?id=871203 Rich Mattes changed: What|Removed |Added Blocks||871205 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
