[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 --- Comment #22 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 Dave Johansen changed: What|Removed |Added Flags||fedora-cvs? --- Comment #21 from Dave Johansen --- Here's the correction for comment 13: Package Change Request == Package Name: qextserialport New Branches: el6 epel7 Owners: daveisfera InitialCC: volter -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 --- Comment #20 from Jon Ciesla --- Request not yet corrected. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 Dave Johansen changed: What|Removed |Added Flags||fedora-cvs? --- Comment #19 from Dave Johansen --- Yes, my username is daveisfera. Thanks, Dave -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 --- Comment #18 from Volker Fröhlich --- I think the user name should be daveisfera and not dlj. Please correct your request, Dave! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 --- Comment #17 from Jon Ciesla --- dlj is not in the packager group. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 Dave Johansen changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 --- Comment #16 from Dave Johansen --- Is there anything else needed before these branches can be created? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 --- Comment #15 from Volker Fröhlich --- That's fine! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 --- Comment #14 from Jon Ciesla --- Comments from primary maintainers? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 Volker Fröhlich changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 Dave Johansen changed: What|Removed |Added CC||davejohan...@gmail.com --- Comment #13 from Dave Johansen --- Package Change Request == Package Name: qextserialport New Branches: el6 epel7 Owners: dlj InitialCC: volter -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872771 --- Comment #12 from Fedora Update System --- qextserialport-1.2-0.2.beta2.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872771 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-11-14 21:26:56 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 --- Comment #11 from Fedora Update System --- qextserialport-1.2-0.2.beta2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 --- Comment #10 from Fedora Update System --- qextserialport-1.2-0.2.beta2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/qextserialport-1.2-0.2.beta2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 --- Comment #9 from Fedora Update System --- qextserialport-1.2-0.2.beta2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/qextserialport-1.2-0.2.beta2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 --- Comment #8 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 Volker Fröhlich changed: What|Removed |Added Blocks||872971 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 Volker Fröhlich changed: What|Removed |Added Assignee|nob...@fedoraproject.org|d...@danny.cz Flags||fedora-cvs? --- Comment #7 from Volker Fröhlich --- New Package SCM Request === Package Name: qextserialport Short Description: Qt interface class for old fashioned serial ports Owners: volter Branches: f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 Dan Horák changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #6 from Dan Horák --- all issues are fixed now, APPROVED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 --- Comment #5 from Volker Fröhlich --- Argh, those were stupid mistakes! Spec URL: http://www.geofrogger.net/review/qextserialport.spec SRPM URL: http://www.geofrogger.net/review/qextserialport-1.2-0.2.beta2.fc16.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771
--- Comment #4 from Dan Horák ---
formal review is here, see the notes explaining OK* and BAD statuses below:
BAD source files match upstream:
cc9e91f6e1bec987616066902fbf532937b120e5
qextserialport-1.2beta2.tar.gz
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros
consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible (MIT). License text included in
package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK rpmlint is silent.
BAD final provides and requires look sane.
N/A %check is present and all tests pass.
OK shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK correct scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK headers in devel subpackage
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.
- please use the whole URL for the source archive -
http://qextserialport.googlecode.com/files/qextserialport-1.2beta2.tar.gz works
here, otherwise a comment is needed
- the devel subpackage should depend on qt4-devel, because
%{_qt4_datadir}/mkspecs/features/
would be unwned otherwise, also it's unusable without qt4-devel
- I prefer trailing slash when whole directory should be included =>
%{_includedir}/QtExtSerialPort/
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 Dan Horák changed: What|Removed |Added Status|NEW |ASSIGNED CC||d...@danny.cz Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 Volker Fröhlich changed: What|Removed |Added Blocks||872883 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 --- Comment #3 from Kevin Kofler --- Also qlandkartegt: http://qlandkartegt.svn.sourceforge.net/viewvc/qlandkartegt/QLandkarteGT/trunk/3rdparty/SerialPort/ Volker found a handful other upstream projects which use this, but it looks like only the GIS stuff is already in Fedora. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 --- Comment #2 from Volker Fröhlich --- Already submitted patch for QGIS: http://hub.qgis.org/issues/6613 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 --- Comment #1 from Kevin Kofler --- At least qgis and merkaartor currently bundle this library: http://hub.qgis.org/projects/quantum-gis/repository/show/src/core/gps/qextserialport http://www.merkaartor.be/projects/merkaartor/repository/revisions/master/show/src/qextserialport -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872771] Review Request: qextserialport - Qt interface class for old fashioned serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=872771 Kevin Kofler changed: What|Removed |Added CC||ke...@tigcc.ticalc.org Blocks||656997 (kde-reviews) Alias||qextserialport -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
