[Bug 873793] Review Request: skb - Simple keyboard layout indicator
https://bugzilla.redhat.com/show_bug.cgi?id=873793 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG Last Closed||2013-05-25 10:55:22 --- Comment #7 from Mario Blättermann mario.blaetterm...@gmail.com --- Still no response for two weeks. That's why I will close this ticket now. Please reopen it once you want to continue working on it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BuAz2bE2Mua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 873793] Review Request: skb - Simple keyboard layout indicator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=873793 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added CC||mario.blaetterm...@gmail.co ||m --- Comment #6 from Mario Blättermann mario.blaetterm...@gmail.com --- Almost half a year without any progress. Is this review request still relevant? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7elKk4IJ28a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 873793] Review Request: skb - Simple keyboard layout indicator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=873793 --- Comment #4 from Mario Blättermann mario.blaetterm...@gmail.com --- Ping...? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=te2aLtiSVwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 873793] Review Request: skb - Simple keyboard layout indicator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=873793 --- Comment #5 from Minh Ngo nlmin...@gmail.com --- Pong. I'm sorry. I'm busy now, because of exams in the University. I'll fix it later. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=q4I88cw8Nta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 873793] Review Request: skb - Simple keyboard layout indicator
https://bugzilla.redhat.com/show_bug.cgi?id=873793
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
CC||mario.blaetterm...@gmail.co
||m
--- Comment #3 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4663991
$ rpmlint -i -v *
skb.src: I: checking
skb.src: I: checking-url http://plhk.ru/ (timeout 10 seconds)
skb.src: I: checking-url http://plhk.ru/static/skb/skb-0.4.tar.gz (timeout 10
seconds)
skb.i686: I: checking
skb.i686: I: checking-url http://plhk.ru/ (timeout 10 seconds)
skb.i686: E: incorrect-fsf-address /usr/share/doc/skb-0.4/LICENSE
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
skb.i686: W: no-manual-page-for-binary skb
Each executable in standard binary directories should have a man page.
skb.x86_64: I: checking
skb.x86_64: I: checking-url http://plhk.ru/ (timeout 10 seconds)
skb.x86_64: E: incorrect-fsf-address /usr/share/doc/skb-0.4/LICENSE
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
skb.x86_64: W: no-manual-page-for-binary skb
Each executable in standard binary directories should have a man page.
skb-debuginfo.i686: I: checking
skb-debuginfo.i686: I: checking-url http://plhk.ru/ (timeout 10 seconds)
skb-debuginfo.i686: E: empty-debuginfo-package
This debuginfo package contains no files. This is often a sign of binaries
being unexpectedly stripped too early during the build, rpmbuild not being
able to strip the binaries, the package actually being a noarch one but
erratically packaged as arch dependent, or something else. Verify what the
case is, and if there's no way to produce useful debuginfo out of it, disable
creation of the debuginfo package.
skb-debuginfo.x86_64: I: checking
skb-debuginfo.x86_64: I: checking-url http://plhk.ru/ (timeout 10 seconds)
skb-debuginfo.x86_64: E: empty-debuginfo-package
This debuginfo package contains no files. This is often a sign of binaries
being unexpectedly stripped too early during the build, rpmbuild not being
able to strip the binaries, the package actually being a noarch one but
erratically packaged as arch dependent, or something else. Verify what the
case is, and if there's no way to produce useful debuginfo out of it, disable
creation of the debuginfo package.
skb.spec: I: checking-url http://plhk.ru/static/skb/skb-0.4.tar.gz (timeout 10
seconds)
5 packages and 1 specfiles checked; 4 errors, 2 warnings.
Due to that CFLAGS is hardcoded in config.mk, the debuginfo packages are empty.
Call make as follows:
make CFLAGS=%{optflags} %{?_smp_mflags}
This should help to fix the issue. Moreover, the %{_prefix} macro is senseless,
because it is the default and the Makefile points to /usr anyway.
Regarding the incorrect FSF address: Don't touch it. Just inform the upstream
developer about the outdated address so that he can fix it in future releases.
(In reply to comment #1)
- libX11-devel can be omitted
https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRequires
No it can't be omitted. It is needed for building the package and is not part
of the basic build environment:
http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2
Indeed, the description could be more informative. But the upstream developer
is very thriftily with additional info, and there seems to be no package in
other distributions where we could borrow the description from. In this case,
we can leave it as is. Anyway, if you have some idea to tweak it, do it.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 873793] Review Request: skb - Simple keyboard layout indicator
https://bugzilla.redhat.com/show_bug.cgi?id=873793
Antonio Trande trp...@katamail.com changed:
What|Removed |Added
CC||trp...@katamail.com
--- Comment #1 from Antonio Trande trp...@katamail.com ---
Hi Minh.
Just few comments:
- Why are you not edit %description more explicitly ?
http://fedoraproject.org/wiki/Packaging:Guidelines
- In Source0, you can use this form
http://plhk.ru/static/%{name}/%{name}-0.4.tar.gz
- libX11-devel can be omitted
https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRequires
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 873793] Review Request: skb - Simple keyboard layout indicator
https://bugzilla.redhat.com/show_bug.cgi?id=873793 --- Comment #2 from Minh Ngo nlmin...@gmail.com --- - Why are you not edit %description more explicitly ? How to edit more explicitly? This utility can only start in daemon or not and shows a keyboard layout :). - In Source0, you can use this form I know about this, but in this case we will have some limitations. For example we cannot easier copy this URL and download the source archive. - libX11-devel can be omitted Okay, I will remove it in the next release -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
