[Bug 874238] Review Request: DOM Tooltip (aka domTT) is a Javascript widget
https://bugzilla.redhat.com/show_bug.cgi?id=874238 MartinKG mgans...@alice.de changed: What|Removed |Added Blocks||1045756 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1045756 [Bug 1045756] Review Request: vdr-live - An interactive web interface for VDR -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874238] Review Request: DOM Tooltip (aka domTT) is a Javascript widget
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874238 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- domtt-0.7.3-6.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874238] Review Request: DOM Tooltip (aka domTT) is a Javascript widget
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874238 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Resolution|NEXTRELEASE |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874238] Review Request: DOM Tooltip (aka domTT) is a Javascript widget
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874238 Matthias Runge mru...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #12 from Matthias Runge mru...@redhat.com --- Great, package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874238] Review Request: DOM Tooltip (aka domTT) is a Javascript widget
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874238 MartinKG mgans...@alice.de changed: What|Removed |Added Flags||fedora-cvs? --- Comment #13 from MartinKG mgans...@alice.de --- Package Name: domtt Short Description: DOM Tooltip (aka domTT) is a Javascript widget Owners: martinkg Branches: f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874238] Review Request: DOM Tooltip (aka domTT) is a Javascript widget
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874238 --- Comment #14 from Jon Ciesla limburg...@gmail.com --- No SCM request found. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874238] Review Request: DOM Tooltip (aka domTT) is a Javascript widget
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874238 MartinKG mgans...@alice.de changed: What|Removed |Added Flags||fedora-cvs? --- Comment #15 from MartinKG mgans...@alice.de --- New Package SCM Request === Package Name: domtt Short Description: DOM Tooltip (aka domTT) is a Javascript widget Owners: martinkg Branches: f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874238] Review Request: DOM Tooltip (aka domTT) is a Javascript widget
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874238 --- Comment #16 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874238] Review Request: DOM Tooltip (aka domTT) is a Javascript widget
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874238 MartinKG mgans...@alice.de changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2012-11-19 12:18:26 --- Comment #17 from MartinKG mgans...@alice.de --- the package built successfully http://koji.fedoraproject.org/koji/buildinfo?buildID=367482 http://koji.fedoraproject.org/koji/buildinfo?buildID=367474 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874238] Review Request: DOM Tooltip (aka domTT) is a Javascript widget
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874238 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- domtt-0.7.3-6.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/domtt-0.7.3-6.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874238] Review Request: DOM Tooltip (aka domTT) is a Javascript widget
https://bugzilla.redhat.com/show_bug.cgi?id=874238
--- Comment #10 from Matthias Runge mru...@redhat.com ---
sorry, that this took so long.
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#ValidLicenseShortNames
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 51200 bytes in 6 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX / PatchY prefixed with %{name}.
[x]: SourceX is a working URL.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to
[Bug 874238] Review Request: DOM Tooltip (aka domTT) is a Javascript widget
https://bugzilla.redhat.com/show_bug.cgi?id=874238 --- Comment #11 from MartinKG mgans...@alice.de --- Mathias, thanks for your review. Spec URL: http://martinkg.fedorapeople.org/Review/SPECS/domtt.spec SRPM URL: http://martinkg.fedorapeople.org/Review/SRPMS/domtt-0.7.3-6.fc17.src.rpm %changelog * Wed Nov 14 2012 Martin Gansser linux4martin[at]gmx.de - 0.7.3-6 - added BuildArch noarch $ rpmlint domtt-0.7.3-6.fc17.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint domtt-0.7.3-6.fc17.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874238] Review Request: DOM Tooltip (aka domTT) is a Javascript widget
https://bugzilla.redhat.com/show_bug.cgi?id=874238 MartinKG mgans...@alice.de changed: What|Removed |Added Status|ASSIGNED|NEW --- Comment #7 from MartinKG mgans...@alice.de --- Spec URL: https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/vdr-live/domtt-0.7.3-4/domtt.spec?a=2c8LgU7HXBI SRPM URL: https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/vdr-live/domtt-0.7.3-4/domtt-0.7.3-4.fc18.src.rpm?a=-FlPPjA2TMo %changelog * Thu Nov 9 2012 Martin Gansser linux4martin[at]gmx.de - 0.7.3-4 - added apache conf file to doc section -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874238] Review Request: DOM Tooltip (aka domTT) is a Javascript widget
https://bugzilla.redhat.com/show_bug.cgi?id=874238 --- Comment #8 from MartinKG mgans...@alice.de --- Spec URL: http://martinkg.fedorapeople.org/Review/SPECS/domtt.spec SRPM URL http://martinkg.fedorapeople.org/Review/SRPMS/domtt-0.7.3-5.fc17.src.rpm %changelog * Thu Nov 9 2012 Martin Gansser linux4martin[at]gmx.de - 0.7.3-5 - rebuild -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874238] Review Request: DOM Tooltip (aka domTT) is a Javascript widget
https://bugzilla.redhat.com/show_bug.cgi?id=874238 MartinKG mgans...@alice.de changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #9 from MartinKG mgans...@alice.de --- Spec URL: http://martinkg.fedorapeople.org/Review/SPECS/domtt.spec SRPM URL http://martinkg.fedorapeople.org/Review/SRPMS/domtt-0.7.3-5.fc17.src.rpm %changelog * Thu Nov 9 2012 Martin Gansser linux4martin[at]gmx.de - 0.7.3-5 - rebuild -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874238] Review Request: DOM Tooltip (aka domTT) is a Javascript widget
https://bugzilla.redhat.com/show_bug.cgi?id=874238 --- Comment #2 from Matthias Runge mru...@redhat.com --- you should drop BuildRequires (as there is no build) and also requirement firefox, which basically makes no sense. Also a suggestion: is it useful to provide a httpd-config snippet for e.g. apache httpd? If yes, you must add a dependency to httpd, which is not exactly what you'd require for vdr-live (because that depends on tntnet). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874238] Review Request: DOM Tooltip (aka domTT) is a Javascript widget
https://bugzilla.redhat.com/show_bug.cgi?id=874238 --- Comment #3 from MartinKG mgans...@alice.de --- (In reply to comment #2) you should drop BuildRequires (as there is no build) and also requirement firefox, which basically makes no sense. Also a suggestion: is it useful to provide a httpd-config snippet for e.g. apache httpd? If yes, you must add a dependency to httpd, which is not exactly what you'd require for vdr-live (because that depends on tntnet). not totally clear why i should provide a httpd-config file ? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874238] Review Request: DOM Tooltip (aka domTT) is a Javascript widget
https://bugzilla.redhat.com/show_bug.cgi?id=874238 --- Comment #4 from MartinKG mgans...@alice.de --- Spec URL: https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/vdr-live/domtt-0.7.3-3/domtt.spec?a=MuFtihFw6k0 SRPM URL: https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/vdr-live/domtt-0.7.3-3/domtt-0.7.3-3.fc18.src.rpm?a=Eq0eAy_FzmU %changelog * Thu Nov 8 2012 Martin Gansser linux4martin[at]gmx.de - 0.7.3-3 - Dropped BuildRequires and Requires because there is no build -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874238] Review Request: DOM Tooltip (aka domTT) is a Javascript widget
https://bugzilla.redhat.com/show_bug.cgi?id=874238 --- Comment #5 from Matthias Runge mru...@redhat.com --- (In reply to comment #3) not totally clear why i should provide a httpd-config file ? Maybe to make this more usable for others? Without that, nobody can use it e.g from their web pages. But: it is just a question/suggestion, not a requirement. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874238] Review Request: DOM Tooltip (aka domTT) is a Javascript widget
https://bugzilla.redhat.com/show_bug.cgi?id=874238 Matthias Runge mru...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mru...@redhat.com Flags||fedora-review? --- Comment #6 from Matthias Runge mru...@redhat.com --- I'll do the review -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874238] Review Request: DOM Tooltip (aka domTT) is a Javascript widget
https://bugzilla.redhat.com/show_bug.cgi?id=874238 MartinKG mgans...@alice.de changed: What|Removed |Added CC||mru...@redhat.com Blocks||821233 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874238] Review Request: DOM Tooltip (aka domTT) is a Javascript widget
https://bugzilla.redhat.com/show_bug.cgi?id=874238 --- Comment #1 from MartinKG mgans...@alice.de --- Spec URL: https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/vdr-live/domtt-0.7.3-2/domtt.spec?a=NRE0_kqpfSs SRPM URL: https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/vdr-live/domtt-0.7.3-2/domtt-0.7.3-2.fc17.src.rpm?a=8NoeyePoKEs %changelog * Wed Nov 7 2012 Martin Gansser linux4martin[at]gmx.de - 0.7.3-2 - added js files -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
