[Bug 875299] Review Request: slowhttptest - An Application Layer DoS attack simulator
https://bugzilla.redhat.com/show_bug.cgi?id=875299 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Flags||fedora-cvs? --- Comment #16 from Fabian Affolter m...@fabian-affolter.ch --- (In reply to Jon Ciesla from comment #15) Any comments from the Fedora maintainer? Well, let's include that Package in EPEL. Package Change Request == Package Name: slowhttptest New Branches: el5 el6 epel7 Owners: dfateyev fab InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875299] Review Request: slowhttptest - An Application Layer DoS attack simulator
https://bugzilla.redhat.com/show_bug.cgi?id=875299 --- Comment #17 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875299] Review Request: slowhttptest - An Application Layer DoS attack simulator
https://bugzilla.redhat.com/show_bug.cgi?id=875299 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875299] Review Request: slowhttptest - An Application Layer DoS attack simulator
https://bugzilla.redhat.com/show_bug.cgi?id=875299 --- Comment #15 from Jon Ciesla limburg...@gmail.com --- Any comments from the Fedora maintainer? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875299] Review Request: slowhttptest - An Application Layer DoS attack simulator
https://bugzilla.redhat.com/show_bug.cgi?id=875299 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875299] Review Request: slowhttptest - An Application Layer DoS attack simulator
https://bugzilla.redhat.com/show_bug.cgi?id=875299 Denis Fateyev de...@fateyev.com changed: What|Removed |Added CC||de...@fateyev.com Flags|fedora-cvs+ |fedora-cvs? --- Comment #14 from Denis Fateyev de...@fateyev.com --- Package Change Request == Package Name: slowhttptest New Branches: el5 el6 epel7 Owners: dfateyev InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875299] Review Request: slowhttptest - An Application Layer DoS attack simulator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875299 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- slowhttptest-1.5-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SVtB8qr5Eja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875299] Review Request: slowhttptest - An Application Layer DoS attack simulator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875299 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-12-16 20:28:27 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YYlvYDzdKTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875299] Review Request: slowhttptest - An Application Layer DoS attack simulator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875299 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- slowhttptest-1.5-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iiSOmASbIea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875299] Review Request: slowhttptest - An Application Layer DoS attack simulator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875299 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875299] Review Request: slowhttptest - An Application Layer DoS attack simulator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875299 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875299] Review Request: slowhttptest - An Application Layer DoS attack simulator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875299 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- slowhttptest-1.5-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/slowhttptest-1.5-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875299] Review Request: slowhttptest - An Application Layer DoS attack simulator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875299 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- slowhttptest-1.5-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/slowhttptest-1.5-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875299] Review Request: slowhttptest - An Application Layer DoS attack simulator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875299 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875299] Review Request: slowhttptest - An Application Layer DoS attack simulator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875299 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- slowhttptest-1.5-1.fc17 has been pushed to the Fedora 17 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875299] Review Request: slowhttptest - An Application Layer DoS attack simulator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875299 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #6 from Fabian Affolter m...@fabian-affolter.ch --- Thanks for the review. (In reply to comment #5) There are warnings about comparing unsigned and signed integers. Maybe you can patch that and send it upstream! I will inform upstream about that. Please ask upstream to provide a license file. http://code.google.com/p/slowhttptest/issues/detail?id=16can=1 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875299] Review Request: slowhttptest - An Application Layer DoS attack simulator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875299 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Fabian Affolter m...@fabian-affolter.ch --- New Package SCM Request === Package Name: slowhttptest Short Description: An Application Layer DoS attack simulator Owners: fab Branches: F17 F18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875299] Review Request: slowhttptest - An Application Layer DoS attack simulator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875299 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added CC||volke...@gmx.at Assignee|nob...@fedoraproject.org|volke...@gmx.at Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875299] Review Request: slowhttptest - An Application Layer DoS attack simulator
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=875299
Volker Fröhlich volke...@gmx.at changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #5 from Volker Fröhlich volke...@gmx.at ---
Antonio, you should actually fill out this form!
There are warnings about comparing unsigned and signed integers. Maybe you can
patch that and send it upstream!
Please ask upstream to provide a license file.
=APPROVED=
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
= MUST items =
C/C++:
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm 4.4
[-]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[-]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Apache (v2.0). 1 files have unknown license. Detailed output of
licensecheck in
/media/speicher1/makerpm/rpmbuild/SPECS/875299-slowhttptest/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[-]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[-]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[!]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: Package functions as described.
Ran one of the tests from the manpage
[x]: Latest version is packaged.
[x]: Package does not include license text
[Bug 875299] Review Request: slowhttptest - An Application Layer DoS attack simulator
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=875299
--- Comment #4 from Fabian Affolter m...@fabian-affolter.ch ---
Thanks for your informal review.
(In reply to comment #2)
- In %setup you can use '%setup -q -n %{name}-%{version}'
Well, there is no benefit from using '-n %{name}-%{version}' in this case
because '-n %{name}-%{version}' is the default.
- According to Licensing Guide Lines [1], if the source package includes the
text of the license(s) in its own file, then that file, containing the text
of the license(s) for the package must be included in %doc. If the source
package does not include the text of the license(s), the packager should
contact upstream and encourage them to correct this mistake.
License seems indicated on slowstats.cc file.
http://code.google.com/p/slowhttptest/issues/detail?id=16thanks=16ts=1353075779
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875299] Review Request: slowhttptest - An Application Layer DoS attack simulator
https://bugzilla.redhat.com/show_bug.cgi?id=875299 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Blocks||563471 (FE-SECLAB) Alias||slowhttptest -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875299] Review Request: slowhttptest - An Application Layer DoS attack simulator
https://bugzilla.redhat.com/show_bug.cgi?id=875299 Antonio Trande trp...@katamail.com changed: What|Removed |Added CC||trp...@katamail.com --- Comment #1 from Antonio Trande trp...@katamail.com --- Hi Fabian. I'm not a packager so let me try an unofficial review of this package. ;) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875299] Review Request: slowhttptest - An Application Layer DoS attack simulator
https://bugzilla.redhat.com/show_bug.cgi?id=875299
--- Comment #2 from Antonio Trande trp...@katamail.com ---
- In %setup you can use '%setup -q -n %{name}-%{version}'
- According to Licensing Guide Lines [1], if the source package includes the
text of the license(s) in its own file, then that file, containing the text of
the license(s) for the package must be included in %doc. If the source package
does not include the text of the license(s), the packager should contact
upstream and encourage them to correct this mistake.
License seems indicated on slowstats.cc file.
[1]
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[?]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
Note: Using prebuilt packages
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: Using prebuilt rpms.
[-]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[ ]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm 4.4
[ ]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[?]: Package uses nothing in %doc for runtime.
[-]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[?]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[?]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Apache (v2.0). 1 files have unknown license. Detailed output of
licensecheck in /home/sagitter/rpmbuild/SRPMS/review-
slowhttptest/licensecheck.txt
[-]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[-]: Package must own all directories that it creates.
[-]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[ ]: Package is not relocatable.
[-]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[-]: Large documentation must go in a -doc subpackage.
[-]: Packages must not store files under /srv, /opt or /usr/local
Note: Cannot unpack rpms (using --prebuilt?)
= SHOULD items =
Generic:
[!]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[!]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[!]: Package does not include license text files separate from upstream.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX / PatchY prefixed with %{name}.
[x]: SourceX is a working
[Bug 875299] Review Request: slowhttptest - An Application Layer DoS attack simulator
https://bugzilla.redhat.com/show_bug.cgi?id=875299 --- Comment #3 from Antonio Trande trp...@katamail.com --- [x]: Reviewer should test that the package builds in mock. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
