[Bug 876915] Review Request: erlang-emmap - Erlang mmap interface
https://bugzilla.redhat.com/show_bug.cgi?id=876915 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||erlang-emmap-0-0.11.git05ae ||1bb.el7 Resolution|CURRENTRELEASE |ERRATA --- Comment #21 from Fedora Update System upda...@fedoraproject.org --- erlang-emmap-0-0.11.git05ae1bb.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876915] Review Request: erlang-emmap - Erlang mmap interface
https://bugzilla.redhat.com/show_bug.cgi?id=876915 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #18 from Peter Lemenkov lemen...@gmail.com --- Package Change Request == Package Name: erlang-emmap New Branches: epel7 Owners: peter InitialCC: erlang-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876915] Review Request: erlang-emmap - Erlang mmap interface
https://bugzilla.redhat.com/show_bug.cgi?id=876915 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876915] Review Request: erlang-emmap - Erlang mmap interface
https://bugzilla.redhat.com/show_bug.cgi?id=876915 --- Comment #19 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876915] Review Request: erlang-emmap - Erlang mmap interface
https://bugzilla.redhat.com/show_bug.cgi?id=876915 --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- erlang-emmap-0-0.11.git05ae1bb.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/erlang-emmap-0-0.11.git05ae1bb.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876915] Review Request: erlang-emmap - Erlang mmap interface
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876915 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- erlang-emmap-0-0.1.git8725d46.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WVLWY8QYSCa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876915] Review Request: erlang-emmap - Erlang mmap interface
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876915 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-12-06 02:08:15 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876915] Review Request: erlang-emmap - Erlang mmap interface
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876915 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- erlang-emmap-0-0.1.git8725d46.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876915] Review Request: erlang-emmap - Erlang mmap interface
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876915 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- erlang-emmap-0-0.1.git8725d46.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876915] Review Request: erlang-emmap - Erlang mmap interface
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876915 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876915] Review Request: erlang-emmap - Erlang mmap interface
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876915 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- erlang-emmap-0-0.1.git8725d46.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/erlang-emmap-0-0.1.git8725d46.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876915] Review Request: erlang-emmap - Erlang mmap interface
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876915 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- erlang-emmap-0-0.1.git8725d46.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/erlang-emmap-0-0.1.git8725d46.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876915] Review Request: erlang-emmap - Erlang mmap interface
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876915 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- erlang-emmap-0-0.1.git8725d46.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/erlang-emmap-0-0.1.git8725d46.el6 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876915] Review Request: erlang-emmap - Erlang mmap interface
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876915 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- erlang-emmap-0-0.1.git8725d46.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876915] Review Request: erlang-emmap - Erlang mmap interface
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876915 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876915] Review Request: erlang-emmap - Erlang mmap interface
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876915 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Can you fedpkg clone? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876915] Review Request: erlang-emmap - Erlang mmap interface
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876915 --- Comment #9 from Peter Lemenkov lemen...@gmail.com --- (In reply to comment #8) Can you fedpkg clone? Yes, I can. It got stuck during fedpkg import, at file uploading. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876915] Review Request: erlang-emmap - Erlang mmap interface
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876915 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Ok, I've re-created the git repo, try it now. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876915] Review Request: erlang-emmap - Erlang mmap interface
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876915 --- Comment #7 from Peter Lemenkov lemen...@gmail.com --- (In reply to comment #6) Fixed. Sorry, artifact of bad wifi on my end. :) Unfortunately there is still something wrong. I can't upload package via fedpkg import ~/rpmbuild/SRPMS/erlang-emmap-0-0.1.git8725d46.fc19.src.rpm . It got stuck at sulaco ~/work/FE/erlang-emmap (git::master): fedpkg import ~/rpmbuild/SRPMS/erlang-emmap-0-0.1.git8725d46.fc19.src.rpm Uploading: 293cb625db449fb83ea1a649eabd546f krestenkrab-emmap-8725d46.tar.gz -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876915] Review Request: erlang-emmap - Erlang mmap interface
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876915 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added CC||limburg...@gmail.com --- Comment #5 from Mario Blättermann mario.blaetterm...@gmail.com --- $ fedpkg clone erlang-emmap Klone nach 'erlang-emmap'... fatal: '/srv/git/rpms//erlang-emmap.git' does not appear to be a git repository fatal: The remote end hung up unexpectedly Could not execute clone: Command '['git', 'clone', 'ssh://mari...@pkgs.fedoraproject.org/erlang-emmap']' returned non-zero exit status 128 According to the tag fedora-cvs + the Git repo actually should exist. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876915] Review Request: erlang-emmap - Erlang mmap interface
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876915 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Fixed. Sorry, artifact of bad wifi on my end. :) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876915] Review Request: erlang-emmap - Erlang mmap interface
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=876915
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #3 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4713616
$ rpmlint -i -v *
erlang-emmap.i686: I: checking
erlang-emmap.i686: W: spelling-error Summary(en_US) mmap - map, m map, mamma
The value of this tag appears to be misspelled. Please double-check.
erlang-emmap.i686: I: checking-url https://github.com/krestenkrab/emmap
(timeout 10 seconds)
erlang-emmap.src: I: checking
erlang-emmap.src: W: spelling-error Summary(en_US) mmap - map, m map, mamma
The value of this tag appears to be misspelled. Please double-check.
erlang-emmap.src: I: checking-url https://github.com/krestenkrab/emmap (timeout
10 seconds)
erlang-emmap.src: W: invalid-url Source0: krestenkrab-emmap-8725d46.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.
erlang-emmap.x86_64: I: checking
erlang-emmap.x86_64: W: spelling-error Summary(en_US) mmap - map, m map, mamma
The value of this tag appears to be misspelled. Please double-check.
erlang-emmap.x86_64: I: checking-url https://github.com/krestenkrab/emmap
(timeout 10 seconds)
erlang-emmap-debuginfo.i686: I: checking
erlang-emmap-debuginfo.i686: I: checking-url
https://github.com/krestenkrab/emmap (timeout 10 seconds)
erlang-emmap-debuginfo.x86_64: I: checking
erlang-emmap-debuginfo.x86_64: I: checking-url
https://github.com/krestenkrab/emmap (timeout 10 seconds)
erlang-emmap.spec: W: invalid-url Source0: krestenkrab-emmap-8725d46.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.
5 packages and 1 specfiles checked; 0 errors, 5 warnings.
Nothing of interest anymore.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
ASL 2.0
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
f0a25e2deda7dc215524cc6348ef6037e7e22e89c0ca40a44e885c17d853f608
krestenkrab-emmap-8725d46.tar.gz
f0a25e2deda7dc215524cc6348ef6037e7e22e89c0ca40a44e885c17d853f608
krestenkrab-emmap-8725d46.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a
[Bug 876915] Review Request: erlang-emmap - Erlang mmap interface
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876915 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Peter Lemenkov lemen...@gmail.com --- Thanks Mario! New Package SCM Request === Package Name: erlang-emmap Short Description: Erlang mmap interface Owners: peter Branches: f17 f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876915] Review Request: erlang-emmap - Erlang mmap interface
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876915 --- Comment #2 from Peter Lemenkov lemen...@gmail.com --- (In reply to comment #1) %global git_tag 8725d46 but: * Tue Nov 13 2012 Peter Lemenkov lemen...@gmail.com - 0-0.1.gitd0ef891 It's the only issue worth to discuss. Ohh, sorry for that. Looks like a leftover from my previous experiments. * http://peter.fedorapeople.org/erlang-emmap.spec * http://peter.fedorapeople.org/erlang-emmap-0-0.1.git8725d46.fc19.src.rpm Also I added comments about patches. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876915] Review Request: erlang-emmap - Erlang mmap interface
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876915 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mario.blaetterm...@gmail.co ||m Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co ||m Alias||erlang-emmap Flags||fedora-review? --- Comment #1 from Mario Blättermann mario.blaetterm...@gmail.com --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4694218 $ rpmlint -i -v * erlang-emmap.i686: I: checking erlang-emmap.i686: W: spelling-error Summary(en_US) mmap - map, m map, mamma The value of this tag appears to be misspelled. Please double-check. erlang-emmap.i686: W: incoherent-version-in-changelog 0-0.1.gitd0ef891 ['0-0.1.git8725d46.fc19', '0-0.1.git8725d46'] The latest entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. erlang-emmap.i686: I: checking-url https://github.com/krestenkrab/emmap (timeout 10 seconds) erlang-emmap.src: I: checking erlang-emmap.src: W: spelling-error Summary(en_US) mmap - map, m map, mamma The value of this tag appears to be misspelled. Please double-check. erlang-emmap.src: I: checking-url https://github.com/krestenkrab/emmap (timeout 10 seconds) erlang-emmap.src: W: invalid-url Source0: krestenkrab-emmap-8725d46.tar.gz The value should be a valid, public HTTP, HTTPS, or FTP URL. erlang-emmap.x86_64: I: checking erlang-emmap.x86_64: W: spelling-error Summary(en_US) mmap - map, m map, mamma The value of this tag appears to be misspelled. Please double-check. erlang-emmap.x86_64: W: incoherent-version-in-changelog 0-0.1.gitd0ef891 ['0-0.1.git8725d46.fc19', '0-0.1.git8725d46'] The latest entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. erlang-emmap.x86_64: I: checking-url https://github.com/krestenkrab/emmap (timeout 10 seconds) erlang-emmap-debuginfo.i686: I: checking erlang-emmap-debuginfo.i686: I: checking-url https://github.com/krestenkrab/emmap (timeout 10 seconds) erlang-emmap-debuginfo.x86_64: I: checking erlang-emmap-debuginfo.x86_64: I: checking-url https://github.com/krestenkrab/emmap (timeout 10 seconds) erlang-emmap.spec: W: invalid-url Source0: krestenkrab-emmap-8725d46.tar.gz The value should be a valid, public HTTP, HTTPS, or FTP URL. 5 packages and 1 specfiles checked; 0 errors, 7 warnings. %global git_tag 8725d46 but: * Tue Nov 13 2012 Peter Lemenkov lemen...@gmail.com - 0-0.1.gitd0ef891 It's the only issue worth to discuss. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876915] Review Request: erlang-emmap - Erlang mmap interface
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876915 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Blocks||848423 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
