[Bug 877152] Review Request: springframework-ws - Spring Web Services
https://bugzilla.redhat.com/show_bug.cgi?id=877152 Fedora Update System changed: What|Removed |Added Fixed In Version|springframework-ws-2.1.1-1. |springframework-ws-2.1.1-1. |fc19|fc20 --- Comment #17 from Fedora Update System --- springframework-ws-2.1.1-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877152] Review Request: springframework-ws - Spring Web Services
https://bugzilla.redhat.com/show_bug.cgi?id=877152 gil cattaneo changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877152] Review Request: springframework-ws - Spring Web Services
https://bugzilla.redhat.com/show_bug.cgi?id=877152 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||springframework-ws-2.1.1-1. ||fc19 Resolution|--- |ERRATA Last Closed||2013-10-28 23:32:03 --- Comment #16 from Fedora Update System --- springframework-ws-2.1.1-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877152] Review Request: springframework-ws - Spring Web Services
https://bugzilla.redhat.com/show_bug.cgi?id=877152 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System --- springframework-ws-2.1.1-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877152] Review Request: springframework-ws - Spring Web Services
https://bugzilla.redhat.com/show_bug.cgi?id=877152 --- Comment #14 from Fedora Update System --- springframework-ws-2.1.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/springframework-ws-2.1.1-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877152] Review Request: springframework-ws - Spring Web Services
https://bugzilla.redhat.com/show_bug.cgi?id=877152 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877152] Review Request: springframework-ws - Spring Web Services
https://bugzilla.redhat.com/show_bug.cgi?id=877152 --- Comment #13 from Fedora Update System --- springframework-ws-2.1.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/springframework-ws-2.1.1-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877152] Review Request: springframework-ws - Spring Web Services
https://bugzilla.redhat.com/show_bug.cgi?id=877152 --- Comment #12 from gil cattaneo --- Thanks! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877152] Review Request: springframework-ws - Spring Web Services
https://bugzilla.redhat.com/show_bug.cgi?id=877152 --- Comment #11 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877152] Review Request: springframework-ws - Spring Web Services
https://bugzilla.redhat.com/show_bug.cgi?id=877152 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877152] Review Request: springframework-ws - Spring Web Services
https://bugzilla.redhat.com/show_bug.cgi?id=877152 gil cattaneo changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from gil cattaneo --- Thanks! New Package SCM Request === Package Name: springframework-ws Short Description: Spring Web Services Owners: gil Branches: f19 f20 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877152] Review Request: springframework-ws - Spring Web Services
https://bugzilla.redhat.com/show_bug.cgi?id=877152 --- Comment #9 from gil cattaneo --- (In reply to Orion Poplawski from comment #8) > I would like to see more comments on the various pom modifications, but this > is not a blocker. As a second party coming in it is hard to know why all of > the various things were done. Many are commented well, but some are not. > > I take it that 2.1.2 and 2.1.3 also are missing dependencies? In any case I > trust you to handle this as needed. Thanks for packaging this. > spring-ws-2.1.2.RELEASE 3.1.3.RELEASE for this one have packaged springframework 3.1.4.RELEASE http://gil.fedorapeople.org/springframework/springframework.spec http://gil.fedorapeople.org/springframework/springframework-3.1.4-1.fc19.src.rpm but there are some problem to solved before import: not support jopt-simple 4.x (rawhide) [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project spring-core: Compilation failure [ERROR] org.springframework.core/src/main/java/org/springframework/core/env/JOptCommandLinePropertySource.java:[103,54] incompatible types [ERROR] required: java.util.List [ERROR] found:java.util.List [ERROR] -> [Help 1] not support derby > 10.5 unavailable method purgeDatabase in org.apache.derby.impl.io.VFMemoryStorageFactory 2.1.3.RELEASE 3.2.2.RELEASE -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877152] Review Request: springframework-ws - Spring Web Services
https://bugzilla.redhat.com/show_bug.cgi?id=877152
Orion Poplawski changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #8 from Orion Poplawski ---
I would like to see more comments on the various pom modifications, but this is
not a blocker. As a second party coming in it is hard to know why all of the
various things were done. Many are commented well, but some are not.
I take it that 2.1.2 and 2.1.3 also are missing dependencies? In any case I
trust you to handle this as needed. Thanks for packaging this.
APPROVED
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Apache (v2.0)", "Unknown or generated". 7 files have unknown license.
Detailed output of licensecheck in /export/home/orion/redhat
/springframework-ws-2.1.1/review-springframework-ws/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It is
pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
[x]: Bundled jar/class files should be removed before build
Maven:
[x]: If package contains pom.xml files install it (including depmaps) even
when building with ant
[x]: If tests are skipped during package build explain why it was needed in a
comment
Note: Tests seem to be skipped. Verify there is a commme
[Bug 877152] Review Request: springframework-ws - Spring Web Services
https://bugzilla.redhat.com/show_bug.cgi?id=877152 --- Comment #7 from gil cattaneo --- (In reply to gil cattaneo from comment #6) > latest release depend on springframework >= 3.2.4.RELEASE and springframework > 3.1.4.RELEASE depend on cglib >= 3.0 (unavailable see https://bugzilla.redhat.com/show_bug.cgi?id=815394) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877152] Review Request: springframework-ws - Spring Web Services
https://bugzilla.redhat.com/show_bug.cgi?id=877152 --- Comment #6 from gil cattaneo --- latest release depend on springframework >= 3.2.4.RELEASE -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877152] Review Request: springframework-ws - Spring Web Services
https://bugzilla.redhat.com/show_bug.cgi?id=877152 --- Comment #5 from gil cattaneo --- (In reply to Orion Poplawski from comment #4) > Some initial comments: > > - 2.1.4 is out latest release depend on springframework >= 3.2.2.RELEASE we have 3.1.1 > - I see both springframework-* and spring-* packages. I think this should > be called spring-ws. see https://bugzilla.redhat.com/show_bug.cgi?id=881753#c5 > - Perhaps http://projects.spring.io/spring-ws/ is a better URL fixed Spec URL: http://gil.fedorapeople.org/springframework-ws.spec SRPM URL: http://gil.fedorapeople.org/springframework-ws-2.1.1-1.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877152] Review Request: springframework-ws - Spring Web Services
https://bugzilla.redhat.com/show_bug.cgi?id=877152 Orion Poplawski changed: What|Removed |Added Status|NEW |ASSIGNED CC||or...@cora.nwra.com Assignee|nob...@fedoraproject.org|or...@cora.nwra.com --- Comment #4 from Orion Poplawski --- Some initial comments: - 2.1.4 is out - I see both springframework-* and spring-* packages. I think this should be called spring-ws. - Perhaps http://projects.spring.io/spring-ws/ is a better URL -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877152] Review Request: springframework-ws - Spring Web Services
https://bugzilla.redhat.com/show_bug.cgi?id=877152 --- Comment #3 from gil cattaneo --- Spec URL: http://gil.fedorapeople.org/springframework-ws.spec SRPM URL: http://gil.fedorapeople.org/springframework-ws-2.1.1-1.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=f66ufPLTB7&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877152] Review Request: springframework-ws - Spring Web Services
https://bugzilla.redhat.com/show_bug.cgi?id=877152 gil cattaneo changed: What|Removed |Added Blocks||968136 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hqNbYoy2vG&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877152] Review Request: springframework-ws - Spring Web Services
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877152 --- Comment #2 from gil cattaneo --- Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=5366013 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2gMYgxPAZX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877152] Review Request: springframework-ws - Spring Web Services
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877152 --- Comment #1 from gil cattaneo --- Spec URL: http://gil.fedorapeople.org/springframework-ws.spec SRPM URL: http://gil.fedorapeople.org/springframework-ws-2.1.1-1.fc16.src.rpm - update to 2.1.1.RELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wQl44mN45d&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877152] Review Request: springframework-ws - Spring Web Services
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877152 Bug 877152 depends on bug 877114, which changed state. Bug 877114 Summary: Review Request: smack - Open Source XMPP (Jabber) client library https://bugzilla.redhat.com/show_bug.cgi?id=877114 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LcX6mWHm3B&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877152] Review Request: springframework-ws - Spring Web Services
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877152 gil cattaneo changed: What|Removed |Added Blocks||881753 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877152] Review Request: springframework-ws - Spring Web Services
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877152 gil cattaneo changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877152] Review Request: springframework-ws - Spring Web Services
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877152 gil cattaneo changed: What|Removed |Added Depends On||877114 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
