[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
https://bugzilla.redhat.com/show_bug.cgi?id=877651 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||sagemath-5.9-5.fc18 --- Comment #93 from Fedora Update System upda...@fedoraproject.org --- sagemath-5.9-5.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=s4DhEJso53a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #92 from Fedora Update System upda...@fedoraproject.org --- sagemath-5.9-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/sagemath-5.9-5.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vSMiXDi9U1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #91 from Fedora Update System upda...@fedoraproject.org --- sagemath-5.8-7.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YR2am1o3cHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | --- Comment #88 from Rex Dieter rdie...@math.unl.edu --- upgraded to 5.8-7, seeing some scriptlet errors: Cleanup: sagemath-core-5.8-6.fc18.x86_64 85/111 /sbin/ldconfig: relative path `1' used to build cache warning: %postun(sagemath-core-5.8-6.fc18.x86_64) scriptlet failed, exit status 1 Non-fatal POSTUN scriptlet failure in rpm package sagemath-core-5.8-6.fc18.x86_64 Cleanup: sagemath-notebook-5.8-6.fc18.x86_64 86/111 Cleanup: sagemath-rubiks-5.8-6.fc18.x86_64 87/111 Cleanup: sagemath-sagetex-5.8-6.fc18.x86_64 88/111 mktexlsr: /var/tmp/rpm-tmp.FWNuUJ: not a directory, skipping. mktexlsr: 1: not a directory, skipping. Cleanup: sagemath-5.8-6.fc18.x86_64 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qk9pLeC6f0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC||package-review@lists.fedora ||project.org -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DZXtFqYjhEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com changed: What|Removed |Added Status|ON_QA |ASSIGNED --- Comment #89 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- Thanks, just learned another rpm feature :-) It should not use %post -p, or remove comments, example: --%-- %postun core -p /sbin/ldconfig # Use symlinks and a minor patch to the notebook to not bundle jmol %postnotebook --%-- and then: --%-- $ rpm -q --scripts sagemath-core postinstall program: /sbin/ldconfig postuninstall scriptlet (using /sbin/ldconfig): # Use symlinks and a minor patch to the notebook to not bundle jmol --%-- it is adding '#' as ldconfig argument. Should rewrite as: %postun core /sbin/ldconfig exit 0 or remove the comment before the notebook subpackage %post Maybe the correct approach is to patch rpm, as it appears opensuse fixed it recently, there is a comment about it in http://en.opensuse.org/openSUSE:Packaging_scriptlet_snippets But in the meantime I will keep this as a todo for the next build, as the error is not fatal. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ehOJw8uZGpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |ERRATA Last Closed||2013-04-27 23:51:07 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ROUeLA7IIla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #90 from Fedora Update System upda...@fedoraproject.org --- sagemath-5.8-7.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eY5KDUDrtta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GWx04c2ta0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #79 from Fedora Update System upda...@fedoraproject.org --- sagemath-5.8-6.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/sagemath-5.8-6.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UU7bgPVOS0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #80 from Fedora Update System upda...@fedoraproject.org --- sagemath-5.8-6.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/sagemath-5.8-6.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OdsFEJ8LSfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PHYo7LW8pba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #81 from Fedora Update System upda...@fedoraproject.org --- sagemath-5.8-6.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FdN4QUzrD0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC||rdie...@math.unl.edu --- Comment #82 from Rex Dieter rdie...@math.unl.edu --- Everyone involved in helping make this review happen has my (and users where I work) eternal gratitude. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cLDFtJmZlna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com changed: What|Removed |Added Status|ON_QA |ASSIGNED --- Comment #83 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- (In reply to comment #70) (In reply to comment #67) Actually, there may be a problem right now, updating my test environment, as it may very likely be that it works with ipython-0.13.1 but not ipython-0.13.2. Will know it shortly. Honestly I think that this bug is unrelated to ipython. Looking into the backtrace we see the following: # The above hopefully was wishful thinking: - 1336 return inspect.ArgSpec(*_sage_getargspec_cython(sage_getsource(obj))) So it seems that the above *was not* wishful thinking. :-) this then fails because sage_getsource(obj) returns None. I now did try to reproduce as close as possible what an end user would do, and can now reproduce the problem. I will make an update, sorry for the problem. In the meantime, it should work if you install sagemath-devel, *or*, run something like: $ sudo ln -sf /usr/lib64/python2.7/site-packages /usr/lib64/sagemath/devel/sage It is just a missing symlink provided by the -devel package, and of course I always had the -devel package installed :-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1DBo2qbSoda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #84 from José Matos jama...@fc.up.pt --- That was my B plan. To install the -devel sub-package. :-) But then I got distracted. :-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=24iO3IJ1LAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #85 from Fedora Update System upda...@fedoraproject.org --- sagemath-5.8-7.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/sagemath-5.8-7.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8j6fD8cW9sa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #86 from Fedora Update System upda...@fedoraproject.org --- sagemath-5.8-7.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/sagemath-5.8-7.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vhRhGIlfDLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0aYQqkzVdaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #87 from Fedora Update System upda...@fedoraproject.org --- sagemath-5.8-6.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YG37OBzQWwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kD68ku7M55a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #75 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mR35ENz0eea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=877651
--- Comment #76 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com
---
(In reply to comment #72)
(In reply to comment #63)
Should I keep this chunk btw? Same issue as other review:
---%---
%post
/bin/touch --no-create %{_datadir}/icons/hicolor /dev/null || :
%postun
if [ $1 -eq 0 ] ; then
/bin/touch --no-create %{_datadir}/icons/hicolor /dev/null
/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor /dev/null ||
:
fi
%posttrans
/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor /dev/null || :
---%---
because the icon is actually installed under %{_datadir}/pixmaps, or
should the icon be moved elsewhere (under %{_datadir}/pixmaps).
You don't need this for an icon installed in %{_datadir}/pixmaps. I don't
yet understand the relative merits of installing an icon in
%{_datadir}/pixmaps versus %{_datadir}/icons/hicolor. If somebody out there
knows, please share that information.
I am about to upload it to git now. Only change was release bump and
removal of that chunk.
- Remove noop icon cache regeneration scriplets (#877651#72)
- First Fedora 18 and Fedora 19 approved package
I believe installing in %{_datadir}/pixmaps is kind of KISS,
possibly with some extra runtime overhead, because there are
way too many subdirectories under %{_datadir}/icons, for
different themes, categories, resolutions, etc.
Following some links, this should be the simplest usage
http://standards.freedesktop.org/icon-theme-spec/latest/ar01s07.html
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=GajNenZ6nAa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #77 from Germano Massullo germano.massu...@gmail.com --- What about enabling SageMath to python-pp usage? Is it possible? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BrCmNkvEz8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #78 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- (In reply to comment #77) What about enabling SageMath to python-pp usage? Is it possible? I think this is a task for upstream sagemath :-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UAvNGcZlK8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #71 from José Matos jama...@fc.up.pt --- Jerry FWIW I think that this package is in a state where it is ready to be approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MgBKeQHWc7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=877651
Jerry James loganje...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #72 from Jerry James loganje...@gmail.com ---
(In reply to comment #63)
Should I keep this chunk btw? Same issue as other review:
---%---
%post
/bin/touch --no-create %{_datadir}/icons/hicolor /dev/null || :
%postun
if [ $1 -eq 0 ] ; then
/bin/touch --no-create %{_datadir}/icons/hicolor /dev/null
/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor /dev/null || :
fi
%posttrans
/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor /dev/null || :
---%---
because the icon is actually installed under %{_datadir}/pixmaps, or
should the icon be moved elsewhere (under %{_datadir}/pixmaps).
You don't need this for an icon installed in %{_datadir}/pixmaps. I don't yet
understand the relative merits of installing an icon in %{_datadir}/pixmaps
versus %{_datadir}/icons/hicolor. If somebody out there knows, please share
that information.
(In reply to comment #71)
Jerry FWIW I think that this package is in a state where it is ready to be
approved.
Thanks, I do, too. This package is APPROVED.(In reply to comment #64)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=2B1rap18b2a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #73 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- (In reply to comment #72) (In reply to comment #63) (In reply to comment #71) Jerry FWIW I think that this package is in a state where it is ready to be approved. Thanks, I do, too. This package is APPROVED.(In reply to comment #64) Thanks! I have been updating and keeping it more or less working in fedora for a year. There are some known issues, but it should pass over 90% of the doctests, and once having it official, hopefully upstream will help more in making it easier for distros to package it incorporated in the base system. Time to comemorate :-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UcWAtSeV8pa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #74 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- New Package SCM Request === Package Name: sagemath Short Description: A free open-source mathematics software system Owners: pcpa Branches: f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=s6UX9EXmYea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #69 from José Matos jama...@fc.up.pt --- (In reply to comment #66) Does the same problem happen if starting from an already open terminal? Works for me opening from kde menu. It fails in any case. My purpose here is just to test sagemath under a normal scenario. Maybe there is some dependency problem with the subpackages. What does rpm -qa | grep sagemath show? # rpm -qa | grep sagemath sagemath-core-5.8-2.fc19.x86_64 sagemath-5.8-2.fc19.x86_64 sagemath-data-graphs-5.8-2.fc19.noarch sagemath-rubiks-5.8-2.fc19.x86_64 sagemath-data-5.8-2.fc19.noarch sagemath-data-extcode-5.8-2.fc19.noarch sagemath-data-polytopes_db-5.8-2.fc19.noarch sagemath-doc-5.8-2.fc19.noarch sagemath-data-elliptic_curves-5.8-2.fc19.noarch sagemath-data-conway_polynomials-5.8-2.fc19.noarch sagemath-doc-en-5.8-2.fc19.noarch sagemath-sagetex-5.8-2.fc19.x86_64 sagemath-notebook-5.8-2.fc19.x86_64 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=M4NqzeautFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #70 from José Matos jama...@fc.up.pt --- (In reply to comment #67) Actually, there may be a problem right now, updating my test environment, as it may very likely be that it works with ipython-0.13.1 but not ipython-0.13.2. Will know it shortly. Honestly I think that this bug is unrelated to ipython. Looking into the backtrace we see the following: # The above hopefully was wishful thinking: - 1336 return inspect.ArgSpec(*_sage_getargspec_cython(sage_getsource(obj))) So it seems that the above *was not* wishful thinking. :-) this then fails because sage_getsource(obj) returns None. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BYXlqAYn4Sa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #65 from José Matos jama...@fc.up.pt --- Created attachment 735989 -- https://bugzilla.redhat.com/attachment.cgi?id=735989action=edit Crash report of sage I took the last srpm and I have used mock to rebuild it for Fedora 19. Installing the resulting rpms, via yum install sagemath worked. As soon as I start sagemath from the menu I get this crash with the corresponding crash report. My purpose here is just to test sagemath under a normal scenario. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gPmS1qathHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #66 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- (In reply to comment #65) Hopefully it should be some simple issue, as I do not see any problems, but I am currently only testing in f18 and rawhide. Created attachment 735989 [details] Crash report of sage I took the last srpm and I have used mock to rebuild it for Fedora 19. Installing the resulting rpms, via yum install sagemath worked. As soon as I start sagemath from the menu I get this crash with the corresponding crash report. Does the same problem happen if starting from an already open terminal? Works for me opening from kde menu. My purpose here is just to test sagemath under a normal scenario. Maybe there is some dependency problem with the subpackages. What does rpm -qa | grep sagemath show? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bt6bJCfZZFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #67 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- Actually, there may be a problem right now, updating my test environment, as it may very likely be that it works with ipython-0.13.1 but not ipython-0.13.2. Will know it shortly. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dkyxj5VO5ha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #68 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- Just did a build with up to date rawhide and could not find any problems. I will try to create a f19 test environment later but for now it works for me on f18 and rawhide. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RfJlVGOcRIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=877651
--- Comment #64 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com
---
(In reply to comment #63)
(In reply to comment #61)
I am a bit unsure if using GPL is valid as license, but I added it
due to (http://www.wrongway.org/?rubiksource):
---%---
The source code for my various rubik solvers are freely available. They are,
for the moment, released GPL (e.g., free to distribute and modify but it and
its derivitives must always remain free and open source).
---%---
If no specific version of the GPL is specified, then the license tag should
contain GPL+. See the entry for GNU General Public License (no version)
here:
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses.
I changed to GPL+.
This should not go in the final package. Just remind me, or
yourself if you wish about ensuring those pretrans and posttrans
are removed once the package is approved :-)
I'm probably going to remind you very, very soon now, then, because I think
this package is ready. Fix the license tag as noted above and ... there
isn't anything else holding this package back, right? All of the bundled
stuff has been granted exceptions. I can't come up with anything else that
is blocking approval, but the package is so large and complex that I'll wait
a short time for comments before I approve it.
Should I keep this chunk btw? Same issue as other review:
---%---
%post
/bin/touch --no-create %{_datadir}/icons/hicolor /dev/null || :
%postun
if [ $1 -eq 0 ] ; then
/bin/touch --no-create %{_datadir}/icons/hicolor /dev/null
/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor /dev/null || :
fi
%posttrans
/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor /dev/null || :
---%---
because the icon is actually installed under %{_datadir}/pixmaps, or
should the icon be moved elsewhere (under %{_datadir}/pixmaps).
Not uploading a new src.rpm because it takes at least one hour
in my DSL (upload is very slow), but here is the spec diff for now:
---%---
--- SPECS/sagemath.spec.orig2013-04-14 15:36:46.068616049 -0300
+++ SPECS/sagemath.spec2013-04-14 15:42:09.567628437 -0300
@@ -74,11 +74,11 @@
Group:Applications/Engineering
Summary:A free open-source mathematics software system
Version:5.8
-Release:2%{?dist}
+Release:3%{?dist}
# The file ${SAGE_ROOT}/COPYING.txt is the upstream license breakdown file
# Additionally, every $files section has a comment with the license name
# before files with that license
-License:ASL 2.0 and BSD and GPLv2+ and LGPLv2+ and MIT and Public Domain
+License:ASL 2.0 and BSD and GPL+ and GPLv2+ and LGPLv2+ and MIT and Public
Domain
URL:http://www.sagemath.org
%if %{download_tarball}
Source0:
http://boxen.math.washington.edu/home/%{name}/sage-mirror/src/sage-%{version}.tar
@@ -1151,24 +1151,8 @@
%postun core -p /sbin/ldconfig
-%pretransdata
-# temporary due to moving directory to symlink when changing data to noarch
-if [ -d %{SAGE_ROOT}/share -a ! -e %{SAGE_SHARE} ]; then
-mv %{SAGE_ROOT}/share %{SAGE_SHARE}
-ln -s %{SAGE_SHARE} %{SAGE_ROOT}/share
-fi
-
-%pretransdoc
-# temporary due to moving directory to symlink when changing data to noarch
-if [ -d %{SAGE_ROOT}/devel/doc -a ! -e %{SAGE_DOC} ]; then
-mv %{SAGE_ROOT}/devel/doc %{SAGE_DOC}
-ln -s %{SAGE_DOC} %{SAGE_ROOT}/devel/doc
-fi
-
-# Note this should be a plain %%post but make a %%posttrans for
-# a small window of time to allow clean upgrades, as previously
-# the (broken) links were added to the package.
-%posttransnotebook
+# Use symlinks and a minor patch to the notebook to not bundle jmol
+%postnotebook
ln -sf %{_javadir}/JmolApplet.jar %{python_sitearch}/sagenb/data/jmol/
ln -sf %{_javadir}/vecmath.jar %{python_sitearch}/sagenb/data/jmol/
@@ -1255,7 +1239,7 @@
#
%filesdata-polytopes_db
-# GPL
+# GPL+
%{SAGE_SHARE}/reflexive_polytopes
#
@@ -1374,12 +1358,12 @@
#
%filesrubiks
-# GPL
+# GPL+
%{SAGE_LOCAL}/bin/optimal
# MIT
%{SAGE_LOCAL}/bin/dikcube
%{SAGE_LOCAL}/bin/size222
-# GPL
+# GPL+
%{SAGE_LOCAL}/bin/cu2
%{SAGE_LOCAL}/bin/cubex
%{SAGE_LOCAL}/bin/mcube
@@ -1393,6 +1377,10 @@
%changelog
+* Sun Apr 14 2013 pcpa paulo.cesar.pereira.de.andr...@gmail.com - 5.8-3
+- Use proper license tag for non versioned GPL attribution (#877651#63)
+- Remove no longer required workarounds for clean upgrades (#877651#63)
+
* Fri Apr 12 2013 pcpa paulo.cesar.pereira.de.andr...@gmail.com - 5.8-2
- Properly describe the license breakdown in the spec (#877651#60)
- Correct lrslib requires to lrslib-utils
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #63 from Jerry James loganje...@gmail.com --- (In reply to comment #61) I am a bit unsure if using GPL is valid as license, but I added it due to (http://www.wrongway.org/?rubiksource): ---%--- The source code for my various rubik solvers are freely available. They are, for the moment, released GPL (e.g., free to distribute and modify but it and its derivitives must always remain free and open source). ---%--- If no specific version of the GPL is specified, then the license tag should contain GPL+. See the entry for GNU General Public License (no version) here: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses. This should not go in the final package. Just remind me, or yourself if you wish about ensuring those pretrans and posttrans are removed once the package is approved :-) I'm probably going to remind you very, very soon now, then, because I think this package is ready. Fix the license tag as noted above and ... there isn't anything else holding this package back, right? All of the bundled stuff has been granted exceptions. I can't come up with anything else that is blocking approval, but the package is so large and complex that I'll wait a short time for comments before I approve it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4WD2nsiMwta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=877651
--- Comment #61 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com
---
(In reply to comment #60)
I won't post the full output of fedora-review again, just a short list of
items to be addressed. We're almost there!
First, lrslib is listed as a Requires. The lrslib package contains only the
library. It looks like the lrs program is needed by
sage/geometry/polyhedron/base.py. In that case, the Requires should be for
lrslib-utils instead.
Fixed.
Second, the license breakdown still needs to be explained in a comment:
https://fedoraproject.org/wiki/Packaging:
LicensingGuidelines#Multiple_Licensing_Scenarios
I know you said the license breakdown is available elsewhere, but it needs
to appear in the spec file, too.
I belive I was missing only the comment about the breakdown before
the License tag line, so, should be fixed now.
I am a bit unsure if using GPL is valid as license, but I added it
due to (http://www.wrongway.org/?rubiksource):
---%---
The source code for my various rubik solvers are freely available. They are,
for the moment, released GPL (e.g., free to distribute and modify but it and
its derivitives must always remain free and open source).
---%---
Third, I did not make my meaning clear with the comment about one-line
scripts. You should have this:
%post sagetex -p %{_bindir}/mktexlsr
%postun sagetex -p %{_bindir}/mktexlsr
Note the use of -p. That allows RPM to invoke the program directly, rather
than spawning a shell to run the contents of the script. See
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Syntax.
Fixed.
Fourth, there is some new output from rpmlint that should be reviewed. Can
you take a look at these to see which are real issues that need to be
addressed?
sagemath-core.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libcsage.so.0 /lib64/libm.so.6
I prefer to keep this in case there are a few of these python modules
$ rpm -ql sagemath-core | grep '.so$' | wc -l
339
that do not really need to link to libcsage.so
sagemath-core.x86_64: E: zero-length
/usr/lib64/python2.7/site-packages/sage/server/notebook/compress/all.py
sagemath-core.x86_64: E: zero-length
/usr/lib64/python2.7/site-packages/sage/misc/test_cpickle_sage.py
Removed in %install for the sake of silencing the warning.
sagemath-core.x86_64: W: dangling-symlink /usr/lib64/sagemath/devel/sage
/usr/lib64/python2.7/site-packages
Fixed by moving the symlink to the -devel package.
sagemath-core.x86_64: E: zero-length
/usr/lib64/python2.7/site-packages/sage/libs/pari/to_gen.pxi
sagemath-data-extcode.noarch: W: dangling-symlink
/usr/share/sagemath/extcode/sage /usr/lib64/python2.7/site-packages
I reworked the requires to have the symlink owned by the
sagemath-data package, and add explicitly requires to the
main package from sagemath-data. But it appears to not
silence the warning, as I thought it was caused by the
case of:
a.bin - requires package that provides /lib/foo
a.noarch - has symlink to /lib/foo
a.bin - requires a.noarch
a.noarch - does not require a.bin
so, what I did was to make a.noarch require a.bin , but
the warning remained.
sagemath-doc.noarch: W: only-non-binary-in-usr-lib
sagemath-doc.noarch: W: doc-file-dependency
/usr/share/doc/sagemath-5.8/common/update-python-inv.sh /usr/bin/env
sagemath-doc.noarch: W: doc-file-dependency
/usr/share/doc/sagemath-5.8/common/builder.py /usr/bin/env
These are kind of documentation files also, that happen to be usable
as scripts. Documentation is not supposed to be regenerated from
installed packages, but possible with some tweaks.
sagemath-doc-en.noarch: W: spurious-executable-perm
/usr/share/doc/sagemath-5.8/en/prep/media/Rplot001.png
Fixed.
sagemath-data.noarch: W: dangerous-command-in-%pretrans mv
sagemath-doc.noarch: W: dangerous-command-in-%pretrans mv
sagemath-notebook.x86_64: W: dangerous-command-in-%postun rm
sagemath-notebook.x86_64: W: dangerous-command-in-%posttrans ln
I am keeping these a bit more for the sake of making clean upgrades
after changing base dir to %{_libdir} for arch specific files, and
after changing doc/data subpackages to noarch. This should be the
last build with it, as I assume people using my f18 repository
have upgraded to the latest version.
This should not go in the final package. Just remind me, or
yourself if you wish about ensuring those pretrans and posttrans
are removed once the package is approved :-)
sagemath-rubiks.x86_64: W: spelling-error %description -l en_US contributers
- contributes, contributors, contribute rs
This is text from sagemath spkg.txt, I changed the spec for the
sake of not having this warning again.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=Cka0BCFziha=cc_unsubscribe
___
package-review mailing list
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #62 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- Update: - Properly describe the license breakdown in the spec (#877651#60) - Correct lrslib requires to lrslib-utils (#877651#60) - Remove zero length files (#877651#60) - Correct png file with executable permission (#877651#60) - Avoid rpmlint warning in rubiks subpackage description (#877651#60) Spec URL: http://pcpa.fedorapeople.org/sagemath.spec SRPM URL: http://pcpa.fedorapeople.org/sagemath/SRPMS/sagemath-5.8-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dC78wUBjA7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=877651
--- Comment #60 from Jerry James loganje...@gmail.com ---
I won't post the full output of fedora-review again, just a short list of items
to be addressed. We're almost there!
First, lrslib is listed as a Requires. The lrslib package contains only the
library. It looks like the lrs program is needed by
sage/geometry/polyhedron/base.py. In that case, the Requires should be for
lrslib-utils instead.
Second, the license breakdown still needs to be explained in a comment:
https://fedoraproject.org/wiki/Packaging:
LicensingGuidelines#Multiple_Licensing_Scenarios
I know you said the license breakdown is available elsewhere, but it needs to
appear in the spec file, too.
Third, I did not make my meaning clear with the comment about one-line scripts.
You should have this:
%post sagetex -p %{_bindir}/mktexlsr
%postun sagetex -p %{_bindir}/mktexlsr
Note the use of -p. That allows RPM to invoke the program directly, rather
than spawning a shell to run the contents of the script. See
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Syntax.
Fourth, there is some new output from rpmlint that should be reviewed. Can you
take a look at these to see which are real issues that need to be addressed?
sagemath-core.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libcsage.so.0 /lib64/libm.so.6
sagemath-core.x86_64: E: zero-length
/usr/lib64/python2.7/site-packages/sage/server/notebook/compress/all.py
sagemath-core.x86_64: E: zero-length
/usr/lib64/python2.7/site-packages/sage/misc/test_cpickle_sage.py
sagemath-core.x86_64: W: dangling-symlink /usr/lib64/sagemath/devel/sage
/usr/lib64/python2.7/site-packages
sagemath-core.x86_64: E: zero-length
/usr/lib64/python2.7/site-packages/sage/libs/pari/to_gen.pxi
sagemath-data.noarch: W: dangerous-command-in-%pretrans mv
sagemath-data-extcode.noarch: W: dangling-symlink
/usr/share/sagemath/extcode/sage /usr/lib64/python2.7/site-packages
sagemath-doc.noarch: W: only-non-binary-in-usr-lib
sagemath-doc.noarch: W: doc-file-dependency
/usr/share/doc/sagemath-5.8/common/update-python-inv.sh /usr/bin/env
sagemath-doc.noarch: W: doc-file-dependency
/usr/share/doc/sagemath-5.8/common/builder.py /usr/bin/env
sagemath-doc.noarch: W: dangerous-command-in-%pretrans mv
sagemath-doc-en.noarch: W: spurious-executable-perm
/usr/share/doc/sagemath-5.8/en/prep/media/Rplot001.png
sagemath-notebook.x86_64: W: dangerous-command-in-%postun rm
sagemath-notebook.x86_64: W: dangerous-command-in-%posttrans ln
sagemath-rubiks.x86_64: W: spelling-error %description -l en_US contributers -
contributes, contributors, contribute rs
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=UDPl4epC7pa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #58 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- Jerry, there is no pending fpc issue now in https://fedorahosted.org/fpc/ticket/238 Please review it again. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pvgaw7beQ9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #59 from Jerry James loganje...@gmail.com --- Oh, great! I have a full workload tonight already, but I should be able to do this first thing tomorrow. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=y73acLbIh5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #57 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- Update: - Update to sagemath 5.8. - Do full cleanup of notebook package on uninstall. - Remove with_sage_cython build conditional. - Remove with_sage_networkx build conditional. - Add nopari2.6 patch to not rely on not yet available interfaces. - Add cryptominisat patch to build package in f18. Spec URL: http://pcpa.fedorapeople.org/sagemath.spec SRPM URL: http://pcpa.fedorapeople.org/sagemath/SRPMS/sagemath-5.8-1.fc20.src.rpm The nopari2.6 is a simple patch due to using features from the upcoming pari 2.6 in the patched pari.spkg. The cryptominisat patch is because it now requires cryptominisat 2.9.6 and does not build with f18 cryptominisat 2.9.5. Remaining changes, not worth to add to changelog, or that I forgot to :-), are patch rediffs, minor corrections to documentation build and adding ldconfig to post and postun. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ymjfiVdztea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=877651
--- Comment #56 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com
---
(In reply to comment #55)
(In reply to comment #54)
- Create jmol symbolic links in post and remove in postun.
Oops, sorry, I did not mean to push you in this direction. I just didn't
realize we were dealing with symbolic links. I think the way you had it
(with the symlinks owned by the package) was better than this approach.
- Disable libgap by default as it does not work with rawhide gap.
Can you tell me what the problem is? Is it something I can fix on the gap
side?
I think libgap should be built at the same time as gap, or coordinate
to not have libgap not matching gap. Volker Braun commented about it
in
https://bitbucket.org/vbraun/libgap/issue/1/please-make-tarball-downloads-available
and pointed to the same problem in upstream sagemath in
http://trac.sagemath.org/14039
I will do a thorough review tomorrow. Sorry for the delay.
No problems. What I want to change next was that I only figured
the missing post and postun of ldconfig after building the
latest srpm, and another issue is that removing the symbolic
links in %postun causes it to leave empty directory
%{python_sitearch}/site-packages/sagenb/data/jmol/
but removes all java related rpmlint warnings...
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=9KQCwzzzFCa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #55 from Jerry James loganje...@gmail.com --- (In reply to comment #54) - Create jmol symbolic links in post and remove in postun. Oops, sorry, I did not mean to push you in this direction. I just didn't realize we were dealing with symbolic links. I think the way you had it (with the symlinks owned by the package) was better than this approach. - Disable libgap by default as it does not work with rawhide gap. Can you tell me what the problem is? Is it something I can fix on the gap side? I will do a thorough review tomorrow. Sorry for the delay. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ViGNmaFbJya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #54 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- Sorry for the delay with another srpm. I preferred to use the simpler canonical python-ipython name. Jerry, please review it :-) Update: - Create jmol symbolic links in post and remove in postun. - Disable libgap by default as it does not work with rawhide gap. - Also add python-ipython to build requires to regenerate documentation. - Add missing python-ipython requires (#877651#52) - Enable libgap build in packager debug build (#877651#52) Spec URL: http://pcpa.fedorapeople.org/sagemath.spec SRPM URL: http://pcpa.fedorapeople.org/sagemath/SRPMS/sagemath-5.7-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PKdfYCyaeza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #53 from Jerry James loganje...@gmail.com --- Does it need python-ipython, or merely python-ipython-console? (The only uses I have found so far need the latter, not the former.) And I echo comment 50. You've done a LOT of work on this package. Give yourself a pat on the back. :-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sSrAENzbrpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 Volker Braun vbr...@physics.upenn.edu changed: What|Removed |Added CC||vbr...@physics.upenn.edu --- Comment #51 from Volker Braun vbr...@physics.upenn.edu --- Requires ipython, but that is missing in the spec file. (as reported on sage-support https://groups.google.com/d/topic/sage-support/MT1jKJLm1eg/discussion) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=whhyeuOCW0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #52 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- Thanks for tests and comments. I will add ipython as Requires for the next build (forgot about it because it is the first sagemath package using system ipython), that should also have an option to build with libgap :-) https://bitbucket.org/vbraun/libgap/issue/1/please-make-tarball-downloads-available -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AM3E1lUJCxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #49 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- Update: - Update to sagemath 5.7. - Add conditional patch for libgap. - Add conditional patch for fes. - Remove with_sage_ipython conditional. - Add patch to create a libcsage with a soname. Spec URL: http://pcpa.fedorapeople.org/sagemath.spec SRPM URL: http://pcpa.fedorapeople.org/sagemath/SRPMS/sagemath-5.7-1.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FrTnhDVMJya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #50 from José Matos jama...@fc.up.pt --- While I am busy I have following this review request and I would like to thank you Paulo for the amazing work you have doing for putting sage in a way that can be imported into Fedora. At the same time as we know from other experiences the final result will not only help us (Fedora) but all the upstream project. Congratulations. :-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mktbU5N3pQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #48 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- I made a new build and updated the f18 repo because it was broken due to rebuilding in a not up to date f18, and also addressed some extra issues. After a run of fedora-review, now is in my todo: W: invalid-license GPL W: wrong-file-end-of-line-encoding /usr/share/doc/sagemath-5.6/output/html/en/bordeaux_2008/objects.inv W: spurious-executable-perm /usr/share/doc/sagemath-5.6/en/prep/media/Rplot001.png W: file-not-utf8 /usr/share/doc/sagemath-5.6/output/html/en/bordeaux_2008/objects.inv W: no-soname /usr/lib64/libcsage.so should just patch the build to add a (zero) soname to it. Should ignore for now: E: zero-length /usr/lib64/python2.7/... E: explicit-lib-dependency lrslib E: explicit-lib-dependency python-matplotlib W: strange-permission testjava.sh 0755L Do not know why the warning is still there, it is a shell script... I will remove the magic to upgrade from arch to noarch soon, so this will be removed shortly: W: dangerous-command-in-%pretrans mv Update: - Rebuild with latest rawhide and f18 updates - Make sagemath-notebook owner of its base data directory - Explicitly mark notebook translations as %%lang (#877651#c46) - Remove sage3d as it is not functional in the rpm package (#877651#c46) - Remove reference to buildroot in libcsage.so debuginfo Spec URL: http://pcpa.fedorapeople.org/sagemath.spec SRPM URL: http://pcpa.fedorapeople.org/sagemath/SRPMS/sagemath-5.6-6.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uG3oKJVS3ta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=877651
--- Comment #46 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com
---
(In reply to comment #45)
Here's a run of fedora-review, noting a few problems that need to be fixed.
Issues, in no particular order:
1. The jpackage-utils and javadoc warnings are due to jmol and sage3d; the
Java packaging guidelines need to be followed for those portions.
I believe it is being caused because the package has symlinks to .jar
files from jmol and vecmath, but fedora-review does not consider this
condition.
NOTE: not addressed yet.
2. Should the -doc subpackages be noarch? How about the -data subpackages?
I changed both to noarch. I wish rpm would be smarter about changing
a directory to a symlink, since to be noarch it needs to be
moved to /usr/share, the previous directories under %_libdir
need to be changed to symlinks, and that makes updates of the
current package not easy. In the current state should be ok, but
changing later is really not desirable because it would create
too many upgrade failure conditions.
3. The build isn't using the right build flags. The build log shows:
+ pushd spkg/build/sage-5.6
+ pushd c_lib
+ CXX=g++
+ UNAME=Linux
+ SAGE64=auto
+ scons
scons: Reading SConscript files ...
scons: done reading SConscript files.
scons: Building targets ...
gcc -o src/convert.os -c -fPIC
-I/builddir/build/BUILDROOT/sagemath-5.6-4.fc19.x86_64/usr/lib64/sagemath/
local/include
-I/builddir/build/BUILDROOT/sagemath-5.6-4.fc19.x86_64/usr/lib64/sagemath/
local/include/python2.7
-I/builddir/build/BUILDROOT/sagemath-5.6-4.fc19.x86_64/usr/lib64/sagemath/
local/include/NTL -Iinclude src/convert.c
... followed by more files compiled without the correct flags. I see more
compilations in other directories later in the build log with the same
problem.
scons is weird, it ignores most environment variables. I did add
hardcoded CFLAGS and CXXFLAGS (and LINKFLAGS). I do not have any
saved logs for the cython build flags, but it is passing the
proper flags (not sure if side effect of exporting CFLAGS and
CXXFLAGS).
Just in case, the SAGE64 is just to fool this:
if os.environ['SAGE64']==yes:
env.Append( CFLAGS=-O2 -g -m64 )
env.Append( CXXFLAGS=-O2 -g -m64 )
env.Append( LINKFLAGS=-m64 )
so that os.environ['SAGE64'] is defined and does not cause
and exception due to being undefined.
4. The bundling issue still needs to be resolved.
I was left alone with the pexpect issue :-( Pexpect upstream did not
respond my query, and sagemath upstream did comment a lot about it,
and that at some point the new pexpect, basically completely rewritten
was significantly slower with sagemath.
The remaining issue is ipython. Hopefully by sagemath-5.7 it will be able
to use latest upstream ipython, otherwise may need to ping back about it.
5. The license check looks okay, except it flags one file with an Apache
license. I think this is okay, because that file is only used for testing
and does not contribute to the binary RPMs, right?
Need to verify when the selenium subdir was added (well, it appears
licensecheck only tells about it, but there are others), but it was
not when I did run licensecheck to generate the License tag. But the
notebook was significantly changed since then, and added several ASL
files indeed.
Updated now.
6. The license breakdown needs to be explained in a comment;
See
https://fedoraproject.org/wiki/Packaging:
LicensingGuidelines#Multiple_Licensing_Scenarios
I did split/review as much as I could, and the directories in sagenb
where there was only one file with a license I assumed that license.
There is a significant breakdown already done in $SAGE_ROOT/COPYING.txt
but that includes what upstream sagemath bundles, so, only a small
portion actually applies to sagemath, that is release under GPLv2+
7. Since the main package installs an icon, it needs this:
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
Fixed.
8. %{_libdir}/sagemath/share is owned by the main package, but the main
package puts no contents into it. It appears to be used only by the
sagemath-data-foo packages, so shouldn't sagemath-data own it?
Corrected.
9. Empty directories in the sagemath-data-extcode package, some of which are
the only items in their parent directories:
- %{_libdir}/sagemath/share/extcode/MuPAD/user
- %{_libdir}/sagemath/share/extcode/QEPCAD
- %{_libdir}/sagemath/share/extcode/gap/user
- %{_libdir}/sagemath/share/extcode/genus2reduction
- %{_libdir}/sagemath/share/extcode/gnuplot
- %{_libdir}/sagemath/share/extcode/kash/user
- %{_libdir}/sagemath/share/extcode/macaulay2/user
- %{_libdir}/sagemath/share/extcode/magma/ell_padic
- %{_libdir}/sagemath/share/extcode/magma/padic_height
- %{_libdir}/sagemath/share/extcode/maple/user
- %{_libdir}/sagemath/share/extcode/mathematica/user
-
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #47 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- Update: - Export CFLAGS and CXXFLAGS (#877651#c45) - Make sagemath-data owner of SAGE_SHARE (#877651#c45) - Relocate SAGE_DOC and make sagemath-doc packages noarch (#877651#c45) - Relocate SAGE_SHARE and make sagemath-data packages noarch (#877651#c45) - Remove sagenb binary egg bundled in tarball (#877651#c45) - Update license tag due to unlisted Apache v2 license (#877651#c45) - Break down licenses in files listing (#877651#c45) - Add post scriplets to handle the installed icon (#877651#c45) - Do not install empty directories in SAGE_EXTCODE (#877651#c45) - Do not install bundled mathjax fonts (#877651#c45) - Add a descriptive comment to patches without one (#877651#c45) - Correct mispelled donwload_tarball macro name (#877651#c45) - Remove reference to buildroot in prep (#877651#c45) - Simplify coin-or-Cbc build requires as it has proper dependencies Spec URL: http://pcpa.fedorapeople.org/sagemath.spec SRPM URL: http://pcpa.fedorapeople.org/sagemath/SRPMS/sagemath-5.6-5.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WjbOSyRey5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #44 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- Created attachment 696525 -- https://bugzilla.redhat.com/attachment.cgi?id=696525action=edit sage-memcheck valgrind run on the first crash in libsymmetrica: sage -t -force_lib devel/sage/sage/algebras/nil_coxeter_algebra.py symmetrica logic is quite complex, but since it does not crash under valgrind (but I did not check --malloc-fill) it should be an issue with uninitialized memory when reading out of bounds memory (probably padding memory). My first guess hack to fix that would be to ensure all malloc calls in symmetrica are converted to calloc (possibly ensuring requested block sizes aligned at 16 bytes), but still possibly leave the bug around because of the logic to reuse objects that may not set them back to zero. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qIwI0Ru1f3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #43 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- Update: I made another update because mock build would fail in the last steps and added two extra macros to make it easier/faster to do debug builds. - Correct canonicalization unexpectedly shrank by one character error. - Add packager_debug macro for conditional package debug mode build. - Add donwload_tarball macro to avoid fedora-review donwloading it every run. Spec URL: http://pcpa.fedorapeople.org/sagemath.spec SRPM URL: http://pcpa.fedorapeople.org/sagemath/SRPMS/sagemath-5.6-4.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TSLU9jOVRBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #42 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- Update: - Add cryptominisat-devel to build requires. - Add conditional build for lrcalc (fedora review rhbz #909510) - Add conditional build for coin-or-CoinUtils (fedora review rhbz #894585) - Add conditional build for coin-or-Osi (fedora review rhbz #894586) - Add conditional build for coin-or-Clp (fedora review rhbz #894587) - Add conditional build for coin-or-Cgl (fedora review rhbz #894588) - Add conditional build for coin-or-Cbc (fedora review rhbz #894597) - Rebuild with latest rawhide and f18 dependency updates. Spec URL: http://pcpa.fedorapeople.org/sagemath.spec SRPM URL: http://pcpa.fedorapeople.org/sagemath/SRPMS/sagemath-5.6-3.fc19.src.rpm I did upload prebuilt binaries to pcpa.fedorapeople,org but remade the srpm for review request to not depend on packages still under review request. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L9oPyNHt5Ea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=877651
Bug 877651 depends on bug 905420, which changed state.
Bug 905420 Summary: RFE: Correct ppl-%{_arch}.hh definition conflicts with
gmpxx.h definition
https://bugzilla.redhat.com/show_bug.cgi?id=905420
What|Removed |Added
Status|NEW |CLOSED
Resolution|--- |RAWHIDE
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=TnNJQlxHQ0a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com changed: What|Removed |Added Depends On||905420 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ud9kZ82Oeea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=877651
--- Comment #38 from Jerry James loganje...@gmail.com ---
Actually, builds are failing in Rawhide, too. I got this in a mock build for
i386 Rawhide:
gcc -pthread -fno-strict-aliasing -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i686
-mtune=atom -fasynchronous-unwind-tables -D_GNU_SOURCE -fPIC -fwrapv -DNDEBUG
-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom
-fasynchronous-unwind-tables -D_GNU_SOURCE -fPIC -fwrapv -fPIC
-I/builddir/build/BUILDROOT/sagemath-5.6-1.fc19.i386/usr/lib/sagemath/local/include
-Ic_lib/include
-I/builddir/build/BUILDROOT/sagemath-5.6-1.fc19.i386/usr/lib/sagemath/devel/sage/sage/ext
-I/usr/include/python2.7 -c sage/libs/ppl.cpp -o
build/temp.linux-i686-2.7/sage/libs/ppl.o -w
In file included from /usr/include/ppl.hh:27:0,
from sage/libs/ppl.cpp:264:
/usr/include/ppl-i386.hh:774:7: error: redefinition of 'class
std::numeric_limits__gmp_expr__mpz_struct [1], __mpz_struct [1] '
class numeric_limitsmpz_class {
^
In file included from sage/libs/ppl.cpp:263:0:
/usr/include/gmpxx.h:3269:21: error: previous definition of 'class
std::numeric_limits__gmp_expr__mpz_struct [1], __mpz_struct [1] '
template class numeric_limitsmpz_class
^
In file included from /usr/include/ppl.hh:27:0,
from sage/libs/ppl.cpp:264:
/usr/include/ppl-i386.hh:835:7: error: redefinition of 'class
std::numeric_limits__gmp_expr__mpq_struct [1], __mpq_struct [1] '
class numeric_limitsmpq_class {
^
In file included from sage/libs/ppl.cpp:263:0:
/usr/include/gmpxx.h:3306:21: error: previous definition of 'class
std::numeric_limits__gmp_expr__mpq_struct [1], __mpq_struct [1] '
template class numeric_limitsmpq_class
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=VpOQCdj3YZa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=877651
--- Comment #39 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com
---
I will try to debug this problem. I notice both ppl-%{_arch}.hh
and gmpxx.hh defines templates for class numeric_limitsmp?_class,
but apparently only in i386 it is conflicting. I did only test
x86_64 builds so far...
If possible please try a x86_64 mock build; that should not
fail (works for me :-)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=JzhgjJEZBYa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=877651
--- Comment #40 from Jerry James loganje...@gmail.com ---
I got the same error on an x86_64 build:
gcc -pthread -fno-strict-aliasing -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic
-D_GNU_SOURCE -fPIC -fwrapv -DNDEBUG -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic
-D_GNU_SOURCE -fPIC -fwrapv -fPIC
-I/builddir/build/BUILDROOT/sagemath-5.6-1.fc19.x86_64/usr/lib64/sagemath/local/include
-Ic_lib/include
-I/builddir/build/BUILDROOT/sagemath-5.6-1.fc19.x86_64/usr/lib64/sagemath/devel/sage/sage/ext
-I/usr/include/python2.7 -c sage/libs/ppl.cpp -o
build/temp.linux-x86_64-2.7/sage/libs/ppl.o -w
In file included from /usr/include/ppl.hh:25:0,
from sage/libs/ppl.cpp:264:
/usr/include/ppl-x86_64.hh:774:7: error: redefinition of 'class
std::numeric_limits__gmp_expr__mpz_struct [1], __mpz_struct [1] '
class numeric_limitsmpz_class {
^
In file included from sage/libs/ppl.cpp:263:0:
/usr/include/gmpxx.h:3269:21: error: previous definition of 'class
std::numeric_limits__gmp_expr__mpz_struct [1], __mpz_struct [1] '
template class numeric_limitsmpz_class
^
In file included from /usr/include/ppl.hh:25:0,
from sage/libs/ppl.cpp:264:
/usr/include/ppl-x86_64.hh:835:7: error: redefinition of 'class
std::numeric_limits__gmp_expr__mpq_struct [1], __mpq_struct [1] '
class numeric_limitsmpq_class {
^
In file included from sage/libs/ppl.cpp:263:0:
/usr/include/gmpxx.h:3306:21: error: previous definition of 'class
std::numeric_limits__gmp_expr__mpq_struct [1], __mpq_struct [1] '
template class numeric_limitsmpq_class
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=rMJv2Ftsfta=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #41 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- I can reproduce it in both i386 and x86_64 now. My guess it is gcc 4.8.0 that does not like the duplicated but not equal templates; my last builds were with gcc 4.7.2. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1edAZz2wy3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #37 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- Only rawhide build should work, f18 should fail until https://admin.fedoraproject.org/updates/eclib-20120830-1.fc18 hits f18 stable. Update: - Update to sagemath 5.6. - Remove no longer required patch to build with system cython. Spec URL: http://pcpa.fedorapeople.org/sagemath.spec SRPM URL: http://pcpa.fedorapeople.org/sagemath/SRPMS/sagemath-5.6-1.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SGbbk4dilua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=877651
--- Comment #35 from Jerry James loganje...@gmail.com ---
Sorry to take so long with this, Paulo. It's a really big package. :-)
Currently, fedora-review is warning that it can't download the sage-5.5.tar
file. That's because it is now 5.6.
Also, the build of 5.5 is failing on both F18 and Rawhide, although a bit
differently. On Rawhide, it looks like there is some kind of conflict between
the ppl and gmp headers. On F18, it fails like this:
In file included from /usr/include/singular/structs.h:15:0,
from /usr/include/libsingular.h:6,
from
sage/algebras/letterplace/free_algebra_letterplace.cpp:261:
/usr/include/singular/si_gmp.h:4:22: fatal error: cf_gmp.h: No such file or
directory
compilation terminated.
It looks like the factory-devel header files have been moved into a
subdirectory of %{_includedir}, so it will now be necessary to specify
-I/usr/include/factory.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=oD5TNxOP09a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #36 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- Thanks! I think I may have been using a Singular with that problem already solved in f18 builds. Interestingly, I just pushed to f18 stable a Singular that matches the rawhide version. I will update to sagemath 5.6 and test mock builds as right now it works for me on f18 and rawhide. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vHCKFXAFD6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #34 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- Update correcting a very large amount of doctest failures: - Rediff rpmbuild patch to address some underlinked modules. - Make gap-sonata a mandatory requires. - Add cremona patch to adjust logic as only cremona mini is built. - Add lrslib patch to know lrslib is available. - Add nauty patch and comment about reason it cannot be made available. - Add gap-hap patch for better description of missing gap hap package. Spec URL: http://pcpa.fedorapeople.org/sagemath.spec SRPM URL: http://pcpa.fedorapeople.org/sagemath/SRPMS/sagemath-5.5-3.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3A58KGZ3pma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 Jerry James loganje...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|loganje...@gmail.com Flags||fedora-review? --- Comment #31 from Jerry James loganje...@gmail.com --- Since Paulo is reviewing polymake for me, I am, with great fear and trepidation, taking this review. Paulo, what is the status of the bundled pexpect? Are you still looking for a way to use the system pexpect? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JfsHjoxkura=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #32 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- (In reply to comment #31) Since Paulo is reviewing polymake for me, I am, with great fear and trepidation, taking this review. Paulo, what is the status of the bundled pexpect? Are you still looking for a way to use the system pexpect? I just added another comment to https://fedorahosted.org/fpc/ticket/238 about it. I believe the only alternative right now is to use the bundled pexpect. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NuqpayNgcFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #33 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- BTW, Many thanks for taking the review Jerry :-) I am working on a minor howto for anybody that used my f17 repository to cleanly update to f18, while I do the same :-) And should provide a temporary f18 repository also, that now is very simple as basically all dependencies are already in f18. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sIlJeAquWba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #30 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- (In reply to comment #16) Have you applied for bundling exceptions for cython, ipython, and pexpect? Exception has been granted for 6 month ipython and pexect only if no solution can be found: https://fedorahosted.org/fpc/ticket/238 It should be 6 months for ipython but depending on flow of review I can at least experiment on backporting the ipython patches targeted to sagemath 5.6. Unfortunately, probably will need to use the bundled pexpect. I did mail the pexpect author but got no response, and started a small thread about in at https://groups.google.com/forum/?fromgroups=#!topic/sage-devel/_tEyhHq7Vwg -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6amzvdfl00a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #28 from José Matos jama...@fc.up.pt --- While building your package in mock the build fails because it can not find cython in path. I am building your package in rawhide FWIW. I had this problems 2 weeks ago and I noticed that it still persists today. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PPE0VANSsla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #29 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- (In reply to comment #28) While building your package in mock the build fails because it can not find cython in path. I am building your package in rawhide FWIW. I had this problems 2 weeks ago and I noticed that it still persists today. Please try this new one (I forgot to validate it was building in a clean chroot after changing to use system cython): - Add cython to build requires (#877651#c28). Spec URL: http://pcpa.fedorapeople.org/sagemath.spec SRPM URL: http://pcpa.fedorapeople.org/sagemath/SRPMS/sagemath-5.5-2.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=t9SnYKWNq0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #27 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- Updated package: - Update to sagemath 5.5. - Add maxima.system patch to work with maxima 5.29.1 package. Spec URL: http://pcpa.fedorapeople.org/sagemath.spec SRPM URL: http://pcpa.fedorapeople.org/sagemath/SRPMS/sagemath-5.5-1.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xW0dz1Db1xa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 Vedran Miletić riva...@gmail.com changed: What|Removed |Added CC||riva...@gmail.com --- Comment #25 from Vedran Miletić riva...@gmail.com --- Paulo, is this planned to be included in F19 or as an update in F18? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FinEDAEN78a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #26 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- (In reply to comment #25) Paulo, is this planned to be included in F19 or as an update in F18? My initial plan was to have sagemath ready for F18, then I gave up and was considering just a private repository, but I did that for F17 at http://pcpa.fedorapeople.org/sagemath/f17/ Once the package is approved, it should be built for rawhide (future F19) and made as a F18 update. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aCYDrLGEHJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 Neal Becker ndbeck...@gmail.com changed: What|Removed |Added CC|vbr...@physics.upenn.edu| --- Comment #24 from Neal Becker ndbeck...@gmail.com --- cython-0.17.3 has been queued for f18 testing, and should be in rawhide now. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oPicFlehWha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #23 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- (In reply to comment #22) I agree that Cython upgrades have been troublesome in the past. But, for the record, with the patch http://trac.sagemath.org/13740 Sage can use up to Cython 0.17.3 (released today). I rebuilt the sagemath rpm with your patch and everything looks file. Well the problems that appear related to cython are still there :-) For now I think I better not lift my request for bundling cython. What I want to have some freedom is to be able to bundle it if things go bad, but having a wider audience for the package should help :-) changelog: - Build with system cython by default on fedora 18 or newer (#877651). Spec URL: http://pcpa.fedorapeople.org/sagemath.spec SRPM URL: http://pcpa.fedorapeople.org/sagemath/SRPMS/sagemath-5.4.1-5.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nHGboSA8uea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 Jerry James loganje...@gmail.com changed: What|Removed |Added CC||loganje...@gmail.com --- Comment #16 from Jerry James loganje...@gmail.com --- Have you applied for bundling exceptions for cython, ipython, and pexpect? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FAE6HbWn2Fa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #17 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- (In reply to comment #16) Have you applied for bundling exceptions for cython, ipython, and pexpect? Not yet. I was expecting to need to ask for bundling during or after the review process. I will make a bundling exception request. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jAT90V1DZaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #18 from Volker Braun vbr...@physics.upenn.edu --- If you apply the patch from http://trac.sagemath.org/13740 then you should be able to use the Fedora Cython rpm. At least it fixes an incompatibility with Cython-0.17.2, so probably also 0.17.1 (Fedora 18). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=11MA08zhyXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #19 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- (In reply to comment #18) If you apply the patch from http://trac.sagemath.org/13740 then you should be able to use the Fedora Cython rpm. At least it fixes an incompatibility with Cython-0.17.2, so probably also 0.17.1 (Fedora 18). I asked for bundling exceptions in https://fedorahosted.org/fpc/ticket/238 I did comment about bundling cython that hopefully it would be temporary. In my Mandriva sagemath packages I did for some time either make my own patches or use patches from trac.sagemath.org, but that caused trouble because system cython could be upgraded in the mean time, making the sagemath package no longer buildable or generating a broken package. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=D7Bcl7NiG8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 Neal Becker ndbeck...@gmail.com changed: What|Removed |Added CC||ndbeck...@gmail.com --- Comment #20 from Neal Becker ndbeck...@gmail.com --- Ironic. Why is cython even in fedora? Because a good while back, we discussed packaging sage. At the time, I volunteered to package cython as a first step. Now, I don't even use cython , and then I learn sage won't use it either. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TndltdBUBga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #21 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- Minor corrections so that it builds cleanly in f18: - The fplll patch is also required to build in f18. - Add factory include to plural.pyx build. Spec URL: http://pcpa.fedorapeople.org/sagemath.spec SRPM URL: http://pcpa.fedorapeople.org/sagemath/SRPMS/sagemath-5.4.1-4.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Bd7S5W1Jhra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #22 from Volker Braun vbr...@physics.upenn.edu --- I agree that Cython upgrades have been troublesome in the past. But, for the record, with the patch http://trac.sagemath.org/13740 Sage can use up to Cython 0.17.3 (released today). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=t9hvFmKPmja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=877651
--- Comment #13 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com
---
(In reply to comment #12)
Hi Paulo,
I had the same issue with python-matplotlib-tk just by using ipython -gui
so I think that this problem is not specific of sage.
It should have been fixed it in yet another python-matplotlib
build
https://admin.fedoraproject.org/updates/FEDORA-2012-19809/python-matplotlib-1.2.0-5.fc18
the problem was that it was not detecting gtk, that is in
the main package (but only for python2.7...) and is the
default backend if available. Wrapping setup.py run in
xvfb-run fixed that. Could also have patched
%{python_sitearch}/matplotlib/mpl-data/matplotlibrc after
%install.
FWIW I am interested in reviewing sage. :-)
I am waiting for someone to click the take link and do the review :-)
But any non official review is welcome, that is, something
like download the srpm and run:
/usr/bin/fedora-review -v -r -n sagemath
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=ig9ZfmJsnaa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #14 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- (In reply to comment #8) * Fonts are missing, should be required. Fonts are truly missing in Fedora. Stix fonts appear to have changed significantly from 1.0.0 (f17) to 1.1.0 (f18+). I opened a bug report, about missing fonts in stix-fonts 1.1.0 at: https://bugzilla.redhat.com/show_bug.cgi?id=885307 and about missing extra jsmath fonts at: https://bugzilla.redhat.com/show_bug.cgi?id=885312 Anyway, this apparently was a side effect of my update to matplotlib 1.2.0 (sage uses 1.1.0), and as commented in the above bug reports, I am ok with making a patch in the matplotlib package to not require/reference those fonts. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gOrXhAMocGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #15 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- Minor corrections: - Revert requires python-matplotlib-tk as it was a python-matplotlib bug. - Add stix-fonts requires. Spec URL: http://pcpa.fedorapeople.org/sagemath.spec SRPM URL: http://pcpa.fedorapeople.org/sagemath/SRPMS/sagemath-5.4.1-3.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HJP8oWDhyRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #11 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- Update: - Change back to install .c and .h files in bundled cython. - Make symlink of gmp-ecm to $SAGE_LOCAL/bin/ecm. - Add SAGE_LOCAL/bin to python path so that sage -gdb works. Forgot to add to changelog that it now explicitly requires python-matplotlib-tk to avoid import errors in sage -testall, will add it to changelog. A not so trivial debug I did was some cutpaste + searchreplace in gdb to verify the address every symbol in the symmetrica shared library (checking all symbols in symmetrica's def.h and macros.h) to confirm it was mapped to libsymmetrica.so and it indeed was, only the generic div symbol was not, but after properly checking symmetrica sources, I learned that it already has a #define div SYM_div in def.h and checking SYM_div showed correct results, so, while it is better to figure out what is causing crashes in symmetrica, an option is to link it statically. Spec URL: http://pcpa.fedorapeople.org/sagemath.spec SRPM URL: http://pcpa.fedorapeople.org/sagemath/SRPMS/sagemath-5.4.1-2.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 José Matos jama...@fc.up.pt changed: What|Removed |Added CC||jama...@fc.up.pt --- Comment #12 from José Matos jama...@fc.up.pt --- Hi Paulo, I had the same issue with python-matplotlib-tk just by using ipython -gui so I think that this problem is not specific of sage. FWIW I am interested in reviewing sage. :-) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 Volker Braun vbr...@physics.upenn.edu changed: What|Removed |Added CC||vbr...@physics.upenn.edu --- Comment #8 from Volker Braun vbr...@physics.upenn.edu --- I've had a look at the test failures: * Fonts are missing, should be required. * the test suite needs the built documentation (to test the built-in help system), hg, scons, Singular help file, fortran compiler, * lrcalc is missing, this is one of the spkgs. * Segfaults when using pari and symmetrica. The latter has a symbol clash which probably explains it (sort_sum_rename.patch in the symmetrica spkg). Both are modified and linked in, so it is likely that you'll have to install the Sage-specific versions. We are planning to move to git next year and revamp some of the built system in the process. I think it would be great if you write about your experience in packaging and what would make your life easier. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #9 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- (In reply to comment #8) Many thanks for the comments Volker! I've had a look at the test failures: * Fonts are missing, should be required. I will work on it, should be only an extra requires. * the test suite needs the built documentation (to test the built-in help system), hg, scons, Singular help file, fortran compiler, Documentation is built during package build, actually I have a somewhat nasty problem with sphinx, see: https://bugzilla.redhat.com/show_bug.cgi?id=839321 http://trac.sagemath.org/sage_trac/ticket/13230 * lrcalc is missing, this is one of the spkgs. Is the spkg the official upstream package? I have a request for information at: http://trac.sagemath.org/sage_trac/ticket/11563#comment:45 but left it as one of the few known issues :-) * Segfaults when using pari and symmetrica. The latter has a symbol clash which probably explains it (sort_sum_rename.patch in the symmetrica spkg). Both are modified and linked in, so it is likely that you'll have to install the Sage-specific versions. I am afraid it should be another issue, the patch is applied, see: http://pkgs.fedoraproject.org/cgit/symmetrica.git/tree/ but may be another symbol, because in fedora symmetrica is built as a shared library. We are planning to move to git next year and revamp some of the built system in the process. I think it would be great if you write about your experience in packaging and what would make your life easier. My major issues, in integrating sagemath in the system are versions of components, it will be required an exception to be able to use: o old ipython version o old and/or non standard cython o old pexpect Otherwise, other then sometimes relying on some very intrusive patches, like the sphinx patch, it is mainly problems with versions of components. An interesting example is that I could not convince upstream pari to use an extra flag to not call mp_set_memory_functions in the library, so it now uses this patch: ---%--- diff -up sage-5.4.1/spkg/build/sage-5.4.1/sage/libs/pari/gen.pyx.orig sage-5.4.1/spkg/build/sage-5.4.1/sage/libs/pari/gen.pyx --- sage-5.4.1/spkg/build/sage-5.4.1/sage/libs/pari/gen.pyx.orig2012-11-12 21:15:23.758879845 -0200 +++ sage-5.4.1/spkg/build/sage-5.4.1/sage/libs/pari/gen.pyx2012-11-12 21:15:43.213880590 -0200 @@ -182,6 +182,10 @@ include '../../ext/stdsage.pxi' cdef extern from mpz_pylong.h: cdef int mpz_set_pylong(mpz_t dst, src) except -1 +cdef extern from gmp.h: +cdef void mp_get_memory_functions(void**, void**, void**) +cdef void mp_set_memory_functions(void*, void*, void*) + # Make sure we don't use mpz_t_offset before initializing it by # putting in a value that's likely to provoke a segmentation fault, # rather than silently corrupting memory. @@ -9171,7 +9175,12 @@ cdef class PariInstance(sage.structure.p # The size here doesn't really matter, because we will allocate # our own stack anyway. We ask PARI not to set up signal handlers. +cdef void *_gmp_malloc +cdef void *_gmp_realloc +cdef void *_gmp_free +mp_get_memory_functions(_gmp_malloc, _gmp_realloc, _gmp_free) pari_init_opts(1, maxprime, INIT_JMPm | INIT_DFTm) +mp_set_memory_functions(_gmp_malloc, _gmp_realloc, _gmp_free) num_primes = maxprime # NOTE: sig_on() can only come AFTER pari_init_opts()! ---%--- There are a few other somewhat related issues, like a back patch for ntl to not rely on a patched ntl. I asked upstream NTL to provide the features required by sagemath, see: http://shoup.net/pipermail/ntl_shoup.net/2012-April/33.html I exchanged a few emails with Victor Shoup at that time, but need to ping again :-), basically, something could be done when a new NTL release were released. Packaging sagemath itself has not been a major issue for quite some time (I did package sagemath in mandriva since late sage 3.x) it is the dependencies that make it non trivial to package. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #10 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- I just updated http://pcpa.fedorapeople.org/sagemath/test.log Issues there that are simple to correct: o just added requires python-matplotlib-tk to requires in sagemath.spec, side effect of my update to matplotlib 1.2, that is, all errors like: ImportError: No module named backend_tkagg are corrected if installing python-matplotlib-tk Not so simple to correct issues: o this error [Errno 2] No such file or directory: '/usr/lib64/sagemath/site-packages/Cython/Utility/ObjectHandling.c' is a side effect of explicitly not installing .c and .h files to reduce number of warnings/errors from rpmlint, but they are required, so, changed the spec back to install them Too bad this did cascade in several other test failures... o this error ---%--- sage -t -force_lib devel/sage/sage/structure/sage_object.pyx [?1034hbunzip2: Can't open input file /usr/lib64/sagemath/share/extcode/pickle_jar/pickle_jar.tar.bz2: No such file or directory. tar: This does not look like a tar archive tar: Exiting with failure status due to previous errors ---%--- will stay for now, need a very good explanation to add it to the package. o the error ImportError: No module named lrcalc should be fixed when solving the issue with what is lrcalc upstream. o this is still happening ---%--- File /usr/lib64/python2.7/site-packages/sage/combinat/sf/sf.py, line 1136, in __call__ return self._codomain._from_dict(dict(self._t(self.fake_sym.monomial(partition))), coerce = True) File schur.pxi, line 574, in sage.libs.symmetrica.symmetrica.t_MONOMIAL_HOMSYM_symmetrica (sage/libs/symmetrica/symmetrica.c:18879) RuntimeError: Segmentation fault ---%--- I did not debug it enough to understand the root cause of the problem, only learned that if I compile symmetrica without -DFAST it would follow a code path jumping over the dereferencing of the invalid pointer, but rebuilding symmetrica that way should not be the proper correction. o this error IOError: [Errno 2] No such file or directory: '/usr/lib64/sagemath/local/bin/ipython' should remain for now, as it should be a single doctest failure, otherwise it works, but I can change it to install ipython wrapper o no idea about this, need to debug: sage: len(pari(p).polroots(precision=128)) File gen.pyx, line 8025, in sage.libs.pari.gen.gen.polroots (sage/libs/pari/gen.c:39360) RuntimeError: Segmentation fault I will do another sage -testall run now with python-matplotlib-tk installed, as missing it caused way too much noise in test.log... -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #7 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- Updated to sagemath 5.4.1: Spec URL: http://pcpa.fedorapeople.org/sagemath.spec SRPM URL: http://pcpa.fedorapeople.org/sagemath/SRPMS/sagemath-5.4.1-1.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #6 from pcpa paulo.cesar.pereira.de.andr...@gmail.com --- (In reply to comment #3) PS. I'm willing to help review this when the time comes. The time is now! You can make an unofficial review request if you prefer :-) Better to have more eyes looking at possible packaging issues. Help on debugging issues as the problems found in http://pcpa.fedorapeople.org/sagemath/test.log also welcome. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=877651
--- Comment #5 from pcpa paulo.cesar.pereira.de.andr...@gmail.com ---
Package was updated to better split subpackages and to
remove some unnecessary files being installed.
Spec URL: http://pcpa.fedorapeople.org/sagemath.spec
SRPM URL:
http://pcpa.fedorapeople.org/sagemath/SRPMS/sagemath-5.4-2.fc19.src.rpm
- Do not install alternate cygdb in %%_bindir
- Create the %{name}-core subpackage
- Create the %{name}-doc subpackage
- Create the %{name}-doc-en subpackage
- Create the %{name}-doc-de subpackage
- Create the %{name}-doc-fr subpackage
- Create the %{name}-doc-pt subpackage
- Create the %{name}-doc-ru subpackage
- Create the %{name}-doc-tr subpackage
- Create the %{name}-data metapackage
- Create the %{name}-data-conway_polynomials subpackage
- Create the %{name}-data-elliptic_curves subpackage
- Create the %{name}-data-extcode subpackage
- Do not install pickle_jar extcode contents
- Do not install notebook extcode contents
- Create the %{name}-data-graphs subpackage
- Create the %{name}-data-polytopes_db subpackage
- Create the %{name}-notebook subpackage
- Create the %{name}-rubiks subpackage
- Create the %{name}-sagetex subpackage
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #4 from pcpa paulo.cesar.pereira.de.andr...@gmail.com --- I made some new branch requests for a possible f18 backport (my initial plan was to have a private repository like I do for f17): https://bugzilla.redhat.com/show_bug.cgi?id=839097 https://bugzilla.redhat.com/show_bug.cgi?id=839098 https://bugzilla.redhat.com/show_bug.cgi?id=839071 I updated https://fedoraproject.org/wiki/SIGs/SciTech/SAGE and removed the required update to libmpc, as I added stubs in a sagemath patch for the missing functions: http://lists.gforge.inria.fr/pipermail/mpc-discuss/2012-October/001214.html Actually, there is another requires issue, but I still suspect a newer numpy snapshot (or final version will be avaiable before a fedora sagemath package): https://bugzilla.redhat.com/show_bug.cgi?id=868585 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #2 from Alex Lancaster al...@users.sourceforge.net --- This is great! I'm so glad somebody is getting around to packaging this. It would be great if you could make this bug dependent on the package reviews for the 3 new packages (assuming they're not yet included in Fedora) so they can be tracked. I notice you've also updated the wiki: https://fedoraproject.org/wiki/SIGs/SciTech/SAGE It would be good if you could add a link to this review there, as some folks might not know about it. (I only found out about it because I happened across the archives for the scitech list, which I'm not a member of right now). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #3 from Alex Lancaster al...@users.sourceforge.net --- PS. I'm willing to help review this when the time comes. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
