[Bug 878236] Review Request: python-waitress - Waitress WSGI server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878236 --- Comment #12 from Fedora Update System --- python-waitress-0.8.2-3.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rZ88UPtw5u&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878236] Review Request: python-waitress - Waitress WSGI server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878236 --- Comment #11 from Fedora Update System --- python-waitress-0.8.2-3.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jCSsrBVXOg&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878236] Review Request: python-waitress - Waitress WSGI server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878236 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-12-07 23:25:46 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1rRbr5gqUN&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878236] Review Request: python-waitress - Waitress WSGI server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878236 --- Comment #10 from Fedora Update System --- python-waitress-0.8.2-3.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878236] Review Request: python-waitress - Waitress WSGI server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878236 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878236] Review Request: python-waitress - Waitress WSGI server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878236 --- Comment #9 from Fedora Update System --- python-waitress-0.8.2-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-waitress-0.8.2-3.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878236] Review Request: python-waitress - Waitress WSGI server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878236 --- Comment #8 from Fedora Update System --- python-waitress-0.8.2-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-waitress-0.8.2-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878236] Review Request: python-waitress - Waitress WSGI server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878236 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878236] Review Request: python-waitress - Waitress WSGI server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878236 --- Comment #7 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878236] Review Request: python-waitress - Waitress WSGI server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878236 Lorenzo Gil Sanchez changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Lorenzo Gil Sanchez --- New Package SCM Request === Package Name: python-waitress Short Description: Waitress WSGI server Owners: lgs Branches: f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878236] Review Request: python-waitress - Waitress WSGI server
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878236
--- Comment #5 from Lorenzo Gil Sanchez ---
Thanks a lot Gianluca. I updated the package with your %{version} suggestion.
I'll take a look at your package.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878236] Review Request: python-waitress - Waitress WSGI server
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878236
Gianluca Sforna changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #4 from Gianluca Sforna ---
(In reply to comment #3)
> I've updated the package with all your suggestions except the
> CFLAGS="$RPM_OPT_FLAGS" thing. This package does not have any C extensions
> so I think the CFLAGS are not needed. I guess the guidelines try to cover
> all cases but this time is cleaner if we don't put that.
Yeah. I suppose it could grow such extension in the future, but I trust your
packager powers to fix it in case it will ever do :)
I think we are in a good shape to go.
Just a minor remark: I suggest you use the %{version} macro in the Source0
line, so you don't need to change it at each new upstream release.
REVIEW CHECKLIST
- package named according to package naming guidelines
- package licensed with allowed license (ZPLv2.1)
- license matches actual license
- license file included in %doc
- spec written in American english
- spec legible
- sources match upstream sha256sum
- successfully builds in mock for rawhide x86_64
- no locales
- no shared libraries
- package owns all directories it creates
- default file permissions
- macro usage is consistent
- package contains code
- no large documentation
- not a GUI app needing a .desktop file
- rpmlint is mostly silent, the only warning can be ignored:
rpmlint /var/lib/mock/fedora-17-x86_64/result/*.rpm
python-waitress.src: W: spelling-error %description -l en_US usr -> use, us,
user
3 packages and 0 specfiles checked; 0 errors, 1 warnings.
This package is APPROVED
PS. I have a package in the queue as well, bug #804125. If you have spare
cycles to help me get it in Fedora it would be great. However, it is much more
complicated than this one, so do not feel obligated in any way.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878236] Review Request: python-waitress - Waitress WSGI server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878236 --- Comment #3 from Lorenzo Gil Sanchez --- Thanks a lot for this review! I've updated the package with all your suggestions except the CFLAGS="$RPM_OPT_FLAGS" thing. This package does not have any C extensions so I think the CFLAGS are not needed. I guess the guidelines try to cover all cases but this time is cleaner if we don't put that. The update links: Spec URL: http://lorenzogil.com/rpms/python-waitress/python-waitress.spec SRPM URL: http://lorenzogil.com/rpms/python-waitress/python-waitress-0.8.2-2.fc17.src.rpm Koji builds: Fedora 17: http://koji.fedoraproject.org/koji/taskinfo?taskID=4723002 Fedora 18: http://koji.fedoraproject.org/koji/taskinfo?taskID=4723006 rpmlint is much happier now :-) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878236] Review Request: python-waitress - Waitress WSGI server
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878236
--- Comment #2 from Gianluca Sforna ---
Few point we can improve.
cosmetic: the 'for more information' part can be rewritten to point user to the
full path in the system like this:
For more information, see %{docdir}/docs or
http://docs.pylonsproject.org/projects/waitress/en/latest/
comparing the spec with the guidelines at
https://fedoraproject.org/wiki/Packaging:Python I see it is recommended to run
rm -rf %{py3dir}
just before
cp -a . %{py3dir}
Not sure it is useful, but there also minor differences in build and install:
CFLAGS="$RPM_OPT_FLAGS" is prepended to setup.py build lines, and setup.py
install now lacks the -O1 flag (maybe it was deprecated at some point)
pakcage builds fine in mock. rpmlint has few things to say:
[giallu@novo SPECS]$ rpmlint /var/lib/mock/fedora-17-x86_64/result/*.rpm
python3-waitress.noarch: W: spurious-executable-perm
/usr/share/doc/python3-waitress-0.8.2/docs/rebuild
python3-waitress.noarch: E: version-control-internal-file
/usr/share/doc/python3-waitress-0.8.2/docs/.gitignore
python-waitress.noarch: E: version-control-internal-file
/usr/share/doc/python-waitress-0.8.2/docs/.gitignore
python-waitress.noarch: W: spurious-executable-perm
/usr/share/doc/python-waitress-0.8.2/docs/rebuild
I guess these are all files you remove outright
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878236] Review Request: python-waitress - Waitress WSGI server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878236 Gianluca Sforna changed: What|Removed |Added CC||gia...@gmail.com Assignee|nob...@fedoraproject.org|gia...@gmail.com Flags||fedora-review? --- Comment #1 from Gianluca Sforna --- I am taking this review, spec looks very clean at first sight. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
