[Bug 878501] Review Request: rubygem-ci_reporter - Generate XML for continuous integration systems
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878501 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2013-01-11 18:57:15 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WO784ltSmea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878501] Review Request: rubygem-ci_reporter - Generate XML for continuous integration systems
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878501 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- rubygem-ci_reporter-1.8.2-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DxrRR0Al2Sa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878501] Review Request: rubygem-ci_reporter - Generate XML for continuous integration systems
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878501 Miroslav Suchý msu...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #10 from Miroslav Suchý msu...@redhat.com --- I guess that you meant: SRPM URL: http://tdawson.fedorapeople.org/rubygems/rubygem-ci_reporter-1.8.2-2.fc18.src.rpm (release is 2 instead of 1) :) Yes, that is good. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aXbZngBPfaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878501] Review Request: rubygem-ci_reporter - Generate XML for continuous integration systems
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878501 Troy Dawson tdaw...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #11 from Troy Dawson tdaw...@redhat.com --- New Package SCM Request === Package Name: rubygem-ci_reporter Short Description: Generate XML for continuous integration systems Owners: tdawson Branches: f18 f17 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8LODXT9nl0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878501] Review Request: rubygem-ci_reporter - Generate XML for continuous integration systems
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878501 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=b8xrGbTzGEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878501] Review Request: rubygem-ci_reporter - Generate XML for continuous integration systems
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878501 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=F4LQLk3bbXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878501] Review Request: rubygem-ci_reporter - Generate XML for continuous integration systems
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878501 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- rubygem-ci_reporter-1.8.2-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-ci_reporter-1.8.2-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ArBTuOD5cKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878501] Review Request: rubygem-ci_reporter - Generate XML for continuous integration systems
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878501 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7uoLeHdDaUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878501] Review Request: rubygem-ci_reporter - Generate XML for continuous integration systems
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878501 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- rubygem-ci_reporter-1.8.2-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9xRyaGAd7Ea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878501] Review Request: rubygem-ci_reporter - Generate XML for continuous integration systems
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878501 --- Comment #9 from Troy Dawson tdaw...@redhat.com --- Spec URL: http://tdawson.fedorapeople.org/rubygems/rubygem-ci_reporter.spec SRPM URL: http://tdawson.fedorapeople.org/rubygems/rubygem-ci_reporter-1.8.2-1.fc18.src.rpm Test problem in rawhide ended up being a dependency problem for the version of cucumber in rawhide. I have filed a bug on in. https://bugzilla.redhat.com/show_bug.cgi?id=885822 Since tests are currently only a recommendation, I have made an if statement that bypasses the tests for F19+. I have put a comment by it stating the bug number and that when the bug is fixed to remove the if statement. I have tested and it builds in both F19 and F18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vhF7x39wfva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878501] Review Request: rubygem-ci_reporter - Generate XML for continuous integration systems
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878501 --- Comment #7 from Miroslav Suchý msu...@redhat.com --- Looks good, but fails to build in mock. See: http://koji.fedoraproject.org/koji/taskinfo?taskID=4765761 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0P5A8IayLha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878501] Review Request: rubygem-ci_reporter - Generate XML for continuous integration systems
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878501 --- Comment #8 from Troy Dawson tdaw...@redhat.com --- It fails to build in rawhide, I build it in F18 http://koji.fedoraproject.org/koji/taskinfo?taskID=4765286 This isn't the first package I've seen that builds fine in F18, but not in rawhide. I think some of the main rubygems have changed what they provide and/or require. Looking into it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nzFhgWROtca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878501] Review Request: rubygem-ci_reporter - Generate XML for continuous integration systems
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878501 --- Comment #5 from Miroslav Suchý msu...@redhat.com --- This works for me: rm Gemfile.lock for i in spec/ci/reporter/*_spec.rb; do if [ $i = spec/ci/reporter/report_manager_spec.rb -o $i = spec/ci/reporter/test_unit_spec.rb ]; then continue fi rspec $i done And I had to add require 'test/unit/diff' on top of /usr/share/gems/gems/test-unit-2.4.5/lib/test/unit/ui/console/testrunner.rb Please report it as bug to rubygem-test-unit and for add that above to %check as comments plus add as comment link to that test-unit bz. Plus link to reports to upstream that those two tests are failing (I think at least one is already reported). And of course you have to add build requires on hoe and diff-lcs, to make this above work. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878501] Review Request: rubygem-ci_reporter - Generate XML for continuous integration systems
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878501 --- Comment #6 from Troy Dawson tdaw...@redhat.com --- Spec URL: http://tdawson.fedorapeople.org/rubygems/rubygem-ci_reporter.spec SRPM URL: http://tdawson.fedorapeople.org/rubygems/rubygem-ci_reporter-1.8.2-1.fc18.src.rpm That was the fix we needed for the test. If we add require 'test/unit/diff' to the top of all the tests, then they wall work, even report_manager_spec.rb and test_unit_spec.rb. I have informed upstream. I have also tested it with a newer version of test-unit, and it works without having to do that. But for now, I have a sed statement that fixes up the tests. Once we have a newer version of test-unit in Fedora we can take that out. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=g98Ng2atYka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878501] Review Request: rubygem-ci_reporter - Generate XML for continuous integration systems
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878501 --- Comment #3 from Miroslav Suchý msu...@redhat.com --- This gem contains spec tests. Any reason why you do not run them in %check? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878501] Review Request: rubygem-ci_reporter - Generate XML for continuous integration systems
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878501 --- Comment #4 from Troy Dawson tdaw...@redhat.com --- Yes. Try as hard as I can, I cannot get any self-tests to run. It doesn't help that this gem works with testing and generating reports on other gems, so there are several files with test in the name. I have written an email to the developers asking if there are any self tests, and if there are, how are they run. If you are able to run the tests, please let me know the commands and I'll put them in. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878501] Review Request: rubygem-ci_reporter - Generate XML for continuous integration systems
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878501
--- Comment #2 from Troy Dawson tdaw...@redhat.com ---
Spec URL: http://tdawson.fedorapeople.org/rubygems/rubygem-ci_reporter.spec
SRPM URL:
http://tdawson.fedorapeople.org/rubygems/rubygem-ci_reporter-1.7.3-2.fc18.src.rpm
rm -rf %{buildroot}%{gem_instdir}/.yardoc - Done
doc subpackage - Done
gem_extdir macro - Removed
Requires: rubygem(rubyforge) - Removed
Requires: rubygem(hoe) - Removed
Requires: rubygem(rdoc) - Removed
(in the Gemfile, it is correct, but the Gemfile.lock has them all just listed
as required. My mistake)
export CONFIGURE_ARGS ... - Removed
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878501] Review Request: rubygem-ci_reporter - Generate XML for continuous integration systems
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878501 Miroslav Suchý msu...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||msu...@redhat.com Assignee|nob...@fedoraproject.org|msu...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878501] Review Request: rubygem-ci_reporter - Generate XML for continuous integration systems
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878501
--- Comment #1 from Miroslav Suchý msu...@redhat.com ---
I would suggest to add to the end of %install:
rm -rf %{buildroot}%{gem_instdir}/.yardoc
so rpmbuild --rebuild will pass on systems where rubygem-yard is installed. But
it is not crucial since in koji it is not installed.
Can you please create -doc subpackage and move there tests, /ri folder and all
files not needed for runtime?
no need to define gem_extdir macro, when it is not used.
This:
Requires: rubygem(rubyforge)
Requires: rubygem(hoe)
Requires: rubygem(rdoc)
is marked as devel deps on rubygems.org. Is it really needed for runtime?
export CONFIGURE_ARGS=--with-cflags='%{optflags}'
This is only needed for gems, which has library written in C.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
