[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556 Troy Dawson changed: What|Removed |Added Depends On||878515 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556 Miroslav Suchý changed: What|Removed |Added Status|NEW |ASSIGNED CC||msu...@redhat.com Assignee|nob...@fedoraproject.org|msu...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878556
--- Comment #1 from Miroslav Suchý ---
Can you please explain?:
# Not doing tests, missing config file
Requires should be (to comply with ~> operator):
Requires: rubygem(multi_json) => 1.0
Requires: rubygem(multi_json) < 2.0
Requires: rubygem(simplecov-html) => %{version}
Requires: rubygem(simplecov-html) < 0.8
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556 --- Comment #2 from Troy Dawson --- I originally was intending to to the tests and made sure all the dependencies were there so the tests would run. But I couldn't ever get it to build in the mock areas or with a regular rpm -ba It would always fail on the tests with No SimpleCov config file found! I then tried on a regular Fedora 18, installing using just gems, and still couldn't get the test to run without the error I guess if I just removed all references to the tests, that would be cleaner. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556 --- Comment #3 from Miroslav Suchý --- According the code, it is expecting file "simplecov_config". Please contact upstream what should be in that file. And either create it yourself and add it as Source1 or ask upstream to include it in gem. If tests are provided with gem, they should be run. And I would say this is blocker for this review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556 Troy Dawson changed: What|Removed |Added Depends On||878500 --- Comment #4 from Troy Dawson --- Spec URL: http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov.spec SRPM URL: http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov-0.7.1-1.fc18.src.rpm Turns out I was just running the tests in the wrong directory and they can be run without the configuration file. Of course, now this depends on a package still under review, rubygem-appraisal. https://bugzilla.redhat.com/show_bug.cgi?id=878500 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878556
--- Comment #5 from Miroslav Suchý ---
>%check
>cd %{buildroot}%{gem_instdir}
>testrb2 -Ilib test
It is prefered to do:
%check
pushd .%{gem_instdir}
testrb2 -Ilib test
popd
Because if that test accidentally change something in files which will land in
package, then if you are running the test in %{buildroot}%{gem_instdir}, this
change will land in package as will. But if you run it in .%{gem_instdir}, then
such accidential change will be isolated. This is behavior "just-in-case".
It is very good habbit to bump up release number for every change of spec
Ah, you put here wrong link. Ok I deducted:
http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov-0.7.1-2.fc18.src.rpm
Again:
export CONFIGURE_ARGS="--with-cflags='%{optflags}'"
# gem install compiles any C extensions and installs into a directory
does not have sense here.
Please fix that directory in %check again, and that will be all.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556 Vít Ondruch changed: What|Removed |Added CC||vondr...@redhat.com --- Comment #6 from Vít Ondruch --- (In reply to comment #4) > Of course, now this depends on a package rubygem-appraisal. Are you sure? I would agree if you are using Rake to execute the test suite, but you aren't. I did not tried, just asking, because I did similar experience with rubygem-audited. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556 Troy Dawson changed: What|Removed |Added Depends On|878500 | --- Comment #7 from Troy Dawson --- Spec URL: http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov.spec SRPM URL: http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov-0.7.1-4.fc18.src.rpm Vit, you are correct. I did a scratch build without rubygem-appraisal and it passed it's tests. Removed rubygem-appraisal dependancy Removed unneeded C extensions stuff from spec Use pushd and popd in %check section -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556 --- Comment #8 from Miroslav Suchý --- Looks much better. But what about license? It seems to me that upstream is using MIT, while you claim GPL or Ruby. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556 --- Comment #9 from Troy Dawson --- Spec URL: http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov.spec SRPM URL: http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov-0.7.1-5.fc18.src.rpm Good catch. Since the rubygems.org page didn't have it listed, I left it at the default until I was able to look at the file. Then it left my mind and I forgot. I have fixed the License to now say MIT. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556 Miroslav Suchý changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #10 from Miroslav Suchý --- I see no other problem, so: APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556 Troy Dawson changed: What|Removed |Added Flags||fedora-cvs? --- Comment #11 from Troy Dawson --- New Package SCM Request === Package Name: rubygem-simplecov Short Description: Code coverage analysis tool for Ruby 1.9 Owners: tdawson Branches: f18 f17 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556 --- Comment #12 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556 --- Comment #13 from Fedora Update System --- rubygem-simplecov-0.7.1-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-simplecov-0.7.1-5.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556 --- Comment #14 from Fedora Update System --- rubygem-simplecov-0.7.1-5.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556 Bug 878556 depends on bug 878515, which changed state. Bug 878515 Summary: Review Request: rubygem-simplecov-html - Default HTML formatter for SimpleCov https://bugzilla.redhat.com/show_bug.cgi?id=878515 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UBOnD98d4O&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556 --- Comment #15 from Fedora Update System --- rubygem-simplecov-0.7.1-5.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WsDtoAKSpY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556 Fedora Update System changed: What|Removed |Added Resolution|--- |CURRENTRELEASE Last Closed||2012-12-11 19:29:51 Status|ON_QA |CLOSED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Mq23msWBJn&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
https://bugzilla.redhat.com/show_bug.cgi?id=878556 Jan Klepek changed: What|Removed |Added CC||jan.kle...@gmail.com Flags|fedora-cvs+ |fedora-cvs? --- Comment #16 from Jan Klepek --- New Package SCM Request === Package Name: rubygem-simplecov Short Description: Code coverage analysis tool for Ruby 1.9 Owners: hpejakle Branches: el5 el6 InitialCC: tdawson -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
https://bugzilla.redhat.com/show_bug.cgi?id=878556 Miroslav Suchý changed: What|Removed |Added Flags|fedora-cvs? | --- Comment #17 from Miroslav Suchý --- You can not request additional branches using new package request. You have to use "change request". See: http://fedoraproject.org/wiki/Package_SCM_admin_requests#Package_Change_Requests_for_existing_packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
https://bugzilla.redhat.com/show_bug.cgi?id=878556 Jan Klepek changed: What|Removed |Added Flags||fedora-cvs? --- Comment #18 from Jan Klepek --- Package SCM Request === Package Name: rubygem-simplecov Short Description: Code coverage analysis tool for Ruby 1.9 Owners: hpejakle Branches: el5 el6 InitialCC: tdawson -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
https://bugzilla.redhat.com/show_bug.cgi?id=878556 --- Comment #19 from Jan Klepek --- Package Change Request == Package Name: rubygem-simplecov Short Description: Code coverage analysis tool for Ruby 1.9 Owners: hpejakle Branches: el5 el6 InitialCC: tdawson -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
https://bugzilla.redhat.com/show_bug.cgi?id=878556 --- Comment #20 from Jon Ciesla --- Git done (by process-git-requests). Correctly formatted branches. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
https://bugzilla.redhat.com/show_bug.cgi?id=878556 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
