[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878653 Maurice James midnightst...@msn.com changed: What|Removed |Added CC||midnightst...@msn.com --- Comment #19 from Maurice James midnightst...@msn.com --- The package is failing to install. The error is the following Resolving Dependencies -- Running transaction check --- Package NetworkManager-l2tp.x86_64 0:0.9.6-2.fc17 will be installed -- Processing Dependency: nm-connection-editor for package: NetworkManager-l2tp-0.9.6-2.fc17.x86_64 -- Finished Dependency Resolution Error: Package: NetworkManager-l2tp-0.9.6-2.fc17.x86_64 (updates) Requires: nm-connection-editor You could try using --skip-broken to work around the problem You could try running: rpm -Va --nofiles --nodigest -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=v2xEvMl6Xca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878653 --- Comment #20 from Maurice James midnightst...@msn.com --- uname -a Linux charon.tierre.net 3.6.7-4.fc17.x86_64 #1 SMP Tue Nov 20 19:40:01 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gJmuKmMGDQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878653 --- Comment #21 from Ivan Romanov dr...@land.ru --- https://bugzilla.redhat.com/show_bug.cgi?id=886773 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mA8BM7AUtsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878653 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-12-10 20:25:34 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4ZoUhbnOxCa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878653 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- NetworkManager-l2tp-0.9.6-2.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SCS6iUFWrqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878653 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- NetworkManager-l2tp-0.9.6-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bbypcsmbsCa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878653 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878653 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- NetworkManager-l2tp-0.9.6-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878653 --- Comment #13 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878653 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878653 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- NetworkManager-l2tp-0.9.6-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/NetworkManager-l2tp-0.9.6-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878653 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- NetworkManager-l2tp-0.9.6-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/NetworkManager-l2tp-0.9.6-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878653
Mathieu Bridon boche...@fedoraproject.org changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #9 from Mathieu Bridon boche...@fedoraproject.org ---
First, taking the issues I had raised before.
[x]: Package requires other packages for directories it uses.
[!]: If the source package does not include the text of the license(s), the
packager should contact upstream and encourage them to correct this
mistake.
= Upstream has been notified, and the next release will include it, so this
will do.
[x]: License field in the package spec file matches the actual license.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package must own all directories that it creates.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
= As I said I wasn't sure about this, but I see you filtered the provides
out, so I trust you figured this was the right thing to do.
[-]: Scriptlets must be sane, if used.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Spec use %global instead of %define.
[x] Rpmlint is silent (or as silent as reasonable)
The only other difference I see in the spec file is this:
-%if 0%{?fedora} 16
BuildRequires: libgnome-keyring-devel
-%else
-BuildRequires: gnome-keyring-devel
-%endif
= I hadn't seen that the first time, but this is a good change as F16 is EOL
soon anyway.
This new package fixes all issues I had found, and doesn't introduce any new
one, so I'm approving it.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878653 Ivan Romanov dr...@land.ru changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from Ivan Romanov dr...@land.ru --- New Package SCM Request === Package Name: NetworkManager-l2tp Short Description: NetworkManager VPN plugin for l2tp Owners: ivanromanov Branches: f17 f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878653
--- Comment #11 from Mathieu Bridon boche...@fedoraproject.org ---
(In reply to comment #10)
Branches: f17 f18 el6
The el6 is not going to work because you removed this:
-%if 0%{?fedora} 16
BuildRequires: libgnome-keyring-devel
-%else
-BuildRequires: gnome-keyring-devel
-%endif
You should add these lines back if you intend to have the package build on el6.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878653 --- Comment #12 from Ivan Romanov dr...@land.ru --- I will use BuildRequires: gnome-keyring-devel for el6 branch -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878653 --- Comment #8 from Ivan Romanov dr...@land.ru --- License text issue fixed by upstream. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878653
--- Comment #3 from Mathieu Bridon boche...@fedoraproject.org ---
Hi Ivan.
There's still a bit of work needed for this package, so I'm not approving it at
the moment.
I summed up all the issues below, so you wouldn't have to hunt them down one by
one in the (long) output of fedora-review.
Most of the problems should be pretty quick to fix though, and after that the
package should be good to go. :)
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Summary of issues (details below) :
===
[!]: Package requires other packages for directories it uses.
- The package drops a files in the following directory:
/usr/share/gnome-vpn-properties/
= Add a requirement on nm-connection-editor
[!]: If the source package does not include the text of the license(s), the
packager should contact upstream and encourage them to correct this
mistake.
= Please notify upstream of the problem.
= You might want to consider adding the file yourself if upstream doesn't
add it:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
[!]: License field in the package spec file matches the actual license.
- The following files are licensed under the LGPLv2+
auth-dialog/vpn-password-dialog.c
auth-dialog/vpn-password-dialog.h
= License tag should read: GPLv2+ and LGPLv2+
[!]: Package consistently uses macro is (instead of hard-coded directory
names).
- Note: Using both %{buildroot} and $RPM_BUILD_ROOT
= See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros
[!]: Package must own all directories that it creates.
= See above for the /usr/share/gnome-vpn-properties/ folder
[!]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
- I'm not sure about this one, but the package provides the following:
libnm-l2tp-properties.so()(64bit)
nm-l2tp-pppd-plugin.so()(64bit)
= These seem to be plugins for NetworkManager, shouldn't the Provides be
filtered out?
[!]: Scriptlets must be sane, if used.
- There are scriptlets to update the desktop-database and the icon-cache, but
no corresponding files are installed. (in fact, they are commented out of
the %files section)
= If these files really shouldn't be installed, then remove the scriptlets.
[!]: Packages should try to preserve timestamps of original installed files.
= You can fix that by running install as follows:
make install DESTDIR=$RPM_BUILD_ROOT INSTALL=/usr/bin/install -p
[!]: Spec use %global instead of %define.
- Note:
%define nm_version 1:0.9.2
%define dbus_version 1.1
%define gtk3_version 3.0
%define ppp_version 2.4.5
%define shared_mime_version 0.16-3
= Replace all %define by %global
[!] Rpmlint is silent (or as silent as reasonable)
- NetworkManager-l2tp.x86_64: E: zero-length
/usr/share/doc/NetworkManager-l2tp-0.9.6/ChangeLog
= You could remove this file, to please rpmlint.
- NetworkManager-l2tp.x86_64: W: non-conffile-in-etc
/etc/dbus-1/system.d/nm-l2tp-service.conf
= This should be marked as %config, probably even %config(noreplace)
- NetworkManager-l2tp.x86_64: W: non-conffile-in-etc
/etc/NetworkManager/VPN/nm-l2tp-service.name
= Ignore, this file is in /etc but IMHO they is not a config file.
- NetworkManager-l2tp.src:94: W: macro-in-comment %{_datadir}
- NetworkManager-l2tp.src:95: W: macro-in-comment %{_datadir}
= Instead of commenting them, maybe remove these two files?
- NetworkManager-l2tp.src:51: W: mixed-use-of-spaces-and-tabs (spaces: line 1,
tab: line 51)
= Not extremely important, but would be nice to fix. :)
= MUST items =
C/C++:
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878653 --- Comment #4 from Ivan Romanov dr...@land.ru --- This errors came from NetworkManager-pptp package. Do I should to inform the NetworkManager-pptp maintainer about it? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878653 --- Comment #5 from Mathieu Bridon boche...@fedoraproject.org --- (In reply to comment #4) This errors came from NetworkManager-pptp package. Do I should to inform the NetworkManager-pptp maintainer about it? If the NetworkManager-pptp package has some packaging errors, it could certainly be fixed, yes. But that's a completely separated issue from this review request. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878653 --- Comment #6 from Ivan Romanov dr...@land.ru --- Fixed. SPEC: https://raw.github.com/drizt/NetworkManager-l2tp-package/9bc4299b02378124604b93ccb2ad7982e78595a2/NetworkManager-l2tp.spec SRPM: https://raw.github.com/drizt/NetworkManager-l2tp-package/9bc4299b02378124604b93ccb2ad7982e78595a2/NetworkManager-l2tp-0.9.6-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878653 --- Comment #7 from Ivan Romanov dr...@land.ru --- [!]: If the source package does not include the text of the license(s), the packager should contact upstream and encourage them to correct this mistake. = Please notify upstream of the problem. https://github.com/seriyps/NetworkManager-l2tp/issues/4 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878653 Mathieu Bridon boche...@fedoraproject.org changed: What|Removed |Added CC||boche...@fedoraproject.org Assignee|nob...@fedoraproject.org|boche...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878653 --- Comment #1 from Ivan Romanov dr...@land.ru --- Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4710817 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878653
--- Comment #2 from Ivan Romanov dr...@land.ru ---
rpmlint output
$ rpmlint NetworkManager-l2tp-0.9.6-1.fc18.src.rpm
NetworkManager-l2tp-0.9.6-1.fc18.x86_64.rpm
NetworkManager-l2tp-debuginfo-0.9.6-1.fc18.x86_64.rpm
NetworkManager-l2tp.src:94: W: macro-in-comment %{_datadir}
NetworkManager-l2tp.src:95: W: macro-in-comment %{_datadir}
NetworkManager-l2tp.src:51: W: mixed-use-of-spaces-and-tabs (spaces: line 1,
tab: line 51)
NetworkManager-l2tp.x86_64: E: zero-length
/usr/share/doc/NetworkManager-l2tp-0.9.6/ChangeLog
NetworkManager-l2tp.x86_64: W: non-conffile-in-etc
/etc/dbus-1/system.d/nm-l2tp-service.conf
NetworkManager-l2tp.x86_64: W: non-conffile-in-etc
/etc/NetworkManager/VPN/nm-l2tp-service.name
3 packages and 0 specfiles checked; 1 errors, 5 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
