[Bug 879933] Review Request: caelum - Add-on for the 3D graphics rendering engine OGRE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=879933

Mattia Verga  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Blocks||201449 (FE-DEADREVIEW)
 Resolution|--- |NOTABUG
   Assignee|mattia.ve...@email.it   |nob...@fedoraproject.org
  Flags|fedora-review?  |
   |needinfo?(pa...@hubbitus.in |
   |fo) |
Last Closed||2017-11-16 11:31:29



--- Comment #13 from Mattia Verga  ---
No response, marking it as FE-DEADREVIEW


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 879933] Review Request: caelum - Add-on for the 3D graphics rendering engine OGRE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=879933



--- Comment #12 from Mattia Verga  ---
Review stalled. Response needed from the reporter.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 879933] Review Request: caelum - Add-on for the 3D graphics rendering engine OGRE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=879933

Mattia Verga  changed:

   What|Removed |Added

 CC||pa...@hubbitus.info
  Flags||needinfo?(pa...@hubbitus.in
   ||fo)



--- Comment #11 from Mattia Verga  ---
Seems that fedora-review gives some false positives: header files ARE in -devel
subpackage, and that's ok; directory ownerships are ok.

Two things to correct:
- license files must be treated with the %license macro (not %doc)
- the version number you used is a pre-release ("0.1.git.b33ce46"), but that's
not necessary, the commit you point is the actual release so you should use "1"
as Release number.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 879933] Review Request: caelum - Add-on for the 3D graphics rendering engine OGRE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=879933



--- Comment #10 from Mattia Verga  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Header files in -devel subpackage, if present.
  Note: caelum-debugsource :
 
/usr/src/debug/caelum-0.6.3-0.1.git.b33ce46.fc28.x86_64/main/include/Astronomy.h
  caelum-debugsource :
 
/usr/src/debug/caelum-0.6.3-0.1.git.b33ce46.fc28.x86_64/main/include/CaelumExceptions.h
  caelum-debugsource :
 
/usr/src/debug/caelum-0.6.3-0.1.git.b33ce46.fc28.x86_64/main/include/CaelumPlugin.h
  caelum-debugsource :
 
/usr/src/debug/caelum-0.6.3-0.1.git.b33ce46.fc28.x86_64/main/include/CaelumPrerequisites.h
  caelum-debugsource :
 
/usr/src/debug/caelum-0.6.3-0.1.git.b33ce46.fc28.x86_64/main/include/CaelumScriptTranslator.h
  caelum-debugsource :
 
/usr/src/debug/caelum-0.6.3-0.1.git.b33ce46.fc28.x86_64/main/include/CaelumSystem.h
  caelum-debugsource :
 
/usr/src/debug/caelum-0.6.3-0.1.git.b33ce46.fc28.x86_64/main/include/CameraBoundElement.h
  caelum-debugsource :
 
/usr/src/debug/caelum-0.6.3-0.1.git.b33ce46.fc28.x86_64/main/include/CloudSystem.h
  caelum-debugsource :
 
/usr/src/debug/caelum-0.6.3-0.1.git.b33ce46.fc28.x86_64/main/include/DepthComposer.h
  caelum-debugsource :
 
/usr/src/debug/caelum-0.6.3-0.1.git.b33ce46.fc28.x86_64/main/include/FastGpuParamRef.h
  caelum-debugsource :
 
/usr/src/debug/caelum-0.6.3-0.1.git.b33ce46.fc28.x86_64/main/include/FlatCloudLayer.h
  caelum-debugsource :
 
/usr/src/debug/caelum-0.6.3-0.1.git.b33ce46.fc28.x86_64/main/include/GroundFog.h
  caelum-debugsource :
 
/usr/src/debug/caelum-0.6.3-0.1.git.b33ce46.fc28.x86_64/main/include/ImageStarfield.h
  caelum-debugsource :
 
/usr/src/debug/caelum-0.6.3-0.1.git.b33ce46.fc28.x86_64/main/include/InternalUtilities.h
  caelum-debugsource :
  /usr/src/debug/caelum-0.6.3-0.1.git.b33ce46.fc28.x86_64/main/include/Moon.h
  caelum-debugsource :
 
/usr/src/debug/caelum-0.6.3-0.1.git.b33ce46.fc28.x86_64/main/include/PointStarfield.h
  caelum-debugsource :
 
/usr/src/debug/caelum-0.6.3-0.1.git.b33ce46.fc28.x86_64/main/include/PrecipitationController.h
  caelum-debugsource :
 
/usr/src/debug/caelum-0.6.3-0.1.git.b33ce46.fc28.x86_64/main/include/PrivatePtr.h
  caelum-debugsource :
 
/usr/src/debug/caelum-0.6.3-0.1.git.b33ce46.fc28.x86_64/main/include/SkyDome.h
  caelum-debugsource :
 
/usr/src/debug/caelum-0.6.3-0.1.git.b33ce46.fc28.x86_64/main/include/SkyLight.h
  caelum-debugsource :
  /usr/src/debug/caelum-0.6.3-0.1.git.b33ce46.fc28.x86_64/main/include/Sun.h
  caelum-debugsource :
 
/usr/src/debug/caelum-0.6.3-0.1.git.b33ce46.fc28.x86_64/main/include/TypeDescriptor.h
  caelum-debugsource :
 
/usr/src/debug/caelum-0.6.3-0.1.git.b33ce46.fc28.x86_64/main/include/UniversalClock.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL (v3 or later)", "GPL (v3)", "Unknown or generated". 62
 files have unknown license. Detailed output of licensecheck in
 /home/rpmbuild/caelum/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/.build-id(kde-
 platform-plugin, cups-client, efivar-libs, rsyslog, policycoreutils-
 python-utils, phonon, rpm-plugin-selinux, abrt, libimagequant, giflib,
 trousers, python2-h5py, libdb-utils, xorg-x11-font-utils, perl-Sys-
 Syslog, libcom_err, libseccomp, kf5-libgravatar, ksysguardd, p11-kit,
 rpm-build, libmodman, cfitsio, parted, gnome-disk-utility,
 kf5-kcontacts, libdvdread, zstd, bluez-libs, kf5-kjobwidgets, libwebp,
 libxslt, system-config-printer-udev, perl-Encode, elfutils,
 python2-cryptography, kf5-kdeclarative, libevdev, libgpg-error, kf5
 -kio-devel, lvm2-libs, kf5-sonnet-core, perl-Digest-SHA, kf5-solid,
 sddm, libzstd, kf5-kpimtextedit, avahi, symlinks, libzip,
 b43-fwcutter, 

[Bug 879933] Review Request: caelum - Add-on for the 3D graphics rendering engine OGRE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=879933

Mattia Verga  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mattia.ve...@email.it
   Assignee|nob...@fedoraproject.org|mattia.ve...@email.it
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 879933] Review Request: caelum - Add-on for the 3D graphics rendering engine OGRE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=879933



--- Comment #9 from Pavel Alexeev  ---
Changes:
https://github.com/Hubbitus/Fedora-packaging/commit/1a21b6833370f97b8091f63e68a6a2a40e7c9e16
Spec:
https://github.com/Hubbitus/Fedora-packaging/blob/1a21b6833370f97b8091f63e68a6a2a40e7c9e16/SPECS/caelum.spec
Srpm:
http://rpm.hubbitus.info/Fedora23/caelum/caelum-0.6.3-0.1.git.b33ce46.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 879933] Review Request: caelum - Add-on for the 3D graphics rendering engine OGRE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=879933



--- Comment #8 from Upstream Release Monitoring 
 ---
hubbitus's scratch build of caelum-0.6.3-0.1.git.b33ce46.fc23.src.rpm for f23
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12673865

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 879933] Review Request: caelum - Add-on for the 3D graphics rendering engine OGRE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=879933



--- Comment #6 from Upstream Release Monitoring 
 ---
hubbitus's scratch build of caelum-0.6.2-0.1.git.e776a80.fc23.src.rpm for f23
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12487488

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 879933] Review Request: caelum - Add-on for the 3D graphics rendering engine OGRE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=879933



--- Comment #7 from Pavel Alexeev  ---
New version.

Changes:
https://github.com/Hubbitus/Fedora-packaging/commit/b06c8595ba1157e195dd4db4549476ec869e28e3
Spec:
https://raw.githubusercontent.com/Hubbitus/Fedora-packaging/b06c8595ba1157e195dd4db4549476ec869e28e3/SPECS/caelum.spec
Srpm:
http://rpm.hubbitus.info/Fedora23/caelum/caelum-0.6.2-0.1.git.e776a80.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 879933] Review Request: caelum - Add-on for the 3D graphics rendering engine OGRE

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=879933

--- Comment #5 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info ---
(In reply to comment #4)
 I threat it as system library. Why you are doubt?
 
 Because there is no soname versioning.
It is because it just OGRE plugin.


  I think it should be enough to include lgpl.txt.
 And exclude gpl.txt? Why?
 
 Well, the caelum license is LGPL. I can't see a reason why you would include
 copies of other licenses.
 
 
 The OIS.h issue isn't solved yet. All mock builds fail.
Ok, BR ois-devel added.

Now it built ok: http://koji.fedoraproject.org/koji/taskinfo?taskID=4942772


https://github.com/Hubbitus/Fedora-packaging/commit/cbfe6d2e4b36d1935507f2154763ca53bb28918b
http://hubbitus.info/rpm/Fedora18/caelum/caelum-0.6.1-4.fc18.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=5yGR52renKa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 879933] Review Request: caelum - Add-on for the 3D graphics rendering engine OGRE

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=879933

--- Comment #4 from Volker Fröhlich volke...@gmx.at ---
I threat it as system library. Why you are doubt?

Because there is no soname versioning.


 I think it should be enough to include lgpl.txt.
And exclude gpl.txt? Why?

Well, the caelum license is LGPL. I can't see a reason why you would include
copies of other licenses.


The OIS.h issue isn't solved yet. All mock builds fail.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=mHhE2Kfemfa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 879933] Review Request: caelum - Add-on for the 3D graphics rendering engine OGRE

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=879933

--- Comment #3 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info ---
Susi Lehtola thanks to the hint.

(In reply to comment #1)
 The build fails for me:
 
 
 -- Looking for C++ include OIS.h - not found
 could not find the OIS includes. Please install them.
 
 
 Not sure if this is the cause though.

 ?_isa (See SocketW comment!)
fixed

 /usr has a macro
It is not sense in case of clearing unneeded files in string:
rm -rf %{buildroot}/usr/doc
because it is not install by correct path but clearing garbage instead by
hardcoded path in build directory.

 I think it should be enough to include lgpl.txt.
And exclude gpl.txt? Why?

 Requires:   pkgconfig should be in the section of the devel package
 and possibly as BR
Moved. But I think it should be Require dependency.
Please look at 
http://fedoraproject.org/wiki/Packaging:Guidelines#Pkgconfig_Files_.28foo.pc.29
and http://fedoraproject.org/wiki/Archive:PackagingDrafts/pkgconfig

As moovind into devel is good catch, it may be also used by developer by hand
as pkgconfig provide cli tool to query database.

 
 BR cmake
Fixed.

 
 Is this really a system wide library or rather a private one?
I threat it as system library. Why you are doubt?


http://hubbitus.info/rpm/Fedora17/caelum/caelum.spec
http://hubbitus.info/rpm/Fedora17/caelum/caelum-0.6.1-2.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 879933] Review Request: caelum - Add-on for the 3D graphics rendering engine OGRE

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=879933

Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info changed:

   What|Removed |Added

 Blocks||879928

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 879933] Review Request: caelum - Add-on for the 3D graphics rendering engine OGRE

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=879933

Volker Fröhlich volke...@gmx.at changed:

   What|Removed |Added

 CC||volke...@gmx.at

--- Comment #1 from Volker Fröhlich volke...@gmx.at ---
The build fails for me:


-- Looking for C++ include OIS.h - not found
could not find the OIS includes. Please install them.


Not sure if this is the cause though.


?_isa (See SocketW comment!)

/usr has a macro

I think it should be enough to include lgpl.txt.

Requires:   pkgconfig should be in the section of the devel package and
possibly as BR

BR cmake

Is this really a system wide library or rather a private one?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 879933] Review Request: caelum - Add-on for the 3D graphics rendering engine OGRE

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=879933

Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 CC||jussi.leht...@iki.fi

--- Comment #2 from Jussi Lehtola jussi.leht...@iki.fi ---
%build
cmake .
make %{?_smp_mflags}

%install
%make_install

mv %{buildroot}/usr/local/* %{buildroot}/usr/
rmdir %{buildroot}/usr/local/
# 64 path fix
mv %{buildroot}/usr/lib %{buildroot}/%{_libdir}


This is just plain wrong. Use

%build
%cmake .
make %{?_smp_mflags}

%install
make install DESTDIR=%{buildroot}

which does everything it should.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review