[Bug 882508] Review Request: appmenu-qt - Global application menu to Qt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882508 Mario Blättermann changed: What|Removed |Added Blocks||656997 (kde-reviews) CC||damianator...@gmail.com --- Comment #1 from Mario Blättermann --- *** Bug 842124 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882508] Review Request: appmenu-qt - Global application menu to Qt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882508 Rex Dieter changed: What|Removed |Added CC||rdie...@math.unl.edu Alias||appmenu-qt --- Comment #2 from Rex Dieter --- i'll try to help review this over this weekend... -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882508] Review Request: appmenu-qt - Global application menu to Qt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882508 Kevin Kofler changed: What|Removed |Added CC||ke...@tigcc.ticalc.org --- Comment #3 from Kevin Kofler --- Your License tag "LGPLv2 with exceptions or GPLv3" is fine. FWIW, the LGPLv2 allows converting to any later version of the GPL, in particular to v3, so the dual-licensing is redundant, but for some reason Nokia decided to make this explicit in some places. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882508] Review Request: appmenu-qt - Global application menu to Qt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882508 Mario Blättermann changed: What|Removed |Added Depends On||882512 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882508] Review Request: appmenu-qt - Global application menu to Qt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882508 Mario Blättermann changed: What|Removed |Added Blocks||882512 Depends On|882512 | -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882508] Review Request: appmenu-qt - Global application menu to Qt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882508 Rex Dieter changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jfiFdk2Y11&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882508] Review Request: appmenu-qt - Global application menu to Qt
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=882508
Rex Dieter changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #4 from Rex Dieter ---
I'll echo some comments from the previous dup'd review,
naming: ok
sources: ok
md5sum *.bz2
90cce750e5412d43ce075b0a9bdb6782 appmenu-qt-0.2.6.tar.bz2
license: ok
(or use Kevin's suggestion)
macros: ok
1. could use some polish, SHOULD be using fedora's %_qt4_plugindir macro
instead of hard-coding %{_libdir}/qt4/plugins
scriptlets: n/a
otherwise, it's a relatively simple package, I see nothing else that needs
work.
As far as I'm concerned, item 1 is relatively cosmetic, and it's ok with me as
long as it is addressed prior to doing any official fedora builds.
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=aIwdWcsa0X&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882508] Review Request: appmenu-qt - Global application menu to Qt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882508 Mario Blättermann changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Mario Blättermann --- Thanks for that quick review. Before I build the packages from the to be created Git repo, I will change the hardcoded plugin path to the proposed %_qt4_plugindir. New Package SCM Request === Package Name: appmenu-qt Short Description: Global application menu to Qt Owners: mariobl Branches: f18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BACr7ZnS7D&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882508] Review Request: appmenu-qt - Global application menu to Qt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882508 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gS3Q1iRPKS&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882508] Review Request: appmenu-qt - Global application menu to Qt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882508 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vFi5tYfHC6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882508] Review Request: appmenu-qt - Global application menu to Qt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882508 --- Comment #7 from Fedora Update System --- appmenu-qt-0.2.6-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/appmenu-qt-0.2.6-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BaERmdjoTp&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882508] Review Request: appmenu-qt - Global application menu to Qt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882508 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jFz3ZFIAKF&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882508] Review Request: appmenu-qt - Global application menu to Qt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882508 --- Comment #8 from Fedora Update System --- appmenu-qt-0.2.6-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=C8nfLq8onR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882508] Review Request: appmenu-qt - Global application menu to Qt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882508 --- Comment #9 from Fedora Update System --- appmenu-qt-0.2.6-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MYdiTlDL9K&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882508] Review Request: appmenu-qt - Global application menu to Qt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882508 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2013-01-11 19:48:07 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2vqrgHzKcG&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882508] Review Request: appmenu-qt - Global application menu to Qt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882508 nucleo changed: What|Removed |Added CC||alekc...@googlemail.com --- Comment #10 from nucleo --- If KDE 4.10 will be in F17 then maybe makes sense F17 branch for appmenu-qt? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lveCjt653U&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882508] Review Request: appmenu-qt - Global application menu to Qt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882508 Rex Dieter changed: What|Removed |Added Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #11 from Rex Dieter --- yes! Package Change Request == Package Name: appmenu-qt New Branches: f17 owners: jreznik rdieter rrix -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UX1OR235Sq&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882508] Review Request: appmenu-qt - Global application menu to Qt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882508 --- Comment #12 from Jon Ciesla --- No owner specified. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vr7rT3ZGUZ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882508] Review Request: appmenu-qt - Global application menu to Qt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882508 Rex Dieter changed: What|Removed |Added Flags||fedora-cvs? --- Comment #13 from Rex Dieter --- Package Change Request == Package Name: appmenu-qt New Branches: f17 Owners: jreznik rdieter rrix -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XahI102EKg&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882508] Review Request: appmenu-qt - Global application menu to Qt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882508 --- Comment #14 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FzkUS6jmir&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882508] Review Request: appmenu-qt - Global application menu to Qt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882508 --- Comment #15 from Fedora Update System --- appmenu-qt-0.2.6-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/appmenu-qt-0.2.6-3.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XswLjhsB4Z&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882508] Review Request: appmenu-qt - Global application menu to Qt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882508 Fedora Update System changed: What|Removed |Added Resolution|CURRENTRELEASE |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HygjeyybGf&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882508] Review Request: appmenu-qt - Global application menu to Qt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882508 --- Comment #16 from Fedora Update System --- appmenu-qt-0.2.6-3.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hOuQgVrMvm&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
