[Bug 884759] Review Request: toilet - colorful ASCII art generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=884759

Miroslav Suchý  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Blocks|177841 (FE-NEEDSPONSOR) |201449 (FE-DEADREVIEW)
 Resolution|--- |NOTABUG
  Flags|needinfo?(zidkova.zuzana@se |
   |znam.cz)|
Last Closed||2016-02-08 09:06:40



--- Comment #19 from Miroslav Suchý  ---
No response. Closing as dead review. If you ever want to continue, please
resubmit.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 884759] Review Request: toilet - colorful ASCII art generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=884759

Miroslav Suchý msu...@redhat.com changed:

   What|Removed |Added

 CC||msu...@redhat.com
  Flags||needinfo?(zidkova.zuzana@se
   ||znam.cz)



--- Comment #18 from Miroslav Suchý msu...@redhat.com ---
Ping! Any progress here?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 884759] Review Request: toilet - colorful ASCII art generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=884759
Bug 884759 depends on bug 1062632, which changed state.

Bug 1062632 Summary: please update to libcaca 0.99.beta18
https://bugzilla.redhat.com/show_bug.cgi?id=1062632

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 884759] Review Request: toilet - colorful ASCII art generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=884759

Zuzana zidkova.zuz...@seznam.cz changed:

   What|Removed |Added

 Depends On||1062632




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1062632
[Bug 1062632] please update to libcaca 0.99.beta18
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 884759] Review Request: toilet - colorful ASCII art generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=884759

Zuzana zidkova.zuz...@seznam.cz changed:

   What|Removed |Added

  Flags|needinfo?(zidkova.zuzana@se |
   |znam.cz)|
   |needinfo?(pknirsch@redhat.c |
   |om) |
   |needinfo?(zidkova.zuzana@se |
   |znam.cz)|



--- Comment #14 from Zuzana zidkova.zuz...@seznam.cz ---
Packages updated. Thank you for advice and sorry for the delay. 

http://jnovy.fedorapeople.org/toilet/toilet.spec
http://jnovy.fedorapeople.org/toilet/toilet-0.2-1.fc19.src.rpm

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 884759] Review Request: toilet - colorful ASCII art generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=884759

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|pknir...@redhat.com |nob...@fedoraproject.org
  Flags|fedora-review?  |



--- Comment #15 from Christopher Meng cicku...@gmail.com ---
(In reply to Zuzana from comment #14)
 Packages updated. Thank you for advice and sorry for the delay. 

No problem. Issues:

1. The latest version is 0.3. Please read comment 3 carefully.

2. Remove rm -rf $RPM_BUILD_ROOT in %install, not needed anymore nowadays.

3. And, you didn't bump the changelog for each change, please do from now on.

4. Michael pointed out the poor summary in the past, and I think the title of
this bug contains a good example, however the one you currently use is poor
still:

5. Summary: Display large colorful characters is still not perfect.

One day

Noob A: Is it a library?
Noob B: Maybe, but I think it's a utility, bash script?
Noob C: Why bash script? Can be javascript as well!
Noob D: W** is the large colorful?
Noob E: Dunno.

Then they go away.

---

Advice: Since you still need a sponsor, please send a self introduction email
to @devel list to introduce yourself.

To assignee: Please keep review flag cohering with the assignee, please re
assign this to yourself if you still have interests.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 884759] Review Request: toilet - colorful ASCII art generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=884759

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 CC|package-review@lists.fedora |
   |project.org |



--- Comment #13 from Christopher Meng cicku...@gmail.com ---
ping again.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 884759] Review Request: toilet - colorful ASCII art generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=884759

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 CC||cicku...@gmail.com
  Flags||needinfo?(pknirsch@redhat.c
   ||om)



--- Comment #11 from Christopher Meng cicku...@gmail.com ---
Status?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=UlKAoZMu25a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 884759] Review Request: toilet - colorful ASCII art generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=884759

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 CC||zidkova.zuz...@seznam.cz
  Flags||needinfo?(zidkova.zuzana@se
   ||znam.cz)



--- Comment #12 from Christopher Meng cicku...@gmail.com ---
What's up?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=wXz8gbDIx4a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 884759] Review Request: toilet - colorful ASCII art generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=884759

Simon Green sgr...@redhat.com changed:

   What|Removed |Added

   Assignee|jn...@redhat.com|pknir...@redhat.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=X9nwtDaO87a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 884759] Review Request: toilet - colorful ASCII art generator

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=884759

--- Comment #9 from Michael Schwendt mschwe...@gmail.com ---
  Summary:figlet alternative

 could you please rephrase the Summary in a way that it starts with
 a capital letter?

Even better, replace the summary with a clear and concise one. Such as the one
used for the title of this ticket:

  Summary: Colorful ASCII Art Generator

Taking the summary from the manual page, it would be:

  Summary: Display large colorful characters

Referencing the figlet utility might be sane in the longer description,
although it requires the reader to know the figlet utility. In the summary,
however, it should be possible to sum up what a package does without
referring to the name of some other package or piece of software. Don't focus
on what the package/software is named. The package %name is for that, and the
%description can also expand on the name of the software.


 %{_datadir}/figlet/*

https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
https://fedoraproject.org/wiki/Packaging:UnownedDirectories

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=IXCURgcHVna=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 884759] Review Request: toilet - colorful ASCII art generator

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=884759

--- Comment #3 from Zuzana zidkova.zuz...@seznam.cz ---
- FAS username is sysl

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=mths9RGqkWa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 884759] Review Request: toilet - colorful ASCII art generator

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=884759

--- Comment #4 from Zuzana zidkova.zuz...@seznam.cz ---
 - toilet 0.3 build requires new libcaca library still not packaged in Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=1xr0iueBDAa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 884759] Review Request: toilet - colorful ASCII art generator

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=884759

Michael Scherer m...@zarb.org changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)

--- Comment #5 from Michael Scherer m...@zarb.org ---
Since you are not in any packager group, could you please follow the step on 
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers ?

I have marked this bug as needing a sponsor.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=pMvQBwgCp5a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 884759] Review Request: toilet - colorful ASCII art generator

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=884759

--- Comment #6 from Zuzana zidkova.zuz...@seznam.cz ---
Ok thaks, 

Spec URL: http://jnovy.fedorapeople.org/toilet/toilet.spec
SRPM URL: http://jnovy.fedorapeople.org/toilet/toilet-0.2-0.2.fc18.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=vqC2oXavela=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 884759] Review Request: toilet - colorful ASCII art generator

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=884759

Jindrich Novy jn...@redhat.com changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|jn...@redhat.com
  Flags||fedora-review?

--- Comment #7 from Jindrich Novy jn...@redhat.com ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=p21PWU7ag0a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 884759] Review Request: toilet - colorful ASCII art generator

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=884759

Jindrich Novy jn...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags||needinfo?(zidkova.zuzana@se
   ||znam.cz)

--- Comment #8 from Jindrich Novy jn...@redhat.com ---
rpmlint output on src.rpm:

$ rpmlint toilet-0.2-0.2.fc18.src.rpm 
toilet.src: W: spelling-error Summary(en_US) figlet - filet, fillet, piglet
- sane as it references figlet utility

toilet.src: W: summary-not-capitalized C figlet alternative
- could you please rephrase the Summary in a way that it starts with a capital
letter?

toilet.src: W: spelling-error %description -l en_US ancronym - acronym,
antonym
- there seems to be a typo in %description here

toilet.src: W: spelling-error %description -l en_US libcaca - biblical
- sane, it's a library name

toilet.src: W: spelling-error %description -l en_US folowing - flowing,
following, fol owing
- seems that 'l' is missing in following

toilet.src: W: spelling-error %description -l en_US colour - color, co lour,
co-lour
- US English prefers color

toilet.src: W: spelling-error %description -l en_US smushing - mushing,
smashing, shushing
- not sure here but 

IMO the %description seems to me too verbose with a lot of duplicities. Could
you please reduce it?

Running rpmlint on built RPM reveals:
toilet.x86_64: E: standard-dir-owned-by-package /usr/share/man/man1

So it seems it is better to own the man page like this in the %files section:
%{_mandir}/man1/%{name}*

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=XY9PqBhVv9a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 884759] Review Request: toilet - colorful ASCII art generator

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=884759

Fabian Affolter m...@fabian-affolter.ch changed:

   What|Removed |Added

 CC||m...@fabian-affolter.ch

--- Comment #2 from Fabian Affolter m...@fabian-affolter.ch ---
Just some quick comments:

- The latest version of toilet is 0.3
- Please rephrase the summery
- There is a test folder in the source tarball. Please consider to run the test
in a %check section
- There are fonts in the source tarball. Are those fonts bundled?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=r08W9FHxDCa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 884759] Review Request: toilet - colorful ASCII art generator

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=884759

Michael Scherer m...@zarb.org changed:

   What|Removed |Added

 CC||m...@zarb.org

--- Comment #1 from Michael Scherer m...@zarb.org ---
Hi,

you didn't gave your username, and the email you us do not correspond to the
one of jnovy in FAS, can you give the info ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=bHoTtOvCvIa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review