[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- seam-solder-3.1.1-2.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0BUNxTdxVNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 Gerard Ryan ger...@ryan.lt changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4Q8WJklUxha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2013-01-19 22:37:52 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=o5ZSywgQxga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- seam-solder-3.1.1-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sioz2MHU9Ya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pthh9SZiG3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- seam-solder-3.1.1-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jjcmf9hENma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 gil cattaneo punto...@libero.it changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from gil cattaneo punto...@libero.it --- New Package SCM Request === Package Name: seam-solder Short Description: A portable CDI extensions library Owners: gil Branches: f17 f18 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tfbbe5H93fa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 gil cattaneo punto...@libero.it changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dfYf7fwXaFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eh4SPzxf61a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wTaPM1ufa2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- seam-solder-3.1.1-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/seam-solder-3.1.1-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uwenmX6zLwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- seam-solder-3.1.1-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/seam-solder-3.1.1-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FEjYNLjxLWa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 --- Comment #5 from Gerard Ryan ger...@ryan.lt --- Ok, I'll review it when you add that to the spec and post new links. :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SpZ14oxrSTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 --- Comment #6 from gil cattaneo punto...@libero.it --- Spec URL: http://gil.fedorapeople.org/seam-solder.spec SRPM URL: http://gil.fedorapeople.org/seam-solder-3.1.1-1.fc18.src.rpm Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=4826922 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NTwKYl5P2Da=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885043
Gerard Ryan ger...@ryan.lt changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|ger...@ryan.lt
Flags||fedora-review?
--- Comment #7 from Gerard Ryan ger...@ryan.lt ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[-]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in %package
javadoc
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Apache (v2.0), LGPL (v2.1 or later), Unknown or generated. 3 files
have unknown license. Detailed output of licensecheck in
/home/grdryn/dev/fedora/review/885043-seam-solder/licensecheck.txt
see issue #1 below
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 40960 bytes in 5 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
[x]: Fully versioned dependency in subpackages, if present.
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
[x]: Bundled jar/class files should be removed before build
Maven:
[x]: Pom files have correct add_maven_depmap call
Note: Some add_maven_depmap calls found. Please check if they are correct
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]: If package contains pom.xml files install it (including depmaps) even
when building with ant
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 Gerard Ryan ger...@ryan.lt changed: What|Removed |Added Whiteboard|NotReady| -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fbdDZ5Nbdya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 --- Comment #8 from gil cattaneo punto...@libero.it --- Spec URL: http://gil.fedorapeople.org/seam-solder.spec SRPM URL: http://gil.fedorapeople.org/seam-solder-3.1.1-2.fc18.src.rpm - fixed license field -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Q54wKnnznoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 Gerard Ryan ger...@ryan.lt changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #9 from Gerard Ryan ger...@ryan.lt --- Thanks, I've verified that it has changed. (For anyone else looking at this review, the spec in the 'Spec URL' of the above post hasn't changed, but the spec inside the srpm has the necessary changes). ACCEPTED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LAVfLxullUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 Bug 885043 depends on bug 885039, which changed state. Bug 885039 Summary: Review Request: seam-parent - The parent for Seam modules https://bugzilla.redhat.com/show_bug.cgi?id=885039 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=v117LFhjDZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 Gerard Ryan ger...@ryan.lt changed: What|Removed |Added CC||ger...@ryan.lt Whiteboard||NotReady --- Comment #1 from Gerard Ryan ger...@ryan.lt --- This currently fails to build in mock for both rawhide and f18. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=95ifx8CPCsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 --- Comment #2 from gil cattaneo punto...@libero.it --- hi Gerard, may be for a lost builrequires ? BuildRequires: seam-parent -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=R3CZ3KD1eIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 --- Comment #3 from Gerard Ryan ger...@ryan.lt --- (In reply to comment #2) hi Gerard, may be for a lost builrequires ? BuildRequires: seam-parent I think that's the problem for f18, but rawhide has a different problem (since seam-parent is available there). I think this is the relevant snippet from build.log for rawhide: [ERROR] Failed to execute goal on project solder-api: Could not resolve dependencies for project org.jboss.solder:solder-api:jar:3.1.1.Final: Failed to collect dependencies for [org.jboss.logging:jboss-logging:jar:any (compile), javax.enterprise:cdi-api:jar:latest (provided), org.jboss.spec.javax.servlet:jboss-servlet-api_3.0_spec:jar:latest (provided)]: Failed to read artifact descriptor for javax.annotation:jsr250-api:jar:1.0: The repository system is offline but the artifact org.apache.geronimo.specs:specs:pom:1.4 is not available in the local repository. - [Help 1] -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nXvW819PXOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 --- Comment #4 from gil cattaneo punto...@libero.it --- ah ok the problem was casued by missing BuildRequires: geronimo-parent-poms this problem is caused by maven-doxia = 0:1.2-4 M-D was rebuilt with xmvn support and the spec file re-written. this one have lost some requires... regards happy new year -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8ilBRU15Vca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dGcqd1conpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 gil cattaneo punto...@libero.it changed: What|Removed |Added Depends On||885039 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lv6fNJL9nIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
