[Bug 885833] Review Request: tw - translate words into different languages

2013-05-02 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #39 from Fedora Update System upda...@fedoraproject.org ---
tw-0.9.16-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/tw-0.9.16-2.fc19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=rrhRCCsl4oa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2013-05-02 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #41 from Fedora Update System upda...@fedoraproject.org ---
tw-0.9.16-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/tw-0.9.16-2.fc17

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=PMHTVH6dxXa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2013-05-02 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #40 from Fedora Update System upda...@fedoraproject.org ---
tw-0.9.16-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/tw-0.9.16-2.fc18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=kqRBbaZixta=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2013-04-28 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #35 from Fedora Update System upda...@fedoraproject.org ---
tw-0.9.16-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/tw-0.9.16-1.fc19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=LXCwdjYBnQa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2013-04-28 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #36 from Fedora Update System upda...@fedoraproject.org ---
tw-0.9.16-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/tw-0.9.16-1.fc18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=9He3s04pspa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2013-04-28 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #37 from Fedora Update System upda...@fedoraproject.org ---
tw-0.9.16-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/tw-0.9.16-1.fc17

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=kM0RtGxMDwa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2013-04-28 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #38 from Kevin Kofler ke...@tigcc.ticalc.org ---
Please DO NOT reference the review request on every single update of the
package. Doing so only makes sense for the initial newpackage update. Once the
package is in (i.e. the initial update is pushed), the review request is closed
and further updates need not and should not reference it anymore.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=aWheloxGDRa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2013-01-28 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #32 from Fedora Update System upda...@fedoraproject.org ---
tw-0.9.8-1.fc18 has been pushed to the Fedora 18 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=pjId7yRKjJa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2013-01-28 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #33 from Fedora Update System upda...@fedoraproject.org ---
tw-0.9.8-1.fc16 has been pushed to the Fedora 16 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=1zJl8PDFKIa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2013-01-28 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #34 from Fedora Update System upda...@fedoraproject.org ---
tw-0.9.8-1.fc17 has been pushed to the Fedora 17 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=P1bDaT5mk3a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2013-01-17 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #29 from Fedora Update System upda...@fedoraproject.org ---
tw-0.9.8-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/tw-0.9.8-1.fc18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=N1bzlnlRZfa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2013-01-17 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #30 from Fedora Update System upda...@fedoraproject.org ---
tw-0.9.8-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/tw-0.9.8-1.fc17

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=HeW1wZRRwQa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2013-01-17 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #31 from Fedora Update System upda...@fedoraproject.org ---
tw-0.9.8-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/tw-0.9.8-1.fc16

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=a2AIcniPvna=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2013-01-11 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #28 from Fedora Update System upda...@fedoraproject.org ---
tw-0.9.4-7.fc18 has been pushed to the Fedora 18 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=mcOMuVQdGMa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-27 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #26 from Fedora Update System upda...@fedoraproject.org ---
tw-0.9.4-7.fc17 has been pushed to the Fedora 17 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=bnd6VtdYWza=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-27 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #27 from Fedora Update System upda...@fedoraproject.org ---
tw-0.9.4-7.fc16 has been pushed to the Fedora 16 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=2Yw4Y7cwAna=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-27 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2012-12-27 22:48:52

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ZYXm9tOsA2a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-14 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #24 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ylnVvuW3vIa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-14 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #25 from Fedora Update System upda...@fedoraproject.org ---
tw-0.9.4-7.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/tw-0.9.4-7.fc16

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=o5Yv041zkea=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-13 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu
  Flags||fedora-review?

--- Comment #14 from Rex Dieter rdie...@math.unl.edu ---
i can help finish up the review today (hopefully)...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=rAAlnfH0dla=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-13 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #15 from Rex Dieter rdie...@math.unl.edu ---
naming: ok

sources: ok
md5sum *.bz2
8e0a7c167e357c860601b5348469ad15  tw-0.9.4.tar.bz2

license: close, but...
licensecheck -r src
src/tw.in.sh: GPL (v3 or later)
src/tw_mythes.sh: GPL (v3 or later)
src/cmd.sh: GPL (v3 or later)
src/mythes.cxx: *No copyright* UNKNOWN
src/engines/tw_cache.sh: GPL (v3 or later)
src/engines/tw_ft.sh: GPL (v3 or later)
src/engines/tw_share.sh: GPL (v3 or later)
src/engines/tw_yb.sh: GPL (v3 or later)
src/engines/tw_local.sh: GPL (v3 or later)
src/engines/tw_gt.sh: GPL (v3 or later)

1. MUST: Seems we can use
License: GPLv3+
here

2. SHOULD consider omitting deprecated stuff from .spec like
BuildRoot:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#BuildRoot_tag

Group:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Group_tag

%clean:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#.25clean

%defattr:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_Permissions

scriptlets: ok

macros: ok

dependencies: NOT ok
3. MUST:  hrm, I can't find it explicitly in the guidelines at the moment, but
pretty sure you can safely omit:
Requires: glibc-common
which is already implicitly pulled in by pretty much everything already.


Being not a complicated package, the rest looks good, please look over items
1-3.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=pTtdI7jKhVa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-13 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #16 from Juan Manuel juanmabcm...@gmail.com ---
Very instructive, thanks.

* Mon Dec 13 2012 Juan Manuel Borges CaƱo juanmabcm...@gmail.com - 0.9.4-7
- Use GPLv3+.
- Omit deprecated stuff like BuildRoot, Group, clean and defattr.
- Omit Requires: glibc-common, implicitly pulled by pretty much everything
already.
- Add tw-config-klipper to files.

Spec URL: http://translateword.googlecode.com/files/tw.spec
SRPM URL: http://translateword.googlecode.com/files/tw-0.9.4-7.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=75bkOgYjZXa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-13 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |
  Flags|fedora-review?  |
  Flags||fedora-review+

--- Comment #17 from Rex Dieter rdie...@math.unl.edu ---
Looks good, though the tarball changed since comment #15 to include your
klipper bit.

As upstream, that's a bit your perogative.


APPROVED (and sponsored).

Move on to:
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ivBECsZIrxa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-13 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #18 from Juan Manuel juanmabcm...@gmail.com ---
New Package SCM Request
===
Package Name: tw
Short Description: Translate words into different languages
Owners: juanmabc
Branches: f17 f18
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=PrxhMPBJC1a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-13 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

  Flags||fedora-cvs?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=QVOS0M7bkVa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-13 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #19 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=xpeWwGLzKUa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-13 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

Juan Manuel juanmabcm...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs+ |
  Flags||fedora-cvs?

--- Comment #20 from Juan Manuel juanmabcm...@gmail.com ---
Package Change Request
==
Package Name: tw
New Branches: f16
Owners: juanmabc

koji build --scratch f16 succeeds.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=WbAKl7uqwna=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-13 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=gCN38i2f6ta=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-13 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #21 from Fedora Update System upda...@fedoraproject.org ---
tw-0.9.4-7.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/tw-0.9.4-7.fc18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Oucibk95Gma=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-13 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #22 from Fedora Update System upda...@fedoraproject.org ---
tw-0.9.4-7.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/tw-0.9.4-7.fc17

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=OhkoWIh7bra=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-13 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #23 from Fedora Update System upda...@fedoraproject.org ---
tw-0.9.4-7.fc18 has been pushed to the Fedora 18 testing repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=5xYsCbqM3Ea=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-13 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=8f3LBMNpzBa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-11 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #10 from Juan Manuel juanmabcm...@gmail.com ---
*
It is not a binary linking to any program or lib (apart from a real executable
utility linking to mythes trhough hunspell, keeping it arch specific instead of
fully noarch package), it is a shell script binary (#!/usr/bin/env bash).

Anyway, Requires cleaned, lynx and aspell added in Requires:

http://koji.fedoraproject.org/koji/taskinfo?taskID=4778055

*
Accessing Your fedorapeople.org Space
- You must be sponsored in a group (other than the CLA groups)

I could keep trying to get access to any place like that but if the already
provided places don't work i can't seem to be able to provide such space. Try
to select open file instead of save/save as on browser dialog.

*
Spec URL: http://translateword.googlecode.com/files/tw.spec
SRPM URL: http://translateword.googlecode.com/files/tw-0.9.4-5.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=wJnnjvSETHa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-11 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #11 from Kevin Kofler ke...@tigcc.ticalc.org ---
 In Requires, I consider that this should not go
 Requires:   sed
 Requires:   bash
 Requires:   gawk
 Requires:   coreutils

Uh, no, these are actually needed!

I think bash is only autodetected if you use #!/bin/bash directly rather than
#!/usr/bin/env bash. The others are definitely NOT autodetected, because
they're only called in the script, not linked by anything nor used as a #!
line.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=THsZbW3byOa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-11 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #12 from Kevin Kofler ke...@tigcc.ticalc.org ---
(and there are NO implicit Requires, unlike BuildRequires, because you cannot
make any assumptions about user systems)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=TQshlu9ox2a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-11 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #13 from Juan Manuel juanmabcm...@gmail.com ---
* Do not assume anything about Requires.
Spec URL: http://translateword.googlecode.com/files/tw.spec
SRPM URL: http://translateword.googlecode.com/files/tw-0.9.4-6.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=j6PZvwYwtza=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-10 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

Kevin Kofler ke...@tigcc.ticalc.org changed:

   What|Removed |Added

 CC||ke...@tigcc.ticalc.org
Summary|Review Request: tw -  |Review Request: tw -
   |translate words into   |translate words into
   |different languages|different languages

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=UoaQf7Dppba=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-10 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

Antonio Trande trp...@katamail.com changed:

   What|Removed |Added

 CC||trp...@katamail.com

--- Comment #1 from Antonio Trande trp...@katamail.com ---
Hi Juan.
There are some issues just for starting:

- License should be GPLv3.

- Source* tag is the full URL for the compressed archive containing the
(original) pristine source code.
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL

- BuildRequires and Requires entries listed one-by-one; it is important for a
better spec legibility.  

- In BuildRequires tag, coreutils, bash and sed can be omitted.
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Exceptions_2

- Description is too long for a single line.

- Changelog is missing

For more details, you can start with
http://fedoraproject.org/wiki/Packaging:Guidelines

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=3J6KvelSvSa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-10 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #2 from Juan Manuel juanmabcm...@gmail.com ---
Thanks for the info, it was really helpful.

Spec URL: http://translateword.googlecode.com/files/tw-0.9.4-0.2.spec
SRPM URL: http://translateword.googlecode.com/files/tw-0.9.4-0.2.fc17.src.rpm

http://koji.fedoraproject.org/koji/taskinfo?taskID=4775089

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=nNWCNaeZjva=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-10 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #3 from Juan Manuel juanmabcm...@gmail.com ---
Conform to rpmlint. :)

Spec URL: http://translateword.googlecode.com/files/tw-0.9.4-0.3.spec
SRPM URL: http://translateword.googlecode.com/files/tw-0.9.4-0.3.fc17.src.rpm

http://koji.fedoraproject.org/koji/taskinfo?taskID=4775252

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=62Eiaac5zwa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-10 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

Eduardo Echeverria echevemas...@gmail.com changed:

   What|Removed |Added

 CC||echevemas...@gmail.com

--- Comment #4 from Eduardo Echeverria echevemas...@gmail.com ---
Hi Juan
- Please put in the field Blocks the tag FE-NEEDSPONSOR.
- The spec should be in a place where it can be reviewed online, and not to
download.
- the package what provides /usr/bin/xmllint is libxml2
- The tag Release is incorrect, in this case should be only 3, not  0.3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=sDlTgFGPHNa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-10 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

Juan Manuel juanmabcm...@gmail.com changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)

--- Comment #5 from Juan Manuel juanmabcm...@gmail.com ---
I'm gonna attach the spec then.
I was thinking about the tag scheme, fixed.
Block tag FE-NEEDSPONSOR updated, rdieter from #fedora-kde offered.

I was already using libxml2 as requires, but rpmlint complains, not with a
warning but an error:
tw.i686: E: explicit-lib-dependency libxml2

Please confirm to use Requires: /usr/bin/xmllint or Requires: libxml2, as the
later raises an rpmlint error. After that i'll upload.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=zg1AcflhQua=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-10 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #6 from Juan Manuel juanmabcm...@gmail.com ---
Created attachment 661177
  -- https://bugzilla.redhat.com/attachment.cgi?id=661177action=edit
tw-0.9.4-4.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=I0DHBcyPYwa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-10 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #7 from Juan Manuel juanmabcm...@gmail.com ---
As this is a shell script that is calling xmllint, the final way to go seems
Requires: %{_bindir}/xmllint (rdieter).

Spec URL: tw-0.9.4-4.spec attached.
SRPM URL: http://translateword.googlecode.com/files/tw-0.9.4-4.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=knSBV3Ea4ea=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-10 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #8 from Eduardo Echeverria echevemas...@gmail.com ---
Hi Juan

In Requires, I consider that this should not go
Requires:   sed
Requires:   bash
Requires:   gawk
Requires:   coreutils

rpm will auto-detect most Requires: based on what your binary links with

- apparently %{_bindir}/xmllint is detected correctly.
- In koji can see 

http://kojipkgs.fedoraproject.org//work/tasks/7249/4777249/build.log

checking for sed... yes
checking for bash... yes
checking for getopt... yes
checking for gawk... yes
checking for curl... yes
checking for iconv... yes
checking for xmllint... yes
checking for lynx... no
checking for aspell... no

lynx and aspell should be BuildRequires

- Perhaps I did not explain, when i say that your spec  should be in a place
where it can be reviewed online, and not to download.  I mean a direct web
link,  like this:
http://echevemaster.fedorapeople.org/xfce-theme-manager/1/xfce-theme-manager.spec

Regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=DAJJNPGzL7a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

2012-12-10 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #9 from Eduardo Echeverria echevemas...@gmail.com ---
Oh I forgot, the name of your spec should not contain more nothing that the
name of the program, without version numbers. i.e is correct tw.spec instead
of  tw-0.9.4-4.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Cz9b4HUdb1a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review