[Bug 887821] Review Request: nagios-plugins-bonding - Nagios plugin to monitor Linux bonding interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=887821 --- Comment #16 from Fedora Update System --- nagios-plugins-bonding-1.4-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887821] Review Request: nagios-plugins-bonding - Nagios plugin to monitor Linux bonding interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=887821 --- Comment #15 from Fedora Update System --- nagios-plugins-bonding-1.4-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887821] Review Request: nagios-plugins-bonding - Nagios plugin to monitor Linux bonding interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=887821 --- Comment #14 from Fedora Update System --- nagios-plugins-bonding-1.4-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887821] Review Request: nagios-plugins-bonding - Nagios plugin to monitor Linux bonding interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=887821 --- Comment #13 from Fedora Update System --- nagios-plugins-bonding-1.4-1.el5 has been pushed to the Fedora EPEL 5 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887821] Review Request: nagios-plugins-bonding - Nagios plugin to monitor Linux bonding interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=887821 --- Comment #12 from Fedora Update System --- nagios-plugins-bonding-1.4-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/nagios-plugins-bonding-1.4-1.el5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887821] Review Request: nagios-plugins-bonding - Nagios plugin to monitor Linux bonding interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=887821 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887821] Review Request: nagios-plugins-bonding - Nagios plugin to monitor Linux bonding interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=887821 --- Comment #11 from Jon Ciesla --- Already exists. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887821] Review Request: nagios-plugins-bonding - Nagios plugin to monitor Linux bonding interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=887821 --- Comment #10 from Fedora Update System --- nagios-plugins-bonding-1.4-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nagios-plugins-bonding-1.4-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887821] Review Request: nagios-plugins-bonding - Nagios plugin to monitor Linux bonding interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=887821 --- Comment #9 from Fedora Update System --- nagios-plugins-bonding-1.4-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nagios-plugins-bonding-1.4-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887821] Review Request: nagios-plugins-bonding - Nagios plugin to monitor Linux bonding interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=887821 --- Comment #8 from Fedora Update System --- nagios-plugins-bonding-1.4-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nagios-plugins-bonding-1.4-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887821] Review Request: nagios-plugins-bonding - Nagios plugin to monitor Linux bonding interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=887821 Trond H. Amundsen changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Flags|fedora-cvs+ |fedora-cvs? Last Closed||2014-05-13 12:25:19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887821] Review Request: nagios-plugins-bonding - Nagios plugin to monitor Linux bonding interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=887821 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887821] Review Request: nagios-plugins-bonding - Nagios plugin to monitor Linux bonding interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=887821 --- Comment #7 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887821] Review Request: nagios-plugins-bonding - Nagios plugin to monitor Linux bonding interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=887821 Trond H. Amundsen changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Trond H. Amundsen --- New Package SCM Request === Package Name: nagios-plugins-bonding Short Description: Nagios plugin to monitor Linux bonding interfaces Owners: trondham Branches: f19 f20 el5 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887821] Review Request: nagios-plugins-bonding - Nagios plugin to monitor Linux bonding interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=887821
--- Comment #5 from Trond H. Amundsen ---
(In reply to Johan Swensson from comment #4)
> [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
> beginning of %install.
> [!]: Buildroot is not present
> [!]: Package has no %clean section with rm -rf %{buildroot} (or
> $RPM_BUILD_ROOT)
>
> I don't think these should be considered blockers in this case
> due to the fact that you're building for EL5 as well.
Yes, these are required for EL5, unfortunately.
> [!]: Each %files section contains %defattr if rpm < 4.4
> %defattr is not needed anymore, you may drop it during import into git
I didn't know that, thanks for the tip.
> Ideally the package should have been BuildArch: noarch
> But that's not possible as discussed in your other
> package review https://bugzilla.redhat.com/show_bug.cgi?id=743615
> You should mention why it's not noarch as a comment in the spec file.
> Right above this comment would be a good place for such a comment.
> # No binaries here, do not build a debuginfo package
> %global debug_package %{nil}
You're right, I should include that in a comment. Noted.
> [!]: Uses parallel make %{?_smp_mflags} macro.
> Make should always be invoked with %{?_smp_mflags} but in this case
> as there isn't much to be built it should be fine.
The %{?_smp_mflags} won't hurt, either. I'll include it.
> [!]: Requires correct, justified where necessary.
> You could Require nagios-common, as that is the owner of
> %_libdir/nagios/plugins/
> But as nagios-plugins Requires nagios-common this is not currently a blocker.
I guess things have changed slightly since I checked. I checked again to be
sure, and it turns out that %_libdir/nagios/plugins/ is provided by
nagios-common on EL6 and Fedora, and by nagios-plugins on EL5. I'll fix that
with a conditional in the spec file. The package shouldn't require
nagios-plugins if it isn't strictly necessary.
> APPROVED
Thank you so much for the review, and for your helpful comments! :)
-trond
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887821] Review Request: nagios-plugins-bonding - Nagios plugin to monitor Linux bonding interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=887821
Johan Swensson changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #4 from Johan Swensson ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= Issues =
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[!]: Buildroot is not present
[!]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
I don't think these should be considered blockers in this case
due to the fact that you're building for EL5 as well.
[!]: Each %files section contains %defattr if rpm < 4.4
%defattr is not needed anymore, you may drop it during import into git
Ideally the package should have been BuildArch: noarch
But that's not possible as discussed in your other
package review https://bugzilla.redhat.com/show_bug.cgi?id=743615
You should mention why it's not noarch as a comment in the spec file.
Right above this comment would be a good place for such a comment.
# No binaries here, do not build a debuginfo package
%global debug_package %{nil}
[!]: Uses parallel make %{?_smp_mflags} macro.
Make should always be invoked with %{?_smp_mflags} but in this case
as there isn't much to be built it should be fine.
[!]: Requires correct, justified where necessary.
You could Require nagios-common, as that is the owner of
%_libdir/nagios/plugins/
But as nagios-plugins Requires nagios-common this is not currently a blocker.
APPROVED
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[!]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 2 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{na
[Bug 887821] Review Request: nagios-plugins-bonding - Nagios plugin to monitor Linux bonding interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=887821 Johan Swensson changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887821] Review Request: nagios-plugins-bonding - Nagios plugin to monitor Linux bonding interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=887821 Johan Swensson changed: What|Removed |Added Assignee|nob...@fedoraproject.org|k...@kupo.se Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887821] Review Request: nagios-plugins-bonding - Nagios plugin to monitor Linux bonding interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=887821 --- Comment #3 from Trond H. Amundsen --- (In reply to Johan Swensson from comment #2) > Wow, this was an old one. :) Yeah, I'd almost forgotten it :) > If you're still interested I can review this. Yes, I'm still interested. Thanks! -trond -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887821] Review Request: nagios-plugins-bonding - Nagios plugin to monitor Linux bonding interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=887821 Johan Swensson changed: What|Removed |Added CC||k...@kupo.se --- Comment #2 from Johan Swensson --- Wow, this was an old one. :) If you're still interested I can review this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887821] Review Request: nagios-plugins-bonding - Nagios plugin to monitor Linux bonding interfaces
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887821 --- Comment #1 from Trond H. Amundsen --- Scratch-build for f17: http://koji.fedoraproject.org/koji/taskinfo?taskID=4796437 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XXY8EkPWIL&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
