[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891232 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-04-26 23:17:39 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jCQh5Eg0Qba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891232 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DAN7ecKXwHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891232 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- nodejs-ronn-0.4.0-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-ronn-0.4.0-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gAr4cM50GQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891232 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- nodejs-ronn-0.4.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-ronn-0.4.0-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=p4rCyFsPs6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891232 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- nodejs-ronn-0.4.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-ronn-0.4.0-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2ZGlyiHbCta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891232 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RlHrbDH9WXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891232 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- nodejs-ronn-0.4.0-1.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UNM4ViFYJga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891232 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=s0xExdwqN0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891232 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BDcJwbTGqga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891232 --- Comment #8 from T.C. Hollingsworth tchollingswo...@gmail.com --- New Package SCM Request === Package Name: nodejs-ronn Short Description: Markdown to roff/html converter Owners: patches Branches: f19 f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wsvYuY55uOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891232 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=39mkPrKNSXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891232
Miro Hrončok mhron...@redhat.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #7 from Miro Hrončok mhron...@redhat.com ---
Description OK.
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces.
$ rpmlint ../SRPMS/nodejs-ronn-0.3.8-6.fc18.src.rpm
../RPMS/noarch/nodejs-ronn-0.3.8-6.fc18.noarch.rpm
nodejs-ronn.src: W: spelling-error Summary(en_US) roff - toff, riff, off
nodejs-ronn.src: W: spelling-error Summary(en_US) html - HTML, ht ml, ht-ml
nodejs-ronn.src: W: spelling-error %description -l en_US Javascript -
JavaScript, Java script, Java-script
nodejs-ronn.src: W: spelling-error %description -l en_US js - dis, ks, j
nodejs-ronn.src: W: spelling-error %description -l en_US roff - toff, riff,
off
nodejs-ronn.noarch: W: spelling-error Summary(en_US) roff - toff, riff, off
nodejs-ronn.noarch: W: spelling-error Summary(en_US) html - HTML, ht ml, ht-ml
nodejs-ronn.noarch: W: spelling-error %description -l en_US Javascript -
JavaScript, Java script, Java-script
nodejs-ronn.noarch: W: spelling-error %description -l en_US js - dis, ks, j
nodejs-ronn.noarch: W: spelling-error %description -l en_US roff - toff, riff,
off
nodejs-ronn.noarch: W: only-non-binary-in-usr-lib
nodejs-ronn.noarch: W: dangling-symlink
/usr/lib/node_modules/ronn/node_modules/opts /usr/lib/node_modules/opts
nodejs-ronn.noarch: W: dangling-symlink
/usr/lib/node_modules/ronn/node_modules/markdown /usr/lib/node_modules/markdown
nodejs-ronn.noarch: W: no-manual-page-for-binary ronn
2 packages and 0 specfiles checked; 0 errors, 14 warnings.
TODO: Capitalize HTML in Summary.
TODO: Capital S in JavaScript.
Symlinks OK, requires npm(opts), npm(markdown)
TODO: Work with upstream on a manpage
All other duplicates or false positives.
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
Checked in LICENSE file, MIT. OK
There is a BSDL part in the file, but the files are missing from this package,
so it's not important.
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. OK
MUST: The spec file must be written in American English. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
$ sha256sum ../SOURCES/ronn-0.3.8.tgz
53a4837881bcd468ffdc8950272508a025c0bb9255d7460792412b8f820027e6
../SOURCES/ronn-0.3.8.tgz
$ spectool -g nodejs-ronn.spec
$ sha256sum ronn-0.3.8.tgz
53a4837881bcd468ffdc8950272508a025c0bb9255d7460792412b8f820027e6
ronn-0.3.8.tgz
OK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. OK
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense. OK, build
in mock
MUST: Packages must NOT bundle copies of system libraries. OK
MUST: A package must own all directories that it creates. OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. OK
MUST: Permissions on files must be set properly.
$ rpm -q -lv -p ../RPMS/noarch/nodejs-ronn-0.3.8-6.fc18.noarch.rpm
lrwxrwxrwx1 rootroot 36 bře 21 15:15
/usr/bin/ronn - ../lib/node_modules/ronn/bin/ronn.js
drwxr-xr-x2 rootroot0 bře 21 15:15
/usr/lib/node_modules/ronn
drwxr-xr-x2 rootroot0 bře 21 15:15
/usr/lib/node_modules/ronn/bin
-rwxr-xr-x1 rootroot 2940 lis 5 2011
/usr/lib/node_modules/ronn/bin/ronn.js
drwxr-xr-x2 rootroot0 bře 21 15:15
/usr/lib/node_modules/ronn/lib
-rw-r--r--1 rootroot11986 bře 21 15:15
/usr/lib/node_modules/ronn/lib/ronn.js
drwxr-xr-x2 rootroot0 bře 21 15:15
/usr/lib/node_modules/ronn/node_modules
lrwxrwxrwx1 rootroot 30 bře 21 15:15
/usr/lib/node_modules/ronn/node_modules/markdown -
/usr/lib/node_modules/markdown
lrwxrwxrwx1 rootroot 26 bře 21 15:15
[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891232
Tom Hughes t...@compton.nu changed:
What|Removed |Added
CC||t...@compton.nu
--- Comment #5 from Tom Hughes t...@compton.nu ---
There's an error in the unbundling patch - when it creates the markdown parser
it should do:
var md = require('markdown').markdown;
not:
var md = require('markdown');
as the top level parse function exported by the unbundled markdown returns HTML
rather than the parse tree that ronn wants.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=QUIxqNOX3qa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891232 --- Comment #6 from T.C. Hollingsworth tchollingswo...@gmail.com --- Spec: http://patches.fedorapeople.org/npm/nodejs-ronn.spec SRPM: http://patches.fedorapeople.org/npm/nodejs-ronn-0.3.8-6.fc18.src.rpm * Wed Mar 20 2013 T.C. Hollingsworth tchollingswo...@gmail.com - 0.3.8-6 - fix require on markdown -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CWOYlhTg3Ca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891232 Bug 891232 depends on bug 911185, which changed state. Bug 911185 Summary: Review Request: nodejs-markdown - A sensible Markdown parser for JavaScript https://bugzilla.redhat.com/show_bug.cgi?id=911185 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fCkQAvxoYra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891232 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Depends On||911185 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=axzsqgv4Yza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891232 Bug 891232 depends on bug 922288, which changed state. Bug 922288 Summary: Review Request: nodejs-markdown - A sensible Markdown parser for JavaScript https://bugzilla.redhat.com/show_bug.cgi?id=922288 What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xE4cbsLERxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891232 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Depends On||922288 Flags|needinfo?(tchollingsworth@g | |mail.com) | --- Comment #4 from T.C. Hollingsworth tchollingswo...@gmail.com --- Sorry for the delay. I have unbundled markdown, filed a review request in bug 922288 for nodejs-markdown, and filed a pull request upstream: https://github.com/kapouer/ronnjs/pull/13 Spec: http://patches.fedorapeople.org/npm/nodejs-ronn.spec SRPM: http://patches.fedorapeople.org/npm/nodejs-ronn-0.3.8-5.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=j2kye2CiJ3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891232 Miro Hrončok mhron...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mhron...@redhat.com Assignee|nob...@fedoraproject.org|mhron...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3fntGhALCHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891232 --- Comment #3 from Miro Hrončok mhron...@redhat.com --- Isn't the markdown.js file bundling? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xLRQxpzGrna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891232 Miro Hrončok mhron...@redhat.com changed: What|Removed |Added Flags||needinfo?(tchollingsworth@g ||mail.com) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AoWyzWn3nra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891232 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||905256 (F19FeatureNodeJS) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GCRUmTcyUwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891232 --- Comment #2 from T.C. Hollingsworth tchollingswo...@gmail.com --- This package isn't strictly needed by anything but I'd like it in the distro anyway because it allows me to write man pages for scripts that are missing man pages in markdown. I suspect most upstreams will be more likely to merge man pages written this way. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Vc1ikSIGdda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891232 Bug 891232 depends on bug 891217, which changed state. Bug 891217 Summary: nodejs-opts - Javascript Command Line Options for Node.js https://bugzilla.redhat.com/show_bug.cgi?id=891217 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L78CGL5epQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891232 Michael Scherer m...@zarb.org changed: What|Removed |Added CC||m...@zarb.org Depends On||891217 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6TVJOZ9iGla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891232 --- Comment #1 from T.C. Hollingsworth tchollingswo...@gmail.com --- Updated with empty %build sections and other issues found in various reviews. Spec: http://patches.fedorapeople.org/npm/nodejs-ronn.spec SRPM: http://patches.fedorapeople.org/npm/nodejs-ronn-0.3.8-4.fc17.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4854388 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WreykT8NCFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891232] nodejs-ronn - markdown to roff/html converter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891232 Michael Scherer m...@zarb.org changed: What|Removed |Added Blocks|891171 | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cjAprMDJABa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
