Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=892315
Darryl L. Pierce dpie...@redhat.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #1 from Darryl L. Pierce dpie...@redhat.com ---
Package Review
==
Key:
[X] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[X]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package requires other packages for directories it uses.
[X]: Package uses nothing in %doc for runtime.
[X]: Package is not known to require ExcludeArch.
[!]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rubygem-
webrobots-doc
The Require in -doc does not include %{?_isa}.
[X]: Package complies to the Packaging Guidelines
[X]: License file installed when any subpackage combination is installed.
[X]: Package consistently uses macro is (instead of hard-coded directory
names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[X]: Package must own all directories that it creates.
[X]: Package does not own files or directories owned by other packages.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[X]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[X]: Each %files section contains %defattr if rpm 4.4
[X]: Macros in Summary, %description expandable at SRPM build time.
[X]: Package does not contain duplicates in %files.
[X]: Permissions on files are set properly.
[X]: Spec file lacks Packager, Vendor, PreReq tags.
[X]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[X]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[X]: Package is named using only allowed ASCII characters.
[X]: Package do not use a name that already exist
[X]: Package is not relocatable.
[X]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[X]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[X]: File names are valid UTF-8.
[X]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 0 bytes in 0 files.
[X]: Packages must not store files under /srv, /opt or /usr/local
[X]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[X]: Package installs properly.
[X]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Ruby:
[-]: Platform dependent files must all go under %{gem_extdir}, platform
independent under %{gem_dir}.
[X]: Gem package must not define a non-gem subpackage
[X]: Gem package is named rubygem-%{gem_name}
[X]: Package contains BuildRequires: rubygems-devel.
[X]: Gem package must define %{gem_name} macro.
[X]: Pure Ruby package must be built as noarch
[X]: Package contains Requires: ruby(abi).
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[X]: Final provides and requires are sane (see attachments).
[-]: Package functions as described.
[!]: Latest version is packaged.
The latest version is 0.1.0, the proposed package is 0.0.13.
[X]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
architectures.
[X]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed files.
[X]: Sources can be downloaded from URI in
