Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=892800
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||mario.blaetterm...@gmail.co
||m
Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
||m
Flags||fedora-review+
--- Comment #3 from Mario Blättermann mario.blaetterm...@gmail.com ---
$ rpmlint -i -v *
WindowMaker-extra.noarch: I: checking
WindowMaker-extra.noarch: I: checking-url http://www.windowmaker.org (timeout
10 seconds)
WindowMaker-extra.noarch: E: incorrect-fsf-address
/usr/share/doc/WindowMaker-extra-0.1/COPYING
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
WindowMaker-extra.src: I: checking
WindowMaker-extra.src: I: checking-url http://www.windowmaker.org (timeout 10
seconds)
WindowMaker-extra.src: W: strange-permission WindowMaker-extra-0.1.tar.gz 0444L
A file that you listed to include in your package has strange permissions.
Usually, a file should have 0644 permissions.
WindowMaker-extra.src: I: checking-url
http://windowmaker.org/pub/source/release/WindowMaker-extra-0.1.tar.gz (timeout
10 seconds)
WindowMaker-extra.spec: I: checking-url
http://windowmaker.org/pub/source/release/WindowMaker-extra-0.1.tar.gz (timeout
10 seconds)
2 packages and 1 specfiles checked; 1 errors, 1 warnings.
Don't bother with the incorrect FSF address. Well, if the upstream folks is
still available, givt them a hint so that they can change the address in future
releases.
Regarding the strange file permissions, 0444 means that's the file isn't
writable even by Root. Doesn't matter, keep it as is.
OK, here we go:
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
GPLv2
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
0b0cc956dec5b583f3e6d95c0172db7da4a4bebc2a51f0036c7257517c803dc2
WindowMaker-extra-0.1.tar.gz
0b0cc956dec5b583f3e6d95c0172db7da4a4bebc2a51f0036c7257517c803dc2
WindowMaker-extra-0.1.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[.] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the
