[Bug 893165] Review Request: mod_qos - Quality of service module for Apache
https://bugzilla.redhat.com/show_bug.cgi?id=893165 Athmane Madjoudj changed: What|Removed |Added CC||athma...@gmail.com Flags|fedora-cvs+ |fedora-cvs? --- Comment #17 from Athmane Madjoudj --- Package Change Request == Package Name: mod_qos New Branches: el5 epel7 Owners: athmane -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893165] Review Request: mod_qos - Quality of service module for Apache
https://bugzilla.redhat.com/show_bug.cgi?id=893165 --- Comment #18 from Kevin Fenzi --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893165] Review Request: mod_qos - Quality of service module for Apache
https://bugzilla.redhat.com/show_bug.cgi?id=893165 Kevin Fenzi changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893165] Review Request: mod_qos - Quality of service module for Apache
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=893165
Adam Miller changed:
What|Removed |Added
CC||admil...@redhat.com
Flags||fedora-review?
--- Comment #1 from Adam Miller ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[ ]: Sources contain only permissible code or content.
[x]: %config files are marked noreplace or the reason is justified.
[ ]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[ ]: Macros in Summary, %description expandable at SRPM build time.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package requires other packages for directories it uses.
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[ ]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GPL (v2 or later)". 1 files have unknown license. Detailed output of
licensecheck in /home/admiller/893165-mod_qos/licensecheck.txt
[ ]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[ ]: Package is named according to the Package Naming Guidelines.
[x]: No %config files under /usr.
[ ]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Package must own all directories that it creates.
[ ]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[ ]: Package is not relocatable.
[ ]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[ ]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[ ]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 389120 bytes in 20 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[ ]: Buildroot is not present
Note: Buildroot: present but not needed
[ ]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
[ ]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[ ]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate fro
[Bug 893165] Review Request: mod_qos - Quality of service module for Apache
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893165 --- Comment #2 from Christof Damian --- (In reply to comment #1) > NOTES: > 1) GPLv2 should be GPLv2+ > 2) This message always appears when run on machines not containing > httpd-devel: "cat: /usr/include/httpd/.mmn: No such file or directory" which > is only a minor issue but I assume that's not desired and instead the echo > message should be present. > 3) rm -rf $RPM_BUILD_ROOT present but not required > > Over all, this looks good. It's nice and clean, just need those couple fixes. I uploaded a new version fixing these issues. I usually keep 3) in, because it doesn't hurt and makes it compatible with EPEL-5, but I am not sure I will build this for that release anyway. Spec URL: http://rpms.damian.net/SPECS/mod_qos.spec SRPM URL: http://rpms.damian.net/SRPMS/mod_qos-10.13-4.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uJCILT3iI2&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893165] Review Request: mod_qos - Quality of service module for Apache
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893165 Adam Miller changed: What|Removed |Added Assignee|nob...@fedoraproject.org|admil...@redhat.com --- Comment #3 from Adam Miller --- Looks good, rpmlint throws this but I don't consider it a blocker. $ rpmlint srpm/mod_qos.spec srpm/mod_qos.spec:17: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 17) 0 packages and 1 specfiles checked; 0 errors, 1 warnings. PASSED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rcYLLyGY21&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893165] Review Request: mod_qos - Quality of service module for Apache
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893165 Christof Damian changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Christof Damian --- (In reply to comment #3) > Looks good, rpmlint throws this but I don't consider it a blocker. > > $ rpmlint srpm/mod_qos.spec > srpm/mod_qos.spec:17: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: > line 17) > 0 packages and 1 specfiles checked; 0 errors, 1 warnings. > > PASSED Cheers I am going to fix the above on import. New Package SCM Request === Package Name: mod_qos Short Description: Quality of service module for Apache Owners: cdamian Branches: f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PyJn2sDh8p&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893165] Review Request: mod_qos - Quality of service module for Apache
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893165 --- Comment #5 from Dennis Gilmore --- the bug does not have the review state set to + -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OncunGKemB&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893165] Review Request: mod_qos - Quality of service module for Apache
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893165 --- Comment #6 from Adam Miller --- Apologies for not setting to +, I realized that I've changed my BZ email and it no longer matches my FAS email which means I don't have permissions to set to +. I have a request into the Fedora Infrastructure team to fix this. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9ku6X2bVlG&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893165] Review Request: mod_qos - Quality of service module for Apache
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893165 Nick Bebout changed: What|Removed |Added CC||n...@fedoraproject.org Flags||fedora_requires_release_not ||e+ --- Comment #7 from Nick Bebout --- In the meantime, I have set the fedora-review to + for you -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NUP9dK4IkS&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893165] Review Request: mod_qos - Quality of service module for Apache
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893165 Nick Bebout changed: What|Removed |Added Flags|fedora-review? | Flags|fedora_requires_release_not | |e+ | Flags||fedora-review+ Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MzIyi747KL&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893165] Review Request: mod_qos - Quality of service module for Apache
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893165 --- Comment #8 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=J1v6IhSLKP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893165] Review Request: mod_qos - Quality of service module for Apache
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893165 --- Comment #9 from Adam Miller --- Awesome, greatly appreciated! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7wAEJQle0p&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893165] Review Request: mod_qos - Quality of service module for Apache
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=893165
--- Comment #10 from Adam Miller ---
The machine I tested on already had mod_ssl enabled so this wasn't caught but a
colleague of mine noticed that the rpm auto-fu doesn't pull in mod_ssl as a
requires.
This should have been fixed before I passed the review, was my oversight.
However, everything else looks good.
Apologies:
%prep
%setup -q -n %{name}-%{version}
%build
-%{_httpd_apxs} -Wc,"%{optflags}" -c apache2/mod_qos.c
+%{_httpd_apxs} -Wc,"%{optflags}" -c apache2/mod_qos.c -lcrypto -lpcre
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=k3IOFcC8Tt&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893165] Review Request: mod_qos - Quality of service module for Apache
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893165 --- Comment #11 from Christof Damian --- (In reply to comment #10) > The machine I tested on already had mod_ssl enabled so this wasn't caught > but a colleague of mine noticed that the rpm auto-fu doesn't pull in mod_ssl > as a requires. > > This should have been fixed before I passed the review, was my oversight. > However, everything else looks good. Thanks, this will also go into the first release I push. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rTUhQ7vyG0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893165] Review Request: mod_qos - Quality of service module for Apache
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893165 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1grnOflVcN&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893165] Review Request: mod_qos - Quality of service module for Apache
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893165 --- Comment #12 from Fedora Update System --- mod_qos-10.13-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mod_qos-10.13-4.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SfXxCWsPI4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893165] Review Request: mod_qos - Quality of service module for Apache
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893165 --- Comment #13 from Fedora Update System --- mod_qos-10.13-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/mod_qos-10.13-4.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=roEnKXHzgc&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893165] Review Request: mod_qos - Quality of service module for Apache
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893165 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MvudW7P5Qi&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893165] Review Request: mod_qos - Quality of service module for Apache
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893165 --- Comment #14 from Fedora Update System --- mod_qos-10.13-4.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jQxG2bBJUv&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893165] Review Request: mod_qos - Quality of service module for Apache
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893165 --- Comment #15 from Fedora Update System --- mod_qos-10.13-4.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PjdNxUV3l4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893165] Review Request: mod_qos - Quality of service module for Apache
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893165 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-03-05 18:25:49 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2pES9ixTPz&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893165] Review Request: mod_qos - Quality of service module for Apache
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893165 --- Comment #16 from Fedora Update System --- mod_qos-10.13-4.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vwew0gNCMa&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
