[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=896193
Bug 896193 depends on bug 1367115, which changed state.

Bug 1367115 Summary: Review Request: valadoc - Documentation tool for the vala 
project
https://bugzilla.redhat.com/show_bug.cgi?id=1367115

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |CURRENTRELEASE




-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=896193
Bug 896193 depends on bug 988667, which changed state.

Bug 988667 Summary: Review Request: valadoc - Documentation tool for the vala 
project
https://bugzilla.redhat.com/show_bug.cgi?id=988667

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |DUPLICATE



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=896193

Gergely Polonkai  changed:

   What|Removed |Added

 Depends On||1367115




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1367115
[Bug 1367115] Review Request: valadoc - Documentation tool for the vala
project
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=896193

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||plank-0.5.0-4.fc20
 Resolution|--- |ERRATA
Last Closed||2014-02-26 08:59:37



--- Comment #33 from Fedora Update System upda...@fedoraproject.org ---
plank-0.5.0-4.fc20 has been pushed to the Fedora 20 stable repository.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=896193

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 Blocks||1068850 (Pantheon)
  Alias||plank




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1068850
[Bug 1068850] Fedora 22 Change Pantheon Desktop tracker
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=896193

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #32 from Fedora Update System upda...@fedoraproject.org ---
plank-0.5.0-4.fc20 has been pushed to the Fedora 20 testing repository.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=896193

Wesley Hearn whe...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs? rhel-rawhide-



--- Comment #29 from Wesley Hearn whe...@redhat.com ---
New Package SCM Request
===
Package Name: plank
Short Description: A port of docky to vala
Owners: jknife
Branches: f20 rawhide
InitialCC:

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=896193

Wesley Hearn whe...@redhat.com changed:

   What|Removed |Added

  Flags|rhel-rawhide-   |



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=896193

Alexander ingle...@gmail.com changed:

   What|Removed |Added

 CC|ingle...@gmail.com  |

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=896193



--- Comment #30 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=896193

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=896193



--- Comment #31 from Fedora Update System upda...@fedoraproject.org ---
plank-0.5.0-4.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/plank-0.5.0-4.fc20

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=896193

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #28 from Christopher Meng cicku...@gmail.com ---
Please also remove the group tag in devel package since you've done that in the
main package. 

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=896193
Bug 896193 depends on bug 1017499, which changed state.

Bug 1017499 Summary: bamf-0.5 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1017499

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=896193



--- Comment #27 from Wesley Hearn whe...@redhat.com ---
Here you go

SPEC: http://jknife.fedorapeople.org/review/plank.spec
SRPM: http://jknife.fedorapeople.org/review/plank-0.5.0-2.fc20.src.rpm

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=896193



--- Comment #26 from Christopher Meng cicku...@gmail.com ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 LGPL (v2.1 or later), GPL (v2 or later), GPL (v3 or later),
 Unknown or generated. 34 files have unknown license. Detailed output of
 licensecheck:

GPL (v2 or later)
-
plank-0.5.0/build-aux/ltmain.sh

GPL (v3 or later)
-
plank-0.5.0/data/apport/source_plank.py
plank-0.5.0/lib/DockController.vala
plank-0.5.0/lib/DockPreferences.vala
plank-0.5.0/lib/DockRenderer.vala
plank-0.5.0/lib/DragManager.vala
plank-0.5.0/lib/Drawing/AnimatedRenderer.vala
plank-0.5.0/lib/Drawing/Color.vala
plank-0.5.0/lib/Drawing/DockSurface.vala
plank-0.5.0/lib/Drawing/DockTheme.vala
plank-0.5.0/lib/Drawing/DrawingService.vala
plank-0.5.0/lib/Drawing/Theme.vala
plank-0.5.0/lib/Factories/AbstractMain.vala
plank-0.5.0/lib/Factories/Factory.vala
plank-0.5.0/lib/Factories/ItemFactory.vala
plank-0.5.0/lib/HideManager.vala
plank-0.5.0/lib/Items/ApplicationDockItem.vala
plank-0.5.0/lib/Items/ApplicationDockItemProvider.vala
plank-0.5.0/lib/Items/DefaultApplicationDockItemProvider.vala
plank-0.5.0/lib/Items/DockItem.vala
plank-0.5.0/lib/Items/DockItemPreferences.vala
plank-0.5.0/lib/Items/DockItemProvider.vala
plank-0.5.0/lib/Items/FileDockItem.vala
plank-0.5.0/lib/Items/PlankDockItem.vala
plank-0.5.0/lib/Items/TransientDockItem.vala
plank-0.5.0/lib/PositionManager.vala
plank-0.5.0/lib/Services/Logger.vala
plank-0.5.0/lib/Services/Matcher.vala
plank-0.5.0/lib/Services/Paths.vala
plank-0.5.0/lib/Services/Preferences.vala
plank-0.5.0/lib/Services/System.vala
plank-0.5.0/lib/Services/WindowControl.vala
plank-0.5.0/lib/Widgets/CompositedWindow.vala
plank-0.5.0/lib/Widgets/DockWindow.vala
plank-0.5.0/lib/Widgets/HoverWindow.vala
plank-0.5.0/lib/Widgets/PoofWindow.vala
plank-0.5.0/src/PlankMain.vala
plank-0.5.0/tests/Drawing.vala
plank-0.5.0/tests/Items.vala
plank-0.5.0/tests/Main.vala
plank-0.5.0/tests/Preferences.vala
plank-0.5.0/tests/Widgets.vala
plank-0.5.0/tests/test-config.h

LGPL (v2.1 or later)

plank-0.5.0/lib/Widgets/TitledSeparatorMenuItem.vala

Unknown or generated

plank-0.5.0/docs/c-doc/ccomments/AbstractMain.c
plank-0.5.0/docs/c-doc/ccomments/AnimatedRenderer.c
plank-0.5.0/docs/c-doc/ccomments/ApplicationDockItem.c
plank-0.5.0/docs/c-doc/ccomments/ApplicationDockItemProvider.c
plank-0.5.0/docs/c-doc/ccomments/Color.c
plank-0.5.0/docs/c-doc/ccomments/CompositedWindow.c
plank-0.5.0/docs/c-doc/ccomments/DefaultApplicationDockItemProvider.c
plank-0.5.0/docs/c-doc/ccomments/DockController.c
plank-0.5.0/docs/c-doc/ccomments/DockItem.c
plank-0.5.0/docs/c-doc/ccomments/DockItemPreferences.c
plank-0.5.0/docs/c-doc/ccomments/DockItemProvider.c
plank-0.5.0/docs/c-doc/ccomments/DockPreferences.c
plank-0.5.0/docs/c-doc/ccomments/DockRenderer.c
plank-0.5.0/docs/c-doc/ccomments/DockSurface.c
plank-0.5.0/docs/c-doc/ccomments/DockTheme.c
plank-0.5.0/docs/c-doc/ccomments/DockWindow.c
plank-0.5.0/docs/c-doc/ccomments/DragManager.c
plank-0.5.0/docs/c-doc/ccomments/DrawingService.c
plank-0.5.0/docs/c-doc/ccomments/Factory.c
plank-0.5.0/docs/c-doc/ccomments/FileDockItem.c
plank-0.5.0/docs/c-doc/ccomments/HideManager.c
plank-0.5.0/docs/c-doc/ccomments/HoverWindow.c
plank-0.5.0/docs/c-doc/ccomments/ItemFactory.c
plank-0.5.0/docs/c-doc/ccomments/Logger.c
plank-0.5.0/docs/c-doc/ccomments/Paths.c
plank-0.5.0/docs/c-doc/ccomments/PlankDockItem.c
plank-0.5.0/docs/c-doc/ccomments/PoofWindow.c
plank-0.5.0/docs/c-doc/ccomments/PositionManager.c
plank-0.5.0/docs/c-doc/ccomments/Preferences.c
plank-0.5.0/docs/c-doc/ccomments/System.c
plank-0.5.0/docs/c-doc/ccomments/Theme.c
plank-0.5.0/docs/c-doc/ccomments/TitledSeparatorMenuItem.c
plank-0.5.0/docs/c-doc/ccomments/TransientDockItem.c
plank-0.5.0/lib/abicheck.sh

[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be 

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=896193



--- Comment #25 from Wesley Hearn whe...@redhat.com ---
Here is the latest:
SPEC: http://jknife.fedorapeople.org/review/plank.spec
SRPM: http://jknife.fedorapeople.org/review/plank-0.5.0-1.fc20.src.rpm

As for BAMF4 as Rico said we do not need it, BAMF3 is enough.
For valadoc a bug can be opened afterwards and I will add the docs to the rpm.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=896193



--- Comment #16 from Christopher Meng cicku...@gmail.com ---
1. Source0 Invalid now:

Actually URL is:

https://launchpad.net/plank/1.0/0.3.0/+download/plank-0.3.0.tar.xz

So you need to modify it to:

https://launchpad.net/%{name}/1.0/%{version}/+download/%{name}-%{version}.tar.xz

2. log:

checking for BAMF... no
checking for GEE_0_8... no
checking for DBUSMENU... yes

So you've missed bamf as BR.

==

plank 0.3.0
Prefix..:  /usr
Vala Compiler...:  /usr/bin/valac
Vala Flags..:  --target-glib=2.32 --define HAVE_DBUSMENU
C Compiler Flags:  -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector-strong --param=ssp-buffer-size=4
-grecord-gcc-switches  -m32 -march=i686 -mtune=atom
-fasynchronous-unwind-tables
Use gee-0.8.:  no
Dbusmenu support:  yes
Headless Tests..:  no
Documentation...:  no

-: This package requires valadoc, I've packaged it but still need upstream to
change something, so I block this bug. 

But for the headless tests, I think you should enable them.


3. devel package need %{?_isa} tag.

4. %{configure}

should be:

%configure

5. %doc COPYING is not enough:

%doc AUTHORS ChangeLog COPYING

6. Don't leave too many blank lines, for example, 

%package devel

Summary:Development files for %{name}
Group:  Development/Libraries
Requires:   %{name} = %{version}-%{release}
Requires:   vala-tools

should be

%package devel
Summary:Development files for %{name}
Group:  Development/Libraries
Requires:   %{name} = %{version}-%{release}
Requires:   vala-tools

and the description is not good, change it to something like:

The %{name}-devel package contains libraries and header files for
developing applications that use %{name}.

7. This package use hidden build, so you can't know the flags/status when
building it. Please append V=1 to make %{?_smp_mflags} like this:

make %{?_smp_mflags} V=1

to make sure build is not hidden.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=8WlXYQDiP9a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=896193

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 Depends On||988667



-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=YAaQ8Gwp82a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=896193



--- Comment #17 from Wesley Hearn whe...@redhat.com ---
1) Fixed

2)
 - I did not miss BAMF, it is checking for BAMF 0.4 now instead of 3. It still
builds just find with 3.
 - Added tests trying to figure out how to check them
 - Ok on valadoc
 - I have also updated which libgee it looks for. So it is now building against
the correct one.

3) Done

4) Changed

5) Done

6) Changed

7) Done

Once I figure out the tests I will push up a updated spec/srpm.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=g10Y6uTFsCa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=896193

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 CC|package-review@lists.fedora |
   |project.org |



--- Comment #18 from Christopher Meng cicku...@gmail.com ---
How did you try valadoc?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=fmqcyeVBixa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=896193

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|cicku...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=l1Pw5AXCPZa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=896193

Wesley Hearn whe...@redhat.com changed:

   What|Removed |Added

  Flags|needinfo?(whe...@redhat.com |
   |)   |
   |needinfo?(whe...@redhat.com |
   |)   |



--- Comment #15 from Wesley Hearn whe...@redhat.com ---
Hey sorry about that.

New Spec: http://jknife.fedorapeople.org/review/plank.spec
New SRPM: http://jknife.fedorapeople.org/review/plank-0.3.0-1.fc19.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=VudQwDmMAqa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=896193

Aaron Clark ad2cl...@gmail.com changed:

   What|Removed |Added

 CC||ad2cl...@gmail.com



--- Comment #13 from Aaron Clark ad2cl...@gmail.com ---
I am interested in this package as well.  I actually packaged it locally back
in February but didn't take it any further due to the lack of a proper release.
 I believe I needed a newer version of bamf-daemon when I tried to get it
working back then.  It has been rock solid for me in the intervening period on
Fedora 17, but I have not upgraded yet so have not done any testing on the more
recent releases other than mock builds.

Here are my specs and srpms, hope they help:

http://fedorapeople.org/~ophidian/plank.spec
http://fedorapeople.org/~ophidian/plank-0.3.0-1.fc17.src.rpm

http://fedorapeople.org/~ophidian/bamf.spec
http://fedorapeople.org/~ophidian/bamf-0.2.126-1.fc17.src.rpm


Based on a quick rpmlint -vi, mine may not be any better than picking up
Wesley's version and updating it:
$ rpmlint -vi plank-0.3.0-1.fc18.x86_64.rpm
plank.x86_64: I: checking
plank.x86_64: W: spelling-error %description -l en_US docky - dock, docks,
dorky
The value of this tag appears to be misspelled. Please double-check.

plank.x86_64: I: checking-url
http://wiki.go-docky.com/index.php?title=Plank:Introduction (timeout 10
seconds)
plank.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/plank ['/usr/lib64']
The binary or shared library defines `RPATH'. Usually this is a bad thing
because it hardcodes the path to search libraries and so makes it difficult to
move libraries around.  Most likely you will find a Makefile with a line like:
gcc test.o -o test -Wl,--rpath.  Also, sometimes configure scripts provide a
--disable-rpath flag to avoid this.

plank.x86_64: E: zero-length /usr/share/doc/plank-0.3.0/README
plank.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libplank.so
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

plank.x86_64: E: postin-without-ldconfig /usr/lib64/libplank.so.0.0.0
This package contains a library and its %post scriptlet doesn't call ldconfig.

plank.x86_64: E: postun-without-ldconfig /usr/lib64/libplank.so.0.0.0
This package contains a library and its %postun doesn't call ldconfig.

1 packages and 0 specfiles checked; 4 errors, 2 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ZgGqr7GT6Ia=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=896193

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

  Flags||needinfo?(whe...@redhat.com
   ||)



--- Comment #14 from Christopher Meng cicku...@gmail.com ---
I'll leave needinfo again to the reporter.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=BW1Wx5tSvga=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=896193

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 CC||cicku...@gmail.com,
   ||whe...@redhat.com
  Flags||needinfo?(whe...@redhat.com
   ||)

--- Comment #12 from Christopher Meng cicku...@gmail.com ---
Hi,

I just want to package it, will you continue?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=SdsccrWSrpa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=896193

Wesley Hearn whe...@redhat.com changed:

   What|Removed |Added

 CC|psyb...@gmail.com   |

--- Comment #11 from Wesley Hearn whe...@redhat.com ---
Hey, sorry. I have been busy with work, once I get some free time(hopefully
this weekend or next week) I will work on this some more. I asked about
libdbusmenu and it will have to be re-reviewed because it has taken so long. So
I guess the goal is to pick that up and dust it off, get it approved and in
Fedora then carry on with this one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ATVtRmoL6Na=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=896193

--- Comment #10 from Eduardo Echeverria echevemas...@gmail.com ---
Ping... Any update here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=7ySJMSngNxa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=896193

Robert Dyer psyb...@gmail.com changed:

   What|Removed |Added

 CC||psyb...@gmail.com

--- Comment #7 from Robert Dyer psyb...@gmail.com ---
Upstream now accepts Fedora bugs.

http://wiki.go-docky.com/index.php?title=Plank:Introduction#Reporting_Bugs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=e2sEvBg24Aa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=896193

--- Comment #8 from Robert Dyer psyb...@gmail.com ---
The upstream installation instructions no longer reference GTK2.

http://wiki.go-docky.com/index.php?title=Plank:Installing

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=XJBu3kBvJZa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=896193

--- Comment #9 from Eduardo Echeverria echevemas...@gmail.com ---
Wesley:

Sorry for delay, I had a busy few days

(In reply to comment #7)
 Upstream now accepts Fedora bugs.
 
 http://wiki.go-docky.com/index.php?title=Plank:Introduction#Reporting_Bugs

Are good news !!

About versioning. 
- Current development version is 0.2.0
- rev is in this case 734 
therefore, the versioning should be: 0.2.0-0.1.20130124bzr734 
and the release number increment every time you make changes in the spec: 
e.g.
0.2.0-0.2.20130124bzr734  
0.2.0-0.3.20130124bzr734 
and so on
in the spec: 
%global bzrid 734
%global checkout 20130124bzr%{bzrid}
Name:   plank
Version:0.2.0
Release:0.1.%{checkout}%{?dist}
Source0:plank-%{version}.%{bzrid}.tar.xz

About @shared-lib-calls-exit 
this is no review blocker,  .But it is worth to inform the upstream about that.
(and fix it soon)

Let's review

rpmlint plank plank-devel plank-debuginfo
plank.x86_64: W: spelling-error Summary(en_US) docky - dock, docks, dorky
plank.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libplank.so.0.0.0
/lib64/libgthread-2.0.so.0
plank.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libplank.so.0.0.0
/lib64/librt.so.1
plank.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libplank.so.0.0.0
/lib64/libatk-1.0.so.0
plank.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libplank.so.0.0.0
/lib64/libcairo-gobject.so.2
plank.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libplank.so.0.0.0
/lib64/libpthread.so.0

See
http://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-dependency

objdump -p libplank.so.0.0.0 | grep NEEDED
  NEEDED   libm.so.6
  NEEDED   libgthread-2.0.so.0
  NEEDED   librt.so.1 *
  NEEDED   libbamf3.so.0
  NEEDED   libwnck-3.so.0
  NEEDED   libgtk-3.so.0
  NEEDED   libgdk-3.so.0
  NEEDED   libatk-1.0.so.0 * 
  NEEDED   libgio-2.0.so.0
  NEEDED   libpangocairo-1.0.so.0
  NEEDED   libgdk_pixbuf-2.0.so.0
  NEEDED   libcairo-gobject.so.2 *
  NEEDED   libpango-1.0.so.0
  NEEDED   libcairo.so.2
  NEEDED   libgee.so.2
  NEEDED   libgobject-2.0.so.0
  NEEDED   libglib-2.0.so.0
  NEEDED   libX11.so.6
  NEEDED   libpthread.so.0 *
  NEEDED   libc.so.6

- (nonblocker) You might mention to upstream the various warnings

Drawing/DockSurface.vala:366.32-366.51: warning: GLib.Thread.create has been
deprecated since 2.32. Use new ThreadT ()
Drawing/DockSurface.vala:375.10-375.29: warning: GLib.Thread.create has been
deprecated since 2.32. Use new ThreadT ()
Drawing/DockSurface.vala:492.32-492.51: warning: GLib.Thread.create has been
deprecated since 2.32. Use new ThreadT ()
Drawing/DockSurface.vala:515.10-515.29: warning: GLib.Thread.create has been
deprecated since 2.32. Use new ThreadT ()
Drawing/DrawingService.vala:54.49-54.77: warning:
GLib.FILE_ATTRIBUTE_THUMBNAIL_PATH has been deprecated since vala-0.16. Use
FileAttribute.THUMBNAIL_PATH
Factories/AbstractMain.vala:271.4-271.15: warning: `null' incompatible with
return type `string[]`
return null;

Items/ApplicationDockItem.vala:442.52-442.87: warning:
GLib.FILE_ATTRIBUTE_STANDARD_CONTENT_TYPE has been deprecated since vala-0.16.
Use FileAttribute.STANDARD_CONTENT_TYPE
Items/FileDockItem.vala:294.52-294.79: warning:
GLib.FILE_ATTRIBUTE_STANDARD_NAME has been deprecated since vala-0.16. Use
FileAttribute.STANDARD_NAME
Items/FileDockItem.vala:295.8-295.40: warning:
GLib.FILE_ATTRIBUTE_STANDARD_IS_HIDDEN has been deprecated since vala-0.16. Use
FileAttribute.STANDARD_IS_HIDDEN
Items/FileDockItem.vala:296.8-296.37: warning:
GLib.FILE_ATTRIBUTE_ACCESS_CAN_READ has been deprecated since vala-0.16. Use
FileAttribute.ACCESS_CAN_READ
DockItems.vala:388.42-388.69: warning: GLib.FILE_ATTRIBUTE_STANDARD_NAME has
been deprecated since vala-0.16. Use FileAttribute.STANDARD_NAME
DockItems.vala:388.79-388.111: warning: GLib.FILE_ATTRIBUTE_STANDARD_IS_HIDDEN
has been deprecated since vala-0.16. Use FileAttribute.STANDARD_IS_HIDDEN
DockItems.vala:224.77-224.104: warning: GLib.FILE_ATTRIBUTE_STANDARD_NAME has
been deprecated since vala-0.16. Use FileAttribute.STANDARD_NAME
DockItems.vala:224.114-224.146: warning: GLib.FILE_ATTRIBUTE_STANDARD_IS_HIDDEN
has been deprecated since vala-0.16. Use FileAttribute.STANDARD_IS_HIDDEN
Services/WindowControl.vala:124.3-124.41: warning: method
`Plank.Services.Windows.WindowControl.has_minimized_window' never used
public static bool has_minimized_window (Bamf.Application app)
^^^
Services/WindowControl.vala:166.3-166.50: warning: method
`Plank.Services.Windows.WindowControl.get_windows' never used
public static ArrayListBamf.Window get_windows 

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=896193

--- Comment #6 from Wesley Hearn whe...@redhat.com ---
- Fixed
- Fixed
- Fixed
- No, that page is outdated, They removed GTK2 support in June of last
year(Changelog entry)
- Asking about this
- Will file a bug
- It is not essential to plank working. 

SPEC: http://jknife.fedorapeople.org/review/plank.spec
SRPM:
http://jknife.fedorapeople.org/review/plank-0.2.0.734-0.1.20130124bzr.fc18.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=uqr5wOBINma=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=896193

Eduardo Echeverria echevemas...@gmail.com changed:

   What|Removed |Added

 CC||echevemas...@gmail.com

--- Comment #5 from Eduardo Echeverria echevemas...@gmail.com ---
Hi Wesley 

- This is a snapshot and pre-release package, please follow the recommendations
are explained on [1] and [2]
Where 
Release Tag for Pre-Release Packages: 0.%{X}.%{alphatag}
Where %{X} =  is the release number increment 
and 
%{alphatag} = is the string that came from the version (20130121bzr731)

- In this line:
cp -r %{buildroot}%{_datadir}/icons/hicolor/
%{buildroot}%{_datadir}/icons/gnome
Actually the icons are not broken, simply use proper scriptlets [2]

- the url should be [4] not http://wiki.go-docky.com/index.php

- This package builds in gtk2 and gtk3 with their respectives dependencies,
take a look in [5]

- Please note that upstream accepts no Fedora related bugs [6]

- Please take a look at your rpmlint output

rpmlint -vi plank-0.2.0.731-1.20130121.fc17.x86_64.rpm 
plank.x86_64: W: shared-lib-calls-exit /usr/lib64/libplank.so.0.0.0
exit@GLIBC_2.2.5
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.

- checking for DBUSMENU... no
As an aside, one of the unfulfilled dependencies of this package is
libdebusmenu, although I do not understand why it was not included in Fedora, 
being a approved package , I recommend that you take a look at this link [7]


[1]
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages
[2] http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
[3] http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
[4] https://launchpad.net/plank
[5] http://wiki.go-docky.com/index.php?title=Plank:Installing
[6] http://wiki.go-docky.com/index.php?title=Plank:Introduction#Reporting_Bugs
[7] bug 842509

Btw, is available rev 734

Regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=GRNoiZwV5Ma=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=896193

--- Comment #4 from Wesley Hearn whe...@redhat.com ---
Uodated again
http://jknife.fedorapeople.org/review/plank-0.2.0.731-1.20130121.fc18.src.rpm
http://jknife.fedorapeople.org/review/plank.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=tRPkWbXSSCa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=896193

--- Comment #3 from Wesley Hearn whe...@redhat.com ---
Updated:
SPEC: http://jknife.fedorapeople.org/review/plank.spec
SRCRPM:
http://jknife.fedorapeople.org/review/plank-0.0-1.20130117bzr723.fc18.src.rpm

Initial items on your list are done, as for the .desktop file I was already
calling desktop-file-validate.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=pkwLJIzoHha=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=896193

Mario Blättermann mario.blaetterm...@gmail.com changed:

   What|Removed |Added

 CC||mario.blaetterm...@gmail.co
   ||m

--- Comment #2 from Mario Blättermann mario.blaetterm...@gmail.com ---
Some initial issues:

It is not needed to extract the configure macro. Just put autogen.sh before
running %configure.



%{_datadir}/icons/gnome/16x16/apps/%{name}.svg
%{_datadir}/icons/gnome/22x22/apps/%{name}.svg
%{_datadir}/icons/gnome/24x24/apps/%{name}.svg
%{_datadir}/icons/gnome/32x32/apps/%{name}.svg
%{_datadir}/icons/gnome/48x48/apps/%{name}.svg
%{_datadir}/icons/gnome/64x64/apps/%{name}.svg
%{_datadir}/icons/gnome/128x128/apps/%{name}.svg
%{_datadir}/icons/hicolor/16x16/apps/%{name}.svg
%{_datadir}/icons/hicolor/22x22/apps/%{name}.svg
%{_datadir}/icons/hicolor/24x24/apps/%{name}.svg
%{_datadir}/icons/hicolor/32x32/apps/%{name}.svg
%{_datadir}/icons/hicolor/48x48/apps/%{name}.svg
%{_datadir}/icons/hicolor/64x64/apps/%{name}.svg
%{_datadir}/icons/hicolor/128x128/apps/%{name}.svg

You could shrink this as follows:

%{_datadir}/icons/gnome/*/apps/%{name}.svg
%{_datadir}/icons/hicolor/*/apps/%{name}.svg



BuildRequires:  desktop-file-utils

This is fine, but the desktop file needs to be installed explicitely or at
least validated:
http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database

The latter is probably not applicable because the desktop file doesn't
introduce new MIME types.



%clean
rm -rf %{buildroot}

Drop the %clean section. It is only needed for EPEL 5 packages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=oDLt0Hz44Xa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=896193

--- Comment #1 from Wesley Hearn whe...@redhat.com ---
Upstream bug regarding the license file not being included
https://bugs.launchpad.net/plank/+bug/1100448

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=kW8ar0k0r5a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review